Re: [virt-tools-list] [virt-viewer][PATCH v2] Introduce bash completion

2019-05-06 Thread Fabiano Fidêncio
On Mon, May 6, 2019 at 1:28 PM Michal Privoznik wrote: > > With this change one can get list of domains on the command line: > > $ virt-viewer -c qemu:///system > dom1 dom2 ... domN > > The list of domains is fetched using virsh, hence the dependency > on libvirt-client recorded in the

[virt-tools-list] [virt-viewer][PATCH v2] Introduce bash completion

2019-05-06 Thread Michal Privoznik
With this change one can get list of domains on the command line: $ virt-viewer -c qemu:///system dom1 dom2 ... domN The list of domains is fetched using virsh, hence the dependency on libvirt-client recorded in the spec file. I think it's fair to assume that Linux hosts with

Re: [virt-tools-list] [virt-viewer][PATCH] Introduce bash completion

2019-05-06 Thread Fabiano Fidêncio
On Mon, May 6, 2019 at 9:25 AM Fabiano Fidêncio wrote: > > Michal, > > Take this review (and, spoiler alert, ack) with a grain of salt as > I've been out of virt-viewer development for several years now. > > On Tue, Mar 26, 2019 at 4:28 PM Michal Privoznik wrote: > > > > With this change one can

Re: [virt-tools-list] [virt-viewer][PATCH] Introduce bash completion

2019-05-06 Thread Fabiano Fidêncio
Michal, Take this review (and, spoiler alert, ack) with a grain of salt as I've been out of virt-viewer development for several years now. On Tue, Mar 26, 2019 at 4:28 PM Michal Privoznik wrote: > > With this change one can get list of domains on the command line: > > $ virt-viewer -c