On 6/7/19 10:37 AM, Christophe Fergeau wrote:
> On Fri, Jun 07, 2019 at 10:04:19AM -0300, Eduardo Lima (Etrunko) wrote:
>> On 6/6/19 1:22 PM, Christophe Fergeau wrote:
>>> Hey,
>>>
>>> I'm not really comfortable with that patch, which ignores some errors,
>>> and adds some code not to crash when we
On Fri, Jun 07, 2019 at 10:04:19AM -0300, Eduardo Lima (Etrunko) wrote:
> On 6/6/19 1:22 PM, Christophe Fergeau wrote:
> > Hey,
> >
> > I'm not really comfortable with that patch, which ignores some errors,
> > and adds some code not to crash when we do that, in the hope that the
> > end result wi
On 6/6/19 1:22 PM, Christophe Fergeau wrote:
> Hey,
>
> I'm not really comfortable with that patch, which ignores some errors,
> and adds some code not to crash when we do that, in the hope that the
> end result will make sense. I'm under the impression that if the oVirt
> instance does not have t
On Fri, Jun 07, 2019 at 01:32:55PM +0200, Fabiano Fidêncio wrote:
> On Fri, Jun 7, 2019 at 12:49 PM Peter Crowther
> wrote:
> >
> > On Fri, 7 Jun 2019 at 11:34, Daniel P. Berrangé wrote:
> >>
> >> On Fri, Jun 07, 2019 at 11:27:36AM +0100, Peter Crowther wrote:
> >> > On Fri, 7 Jun 2019 at 11:18,
On Fri, 7 Jun 2019 at 12:33, Fabiano Fidêncio wrote:
> On Fri, Jun 7, 2019 at 12:49 PM Peter Crowther
> wrote:
> >> > Not for many, many years. Even Windows 2000 enabled you to burn a CD
> with
> >> > a winnt.sif answer file on it; I've not checked further back. How
> far back
> >> > do we wis
On Fri, Jun 7, 2019 at 12:49 PM Peter Crowther
wrote:
>
> On Fri, 7 Jun 2019 at 11:34, Daniel P. Berrangé wrote:
>>
>> On Fri, Jun 07, 2019 at 11:27:36AM +0100, Peter Crowther wrote:
>> > On Fri, 7 Jun 2019 at 11:18, Daniel P. Berrangé
>> > wrote:
>> >
>> > > On Fri, Jun 07, 2019 at 12:00:56PM
On Fri, 7 Jun 2019 at 11:34, Daniel P. Berrangé wrote:
> On Fri, Jun 07, 2019 at 11:27:36AM +0100, Peter Crowther wrote:
> > On Fri, 7 Jun 2019 at 11:18, Daniel P. Berrangé
> wrote:
> >
> > > On Fri, Jun 07, 2019 at 12:00:56PM +0200, Fabiano Fidêncio wrote:
> > > > Instead of using "floppy" as t
On Fri, 7 Jun 2019 at 11:18, Daniel P. Berrangé wrote:
> On Fri, Jun 07, 2019 at 12:00:56PM +0200, Fabiano Fidêncio wrote:
> > Instead of using "floppy" as the way to perform unattended installations
> > for Windoes, let's prefer using "cdrom" instead.
>
> Aren't there versions of windows which /
On Fri, Jun 07, 2019 at 11:27:36AM +0100, Peter Crowther wrote:
> On Fri, 7 Jun 2019 at 11:18, Daniel P. Berrangé wrote:
>
> > On Fri, Jun 07, 2019 at 12:00:56PM +0200, Fabiano Fidêncio wrote:
> > > Instead of using "floppy" as the way to perform unattended installations
> > > for Windoes, let's
On Fri, Jun 07, 2019 at 12:00:56PM +0200, Fabiano Fidêncio wrote:
> Instead of using "floppy" as the way to perform unattended installations
> for Windoes, let's prefer using "cdrom" instead.
Aren't there versions of windows which /only/ support "floppy", which
would require us to preferentially u
Let's just use mktemp() as done in several other places and avoid the
risk of having the content of the folder overwritten in case of parallel
installations.
Signed-off-by: Fabiano Fidêncio
---
virtinst/unattended.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/virtinst/
Similarly to what's already done in installertreeinfo.py, let's log when
removing the files used during the unattended installation.
Signed-off-by: Fabiano Fidêncio
---
virtinst/installer.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/virtinst/installer.py b/virtinst/installer.py
index 4
Patches are related to:
- Prefer mktemp() to create dirs instead of using a fixed "unattended"
dir;
- Log when unattended files are removed;
- Remove also the temp dirs created for unattended installations;
- I'm not sure whether we actually want to do this or not ... if that's
not desirabl
Together with the temporary files removal, let's also remove the
directories created to store those files.
Signed-off-by: Fabiano Fidêncio
---
virtinst/installer.py | 10 ++
virtinst/installertreemedia.py | 9 +
2 files changed, 19 insertions(+)
diff --git a/virtinst/i
Instead of using "floppy" as the way to perform unattended installations
for Windoes, let's prefer using "cdrom" instead.
The main reasons behind this change are:
- VMs using q35 may have floppy device disabled in some systems;
- We can drop mstools dependency;
Generating the ISO depends on genis
15 matches
Mail list logo
