Re: [virt-tools-list] [PATCH virt-viewer v3] ovirt-foreign-menu: Bypass errors from Host/Cluster/Data Center

On Fri, Jun 07, 2019 at 10:04:19AM -0300, Eduardo Lima (Etrunko) wrote: > On 6/6/19 1:22 PM, Christophe Fergeau wrote: > > Hey, > > > > I'm not really comfortable with that patch, which ignores some errors, > > and adds some code not to crash when we do that, in the h

Re: [virt-tools-list] [PATCH virt-viewer v3] ovirt-foreign-menu: Bypass errors from Host/Cluster/Data Center

Hey, I'm not really comfortable with that patch, which ignores some errors, and adds some code not to crash when we do that, in the hope that the end result will make sense. I'm under the impression that if the oVirt instance does not have the permissions issues that you mention, but if instead

Re: [virt-tools-list] [virt-viewer PATCH 01/14] po: provide custom make rules for po file management

Hey, On Thu, Mar 07, 2019 at 02:42:45PM +, Daniel P. Berrangé wrote: > After investigating in more detail it seems you can provide custom rules > for XML files by setting GETTEXTDATADIR, so I can support mime files with > this extra diff: Ah indeed, nice finding. Seeing what is shipped in

Re: [virt-tools-list] [virt-viewer PATCH 01/14] po: provide custom make rules for po file management

On Tue, Mar 05, 2019 at 10:27:07AM +, Daniel P. Berrangé wrote: > On Tue, Mar 05, 2019 at 11:23:34AM +0100, Christophe Fergeau wrote: > > On Wed, Feb 20, 2019 at 05:50:52PM +, Daniel P. Berrangé wrote: > > > Historically we have relied on intltool to install a

Re: [virt-tools-list] [virt-viewer PATCH 00/14] po: improve translation handling

A few comments on the first patch, for the rest of the series, Reviewed-by: Christophe Fergeau Did you get feedback from people involved with translations regarding these changes? Christophe On Wed, Feb 20, 2019 at 05:50:51PM +, Daniel P. Berrangé wrote: > This applies the s

Re: [virt-tools-list] [virt-viewer PATCH 01/14] po: provide custom make rules for po file management

On Wed, Feb 20, 2019 at 05:50:52PM +, Daniel P. Berrangé wrote: > Historically we have relied on intltool to install a standard > po/Makefile.in.in which has very limited scope for customization. > intltool is deprecated in favour of standard gettextize tools, > but these share the same

Re: [virt-tools-list] [virt-viewer PATCH v2 3/3] Switch to gnulib's compiler warning flags

On Tue, Feb 19, 2019 at 03:00:11PM +, Daniel P. Berrangé wrote: > diff --git a/m4/virt-viewer-warnings.m4 b/m4/virt-viewer-warnings.m4 > new file mode 100644 > index 000..4036b75 > --- /dev/null > +++ b/m4/virt-viewer-warnings.m4 > [...] > +# List of warnings that are not relevant /

Re: [virt-tools-list] [virt-viewer PATCH v2 1/3] Annotate message dialog helpers with format(gnu_printf)

The shortlog should mention G_GNUC_PRINTF rather than format(printf) On Tue, Feb 19, 2019 at 03:00:09PM +, Daniel P. Berrangé wrote: > This allows the compiler to validate the format string and args passed > to the function. > > Signed-off-by: Daniel P. Berrangé > --- >

Re: [virt-tools-list] [virt-viewer PATCH v2 2/3] Fix warning about missing nul terminator with strncpy

Reviewed-by: Christophe Fergeau On Tue, Feb 19, 2019 at 03:00:10PM +, Daniel P. Berrangé wrote: > We're intentionally not copying the nul terminator, but gcc rightly > worries that this could be a coding mistake > > windows-cmdline-wrapper.c: In function 'main': > windows-cm

Re: [virt-tools-list] [PATCH virt-viewer v2 1/2] Update usage of GObject private structures

Series looks good to me, Reviewed-by: Christophe Fergeau On Wed, Feb 20, 2019 at 11:05:36AM -0300, Eduardo Lima (Etrunko) wrote: > ping > > On 2/13/19 12:46 PM, Eduardo Lima (Etrunko) wrote: > > New functions and macros have been added in glib 2.38 to better handle > > this

Re: [virt-tools-list] [PATCH virt-viewer v2] Update usage of GObject private structures

remote_viewer_iso_list_dialog_get_instance_private(self); Hiding the initialization of 'self->priv' in the middle of local variable declaration/initialization is not the most readable thing ever, this could be split too ;) Apart from this, looks good to me, Reviewed-by: Christophe Fergeau

Re: [virt-tools-list] [PATCH virt-viewer 3/3] ovirt-foreign-menu: Bypass errors from Host/Cluster/Data Center

On Tue, Feb 05, 2019 at 03:38:35PM -0200, Eduardo Lima (Etrunko) wrote: > On 7/17/18 11:48 AM, Christophe Fergeau wrote: > > On Fri, Jul 06, 2018 at 09:59:23AM -0300, Eduardo Lima (Etrunko) wrote: > >> When accessing ovirt as a regular user, it may happen that queries to &g

Re: [virt-tools-list] [PATCH virt-viewer v2] Fix a regression when initial connection fails

Acked-by: Christophe Fergeau On Thu, Jan 31, 2019 at 09:04:11AM -0600, Jonathon Jongsma wrote: > Due to changes in commit 65ef66e4, when the initial connection fails, > virt-viewer just sat quietly and didn't indicate what was wrong. It also > did not exit as it did before. This is b

Re: [virt-tools-list] [PATCH virt-viewer] Fix a regression when initial connection fails

*s, > g_signal_emit_by_name(self, "session-disconnected", error ? > error->message : NULL); > } > > +/* called when the spice session indicates that a session has been destroyed > */ > static void > virt_viewer_session_spice_c

Re: [virt-tools-list] [PATCH] spice: add unix-path in .vv file support

On Fri, Dec 21, 2018 at 03:27:59PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This will allow to connect to a Spice server using a unix socket path, > for example: If you want, but are .vv file used for local spice instance? Reviewed-by: Christ

Re: [virt-tools-list] Help, Need inform about set-lifecycle-action.

Hey, On Thu, Dec 13, 2018 at 01:37:39PM +0900, leej...@gmail.com wrote: >Could you give me a favor? > I would like know how to use set-lifecycle-action in virsh. > > They are requesting --type, but I could not find type in "help doc", > "info > virsh doc". > > I think

Re: [virt-tools-list] reset virt

Hey, On Tue, Nov 27, 2018 at 03:47:47PM +, Joachim Wagner wrote: > > In order to use virt-manager as root I need to reset it. > [...] > > How can I delete all preferences? So it will fix that problem, as before. > > Thanks > >

Re: [virt-tools-list] [PATCH] Set window title to VM name

hey, On Mon, Nov 19, 2018 at 03:29:45AM +, Ben Mathews wrote: > The attached patch address an issue with virt-view not setting the titlebar > text to be the title of the VM (previously discussed on: > https://www.redhat.com/archives/virt-tools-list/2018-September/msg00064.html). > > Thank

Re: [virt-tools-list] [virt-viewer PATCH v2 0/3] Remove Test::AutoBuild leftovers

Hey, On Thu, Nov 08, 2018 at 12:13:51PM +0100, Andrea Bolognani wrote: > On Thu, 2018-11-08 at 10:45 +0100, Christophe Fergeau wrote: > > Hey, > > > > Looks good to me, I assume you discussed the autobuild.sh -> > > prepare-release.sh changes with danpb?

Re: [virt-tools-list] [virt-viewer PATCH v2 0/3] Remove Test::AutoBuild leftovers

Hey, Looks good to me, I assume you discussed the autobuild.sh -> prepare-release.sh changes with danpb? Reviewed-by: Christophe Fergeau Christophe On Mon, May 07, 2018 at 04:40:28PM +0200, Andrea Bolognani wrote: > Changes from [v1]: > > * rename the script instead

Re: [virt-tools-list] [PATCH virt-viewer] Fullscreen displays on wrong monitors in Wayland

On Mon, Oct 15, 2018 at 03:33:27PM -0500, Jonathon Jongsma wrote: > On Mon, 2018-10-15 at 10:42 +0200, Christophe Fergeau wrote: > > On Fri, Oct 12, 2018 at 02:51:19PM -0500, Jonathon Jongsma wrote: > > > In fullscreen mode, we attempt to enable a guest display for each > >

Re: [virt-tools-list] [PATCH virt-viewer] fix character encoding on Windows platform

e_strv > (https://gitlab.gnome.org/GNOME/glib/blob/7c1f38b1c9d97519bf087a37a7d8c0a6e6bfdf18/gio/gapplication.c#L561) > we can use the same code path. I have generated a new patch. > > On 2018/10/15 19:54, Christophe Fergeau wrote: > > Hey, > > > > On Mon, Oct 15, 2018 at 07:2

Re: [virt-tools-list] [PATCH virt-viewer] fix character encoding on Windows platform

Hey, On Mon, Oct 15, 2018 at 07:26:12PM +0800, Qiu Wenbo wrote: > Thank you. We can't use the same code path here. The code path of > GApplication on Windows is different compared to Linux. To handle different > file name encodings on Windows, GApplication will get its command line > arguments

Re: [virt-tools-list] [PATCH virt-viewer] fix character encoding on Windows platform

Hey, For some reason, the patch did not get through so well (html maybe), blank space was missing. I'm attaching a version which should be more readable to this email. g_option_context_parse_strv documentation has more details regarding the different with g_option_context_parse, I'd add this to

Re: [virt-tools-list] [PATCH virt-viewer] Fullscreen displays on wrong monitors in Wayland

he existing logic. Any plans to remove the gtk_window_move() call later on? Or do you think we should keep it forever? Apart from that, Acked-by: Christophe Fergeau Christophe signature.asc Description: PGP signature ___ virt-tools-list mailing list virt-tools

Re: [virt-tools-list] Virt-Viewer Bug: Not Reading In And Using VM Title

Hey, On Mon, Sep 17, 2018 at 01:19:55AM +, Ben Mathews wrote: > If I understand the implementation correctly, I believe that > virt-viewer should display the Title of the VM in the titlebar if the > Title has been set for that particular VM on the server.  See the > logic in

Re: [virt-tools-list] Vertical bar key / Pipe key not working sometimes

On Tue, Sep 18, 2018 at 12:12:12PM +0200, Christian Rilke wrote: > Sometimes the Pipe key is not working for me. Only sometimes? This is unexpected... I assume it's quite random, you don't know a reliable way to reproduce this? Where is the key physically located on the keyboard? (there are

Re: [virt-tools-list] How to: Unattended Windows installs in virt-install

On Wed, Sep 12, 2018 at 03:37:27PM +0100, Richard W.M. Jones wrote: > There are also several problems with the current autounattend file or > Windows itself. > > I couldn't get Windows to install virtio drivers even though I > supplied the virtio ISO. I guess some change is needed to the XML >

Re: [virt-tools-list] [virt-viewer] app: Always add guest name comment

Acked-by: Christophe Fergeau On Thu, Aug 30, 2018 at 01:56:27PM +0200, Victor Toso wrote: > From: Victor Toso > > Even when the user adds comments, we should place the guest's name > unless it is present already. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1

Re: [virt-tools-list] Problem watching guest OS?

Hey, Can you provide a text description of the issue you are having? On Mon, Jul 30, 2018 at 09:53:31AM +0200, Per Gunnarsson wrote: > My host is: > > Linux konjak 4.17.0-1-amd64 #1 SMP Debian 4.17.8-1 (2018-07-20) x86_64 > GNU/Linux > > I run virt-manager with this guest: > > NetBSD nettan

Re: [virt-tools-list] [PATCH virt-viewer 3/3] ovirt-foreign-menu: Bypass errors from Host/Cluster/Data Center

On Fri, Jul 06, 2018 at 09:59:23AM -0300, Eduardo Lima (Etrunko) wrote: > When accessing ovirt as a regular user, it may happen that queries to > Hosts, Clusters and Data Centers return errors due to insufficient > permissions, while they will work fine if access is done by admin user. > In this

Re: [virt-tools-list] [PATCH virt-viewer 1/3] build: Update govirt and rest requirements

o mention the versions used by various distros. In that case, all supported fedoras have these, rhel 7.5/7.4 have these too. Ubuntu 16.04 LTS only has librest 0.7.93 though (17.10 has 0.8.0), but I would say that's ok if we don't get libgovirt support there. Did not check other distros.. Acked-by: C

Re: [virt-tools-list] [PATCH virt-viewer 2/3] ovirt-foreign-menu: New function storage_domain_validate()

Ok, Acked-by: Christophe Fergeau On Fri, Jul 06, 2018 at 09:59:22AM -0300, Eduardo Lima (Etrunko) wrote: > It may be useful to know why the storage domain has not been listed, > given that there are different reasons for that. To make it easier to > provide more detailed debug messages

[virt-tools-list] [virt-viewer v2] ovirt: Improve handling of g_strv_contains()

. This commit wraps both the compat code and the g_strv_contains() call in a strv_contains() helper where we can hide the magic needed to avoid deprecation warnings. Signed-off-by: Christophe Fergeau --- src/ovirt-foreign-menu.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff

Re: [virt-tools-list] [virt-viewer 2/4] spice: Stop using deprecated SpiceMainChannel API

On Thu, Jun 28, 2018 at 05:09:48PM -0300, Eduardo Lima (Etrunko) wrote: > On 14/06/18 13:01, Christophe Fergeau wrote: > > spice_main_set_display and spice_main_set_display_enabled have been > > superseded by spice_main_channel_update_display and > > spice_main_channel_u

Re: [virt-tools-list] [virt-viewer 4/4] ovirt: Improve handling of g_strv_contains()

On Thu, Jun 28, 2018 at 04:45:01PM -0300, Eduardo Lima (Etrunko) wrote: > On 14/06/18 13:01, Christophe Fergeau wrote: > > The ovirt code uses g_strv_contains() with fallback code in > > glib-compat.h when we are using a glib version where it's not available. > > Howeve

[virt-tools-list] [virt-viewer 3/4] window: Adjust get_image_format() prototype

* (*)(void *)' [-Wcast-function-type] g_once(_formats_once, (GThreadFunc)init_image_formats, NULL); Signed-off-by: Christophe Fergeau --- src/virt-viewer-window.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c index

[virt-tools-list] [virt-viewer 2/4] spice: Stop using deprecated SpiceMainChannel API

spice_main_set_display and spice_main_set_display_enabled have been superseded by spice_main_channel_update_display and spice_main_channel_update_display_enabled Signed-off-by: Christophe Fergeau --- src/virt-viewer-display-spice.c | 7 ++- src/virt-viewer-session-spice.c | 27

[virt-tools-list] [virt-viewer 4/4] ovirt: Improve handling of g_strv_contains()

. This commit wraps both the compat code and the g_strv_contains() call in a strv_contains() helper where we can hide the magic needed in the 2 cases to avoid compilation issues. Signed-off-by: Christophe Fergeau --- src/Makefile.am | 2 -- src/glib-compat.c| 35

Re: [virt-tools-list] Fwd: Remote VM no display

Could it be that you need to upload a new ssh key to the remote servers so that ssh-agent can log you in without additional password prompt once you have unlocked the key? Christophe On Sat, Jun 02, 2018 at 10:10:23AM -0400, Ross Decker wrote: > I recently changed my desktop from Centos Server

Re: [virt-tools-list] [PATCH virt-viewer] build: Explicitly link against librest

On Thu, May 31, 2018 at 01:56:00PM -0300, Eduardo Lima (Etrunko) wrote: > In remote-viewer, there is an explicit call to rest_proxy_auth_cancel(), > so we should be linking against librest as well. This patch fixes the > following error: > > make[3]: Entering directory

Re: [virt-tools-list] about virt-install

On Fri, May 11, 2018 at 08:07:44AM +0800, lizhuoyao wrote: > hi: > I think there is something I expressed inaccurate,because my English is > poor. > Or,except vnc and virt-manager, is there other way can I login into domain? > (virt-install is succeed,and domain is seen by virsh list..)

[virt-tools-list] [virt-viewer v2] win32: Look up translations relative to installation directory

bindtextdomain() with a directory which is relative to the installation path so that translation are properly found. This is similar to what spice-gtk is doing: https://cgit.freedesktop.org/spice/spice-gtk/tree/src/spice-glib-main.c Signed-off-by: Christophe Fergeau <cferg...@redhat.com> --- Changes si

[virt-tools-list] [virt-viewer] win32: Look up translations relative to installation directory

bindtextdomain() with a directory which is relative to the installation path so that translation are properly found. This is similar to what spice-gtk is doing: https://cgit.freedesktop.org/spice/spice-gtk/tree/src/spice-glib-main.c Signed-off-by: Christophe Fergeau <cferg...@redhat.com> --- src/virt-

Re: [virt-tools-list] Virt-Viewer not working over VPN

Hey, On Thu, Feb 08, 2018 at 09:47:40AM -0800, Vincent Royer wrote: > Hi, > > When I access my vm's locally over virt-viewer on windows clients, > everything works fine. > > When I access the same vm's over a site-to-site VPN (setup between the two > firewalls), it fails with an error: unable

[virt-tools-list] [virt-viewer] Mark PrintScreen as translatable

It's for example ImprÉcran on French keyboards. Signed-off-by: Christophe Fergeau <cferg...@redhat.com> https://bugzilla.redhat.com/show_bug.cgi?id=1510411 --- src/virt-viewer-window.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/virt-viewer-window.c b/src/virt-

Re: [virt-tools-list] [PATCH v2] Add alpine linux 3.5, 3.6 and 3.7

Hey, On Wed, Nov 29, 2017 at 01:17:15PM +0100, Natanael Copa wrote: > Signed-off-by: Natanael Copa > --- > Changes since v1: > - add minimum and recommended memory/disk > - add alpine 3.7 release > - fix so release candidate iso images are detected (eg 3.7.0_rc2) > >

Re: [virt-tools-list] [PATCH virt-viewer v3] Fixes to spec file

Acked-by: Christophe Fergeau <cferg...@redhat.com> On Thu, Nov 23, 2017 at 11:52:53AM -0200, Eduardo Lima (Etrunko) wrote: > - Use macros for paths instead of absolute paths. > - Remove dangling %{gtk_arg} macro in configure. > - Fix scope of enable_autotools macro to avoid warni

Re: [virt-tools-list] [PATCH virt-viewer v2] Fixes to spec file

On Wed, Nov 22, 2017 at 04:21:49PM -0200, Eduardo Lima (Etrunko) wrote: > - Use macros for paths instead of absolute paths. > - Fix scope of enable_autotools macro to avoid warning during build. > warning: Macro %enable_autotools defined but not used within scope > > Signed-off-by: Eduardo Lima

Re: [virt-tools-list] [PATCH virt-viewer] doc: Adjust reference to spice-gtk man page for remote-viewer

Acked-by: Christophe Fergeau <cferg...@redhat.com> On Wed, Nov 22, 2017 at 03:09:32PM -0200, Eduardo Lima (Etrunko) wrote: > Similar to last commit, as noticed by reporter in bugzilla: > > https://bugzilla.redhat.com/show_bug.cgi?id=1477966 > > Man page should reference sp

Re: [virt-tools-list] [virt-viewer] doc: Adjust reference to spice-gtk man page

On Thu, Sep 21, 2017 at 05:56:21PM +0200, Pavel Grunt wrote: > > Yup, that was also my feeling when finding the doc-only spice-gtk > package :) > >I agree, is it in Fedora? el7 has just spice-gtk3 rpm >Pavel Yes, Fedora which still has %files %doc AUTHORS %doc COPYING %doc

Re: [virt-tools-list] [virt-viewer] doc: Adjust reference to spice-gtk man page

On Thu, Sep 21, 2017 at 10:12:01AM +0100, Daniel P. Berrange wrote: > On Thu, Sep 21, 2017 at 10:16:56AM +0200, Christophe Fergeau wrote: > > The man page spice-gtk ships is named "spice-client", not "spice-gtk" > > > > Signed-off-by: Christophe Fer

[virt-tools-list] [virt-viewer] doc: Adjust reference to spice-gtk man page

The man page spice-gtk ships is named "spice-client", not "spice-gtk" Signed-off-by: Christophe Fergeau <cferg...@redhat.com> https://bugzilla.redhat.com/show_bug.cgi?id=1477966 --- man/virt-viewer.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [virt-tools-list] remote viewer - auto scale screen

On Fri, Sep 15, 2017 at 01:56:59AM +0200, Oscar Segarra wrote: > Hi,  > > I have recently upgraded to windows virt-viewer (Remote Viewer 6.0) > > Imágenes integradas 1 > > But I have realized that the guest system does not autoscale resolution when > making bigger or smaller the guest desktop.

Re: [virt-tools-list] [PATCH virt-viewer 1/3] foreign-menu: Use query for fetching virtual machines

On Mon, Aug 07, 2017 at 10:28:32AM -0300, Eduardo Lima (Etrunko) wrote: > > IMHO would be better to have a release of libgovirt to make the new api > > stable :) (However I'd still consider using the `#ifdef > > |HAVE_OVIRT_API_SEARCH_VMS` check) > > Yeah, the idea is to release libgovirt soon

Re: [virt-tools-list] [PATCH virt-viewer 2/3] ovirt-foreign-menu: Fetch host, cluster and data center information

Hey, It would be nice to have an explanation in the commit log explaining *why* we need that. This might be explained in these bug reports, but we should not expect people to follow these links to understand why we needed to add this. Apart from this, the patch looks good to me. Christophe On

Re: [virt-tools-list] [PATCH virt-viewer] msi: Do not escape '$' for wixl-heat

On Mon, Jul 24, 2017 at 10:10:02AM +0200, Pavel Grunt wrote: > Hi, > > On Mon, 2017-07-24 at 08:54 +0100, Christophe Fergeau wrote: > > Hey, > > > > On Fri, Jul 21, 2017 at 07:27:45PM +0200, Pavel Grunt wrote: > > > wixl-heat does it itself since it

Re: [virt-tools-list] [PATCH virt-viewer] msi: Do not escape '$' for wixl-heat

Hey, On Fri, Jul 21, 2017 at 07:27:45PM +0200, Pavel Grunt wrote: > wixl-heat does it itself since its commit 9273514c95e343340d18067b4f1 > > otherwise msi generation fails with: > Couldn't find file > $/tmp/tmp.1MYrxTLd1U/usr/x86_64-w64-mingw32/sys-root/mingw/bin/debug-helper.exe Looks like

Re: [virt-tools-list] problems with virt-viewer 2.0-14

Hey, On Fri, May 26, 2017 at 12:35:19PM +0100, cmc wrote: > Hi, > > (I'm posting this to the correct list this time) > > Having trouble launching consoles for VMs in oVirt 4.1 on RHEL 6.8 > (virt-viewer > 2.0-14). I get: > > "At least Remote Viewer version 99.0-1 is required to setup this

[virt-tools-list] [virt-viewer] spec: Use https:// for Source/URL fields

The mingw-virt-viewer.spec/virt-viewer.spec file are currently using a mix of http and ftp for their URLs. ftp://virt-manager.org has never existed. This commit switches to use https:// everywhere. Signed-off-by: Christophe Fergeau <cferg...@redhat.com> --- mingw-virt-viewer.spec.

Re: [virt-tools-list] [PATCH virt-viewer] configure: Check for all libvirt dependencies

virt support to be silently enabled/disabled depending on what is installed. This fails when libvirt is detected, but libvirt-glib is missing/too old. In this situation, without your change, configure would error out when we expect it to just disable libvirt support. Your patch should fix this case,

Re: [virt-tools-list] [virt-manager] Reset Guest.domain to None on domain creation error

On Thu, Apr 13, 2017 at 07:04:13AM -0400, Xiaodai Wang wrote: > > > > > - Original Message ----- > > From: "Christophe Fergeau" <cferg...@redhat.com> > > To: virt-tools-list@redhat.com > > Sent: Thursday, April 13, 2017 5:18:46 PM &g

[virt-tools-list] [virt-manager] Reset Guest.domain to None on domain creation error

;, line 457, in start_install raise RuntimeError(_("Domain has already been started!")) RuntimeError: Domain has already been started! This is caused by code introduced in commit fc6778 which does not reset self.domain to None when an exception is caught. Signed-off-by: Christophe Fergea

Re: [virt-tools-list] [PATCH virt-viewer] Remove G_VALUE_INIT definition

Acked-by: Christophe Fergeau <cferg...@redhat.com> On Wed, Mar 29, 2017 at 11:14:42AM +0200, Pavel Grunt wrote: > Available in GLib since the version 2.30 I would have explicitly mentioned "and virt-viewer requires glib 2.38" Christophe signature.asc Descrip

[virt-tools-list] [virt-viewer] build-sys: Make spice-controller optional

The spice-controller integration code is only needed when a browser plugin is in use. This has been deprecated in favour of .vv files for several years now. This commit makes this code optional, if spice-controller.pc cannot be found, the controller code is not going to be built. --- configure.ac

[virt-tools-list] [virt-viewer] spice: Remove unneeded braces

Two statements in virt_viewer_session_spice_main_channel_event() are wrapped in a { } block, but this is unneeded. Signed-off-by: Christophe Fergeau <cferg...@redhat.com> --- src/virt-viewer-session-spice.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/sr

[virt-tools-list] [virt-viewer] man: Fix qemu+ssh URL in example

The 'system' path was missing: qemu+ssh://example.org/system Resolves: rhbz#1377283 --- man/virt-viewer.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/virt-viewer.pod b/man/virt-viewer.pod index ad3e298..9abf03c 100644 --- a/man/virt-viewer.pod +++

Re: [virt-tools-list] [virt-viewer PATCH] Test error->message and, if NULL, use a default message

On Fri, Feb 10, 2017 at 03:50:36PM +0100, Pavel Grunt wrote: > On Thu, 2017-02-09 at 18:46 +0100, Christophe de Dinechin wrote: > > I tend to agree. I don’t see how any legitimate GError * (from > > g_error_new or the like) would have a NULL message. So this is > > really defensive coding. > > >

Re: [virt-tools-list] [PATCH virt-viewer v3] Do not print password in the debug log

Acked-by: Christophe Fergeau <cferg...@redhat.com> On Tue, Jan 17, 2017 at 06:42:51PM +0100, Pavel Grunt wrote: > Do not show a length since it is sensitive info as well. > > Resolves: rhbz#1410030 > --- > src/virt-viewer.c | 11 ++- > 1 file changed, 10 i

Re: [virt-tools-list] [PATCH virt-viewer v2] Update for README.md

oreign] Acked-by: Christophe Fergeau <cferg...@redhat.com> signature.asc Description: PGP signature ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] [PATCH virt-viewer] iso-dialog: Avoid crash when closing dialog early

On Mon, Feb 06, 2017 at 05:55:58PM +0100, Pavel Grunt wrote: > On Fri, 2017-02-03 at 14:42 -0200, Eduardo Lima (Etrunko) wrote: > > On 03/02/17 14:34, Christophe Fergeau wrote: > > > Hey, > > > > > > On Thu, Jan 26, 2017 at 06:01:23PM -0200, Eduardo Lima (E

Re: [virt-tools-list] [PATCH virt-viewer] Update for README.md

On Mon, Feb 06, 2017 at 12:06:25PM +0100, Pavel Grunt wrote: > It is needed to use the 'foreign' init option otherwise autotools > requires README > --- > I am sorry for breaking the build again. > An alternative for this patch would be to generate README from README.md > or reverting the previous

Re: [virt-tools-list] [PATCH virt-viewer] iso-dialog: Avoid crash when closing dialog early

Hey, On Thu, Jan 26, 2017 at 06:01:23PM -0200, Eduardo Lima (Etrunko) wrote: > We must take into account that users can close the dialog at anytime, > even during an operation of fetch or set ISO has not been finished. This > will cause the callbacks for those operations to be invoked with an >

Re: [virt-tools-list] [PATCH virt-viewer 4/4] iso-dialog: Use header bar for buttons

Patch looks good to me, regarding the UI implications of the change to header bar, I don't know, I haven't followed that up closely. Christophe On Mon, Jan 23, 2017 at 05:28:16PM -0200, Eduardo Lima (Etrunko) wrote: > It seems to give more modern look to the dialog, but it requires Gtk+ > 3.12,

Re: [virt-tools-list] [PATCH virt-viewer 2/4] Run ISO dialog when 'Change CD' menu is activated

om RemoteViewer, acessible via property, so 'accessible'. Behaviour of the menu with this patch is quite odd, maybe a few bits from the next patch belong in here? However, I think I'd just merge both patches (?). Apart from this, Acked-by: Christophe Fergeau <cferg...@redhat.com> Christoph

Re: [virt-tools-list] [PATCH virt-viewer 1/5] ovirt-foreign-menu: Add accessors for current iso and iso list

Acked-by: Christophe Fergeau <cferg...@redhat.com> On Thu, Jan 19, 2017 at 01:42:10PM -0200, Eduardo Lima (Etrunko) wrote: > Also, to keep consistency around the codebase, changed the return value > of ovirt_foreign_menu_get_current_iso_name() from char * to gchar *. > > Sign

Re: [virt-tools-list] [PATCH virt-viewer 5/5] ovirt-foreign-menu: Remove GtkMenu related functions

Acked-by: Christophe Fergeau <cferg...@redhat.com> On Thu, Jan 19, 2017 at 01:42:14PM -0200, Eduardo Lima (Etrunko) wrote: > With this commit, we finish cleaning up ovirt foreign menu code, which > only deals with data, leaving the UI bits to be handled properly in the > new

Re: [virt-tools-list] [PATCH virt-viewer 4/5] Run ISO dialog when 'Change CD' menu is activated

Looks good, Acked-by: Christophe Fergeau <cferg...@redhat.com> On Thu, Jan 19, 2017 at 01:42:13PM -0200, Eduardo Lima (Etrunko) wrote: > Also moves 'Change CD' menu item from the toplevel menu to a subitem > under 'File' toplevel menu. > > In order to avoid obje

Re: [virt-tools-list] [PATCH virt-viewer 3/5] iso-dialog: Use header bar for buttons

I haven't looked at this patch at all, as I don't know what the plan is for virt-viewer regarding gtk+ versions. It's easy to move last in the series though. Would be nice if someone more informed about that chimed in on this patch ;) Christophe On Thu, Jan 19, 2017 at 01:42:12PM -0200, Eduardo

Re: [virt-tools-list] [PATCH virt-viewer 2/5] Introduce ISO List dialog

GTK_MESSAGE_ERROR, > +GTK_BUTTONS_CLOSE, > + message ? message : _("Unspecified > error")); > +gtk_dialog_run(GTK_DIALOG(dialog)); > +gtk_widget_destroy(dialog); >

Re: [virt-tools-list] [PATCH virt-viewer 8/9] Run iso-dialog when 'Change CD' menu is activated

On Thu, Jan 19, 2017 at 01:07:48PM -0200, Eduardo Lima (Etrunko) wrote: > On 19/01/17 11:06, Christophe Fergeau wrote: > > On Wed, Jan 18, 2017 at 12:16:59PM -0200, Eduardo Lima (Etrunko) wrote: > >> Also makes 'Change CD' menu item a submenu under 'File' toplevel menu &g

Re: [virt-tools-list] [PATCH virt-viewer 8/9] Run iso-dialog when 'Change CD' menu is activated

On Wed, Jan 18, 2017 at 12:16:59PM -0200, Eduardo Lima (Etrunko) wrote: > Also makes 'Change CD' menu item a submenu under 'File' toplevel menu > > Signed-off-by: Eduardo Lima (Etrunko) > --- > src/resources/ui/virt-viewer.ui | 19 ++- >

Re: [virt-tools-list] [PATCH virt-viewer 5/9] ovirt-foreign-menu: Add accessors for current iso and iso list

On Wed, Jan 18, 2017 at 12:16:56PM -0200, Eduardo Lima (Etrunko) wrote: > Signed-off-by: Eduardo Lima (Etrunko) > --- > src/ovirt-foreign-menu.c | 11 +-- > src/ovirt-foreign-menu.h | 2 ++ > 2 files changed, 11 insertions(+), 2 deletions(-) > > diff --git

Re: [virt-tools-list] [PATCH virt-viewer 3/9] remote-viewer: Make ovirt-foreign-menu a property

Looks good, but maybe better to squash this with later commits? (see my comment in one of the subsequent commits) Christophe On Wed, Jan 18, 2017 at 12:16:54PM -0200, Eduardo Lima (Etrunko) wrote: > The OvirtForeignMenu pointer is needed by the new ISO list dialog, and > we make it acessible

Re: [virt-tools-list] [PATCH virt-viewer 6/9] iso-dialog: Implement functionality provided by oVirt foreign menu

The issues pointed out in https://www.redhat.com/archives/virt-tools-list/2017-January/msg00039.html do not seem to have been addressed? Did you try merging the patches from "Introduce ISO List dialog" to "Run iso-dialog when 'Change CD' menu is activated" (without the headerbar change)? I think

Re: [virt-tools-list] virt-viewer moved GIT repository

On Thu, Jan 19, 2017 at 10:53:16AM +, Daniel P. Berrange wrote: > If you have a checkout, you'll need to replace your "origin" remote. > > git remote rm origin > > then one or these as appropriate: > > git remote add origin ssh://g...@pagure.io/virt-viewer.git (committers) > git

Re: [virt-tools-list] [PATCH virt-viewer 2/9] ovirt-foreign-menu: Fetch ISO names using GTask API

corner cases where this could be racy, with ovirt_foreign_menu_set_files() invalidating menu->priv->iso_names while this GTask still contains a pointer to it. I don't think this can occur with the way we use that API though, so probably not worth making a deep copy of it. Acked-by: Christophe Fergea

Re: [virt-tools-list] [PATCH virt-viewer 07/10] iso-dialog: Implement functionality provided by oVirt foreign menu

On Wed, Jan 18, 2017 at 10:12:20AM -0200, Eduardo Lima (Etrunko) wrote: > On 17/01/17 14:01, Christophe Fergeau wrote: > > On Fri, Jan 13, 2017 at 07:11:09PM -0200, Eduardo Lima (Etrunko) wrote: > >> Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> > >>

Re: [virt-tools-list] [PATCH virt-viewer 05/10] remote-viewer: Make ovirt-foreign-menu a property

On Wed, Jan 18, 2017 at 10:08:42AM -0200, Eduardo Lima (Etrunko) wrote: > On 18/01/17 09:53, Eduardo Lima (Etrunko) wrote: > > On 17/01/17 14:00, Christophe Fergeau wrote: > >> On Fri, Jan 13, 2017 at 07:11:07PM -0200, Eduardo Lima (Etrunko) wrote: > >>> The Ovir

Re: [virt-tools-list] [PATCH virt-viewer 01/10] remote-viewer: Extend #ifdef HAVE_OVIRT block

Acked-by: Christophe Fergeau <cferg...@redhat.com> On Fri, Jan 13, 2017 at 07:11:03PM -0200, Eduardo Lima (Etrunko) wrote: > The #endif is closing a #ifdef HAVE_OVIRT block, while another one is > opened right next, so there is no need to have those lines. Also, due to > t

Re: [virt-tools-list] [PATCH virt-viewer 05/10] remote-viewer: Make ovirt-foreign-menu a property

On Fri, Jan 13, 2017 at 07:11:07PM -0200, Eduardo Lima (Etrunko) wrote: > The OvirtForeignMenu pointer is needed by the new ISO list dialog, and > we make it acessible via property to avoid interdependency between > objects. > > Signed-off-by: Eduardo Lima (Etrunko) > --- >

Re: [virt-tools-list] [PATCH virt-viewer 03/10] ovirt-foreign-menu: Fetch ISO names using GTask API

ject, > gpointer user_data) > { > GError *error = NULL; > -OvirtForeignMenu *menu = OVIRT_FOREIGN_MENU(user_data); > -OvirtCollection *collection; > +GTask *task = G_TASK(user_data); > +OvirtForeignMenu *menu = > OVIRT_FOREIGN_MENU(g_task_get_source_object(task)); > +OvirtCollection *collection = OVIRT_COLLECTION(source_object); > GHashTableIter iter; > OvirtVm *vm; > > -collection = OVIRT_COLLECTION(source_object); > ovirt_collection_fetch_finish(collection, result, ); > if (error != NULL) { > g_debug("failed to fetch VM list: %s", error->message); > -g_clear_error(); > +g_task_return_error(task, error); > +g_object_unref(task); > return; > } > > @@ -736,14 +758,15 @@ static void vms_fetched_cb(GObject *source_object, > g_free(guid); > } > if (menu->priv->vm != NULL) { > -ovirt_foreign_menu_next_async_step(menu, STATE_VM); > +ovirt_foreign_menu_next_async_step(menu, task, STATE_VM); > } else { > g_warning("failed to find a VM with guid \"%s\"", > menu->priv->vm_guid); g_task_return_error() Reviewed-by: Christophe Fergeau <cferg...@redhat.com> signature.asc Description: PGP signature ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] [PATCH virt-viewer] Do not print credentials in the debug log

Hey, On Wed, Jan 04, 2017 at 10:44:22AM +0100, Pavel Grunt wrote: > Resolves: rhbz#1410030 > --- > src/virt-viewer.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/virt-viewer.c b/src/virt-viewer.c > index 1121146..4da5cd5 100644 > --- a/src/virt-viewer.c > +++ b/src/virt-viewer.c

[virt-tools-list] [virt-viewer] vnc: Report error on virt_viewer_session_vnc_open_uri() failures

For example this changes the error message for 'vnc:foo:1' from "Failed to initiate connection" to "Invalid VNC URI: 'vnc:foo:1'" --- src/virt-viewer-session-vnc.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/src/virt-viewer-session-vnc.c

Re: [virt-tools-list] [virt-viewer] vnc: Error out when failing to parse URI in open_uri()

Hey, On Sat, Dec 10, 2016 at 01:42:10PM +0100, Fabiano Fidêncio wrote: > On Fri, Dec 9, 2016 at 4:48 PM, Christophe Fergeau <cferg...@redhat.com> > wrote: > > Currently, if an invalid URI is passed to > > virt_viewer_session_vnc_open_uri(), we wi

[virt-tools-list] [virt-viewer] vnc: Error out when failing to parse URI in open_uri()

Currently, if an invalid URI is passed to virt_viewer_session_vnc_open_uri(), we will pass a NULL host/port to vnc_display_open_host(), which will trigger a crash (see https://bugzilla.gnome.org/show_bug.cgi?id=775890). This commit errors out before calling vnc_display_open_host() when we failed

Re: [virt-tools-list] [virt-viewer] man: Mention that ssh-agent can be useful

On Fri, Dec 02, 2016 at 08:50:04PM +0100, Pavel Grunt wrote: > Hi, > > On Thu, 2016-12-01 at 17:32 +0100, Christophe Fergeau wrote: > > When using a tunneled SPICE connection, the user will get a dozen > > authentication prompts if they are not using ssh-agent. >

[virt-tools-list] [virt-viewer] man: Mention that ssh-agent can be useful

When using a tunneled SPICE connection, the user will get a dozen authentication prompts if they are not using ssh-agent. --- man/virt-viewer.pod | 9 + 1 file changed, 9 insertions(+) diff --git a/man/virt-viewer.pod b/man/virt-viewer.pod index bd953ed..ad3e298 100644 ---

Re: [virt-tools-list] where is virt-viewer

On Tue, Nov 15, 2016 at 10:10:16AM +1100, Tom Robinson wrote: > > On 14/11/16 17:51, Fabiano Fidêncio wrote: > > On Mon, Nov 14, 2016 at 4:12 AM, Tom Robinson > > wrote: > >> Ubuntu Xenial (16.04.1 LTS) > >> virt-viewer: virt-viewer-4.0.tar.gz > >> > >> Hi, > >> > >>

Re: [virt-tools-list] [PATCH virt-viewer v4 00/12] Replace oVirt foreign menu with dedicated dialog

On Wed, Nov 02, 2016 at 06:15:45PM +0100, Christophe Fergeau wrote: > This does not seem to apply on top of git master. Ah, just minor merge conflict in src/Makefile.am, easy to fix locally ;) Christophe signature.asc Description: PGP signat

  1   2   3   4   5   6   7   8   9   10   >