ANNOUNCE: forthcoming retirement of virt-tools mailing list

2023-10-17 Thread Daniel P . Berrangé
Hello Virt Tools Community For the past 14-ish years this mailing list has served as a place for accepting patches and having discussions for various virtualization userspace projects that didn't justify their own dedicated mailing list. Mostly this was virt-manager and virt-viewer, but also some

Re: Does Xen dom0 count as a VM?

2023-07-19 Thread Daniel P . Berrangé
On Wed, Jul 19, 2023 at 10:12:07AM +, Sergio Gelato wrote: > Does this project share the view expressed in > https://github.com/systemd/systemd/issues/28113#issuecomment-1621986461 > that "when it comes to systemd's PoV xen dom0 is not a VM. i.e. the VM > that owns the hardware is not a VM in o

[PATCH 1/5] virt-what-cvm: check if hypervisor bit is set

2023-06-29 Thread Daniel P . Berrangé
Before doing any probes for a confidential VM, check that the tool is running under a hypervisor, rather than bare metal Signed-off-by: Daniel P. Berrangé --- virt-what-cvm.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/virt-what-cvm.c b/virt-what-cvm.c index

[PATCH 0/5] virt-what-cvm: improve SEV-SNP detection on Azure/HyperV

2023-06-29 Thread Daniel P . Berrangé
CPUID. The fact name is also changed to 'hyperv-' instead of 'azure-' since it is really a property of the hypervisor rather than cloud service. Daniel P. Berrangé (5): virt-what-cvm: check if hypervisor bit is set virt-what-cvm: support alternative cpuid leaf ordering

[PATCH 4/5] virt-what-cvm: drop TPM logic for detecting SNP on HyperV/Azure

2023-06-29 Thread Daniel P . Berrangé
Now we have proper CPUID detection, we no longer need the TPM hacks. Signed-off-by: Daniel P. Berrangé --- Makefile.am | 3 - configure.ac| 2 - virt-what-cvm.c | 161 ++-- 3 files changed, 6 insertions(+), 160 deletions(-) diff --git a

[PATCH 5/5] virt-what-cvm: rename 'azure-hcl' fact to 'hyperv-hcl'

2023-06-29 Thread Daniel P . Berrangé
Azure is a cloud service that uses the HyperV platform, so we should refer to the fact as 'hyperv-hcl', not 'azure-hcl'. Signed-off-by: Daniel P. Berrangé --- virt-what-cvm.c | 2 +- virt-what-cvm.pod | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 2/5] virt-what-cvm: support alternative cpuid leaf ordering

2023-06-29 Thread Daniel P . Berrangé
The HyperV CPUID leaf for reporting the vendor string has an alternative ordering of ecx/edx. Signed-off-by: Daniel P. Berrangé --- virt-what-cvm.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/virt-what-cvm.c b/virt-what-cvm.c index f184768..1e7c50b 100644

[PATCH 3/5] virt-what-cvm: probe for SNP/HCL on HyperV/Azure via CPUID

2023-06-29 Thread Daniel P . Berrangé
When running a confidential VM on Azure (HyperV) we can probe CPUID leaf 0x4003 to detect if VM isolation is present, and 0x400c to detect what kind of isolation is used. Signed-off-by: Daniel P. Berrangé --- virt-what-cvm.c | 62 +++-- 1 file

[PATCH virt-what] Introduce 'virt-what-cvm' program

2023-05-26 Thread Daniel P . Berrangé
nvironments * Azure confidential guest with AMD SEV-SNP (GA) * Azure confidential guest with Intel TDX (technology preview) * Fedora 37 QEMU/KVM guest with AMD SEV (GA) * Fedora 37 QEMU/KVM guest with AMD SEV-ES (GA) * Fedora 38 QEMU/KVM guest with AMD SEV-SNP + SVSM (devel snapshot) Signed-off

Re: virt-manager upgrade

2022-10-07 Thread Daniel P . Berrangé
On Fri, Oct 07, 2022 at 10:21:18AM +0100, Richard W.M. Jones wrote: > On Thu, Oct 06, 2022 at 07:14:39PM +, woodcab wrote: > > Hello, > > > > Still new to Linux and had a few questions regarding upgrading to 4.1.0 > > > > I'm using virt-manager 2.2.1 on Ubuntu MATE 20.4. There is an > > upgr

Re: Support for IPv6 NAT Mode

2022-08-24 Thread Daniel P . Berrangé
On Wed, Aug 24, 2022 at 10:22:29AM +0530, vaishu venkat wrote: > Hello Daniel, > > Thanks for the quick response. > > By changing the above lines in the xml file, when applying/saving the > changes, it reverts back. Still I could notice the FORWARDING mode as > routed, not as NAT for IPv6. Pleas

Re: Support for IPv6 NAT Mode

2022-08-23 Thread Daniel P . Berrangé
On Tue, Aug 23, 2022 at 08:07:57PM +0530, vaishu venkat wrote: > Hi Team, > We currently experiment with the IPv6 application inside the > QEMU/KVM. But by default, Ipv6 is only enabled in the route mode, not able > to figure out how to change this NAT mode. I have attached the screensh

Re: How can I disable secure boot using virt-install cli?

2022-08-03 Thread Daniel P . Berrangé
On Wed, Aug 03, 2022 at 11:00:30AM -0500, Andrea Bolognani wrote: > On Wed, Aug 03, 2022 at 01:17:33PM +0800, Lucas Liu wrote: > > Hello all: > > > > I am looking for a way to disable secure boot for UEFI guests: > > In 3.2.0 I use the command blow to achieve it: > > > > # virt-install --name Guest

Re: [PATCH] detect AWS arm virtual instance as kvm

2022-05-25 Thread Daniel P . Berrangé
On Wed, May 25, 2022 at 02:34:53PM +0800, Frank Liang wrote: > Hello, > > aws arm virtual instances are running on top of Nitro hypervisor(KVM-based > hypervisor). > I am proposing this patch to keep virt-what output consistent with x86 > virtual instances. > Please review it. Thanks > > With thi

Re: no release tarball

2022-04-21 Thread Daniel P . Berrangé
On Thu, Apr 21, 2022 at 01:30:29PM +0200, Henrik Riomar wrote: > On Thu, Apr 21, 2022 at 1:11 PM Richard W.M. Jones wrote: > > > > On Thu, Apr 21, 2022 at 12:54:42PM +0200, Henrik Riomar wrote: > > > > I now note that commit b7cc3d93a613ef6d0ac5ccd6e32cc3d66e057243, that > > > is part of v1.22 in

Re: Add support for enabling Secure Encrypted Virtualization in the GUI

2022-04-20 Thread Daniel P . Berrangé
On Wed, Apr 20, 2022 at 09:11:27AM -0400, Cole Robinson wrote: > On 4/19/22 1:21 PM, Daniel P. Berrangé wrote: > > On Tue, Apr 19, 2022 at 12:05:29PM -0400, Cole Robinson wrote: > >> On 4/4/22 11:49 AM, Charles Arnold wrote: > >>> > >>> > >>>

Re: Add support for enabling Secure Encrypted Virtualization in the GUI

2022-04-19 Thread Daniel P . Berrangé
On Tue, Apr 19, 2022 at 12:05:29PM -0400, Cole Robinson wrote: > On 4/4/22 11:49 AM, Charles Arnold wrote: > > > > > > On 4/4/22 6:50 AM, Daniel P. Berrangé wrote: > >> On Fri, Apr 01, 2022 at 12:13:17PM -0600, Charles Arnold wrote: > >>>  From d700e8cee

Re: Add support for enabling Secure Encrypted Virtualization in the GUI

2022-04-04 Thread Daniel P . Berrangé
On Mon, Apr 04, 2022 at 06:21:42PM +0200, Boris Fiuczynski wrote: > On 4/4/22 5:48 PM, Charles Arnold wrote: > > On 4/4/22 8:37 AM, Boris Fiuczynski wrote: > > > On 4/4/22 2:50 PM, Daniel P. Berrangé wrote: > > > > On Fri, Apr 01, 2022 at 12:13:17PM -0600, Charles

Re: Add support for enabling Secure Encrypted Virtualization in the GUI

2022-04-04 Thread Daniel P . Berrangé
On Fri, Apr 01, 2022 at 12:13:17PM -0600, Charles Arnold wrote: > From d700e8cee7cd525c0022b5a9a440f64c4ab149f0 Mon Sep 17 00:00:00 2001 > From: Charles Arnold > Date: Fri, 1 Apr 2022 12:01:21 -0600 > Subject: [PATCH 1/1] Add support for enabling Secure Encrypted > Virtualization >  in the GUI >

Re: virt-viewer light theme?

2021-11-29 Thread Daniel P . Berrangé
On Fri, Nov 26, 2021 at 02:37:45PM -0800, ToddAndMargo wrote: > Hi All, > > FC35 > Xfce 4.16 > virt-viewer-10.0-4.fc35.x86_64 > > Is there a way to switch virt-viewer's decorations > from its current dark theme to a light or system > theme? You can set an env variable if desired GTK_THEME=Adw

Re: [PATCH virt-manager v2 1/2] tests: add tests to support MDEV name change

2021-11-12 Thread Daniel P . Berrangé
On Fri, Nov 12, 2021 at 11:51:48AM +0100, Shalini Chellathurai Saroja wrote: > Add tests to ensure that the UUID of mediated devices are parsed > correctly in both newer and older(<7.3.0) versions of libvirt. > > The node device names of mediated devices are changed from > 'MDEV_$UUID'(eg: mdev_b2

Re: Triggering a checkpoint from inside the VM

2021-09-09 Thread Daniel P . Berrangé
On Thu, Sep 09, 2021 at 08:31:58AM +, Leek, Jim wrote: > I’ll try snapshot create, I didn’t know about that. > > I understand your security concerns, but they don’t apply in this case. The > target environment is air gapped and isolated. I can’t see any reason to fear > an attack on the VM b

Re: Triggering a checkpoint from inside the VM

2021-09-09 Thread Daniel P . Berrangé
On Thu, Sep 09, 2021 at 12:30:53AM +, Leek, Jim wrote: > Here's the error I sometimes get on checkpoint/restore. It just happened > again. In this test I had at least a 40 second break between checkpoint and > restore, so extra sleep doesn't seem to help much. > > Error unpausing domain: T

Re: Triggering a checkpoint from inside the VM

2021-09-09 Thread Daniel P . Berrangé
On Wed, Sep 08, 2021 at 04:22:31AM +, Leek, Jim wrote: > I'm on a RHEL 8 host, using virt-manager to run a CentOS 8 guest. I need > to be able to have a program on the guest trigger a checkpoint to save > the guest. I came up with a kludgy way to do this involving a script > that ssh's to the

Re: [PATCH v2] virtmanager: Fixed the legacy firmware installation error

2021-01-12 Thread Daniel P . Berrangé
On Tue, Jan 12, 2021 at 05:38:48PM +0800, Yu-Chen, Cho wrote: > From: "Cho, Yu-Chen" > > When we choose /usr/share/qemu/bios.bin or /usr/share/qemu/bios-256k.bin > in Customize configuration before install, show this error message: > > Unable to complete install: 'operation failed: unable to fin

Re: [PATCH] Add -m/--machine option. Pick the default machine type depending on arch.

2020-09-10 Thread Daniel P . Berrangé
*) machine= ;; > +esac avr, rx and tricore also lack a defalt but none of those matter for this purpose Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

Re: [virt-viewer PATCH] about ui: year 2020 in Copyright

2020-08-28 Thread Daniel P . Berrangé
On Fri, Aug 28, 2020 at 10:40:07AM -0400, Frediano Ziglio wrote: > > > > On Fri, Aug 28, 2020 at 10:22:49AM -0400, Frediano Ziglio wrote: > > > > > > > > On Thu, Aug 27, 2020 at 09:39:37PM +0300, Uri Lublin wrote: > > > > > rhbz#1848267 > > > > > > > > > > Signed-off-by: Uri Lublin > > > > > >

Re: [virt-viewer PATCH] about ui: year 2020 in Copyright

2020-08-28 Thread Daniel P . Berrangé
On Fri, Aug 28, 2020 at 10:22:49AM -0400, Frediano Ziglio wrote: > > > > On Thu, Aug 27, 2020 at 09:39:37PM +0300, Uri Lublin wrote: > > > rhbz#1848267 > > > > > > Signed-off-by: Uri Lublin > > > > Patches need to be subitted as pull requests to the gitlab repo > > please. > > > > > --- > > >

Re: [virt-viewer PATCH] about ui: year 2020 in Copyright

2020-08-28 Thread Daniel P . Berrangé
On Thu, Aug 27, 2020 at 09:39:37PM +0300, Uri Lublin wrote: > rhbz#1848267 > > Signed-off-by: Uri Lublin Patches need to be subitted as pull requests to the gitlab repo please. > --- > > Should po/* files be modified too ? Not really. There's no need to keep changing copyright dates in source

Re: [PATCH] Correct two translations for zh_CN

2020-08-05 Thread Daniel P . Berrangé
On Wed, Aug 05, 2020 at 10:42:22AM -0400, Cole Robinson wrote: > On 8/5/20 4:32 AM, Pavel Hrdina wrote: > > On Wed, Aug 05, 2020 at 12:44:24PM +0800, Huacai Chen wrote: > >> Hi, Pavel, > >> > >> On Mon, Aug 3, 2020 at 8:06 PM Pavel Hrdina wrote: > >>> > >>> On Mon, Aug 03, 2020 at 04:45:03PM +0800

Re: How to update virt-viewer translations

2020-07-09 Thread Daniel P . Berrangé
On Thu, Jul 09, 2020 at 04:46:30AM -0400, Frediano Ziglio wrote: > Hi, > I'm trying to fix https://bugzilla.redhat.com/show_bug.cgi?id=1503187, > a translation bug in virt-viewer. > It's not clear how to proceed. Looking at virt-viewer source the translations > are synced from Zanata. I have an a

Re: Multiple video elements lead to erratic mouse behavior through spice

2020-06-10 Thread Daniel P . Berrangé
On Wed, Jun 10, 2020 at 01:58:13PM +0200, Christian Ehrhardt wrote: > Hi, > with a guest set up as in the following example mouse behavior breaks: > > > > > > > primary='yes'/> > function='0x0'/> > > > > function='0x0'/> > > > Please no

Re: Connection issues with virt-viewer 9.0 (win)

2020-05-20 Thread Daniel P . Berrangé
On Wed, May 20, 2020 at 12:19:59PM -0500, fletch b wrote: > Hi, > I just upgraded to virt-viever-9.0(win) and ran into issues I never saw > with ver 7,0 > > When trying to connect to my vm I would get to the point where I would see > this: > > "connected to graphic server" and nothing after that

Re: How to install an OS with 2 installation iso file

2020-05-05 Thread Daniel P . Berrangé
On Tue, May 05, 2020 at 03:14:25PM +0100, Richard W.M. Jones wrote: > On Sun, May 03, 2020 at 03:31:38PM +0530, Harsh chopra wrote: > > Hi everyone, > > I was trying to install Centos 2.1 on the virtual machine, > > Ambitious! Note that older operating systems often don't work in > qemu, not for

ANNOUCE: virt-viewer version 9.0 released

2020-05-01 Thread Daniel P . Berrangé
I am happy to announce a new bugfix release of virt-viewer 9.0: https://virt-manager.org/download/sources/virt-viewer/virt-viewer-9.0.tar.gz https://virt-manager.org/download/sources/virt-viewer/virt-viewer-9.0.tar.gz.asc including experimental Windows installers for Win x86: https://virt-manage

Re: [PATCH] virtinst: use 'host-passthrough' as default 'host' on AArch64

2020-04-07 Thread Daniel P . Berrangé
On Tue, Apr 07, 2020 at 08:01:50AM -0400, Liang Yan wrote: > Thanks for the input. > > On 4/7/20 3:54 AM, Andrea Bolognani wrote: > > On Mon, 2020-04-06 at 16:51 -0400, Liang Yan wrote: > >> virt-install already uses 'host-passthrough' as default when no setup > >> for cmline '--cpu'. However, it

virt-viewer move to GitLab, with merge requests

2020-04-07 Thread Daniel P . Berrangé
Hi All, Historically the virt-viewer project has accepted contributions via patches submitted to this mailing list, with the master git repository originally being on fedorahosted.org and then on pagure.io. With libvirt moving to GitLab and merge requests, and spice-gtk/gtk-vnc also both already

Re: [PATCH remote-viewer] Fix potential file descriptor leaks found by Coverity.

2020-04-01 Thread Daniel P . Berrangé
t; a leak of resources. > > This was reported by a Coverity scan, logged under > https://bugzilla.redhat.com/show_bug.cgi?id=1655792 > > Signed-off-by: Julien Ropé > --- > src/virt-viewer-app.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) Review

Re: Adding an "Enable Launch Security" checkbox to the Memory Details dialog

2020-03-27 Thread Daniel P . Berrangé
On Fri, Mar 27, 2020 at 12:13:09PM -0400, Cole Robinson wrote: > CCing Erik who knows more about that launchSecurity/sev than I do > > On 3/27/20 11:44 AM, Charles Arnold wrote: > > What is the opinion of adding a checkbox called "Enable Launch > > Security" under the 'Current allocation' and 'Max

Re: shm as domain to virt-viewer protocol?

2020-03-26 Thread Daniel P . Berrangé
On Wed, Mar 25, 2020 at 06:16:47PM +, David Geise wrote: > Hi, > > I've been using an open-source project that's currently in beta called > Looking Glass (https://looking-glass.hostfission.com/) to achieve high- > performance VM graphics in a standalone workstation scenario where the > guest V

Re: [PATCH remote-viewer v2 1/1] Remember monitor mapping on close.

2020-02-07 Thread Daniel P . Berrangé
c | 120 ++++++ > 1 file changed, 120 insertions(+) Reviewed-by: Daniel P. Berrangé and pushed to git master Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-http

Re: [PATCH remote-viewer 1/1] Remember monitor mapping on close.

2020-02-05 Thread Daniel P . Berrangé
On Wed, Feb 05, 2020 at 10:02:25AM +0100, Julien ROPE wrote: > > Hi Daniel, > > I looked into this, and I'm not sure how to fix it. > > I'm new to GTK. But from what I can tell, there was no way of accessing > Monitor information before GTK 3.22. > > All those APIs that I'm using were introduc

Re: [PATCH remote-viewer 1/1] Remember monitor mapping on close.

2020-01-28 Thread Daniel P . Berrangé
On Tue, Jan 21, 2020 at 08:48:35AM +0100, Julien Ropé wrote: > When the application is stopped, if the windows are in fullscreen, their > position on the client will be remembered. > > This change uses the existing option 'monitor-mapping' in the settings > file to save the position and reuse it o

Re: virt-manager version question

2020-01-28 Thread Daniel P . Berrangé
On Mon, Jan 27, 2020 at 02:15:28PM -0500, Scott Reeve wrote: > Virtual Machine Manager version I have is 0.9.5. > Says: Copyright (C) 2006-2011 Red Hat Inc. > > I see this version on a ubuntu machine running 14.04 (yes old). > See the same version on a Centos machine running 6.6. > > On a Centos

Re: [virt-viewer PATCH v4 1/1] remote-viewer: add handler for SIGINT signal

2020-01-17 Thread Daniel P . Berrangé
On Fri, Jan 17, 2020 at 04:06:13PM +0100, Francesco Giudici wrote: > When remote-viewer is started from terminal, CTRL-C sends a SIGINT > signal to the program causing immediate termination. On linux clients > usb redirected devices are left without any kernel driver attached, > causing them to app

Re: [virt-viewer PATCH v2] remote-viewer: add handler for SIGINT signal

2020-01-17 Thread Daniel P . Berrangé
On Fri, Jan 17, 2020 at 12:04:08PM +0100, Francesco Giudici wrote: > When remote-viewer is started from terminal, CTRL-C sends a SIGINT > signal to the program causing immediate termination. On linux clients > usb redirected devices are left without any kernel driver attached, > causing them to app

Re: [virt-tools-list] FYI: intention to remove mail subject prefix & footer text

2020-01-15 Thread Daniel P . Berrangé
FYI, I'm intending to make this change tomorrow (Thurs Jan 16th) On Fri, Jan 10, 2020 at 11:44:04AM +0000, Daniel P. Berrangé wrote: > Hi List Subscribers, > > In recent months we have been seeing an increasing number of bounced > deliveries from the mailing list due to DMARC

[virt-tools-list] FYI: intention to remove mail subject prefix & footer text

2020-01-10 Thread Daniel P . Berrangé
Hi List Subscribers, In recent months we have been seeing an increasing number of bounced deliveries from the mailing list due to DMARC policies on list subscriber's mail servers. IOW, many subscribers are only receiving a subset of mails sent to this list. We believe the root cause of many of th

Re: [virt-tools-list] virt-manager: snapshot uefi vm

2019-12-24 Thread Daniel P . Berrangé
On Mon, Dec 23, 2019 at 03:27:05PM -0800, femi wrote: > When will snapshots of UEFI virtual machines become a reality? It is blocked by limitations in QEMU. The savevm command doens't have any way to be told a list of disks to snapshot & this breaks with UEFI as it considers the NVRAM file a disk

Re: [virt-tools-list] virt-manager test suite hangs on FreeBSD

2019-12-12 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 09:47:42AM +0100, Andrea Bolognani wrote: > On Wed, 2019-12-11 at 18:01 -0500, Cole Robinson wrote: > > On 12/11/19 7:40 AM, Andrea Bolognani wrote: > > > On Wed, 2019-12-11 at 07:28 -0500, Cole Robinson wrote: > > > > On 12/11/19 5:22 AM, Andrea Bolognani wrote: > > > > > I

Re: [virt-tools-list] virt-install and cloud-init, feedback wanted

2019-11-25 Thread Daniel P . Berrangé
On Mon, Nov 25, 2019 at 11:29:38AM +, Richard W.M. Jones wrote: > On Mon, Nov 25, 2019 at 11:23:14AM +0000, Daniel P. Berrangé wrote: > > On Mon, Nov 25, 2019 at 11:13:00AM +, Richard W.M. Jones wrote: > > > On Fri, Nov 22, 2019 at 09:56:17AM +, Daniel P. Berrangé wro

Re: [virt-tools-list] virt-install and cloud-init, feedback wanted

2019-11-25 Thread Daniel P . Berrangé
On Mon, Nov 25, 2019 at 11:13:00AM +, Richard W.M. Jones wrote: > On Fri, Nov 22, 2019 at 09:56:17AM +0000, Daniel P. Berrangé wrote: > > On Thu, Nov 21, 2019 at 09:39:46PM -0500, Dusty Mabe wrote: > > > > > > > > > On 11/21/19 6:20 AM, Daniel P. Berrangé

Re: [virt-tools-list] virt-install and cloud-init, feedback wanted

2019-11-22 Thread Daniel P . Berrangé
On Thu, Nov 21, 2019 at 07:44:38PM -0500, Cole Robinson wrote: > On 11/21/19 5:28 AM, Daniel P. Berrangé wrote: > > One option is to take the lazy approach and always enable cloud init > > if we are given a pre-built disk image. > > > > * If the disk image doesn

Re: [virt-tools-list] virt-install and cloud-init, feedback wanted

2019-11-22 Thread Daniel P . Berrangé
On Thu, Nov 21, 2019 at 09:39:46PM -0500, Dusty Mabe wrote: > > > On 11/21/19 6:20 AM, Daniel P. Berrangé wrote: > > On Thu, Nov 21, 2019 at 11:07:24AM +, Richard W.M. Jones wrote: > >> On Thu, Nov 21, 2019 at 10:34:14AM +, Daniel P. Berrangé wrote: > >&g

Re: [virt-tools-list] virt-install and cloud-init, feedback wanted

2019-11-21 Thread Daniel P . Berrangé
On Thu, Nov 21, 2019 at 12:04:11PM +0100, Christian Ehrhardt wrote: > On Thu, Nov 21, 2019 at 11:52 AM Florian Weimer wrote: > > > > * Daniel P. Berrangé: > > > > >> This goes probably in a different direction of what has been implement > > >> so

Re: [virt-tools-list] virt-install and cloud-init, feedback wanted

2019-11-21 Thread Daniel P . Berrangé
On Thu, Nov 21, 2019 at 12:06:49PM +0100, Florian Weimer wrote: > * Daniel P. Berrangé: > > > On Thu, Nov 21, 2019 at 11:52:26AM +0100, Florian Weimer wrote: > >> * Daniel P. Berrangé: > >> > >> >> This goes probably in a different direction of what

Re: [virt-tools-list] virt-install and cloud-init, feedback wanted

2019-11-21 Thread Daniel P . Berrangé
On Thu, Nov 21, 2019 at 11:07:24AM +, Richard W.M. Jones wrote: > On Thu, Nov 21, 2019 at 10:34:14AM +0000, Daniel P. Berrangé wrote: > > On Wed, Nov 20, 2019 at 08:18:01PM -0500, Dusty Mabe wrote: > > > Basically in Fedora CoreOS we need a generic user data mechanism that

Re: [virt-tools-list] virt-install and cloud-init, feedback wanted

2019-11-21 Thread Daniel P . Berrangé
On Thu, Nov 21, 2019 at 11:52:26AM +0100, Florian Weimer wrote: > * Daniel P. Berrangé: > > >> This goes probably in a different direction of what has been implement > >> so far, but would it actually harm to enable the network-based > >> instance-data injection

Re: [virt-tools-list] virt-install and cloud-init, feedback wanted

2019-11-21 Thread Daniel P . Berrangé
On Thu, Nov 21, 2019 at 08:40:12AM +0100, Florian Weimer wrote: > * Cole Robinson: > > > One more point: my main interaction with cloud-init has historically > > been by grabbing a Fedora/RHEL cloud image, passing it to > > virt-install/virt-manager, and watching the boot hang, because there's > >

Re: [virt-tools-list] virt-install and cloud-init, feedback wanted

2019-11-21 Thread Daniel P . Berrangé
On Wed, Nov 20, 2019 at 08:18:01PM -0500, Dusty Mabe wrote: > > > On 11/20/19 5:49 PM, Cole Robinson wrote: > > Hi all. The purpose of this mail is to get some feedback on pending > > cloud-init support in virt-install. If you're on the CC list here, I > > either pulled your email from a cloud-in

Re: [virt-tools-list] virt-install and cloud-init, feedback wanted

2019-11-21 Thread Daniel P . Berrangé
On Wed, Nov 20, 2019 at 05:49:45PM -0500, Cole Robinson wrote: > Hi all. The purpose of this mail is to get some feedback on pending > cloud-init support in virt-install. If you're on the CC list here, I > either pulled your email from a cloud-init discussion on the the > virt-tools-list mailing li

Re: [virt-tools-list] [PATCH 0/3] virt-viewer: add SIGINT handler

2019-11-12 Thread Daniel P . Berrangé
On Tue, Nov 12, 2019 at 12:29:09PM +0100, Francesco Giudici wrote: > When remote-viewer or virt-viewer are terminated by a signal, they quit > without explicitly releasing resources. A bug[1] has been filed against > virt-viewer for not releasing redirected usb devices when it's terminated > by CTR

Re: [virt-tools-list] [PATCH 3/3] remote-viewer: allow to build with Microsoft Visual Studio

2019-11-12 Thread Daniel P . Berrangé
On Tue, Nov 12, 2019 at 12:29:12PM +0100, Francesco Giudici wrote: > In order to meaningfully use the g_io_channel_win32_new_fd() function > the C runtime used by GLib is required, which is msvcrt.dll. In current > Microsoft compilers it is near impossible to convince it to build code > that would

Re: [virt-tools-list] [RFC virt-viewer] virt-viewer-app: force quit if quit is requested twice

2019-11-01 Thread Daniel P . Berrangé
On Thu, Oct 31, 2019 at 12:19:17PM +0100, Kevin Pouget wrote: > The investigation of BZ#1713548 shows that the viewer cannot be closed > if Spice-GTK does not send the DISCONNECTED signal [1]. > > This patch allows a 'force-close' if the user requests twice to close > the app: > > 1. The first ti

Re: [virt-tools-list] [virt-manager PATCH 2/2] unattended: Don't log user & admin passwords

2019-07-03 Thread Daniel P . Berrangé
On Wed, Jul 03, 2019 at 02:42:30PM +0200, Fabiano Fidêncio wrote: > On Wed, Jul 3, 2019 at 1:54 PM Pavel Hrdina wrote: > > > > On Tue, Jul 02, 2019 at 09:21:45PM +0200, Fabiano Fidêncio wrote: > > > Logging user & admin passwords in the command-line is a security issue, > > > let's avoid doing so

Re: [virt-tools-list] [virt-manager PATCH v3] Introduction of cloud-init configuration in virt-install

2019-07-02 Thread Daniel P . Berrangé
On Fri, Jun 28, 2019 at 07:05:18PM +0300, Athina Plaskasoviti wrote: > Usage: > --cloud-init > > Signed-off-by: Athina Plaskasoviti > --- > virt-install| 5 +++ > virtinst/cli.py | 25 + > virtinst/install/cloudinit.py | 57 +

Re: [virt-tools-list] [virt-manager PATCH v3] Introduction of cloud-init configuration in virt-install

2019-07-02 Thread Daniel P . Berrangé
On Fri, Jun 28, 2019 at 07:05:18PM +0300, Athina Plaskasoviti wrote: > Usage: > --cloud-init > > Signed-off-by: Athina Plaskasoviti > --- > virt-install| 5 +++ > virtinst/cli.py | 25 + > virtinst/install/cloudinit.py | 57 +

Re: [virt-tools-list] [virt-manager PATCH][v2][RFC] Introduction of cloud-init configuration in virt-install

2019-06-25 Thread Daniel P . Berrangé
On Mon, Jun 24, 2019 at 01:53:38PM -0400, Cole Robinson wrote: > On 6/24/19 12:40 PM, Daniel P. Berrangé wrote: > > On Mon, Jun 24, 2019 at 12:12:16PM -0400, Cole Robinson wrote: > >> On 6/21/19 1:18 PM, Athina Plaskasoviti wrote: > >>> I am sending a v2 of

Re: [virt-tools-list] [virt-manager PATCH][v2][RFC] Introduction of cloud-init configuration in virt-install

2019-06-24 Thread Daniel P . Berrangé
On Mon, Jun 24, 2019 at 12:12:16PM -0400, Cole Robinson wrote: > On 6/21/19 1:18 PM, Athina Plaskasoviti wrote: > > I am sending a v2 of the patch for cloud init basic configuration during > > cloud image installation, applying previous suggestions. > > > > Fixed: > > > > -the way the installat

Re: [virt-tools-list] RFC: virt-manager UI philosophy draft

2019-06-24 Thread Daniel P . Berrangé
On Wed, Jun 19, 2019 at 06:34:38PM -0400, Cole Robinson wrote: > Hi all, > > I've drafted a wiki page about virt-manager UI philosophy, for lack of a > better term, suggestions welcome. The intention here is to provide some > guidance about what types of things we want to expose in the UI, both to

Re: [virt-tools-list] RFC: virt-manager feature removals

2019-06-24 Thread Daniel P . Berrangé
On Fri, Jun 21, 2019 at 07:14:56PM -0400, Cole Robinson wrote: > On 6/19/19 6:34 PM, Cole Robinson wrote: > > Hi all, > > > > I've drafted a wiki page about virt-manager UI philosophy, for lack of a > > better term, suggestions welcome. The intention here is to provide some > > guidance about what

Re: [virt-tools-list] [virt-manager PATCH][v2][RFC] Introduction of cloud-init configuration in virt-install

2019-06-24 Thread Daniel P . Berrangé
On Fri, Jun 21, 2019 at 01:50:51PM -0400, Cole Robinson wrote: > On 6/21/19 1:34 PM, Daniel P. Berrangé wrote: > > On Fri, Jun 21, 2019 at 08:18:45PM +0300, Athina Plaskasoviti wrote: > >> Triggered by: > >> --install is_cloud=yes ... --import > >> >

Re: [virt-tools-list] [virt-manager PATCH][v2][RFC] Introduction of cloud-init configuration in virt-install

2019-06-21 Thread Daniel P . Berrangé
On Fri, Jun 21, 2019 at 08:18:45PM +0300, Athina Plaskasoviti wrote: > Triggered by: > --install is_cloud=yes ... --import > > Signed-off-by: Athina Plaskasoviti > --- > virt-install| 9 --- > virtinst/cli.py | 2 ++ > virtinst/install/cloudinit.

Re: [virt-tools-list] [virt-manager PATCH] installer: Prefer "cdrom" over "floppy"

2019-06-07 Thread Daniel P . Berrangé
On Fri, Jun 07, 2019 at 01:32:55PM +0200, Fabiano Fidêncio wrote: > On Fri, Jun 7, 2019 at 12:49 PM Peter Crowther > wrote: > > > > On Fri, 7 Jun 2019 at 11:34, Daniel P. Berrangé wrote: > >> > >> On Fri, Jun 07, 2019 at 11:27:36AM +0100, Peter Crowther wrote

Re: [virt-tools-list] [virt-manager PATCH] installer: Prefer "cdrom" over "floppy"

2019-06-07 Thread Daniel P . Berrangé
On Fri, Jun 07, 2019 at 11:27:36AM +0100, Peter Crowther wrote: > On Fri, 7 Jun 2019 at 11:18, Daniel P. Berrangé wrote: > > > On Fri, Jun 07, 2019 at 12:00:56PM +0200, Fabiano Fidêncio wrote: > > > Instead of using "floppy" as the way to perform unattended install

Re: [virt-tools-list] [virt-manager PATCH] installer: Prefer "cdrom" over "floppy"

2019-06-07 Thread Daniel P . Berrangé
On Fri, Jun 07, 2019 at 12:00:56PM +0200, Fabiano Fidêncio wrote: > Instead of using "floppy" as the way to perform unattended installations > for Windoes, let's prefer using "cdrom" instead. Aren't there versions of windows which /only/ support "floppy", which would require us to preferentially u

[virt-tools-list] [virt-manager PATCH] domcapabilities: add md-clear to automatically enabled security features

2019-05-14 Thread Daniel P . Berrangé
The bit is set when microcode provides the mechanism to invoke a flush of various exploitable CPU buffers by invoking the VERW instruction. CVE-2018-12126, CVE-2018-12127, CVE-2018-12130, CVE-2019-11091 Signed-off-by: Daniel P. Berrangé --- virtinst/domcapabilities.py | 3 ++- 1 file changed

Re: [virt-tools-list] [virt-manager PATCH 5/5] virt-manager: add new checkbox to control CPU security features

2019-04-04 Thread Daniel P . Berrangé
On Thu, Apr 04, 2019 at 11:38:08AM +0200, Pavel Hrdina wrote: > On Thu, Apr 04, 2019 at 10:18:23AM +0100, Daniel P. Berrangé wrote: > > On Wed, Apr 03, 2019 at 03:52:51PM +0200, Pavel Hrdina wrote: > > > By default we copy CPU security features to the guest if specific CPU >

Re: [virt-tools-list] [virt-manager PATCH 4/5] domcapabilities: add caching of CPU security features

2019-04-04 Thread Daniel P . Berrangé
On Thu, Apr 04, 2019 at 11:34:56AM +0200, Pavel Hrdina wrote: > On Thu, Apr 04, 2019 at 10:17:10AM +0100, Daniel P. Berrangé wrote: > > On Wed, Apr 03, 2019 at 03:52:50PM +0200, Pavel Hrdina wrote: > > > We will call this function multiple times so it makes sense to cache the

Re: [virt-tools-list] [virt-manager PATCH 5/5] virt-manager: add new checkbox to control CPU security features

2019-04-04 Thread Daniel P . Berrangé
translatable="yes">Copy host security features: I'd probably change the label to "Enable known CPU security flaw mitigations" Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flick

Re: [virt-tools-list] [virt-manager PATCH 4/5] domcapabilities: add caching of CPU security features

2019-04-04 Thread Daniel P . Berrangé
t does change you likely want virt-install to have a consistent view of capabilities throughout its execution. For virt-manager though being more dynamic is possibly more desirable given its long life. Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https

Re: [virt-tools-list] [virt-manager PATCH 3/5] cli: introduce CPU secure parameter

2019-04-04 Thread Daniel P . Berrangé
On Thu, Apr 04, 2019 at 10:14:21AM +0100, Daniel P. Berrangé wrote: > On Wed, Apr 03, 2019 at 03:52:49PM +0200, Pavel Hrdina wrote: > > This will allow users to override the default behavior of virt-install > > which copies CPU security features available on the host to the g

Re: [virt-tools-list] [virt-manager PATCH 3/5] cli: introduce CPU secure parameter

2019-04-04 Thread Daniel P . Berrangé
On Wed, Apr 03, 2019 at 03:52:49PM +0200, Pavel Hrdina wrote: > This will allow users to override the default behavior of virt-install > which copies CPU security features available on the host to the guest > XML if specific CPU model is configured. > > Signed-off-by: Pavel Hrdina > --- > man/vi

Re: [virt-tools-list] [virt-manager PATCH 1/5] domcapabilities: remove recommended CPU features from security features

2019-04-04 Thread Daniel P . Berrangé
amd-ssbd is a security feature which fixes the same SSBD flaws as the virt-ssbd feature does. virt-ssbd is usable across all CPU models affected by SSBD, while amd-ssbd is only available in very new silicon. So virt-ssbd is the bette rchoice. amd-no-ssb just indicates that the CPU is not

Re: [virt-tools-list] [virt-manager PATCH 2/5] domcapabilities: fix typo in function name

2019-04-04 Thread Daniel P . Berrangé
On Wed, Apr 03, 2019 at 03:52:48PM +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > virtinst/domcapabilities.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com

Re: [virt-tools-list] [virt-manager PATCH 0/5] CPU security features improvements

2019-04-04 Thread Daniel P . Berrangé
On Thu, Apr 04, 2019 at 10:00:21AM +0100, Peter Crowther wrote: > On Thu, 4 Apr 2019 at 09:15, Daniel P. Berrangé wrote: > > > On Wed, Apr 03, 2019 at 07:49:48PM -0400, Cole Robinson wrote: > > I > > think it is reasonable to assume that if the user has upgraded the >

Re: [virt-tools-list] [virt-manager PATCH 0/5] CPU security features improvements

2019-04-04 Thread Daniel P . Berrangé
On Wed, Apr 03, 2019 at 07:49:48PM -0400, Cole Robinson wrote: > ccing danpb > > On 4/3/19 9:52 AM, Pavel Hrdina wrote: > > Pavel Hrdina (5): > > domcapabilities: remove recommended CPU features from security > > features > > domcapabilities: fix typo in function name > > cli: introduce

Re: [virt-tools-list] virt-viewer 8.0?

2019-03-29 Thread Daniel P . Berrangé
On Fri, Mar 29, 2019 at 06:43:34PM +0300, Hetz Ben Hamo wrote: > Oh thanks. > Any chance for a Fedora 29 build also please? :) I generally avoid sending rebases into existing Fedora releases. The time between Fedora releases is short enough that users don't have to wait long to get the new version

Re: [virt-tools-list] virt-viewer 8.0?

2019-03-29 Thread Daniel P . Berrangé
On Fri, Mar 29, 2019 at 05:38:29PM +0300, Hetz Ben Hamo wrote: > Hi, > > I see virt-viewer is available as version 8.0 on the home page. It's > available for Windows as well as the source. > > When will it be available as a binary package for linux distributions? I forgot to update Fedora, so I'

Re: [virt-tools-list] [virt-viewer PATCH 01/14] po: provide custom make rules for po file management

2019-03-11 Thread Daniel P . Berrangé
On Mon, Mar 11, 2019 at 12:05:25PM +0100, Christophe Fergeau wrote: > Hey, > > On Thu, Mar 07, 2019 at 02:42:45PM +0000, Daniel P. Berrangé wrote: > > After investigating in more detail it seems you can provide custom rules > > for XML files by setting GETTEXTDATADIR, so I c

Re: [virt-tools-list] [virt-viewer PATCH 01/14] po: provide custom make rules for po file management

2019-03-07 Thread Daniel P . Berrangé
On Tue, Mar 05, 2019 at 11:51:01AM +0100, Christophe Fergeau wrote: > On Tue, Mar 05, 2019 at 10:27:07AM +0000, Daniel P. Berrangé wrote: > > On Tue, Mar 05, 2019 at 11:23:34AM +0100, Christophe Fergeau wrote: > > > On Wed, Feb 20, 2019 at 05:50:52PM +, Daniel

Re: [virt-tools-list] [virt-viewer PATCH 00/14] po: improve translation handling

2019-03-05 Thread Daniel P . Berrangé
On Tue, Mar 05, 2019 at 11:24:49AM +0100, Christophe Fergeau wrote: > A few comments on the first patch, for the rest of the series, > > Reviewed-by: Christophe Fergeau > > Did you get feedback from people involved with translations regarding > these changes? No, but in general case it will hav

Re: [virt-tools-list] [virt-viewer PATCH 01/14] po: provide custom make rules for po file management

2019-03-05 Thread Daniel P . Berrangé
On Tue, Mar 05, 2019 at 11:23:34AM +0100, Christophe Fergeau wrote: > On Wed, Feb 20, 2019 at 05:50:52PM +0000, Daniel P. Berrangé wrote: > > Historically we have relied on intltool to install a standard > > po/Makefile.in.in which has very limited scope for customization.

Re: [virt-tools-list] [virt-viewer PATCH] Add a git-publish configuration file

2019-03-04 Thread Daniel P . Berrangé
On Tue, Feb 19, 2019 at 03:10:33PM +, Daniel P. Berrangé wrote: > On Tue, Feb 19, 2019 at 04:05:00PM +0100, Marc-André Lureau wrote: > > Hi > > On Tue, Feb 19, 2019 at 4:03 PM Daniel P. Berrangé > > wrote: > > > > > > Signed-off-by: Daniel P. Ber

Re: [virt-tools-list] [virt-viewer PATCH 00/14] po: improve translation handling

2019-03-04 Thread Daniel P . Berrangé
ping... On Wed, Feb 20, 2019 at 05:50:51PM +, Daniel P. Berrangé wrote: > This applies the same improvements previously done in libvirt: > > https://www.redhat.com/archives/libvir-list/2018-April/msg01004.html > > https://www.berrange.com/posts/2018/11/29/improved-tran

Re: [virt-tools-list] virt manager downloads not working

2019-02-27 Thread Daniel P . Berrangé
On Tue, Feb 26, 2019 at 01:07:15PM -0800, Dusty Humphries wrote: > Hi, > > I am attempting to download virt-viewer and virt-manager from > virtualize-manager.org but the downloads are not working for both. Is > someone on this list able to correct the issue please? That website address is wrong.

[virt-tools-list] [virt-viewer PATCH 04/14] po: minimize & canonicalize translations stored in git

2019-02-22 Thread Daniel P . Berrangé
in git. The languages are minimized in the following commit since it is a large mechanical process. Signed-off-by: Daniel P. Berrangé --- build-aux/minimize-po.pl | 37 + po/Makefile.am | 30 +++-- po/README.md | 58 +

[virt-tools-list] [virt-viewer PATCH 03/14] po: add rules for integration with zanata

2019-02-22 Thread Daniel P . Berrangé
Add rules to handle pushing virt-viewer.pot to zanata, and refreshing .po files with new content from zanata. Signed-off-by: Daniel P. Berrangé --- po/Makefile.am | 8 1 file changed, 8 insertions(+) diff --git a/po/Makefile.am b/po/Makefile.am index c5f7c36..f32537d 100644 --- a/po

[virt-tools-list] [virt-viewer PATCH 02/14] po: remove language list from zanata configuration

2019-02-22 Thread Daniel P . Berrangé
The element in zanata.xml is no longer relevant as this info is recorded server side. Signed-off-by: Daniel P. Berrangé --- po/zanata.xml | 99 --- 1 file changed, 99 deletions(-) diff --git a/po/zanata.xml b/po/zanata.xml index 63c682e..09396d3

[virt-tools-list] [virt-viewer PATCH v2 3/3] Switch to gnulib's compiler warning flags

2019-02-22 Thread Daniel P . Berrangé
This enables many more compiler warnings than the current code. It also ensures that -Werror is enabled by default when building from GIT so that maintainers see regressions as hard failures. Reviewed-by: Marc-André Lureau Signed-off-by: Daniel P. Berrangé --- acinclude.m4 | 98

  1   2   >