[virt-tools-list] [virt-what PATCH] Determine architecture via 'uname -m'

2018-01-27 Thread Guido Günther
'uname -p' only gives unknown on x86_64, i386, arm6l (rpi) and aarch64 (scaleways). --- It doesn't matter that much these days since cpuid is used most of the time but it's better to have this fixed (or remove the whole uname based code). virt-what.in | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [virt-tools-list] [virt-what PATCH v2] Remove bashisms

2017-09-28 Thread Guido Günther
Hi, On Thu, Sep 28, 2017 at 01:32:16PM +0100, Richard W.M. Jones wrote: > On Fri, Aug 04, 2017 at 12:02:08PM -0300, Guido Günther wrote: > > Use [ instead of [[ so we fall back to test if necessary: > > > > http://pubs.opengroup.org/onlinepubs/9699919799/utilities/test

Re: [virt-tools-list] [PATCH virt-viewer] Make it clear that only running VMs are listed

2017-09-15 Thread Guido Günther
Hi, On Thu, Sep 14, 2017 at 10:49:15AM -0500, Jonathon Jongsma wrote: > On Thu, 2017-08-31 at 09:49 +0200, Guido Günther wrote: > > this might otherwise be confusing. > > > > Reference: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=873597#2 > > 5 > > --- >

Re: [virt-tools-list] [virt-what PATCH v2] Remove bashisms

2017-09-10 Thread Guido Günther
Hi, On Tue, Aug 22, 2017 at 08:47:55PM +0200, Guido Günther wrote: > Hi, > > Ping? > -- Guido Ping? It already had a review by Eric. -- Guido > > On Fri, Aug 04, 2017 at 12:02:08PM -0300, Guido Günther wrote: > > Use [ instead of [[ so we fall back to test if neces

[virt-tools-list] [PATCH virt-viewer] Make it clear that only running VMs are listed

2017-08-31 Thread Guido Günther
this might otherwise be confusing. Reference: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=873597#25 --- src/virt-viewer-vm-connection.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/virt-viewer-vm-connection.c b/src/virt-viewer-vm-connection.c index ebaa92b..2f2c39

Re: [virt-tools-list] [virt-what PATCH v2] Remove bashisms

2017-08-22 Thread Guido Günther
Hi, Ping? -- Guido On Fri, Aug 04, 2017 at 12:02:08PM -0300, Guido Günther wrote: > Use [ instead of [[ so we fall back to test if necessary: > > http://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html > > Gbp-Pq: Name Remove-bashisms.patch > --- > Updat

Re: [virt-tools-list] [virt-what PATCH] Remove bashisms

2017-08-04 Thread Guido Günther
Hi, On Fri, Aug 04, 2017 at 09:37:53AM -0500, Eric Blake wrote: > On 08/04/2017 09:25 AM, Guido Günther wrote: > > Use [ instead of [[ > > Good. > > > and -a instead of && > > Absolutely not. Per POSIX, 'test cond1 -a cond2' is not portable; on

[virt-tools-list] [virt-what PATCH v2] Remove bashisms

2017-08-04 Thread Guido Günther
Use [ instead of [[ so we fall back to test if necessary: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html Gbp-Pq: Name Remove-bashisms.patch --- Updated with Eric's review comments addressed. virt-what.in | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-

[virt-tools-list] [virt-what PATCH] Remove bashisms

2017-08-04 Thread Guido Günther
Use [ instead of [[ and -a instead of && so we fall back to test if necessary: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html --- virt-what.in | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/virt-what.in b/virt-what.in index 8c27b11..56af

[virt-tools-list] [virt-manager PATCH] osdict: Debian8 onwards has qemu-ga

2016-10-24 Thread Guido Günther
--- Put to the front of the list to preserve the alphabetical order. virtinst/osdict.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virtinst/osdict.py b/virtinst/osdict.py index 3272a98..cddffbd 100644 --- a/virtinst/osdict.py +++ b/virtinst/osdict.py @@ -495,7 +495,7 @@ c

Re: [virt-tools-list] [PATCH virt-manager]: virtinst: correctly find the sles s390x kernel and initrd

2015-09-12 Thread Guido Günther
On Fri, Sep 11, 2015 at 10:28:08AM -0600, Charles Arnold wrote: > >>> On 9/11/2015 at 09:59 AM, Cole Robinson wrote: > > On 09/11/2015 11:41 AM, Charles Arnold wrote: > >> Allow virt-install to correctly find the SLES kernel/initrd on the media > >> when installing an s390x VM. > >> > >> Signed-

Re: [virt-tools-list] libvirt/virt-manager source integration with xen

2015-03-04 Thread Guido Günther
On Tue, Mar 03, 2015 at 02:31:27PM -0500, Wayne Mills wrote: > I downloaded and untarred the deb package and grepped for 'configure', but > none of the hits were configure commands. Is there a better way to find it? Assuming this is still based on the Debian package look for DEB_CONFIGURE_EXTRA_A

Re: [virt-tools-list] [virt-manager PATCH] Make SpiceClientGtk optional

2014-11-12 Thread Guido Günther
On Wed, Nov 12, 2014 at 04:11:17PM +0100, Christophe Fergeau wrote: > Hey, > > On Wed, Nov 12, 2014 at 09:33:44AM -0500, Cole Robinson wrote: > > In fedora, spice-gtk is built on all archs + secondary archs, which includes > > arm, ppc, and s390 at least. > > > > However spice-server is build res

Re: [virt-tools-list] [virt-manager PATCH] Make SpiceClientGtk optional

2014-11-09 Thread Guido Günther
On Fri, Nov 07, 2014 at 03:36:08PM -0500, Marc-André Lureau wrote: > Hi Guido > > - Original Message - > > It's not available on all architectures. This allows us to turn > > the hard dependency into a soft on. > > Could you precise on which architecture it is not available (but > gtk-vnc

[virt-tools-list] [virt-manager PATCH] Make SpiceClientGtk optional

2014-11-07 Thread Guido Günther
It's not available on all architectures. This allows us to turn the hard dependency into a soft on. --- virtManager/console.py | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/virtManager/console.py b/virtManager/console.py index 67bfe10..54e476f 100644 --- a/virt

[virt-tools-list] [virt-manager PATCH] Add conversion file to migrate GConf values to GSettings

2014-09-28 Thread Guido Günther
This makes sure we don't lose already configured connections. Reference: http://bugs.debian.org/740047 --- data/org.virt-manager.virt-manager.convert | 27 +++ setup.py | 2 ++ 2 files changed, 29 insertions(+) create mode 100644 data/or

[virt-tools-list] [virt-manager PATCH] s/gconf/gsettings/

2014-09-28 Thread Guido Günther
GConf got replaced by GSettings but some methods kept the old name --- virt-manager | 12 ++-- virtManager/baseclass.py | 14 +++--- virtManager/config.py| 8 virtManager/console.py | 14 +++--- virtManager/create.py| 2 +- virtManager/domai

Re: [virt-tools-list] [PATCH virt-viewer 1/2] VirtViewer: Fix memory leaks

2014-09-10 Thread Guido Günther
On Wed, Sep 10, 2014 at 01:42:13PM -0500, Jonathon Jongsma wrote: > Don't leak priv->uri or priv->domkey from VirtViewer class > --- > src/virt-viewer.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/src/virt-viewer.c b/src/virt-viewer.c > index c03503e..55780af 100644 > --- a/s

Re: [virt-tools-list] RFC: drop virt-viewer support for GTK-2 and use GTK-3 features

2014-06-09 Thread Guido Günther
On Mon, Jun 09, 2014 at 11:29:33AM +0100, Daniel P. Berrange wrote: > Currently the virt-viewer codebase is written to build with both GTK-2 > and GTK-3. This was primarily so that we could continue to support use > of virt-viewer on older distros like RHEL-6 which lack GTK-3 support. > GTK-3 has b

Re: [virt-tools-list] virt-manager 1.0 release this friday

2014-02-13 Thread Guido Günther
Hi Cole, On Tue, Feb 11, 2014 at 04:55:27PM -0500, Cole Robinson wrote: > Hey all, > > I've finished everything I wanted to finish for the next release, which I'd > like to call virt-manager 1.0 (bumping the major version is trendy these days > and this is probably the best opportunity we will hav

Re: [virt-tools-list] virt-manager 0.10.0 in Debian wheezy

2014-01-13 Thread Guido Günther
On Mon, Jan 13, 2014 at 11:23:00AM +0100, Christoph Pleger wrote: > Hello, > > >> Yes, latest virt-manager defaults to USB2 for new VMs (ehci). You must > >> be > >> using an old qemu version if it's blocking migration though... > > > > Great to know. There's 1.7.0 in backports which is hopefully

Re: [virt-tools-list] virt-manager 0.10.0 in Debian wheezy

2014-01-11 Thread Guido Günther
On Fri, Jan 10, 2014 at 10:50:17AM -0500, Cole Robinson wrote: > On 01/10/2014 10:31 AM, Christoph Pleger wrote: > > Hello, > > > >> You need whatever package provides the vte3 gobject introspection support. > > > > Version 0.10.0 is running now on another wheezy machine. I do not yet know > > wh

Re: [virt-tools-list] virt-manager 0.10.0 in Debian wheezy

2014-01-11 Thread Guido Günther
On Fri, Jan 10, 2014 at 08:13:55AM -0500, Cole Robinson wrote: > On 01/10/2014 06:11 AM, Christoph Pleger wrote: > > Hello, > > > > I am trying to run virt-manager 0.10.0 in Debian wheezy, but after > > starting virt-manager, the following error message appears: > > > > "Error starting Virtual Ma

Re: [virt-tools-list] [virt-viewer PATCH] Use format string

2013-06-25 Thread Guido Günther
Hi, On Tue, Jun 25, 2013 at 12:55:59PM +0200, Christophe Fergeau wrote: > On Tue, Jun 25, 2013 at 12:32:31PM +0200, Guido Günther wrote: > > to fix > > > > virt-viewer.c: In function 'virt_viewer_connect': > > virt-viewer.c:686:13: error: format not a string

[virt-tools-list] [virt-viewer PATCH] Use format string

2013-06-25 Thread Guido Günther
to fix virt-viewer.c: In function 'virt_viewer_connect': virt-viewer.c:686:13: error: format not a string literal and no format arguments [-Werror=format-security] g_warning(error->message); --- src/virt-viewer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sr

Re: [virt-tools-list] virt-manager gtk3 branch now available

2013-02-18 Thread Guido Günther
Hi, On Sat, Feb 16, 2013 at 02:32:36PM -0500, Cole Robinson wrote: [..snip..] > merge virtinst: > - no big clean up, just get it all + unit tests working > - merge history or just add code? Is there any pressing reason for this? It's great to have this as a separate python module for user in oth

Re: [virt-tools-list] virt-viewer over ssh

2012-11-06 Thread Guido Günther
On Tue, Nov 06, 2012 at 09:56:19AM -0500, Dave Allan wrote: > I'm having trouble with virt-viewer not connecting to a VM on a remote > host over SSH. It connects, briefly gives me a black VM display, and > then says that the remote disconnected. I've noticed a few paches on That was basically wh

Re: [virt-tools-list] [PATCH] Fail if neither vnc nor spice is detected

2012-10-24 Thread Guido Günther
stophe > > On Wed, Oct 24, 2012 at 09:05:01AM +0200, Guido Günther wrote: > > Since the viewer makes little sense otherwise. > > --- > > Fix -ENOCOFFEE error of v2 > > > > configure.ac |4 > > 1 file changed, 4 insertions(+) > > > > di

[virt-tools-list] [PATCH] Fail if neither vnc nor spice is detected

2012-10-24 Thread Guido Günther
Since the viewer makes little sense otherwise. --- Fix -ENOCOFFEE error of v2 configure.ac |4 1 file changed, 4 insertions(+) diff --git a/configure.ac b/configure.ac index e7ddd3e..f72e615 100644 --- a/configure.ac +++ b/configure.ac @@ -192,6 +192,10 @@ if test "x$enable_plugin" = "x

[virt-tools-list] [PATCH virt-viewer v2] Fail if neither vnc nor spice is detected

2012-10-24 Thread Guido Günther
Since the viewer makes little sense otherwise. --- Changes: Use && instead of -a configure.ac |4 1 file changed, 4 insertions(+) diff --git a/configure.ac b/configure.ac index e7ddd3e..c2aad40 100644 --- a/configure.ac +++ b/configure.ac @@ -192,6 +192,10 @@ if test "x$enable_plugin" =

[virt-tools-list] [PATCH virt-viewer] Don't fail early if virDomainOpenGraphics fails

2012-10-22 Thread Guido Günther
virt_viewer_app_open_connection invokes virDomainOpenGraphics which only works for local connections. Returning after this failure makes us never reach the ssh part so this unbreaks connections tunneled over ssh. --- src/virt-viewer-app.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

[virt-tools-list] [PATCH virt-viewer] Fail if opening the connection fails

2012-10-22 Thread Guido Günther
instead of returning True. Which then fails with the misleading error (virt-viewer:18631): Gtk-WARNING **: Attempting to add a widget with type VncDisplay to a container of type VirtViewerDisplayVnc, but the widget is already inside a container of type VirtViewerDisplayVnc, please use gtk_widget_r

[virt-tools-list] [PATCH virt-viewer] Fail if neither vnc nor spice is detected

2012-10-22 Thread Guido Günther
Since the viewer makes little sense otherwise. --- configure.ac |4 1 file changed, 4 insertions(+) diff --git a/configure.ac b/configure.ac index e7ddd3e..d5feb0f 100644 --- a/configure.ac +++ b/configure.ac @@ -192,6 +192,10 @@ if test "x$enable_plugin" = "xyes"; then fi AM_CONDITION

Re: [virt-tools-list] virt-install: zero allocation on lvm volumes

2012-10-16 Thread Guido Günther
Hi Cole, On Tue, Oct 16, 2012 at 08:45:03PM -0400, Cole Robinson wrote: > On 10/02/2012 04:30 PM, Doug Goldstein wrote: > > On Tue, Oct 2, 2012 at 12:16 PM, Guido Günther wrote: > >> Hi, > >> creating a vm with a virtual disk in an lvm pool e.g. via: > >> &

[virt-tools-list] [PATCH] Update Debian stable link

2012-10-12 Thread Guido Günther
This came in via the Debian bts: -- From: Geoff Simmons Date: Sat, 13 Oct 2012 01:34:52 +0200 Subject: The Debian stable release always exists. Release names go away. --- man/en/virt-install.1 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/en/virt-install.1 b/man/en

[virt-tools-list] [PATCH virtinst] Don't fail if no meter is used

2012-10-11 Thread Guido Günther
like in the other modules --- virtinst/DistroInstaller.py | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/virtinst/DistroInstaller.py b/virtinst/DistroInstaller.py index e559431..33efc31 100644 --- a/virtinst/DistroInstaller.py +++ b/virtinst/DistroInstaller.py @@

[virt-tools-list] [virt-viewer PATCH] Key here refers to a keyboard's key not that of a keyring

2012-10-07 Thread Guido Günther
so adjust the German translation. --- po/de.po |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/po/de.po b/po/de.po index 27f1b59..01f64aa 100644 --- a/po/de.po +++ b/po/de.po @@ -512,7 +512,7 @@ msgstr "Cursor freigeben" #: ../src/virt-viewer.xml.h:12 msgid "_Send key" -

[virt-tools-list] [PATCH] virt-install: avoid disk name collisions

2012-10-04 Thread Guido Günther
When specifying multiple disks in pool without giving a name: virt-install \ --disk=pool=test,bus=virtio,size=3.0,sparse=false --disk=pool=test,bus=virtio,size=3.0,sparse=false ... virt-install creates the names before hand which leads to name collisions later on. Avoid this by filling in a

[virt-tools-list] virt-install: zero allocation on lvm volumes

2012-10-02 Thread Guido Günther
Hi, creating a vm with a virtual disk in an lvm pool e.g. via: virt-install --disk=pool=vm_test,size=3.0 ... results in (from libvirtd's log): virCommandWait:2332 : internal error Child process (/sbin/lvcreate --name test01.img -L 0K --virtualsize 3145728K vg_vm_test) unexpected exit status 5:

[virt-tools-list] [python-virtinst][PATCH] Don't overwrite target element for disks that have it already set

2012-09-19 Thread Guido Günther
This makes the usage consistent with the bus element just above and allows to setup the target device before adding it to the Installer. --- I've attached the changed test output as well. As far as I can see this results from cases where we explicitly set a disk element which gets overridden. Is th

[virt-tools-list] [PATCH] LogicalPool: properly pass on autostart flag

2012-09-05 Thread Guido Günther
Otherwise setting autostart on pool creation doesn't work. --- virtinst/Storage.py |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virtinst/Storage.py b/virtinst/Storage.py index 2890700..42e7ab6 100644 --- a/virtinst/Storage.py +++ b/virtinst/Storage.py @@ -741,7 +741,7 @@

[virt-tools-list] [PATCH] (resend) Fix epydoc parsing errors.

2012-09-03 Thread Guido Günther
The API docs can now be built via: epydoc --parse-only -v virtinst --- Can this be applied? virtinst/CapabilitiesParser.py | 14 virtinst/DistroInstaller.py | 11 +++--- virtinst/Installer.py |4 +-- virtinst/NodeDeviceParser.py| 13

[virt-tools-list] [PATCH] Fix epydoc parsing errors.

2012-08-16 Thread Guido Günther
The API docs can now be built via: epydoc --parse-only -v virtinst --- virtinst/CapabilitiesParser.py | 14 virtinst/DistroInstaller.py | 11 +++--- virtinst/Installer.py |4 +-- virtinst/NodeDeviceParser.py| 13 virtinst/Storage

[virt-tools-list] [libosinfo] tests: skip schema check if xmllint is missing

2012-05-01 Thread Guido Günther
--- This makes it more obvious why the test fails/isn't being run. Cheers, -- Guido test/test-xml-validate |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/test-xml-validate b/test/test-xml-validate index e5be325..93a2d6b 100755 --- a/test/test-xml-validate +++ b/

[virt-tools-list] [virt-manager PATCH] Improve error message if netcat can't forward Unix domain sockets

2012-01-14 Thread Guido Günther
Otherwise the information: End of file while reading data: nc: invalid option -- 'U' nc -h for help: Input/output error is hidden in the error detail. See Debian bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=614291 --- src/virtManager/manager.py |6 +- 1 files changed, 5 ins

[virt-tools-list] [virt-manager PATCH] storagebrowser: ignore unparseable volumes

2012-01-10 Thread Guido Günther
This e.g. happens when the volume was moved away but the pool didn't get refereshed: Traceback (most recent call last): File "/usr/share/virt-manager/virtManager/create.py", line 1229, in browse_import self._browse_file(set_path, is_media=False) File "/usr/share/virt-manager/virtManager/c

Re: [virt-tools-list] [libosinfo PATCH] Fix libxml error reporting

2011-11-25 Thread Guido Günther
On Fri, Nov 25, 2011 at 10:32:41AM +0100, Christophe Fergeau wrote: > On Fri, Nov 25, 2011 at 09:30:27AM +0100, Guido Günther wrote: > > On Fri, Nov 18, 2011 at 11:03:41PM +0100, Guido Günther wrote: > > > The error code might be set in catchXMLError so make sure we don't m

Re: [virt-tools-list] [libosinfo PATCH] Fix libxml error reporting

2011-11-25 Thread Guido Günther
On Fri, Nov 25, 2011 at 01:34:02PM +0100, Christophe Fergeau wrote: > On Fri, Nov 25, 2011 at 09:30:27AM +0100, Guido Günther wrote: > > On Fri, Nov 18, 2011 at 11:03:41PM +0100, Guido Günther wrote: > > > The error code might be set in catchXMLError so make sure we don't m

Re: [virt-tools-list] [libosinfo PATCH] Fix libxml error reporting

2011-11-25 Thread Guido Günther
On Fri, Nov 18, 2011 at 11:03:41PM +0100, Guido Günther wrote: > The error code might be set in catchXMLError so make sure we don't miss > it. Otherwise this results in errors like: > > /usr/lib/python2.7/dist-packages/gi/types.py:43: Warning: GError set over the > top of

[virt-tools-list] [libosinfo PATCH] Fix libxml error reporting

2011-11-18 Thread Guido Günther
The error code might be set in catchXMLError so make sure we don't miss it. Otherwise this results in errors like: /usr/lib/python2.7/dist-packages/gi/types.py:43: Warning: GError set over the top of a previous GError or uninitialized memory. This indicates a bug in someone's code. You must ensur

[virt-tools-list] [PATCH] Document that ff callbacks need to be invoked from a clean stack

2011-10-03 Thread Guido Günther
On Tue, Aug 16, 2011 at 02:24:53PM +0200, Guido Günther wrote: > Hi Daniel, > On Sat, Aug 13, 2011 at 08:57:45PM -0700, Daniel P. Berrange wrote: > > On Fri, Aug 12, 2011 at 11:54:28PM +0200, Guido Günther wrote: > [..snip..] > > In the default libvirt event loop, the &#

Re: [virt-tools-list] [libvirt] Deadlock when using custom handlers

2011-08-16 Thread Guido Günther
Hi Daniel, On Sat, Aug 13, 2011 at 08:57:45PM -0700, Daniel P. Berrange wrote: > On Fri, Aug 12, 2011 at 11:54:28PM +0200, Guido Günther wrote: [..snip..] > In the default libvirt event loop, the 'ff' callback is always invoked > from a "clean" stack in the event

[virt-tools-list] [PATCH 3/4] Don't print incorrect port numbers

2011-08-12 Thread Guido Günther
The port isn't 22 when we connect to an alternate port given in .ssh/config. --- src/virt-viewer-app.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c index 2ad5710..c80d52f 100644 --- a/src/virt-viewer-app.c +++ b/src

[virt-tools-list] [PATCH 2/4] Don't hardcode ssh port to 0

2011-08-12 Thread Guido Günther
Many thanks to Luca Capello for debugging this. --- src/virt-viewer-app.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c index 71284b6..2ad5710 100644 --- a/src/virt-viewer-app.c +++ b/src/virt-viewer-app.c @@ -1311,7 +1311,

[virt-tools-list] [PATCH 1/4] Fix reversed logic for ssh port setting

2011-08-12 Thread Guido Günther
/me grabs a brown paper bag. --- src/virt-viewer-app.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c index cf7811e..71284b6 100644 --- a/src/virt-viewer-app.c +++ b/src/virt-viewer-app.c @@ -319,7 +319,7 @@ virt_viewer_app_o

[virt-tools-list] [PATCH 4/4] Don't print (null) as user

2011-08-12 Thread Guido Günther
--- src/virt-viewer-app.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c index c80d52f..6098b29 100644 --- a/src/virt-viewer-app.c +++ b/src/virt-viewer-app.c @@ -647,8 +647,10 @@ virt_viewer_app_activate(VirtViewerApp

[virt-tools-list] [PATCH 0/4] fix non standard port numbers in virt-viewer

2011-08-12 Thread Guido Günther
Hi, attched patches really fix using non standard ssh port numbers in virt-viewer, please apply. Cheers, -- Guido Guido Günther (5): Fix reversed logic for ssh port setting Don't hardcode ssh port to 0 Don't print incorrect port numbers Don't print (null) as user src/vi

[virt-tools-list] [PATCH] Add Debian Wheezy to the OS_TYPES

2011-08-11 Thread Guido Günther
--- virtinst/osdict.py | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/virtinst/osdict.py b/virtinst/osdict.py index e59f7a4..7fe1082 100644 --- a/virtinst/osdict.py +++ b/virtinst/osdict.py @@ -433,7 +433,17 @@ OS_TYPES = { INPUT: USB_TABLET,

[virt-tools-list] [PATCH] Remove formatting character for empty string

2011-08-11 Thread Guido Günther
Avoids printing '%s' as seen when trying to create a new vm in virt-manager with an empty hostname. --- virtinst/_util.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/virtinst/_util.py b/virtinst/_util.py index e7e3e7f..d7edd94 100644 --- a/virtinst/_util.py +++ b/vir

Re: [virt-tools-list] [PATCH] virt-viewer: Don't hardcode sshport

2011-07-29 Thread Guido Günther
Hi, On Sat, Jul 23, 2011 at 06:30:41PM +0200, Guido Günther wrote: > this unbreaks using different ports via .ssh/config can this be applied? Cheers, -- Guido > > --- > src/virt-viewer-app.c | 12 +--- > 1 files changed, 5 insertions(+), 7 deletions(-) > >

Re: [virt-tools-list] virt-manager/libvirt backwards compatibility problem?

2011-07-27 Thread Guido Günther
On Wed, Jul 27, 2011 at 10:53:01AM -0600, Eric Blake wrote: > [adding libvir-list] > > On 07/27/2011 10:28 AM, Whit Blauvelt wrote: > >Looks like my real problem may be not incorporating a Debian/Ubuntu patch > >before building 0.9.x, since netcat differs: > > > >https://bugs.launchpad.net/ubuntu/

[virt-tools-list] [PATCH] virt-viewer: Don't hardcode sshport

2011-07-23 Thread Guido Günther
this unbreaks using different ports via .ssh/config --- src/virt-viewer-app.c | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c index 687927c..06cde0d 100644 --- a/src/virt-viewer-app.c +++ b/src/virt-viewer-app.c @@

Re: [virt-tools-list] Openvz guests

2011-02-28 Thread Guido Günther
Hi, On Wed, Dec 01, 2010 at 04:07:23PM +0100, Guido Günther wrote: > On Wed, Nov 24, 2010 at 03:17:41PM -0500, Cleber Rosa wrote: > > Rich, > > > > Are you sure there's GUI code for this on virt-manager? > > > > I remember that not long ago the

Re: [virt-tools-list] Openvz guests

2010-12-01 Thread Guido Günther
you can at least start/stop OpenVZ containers. The wizard needs more work since it doesn't allow for numeric vm names and we need an option to not require a disk image. Cheers -- Guido # HG changeset patch # Parent dedbf8d0d5a34399a2baa8422b0f154a1c243bb0 # User Guido Günther Allow to select

Re: [virt-tools-list] virsh and attach-device

2010-10-15 Thread Guido Günther
On Fri, Oct 15, 2010 at 11:13:21AM +0200, David Cure wrote: > > Hello, > > I want to attach a disk in a running linux squeeze VM (KVM), the > disk is based on an lv snapshot. > > I define my disk in an xml file : > > > > > > > > An

Re: [virt-tools-list] [PATCH] add AM_MAINTAINER_MODE macro

2010-10-15 Thread Guido Günther
On Fri, Oct 15, 2010 at 01:18:16PM +0100, Daniel P. Berrange wrote: > On Fri, Oct 15, 2010 at 06:06:35AM -0600, Eric Blake wrote: > > On 10/15/2010 05:29 AM, Guido Günther wrote: > > >Hi, > > >On Wed, Sep 29, 2010 at 04:46:23PM +0200, Guido Günther wrote: > > >

Re: [virt-tools-list] [PATCH] add AM_MAINTAINER_MODE macro

2010-10-15 Thread Guido Günther
Hi, On Wed, Sep 29, 2010 at 04:46:23PM +0200, Guido Günther wrote: > Hi, > Please add the AM_MAINTAINER_MODE macro to configure.ac for > virt-manager. This allows downstream distributions to disable this > feature so no autotools are required to build the package. The patch >

Re: [virt-tools-list] ANNOUNCE: virt-tools.org website

2010-10-14 Thread Guido Günther
On Wed, Oct 13, 2010 at 02:58:36PM +0100, Richard W.M. Jones wrote: > On Wed, Oct 13, 2010 at 03:00:05PM +0200, Laurent Léonard wrote: > > virt-what is also available in Debian, so you can add it on > > http://virt-tools.org/learning/start-virt-tools/#debian > > Thanks, I've added that. Cool stuf

[virt-tools-list] [PATCH] add AM_MAINTAINER_MODE macro

2010-09-29 Thread Guido Günther
Hi, Please add the AM_MAINTAINER_MODE macro to configure.ac for virt-manager. This allows downstream distributions to disable this feature so no autotools are required to build the package. The patch doesn't change behaviour for upstream: http://www.gnu.org/software/hello/manual/automake/maint

Re: [virt-tools-list] [libvirt] unable to connect to a ESX via ssh

2010-03-16 Thread Guido Günther
HI Matthias, On Fri, Mar 12, 2010 at 10:12:37PM +0100, Matthias Bolte wrote: [..snip..] > You could use the 60 days evaluation version of ESXi 4.0 for testing. > A small hurdle is that you need supported hardware, at leasts a > supported NIC. Thanks for the hint! > > Once in a while, when I can't

Re: [virt-tools-list] [libvirt] unable to connect to a ESX via ssh

2010-03-09 Thread Guido Günther
Hi Matthias, On Mon, Mar 08, 2010 at 08:28:07PM +0100, Matthias Bolte wrote: > 2010/3/8 Dimitris Kalogeras : > > Hi *, > > > > Apologies for cross posting. > > I have installed the the libvirt and virt-toolss in an ubuntu karmic > > 9.10. I am trying to access-manage an ESX 3.5i via ssh protocol. >

Re: [virt-tools-list] virt-viewer: fix plugin build with xulrunner 1.9.1

2010-02-28 Thread Guido Günther
Hi, On Tue, Feb 02, 2010 at 09:34:17PM +0100, Guido Günther wrote: > Hi, > attached patch fixes the build of the mozilla plugin with 1.9.1. Can this one be applied? Cheers, -- Guido ___ virt-tools-list mailing list virt-tools-list@redhat.com

[virt-tools-list] virt-viewer: fix plugin build with xulrunner 1.9.1

2010-02-02 Thread Guido Günther
Hi, attached patch fixes the build of the mozilla plugin with 1.9.1. Cheers, -- Guido >From e69e8794f08c7b3469140a81454c0af2e3c1ce7f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Guido=20G=C3=BCnther?= Date: Tue, 2 Feb 2010 20:16:52 +0100 Subject: [PATCH 1/2] Fix build with xulrunner 1.9.1 --- plugi

[virt-tools-list] virt-viewer: add some docs for the mozilla plugin

2010-02-02 Thread Guido Günther
Hi, attached patch adds some basic documentation. Cheers, -- Guido >From fd64d0160f61582b986647918eddfe29c3bf09d0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Guido=20G=C3=BCnther?= Date: Tue, 2 Feb 2010 20:59:10 +0100 Subject: [PATCH 3/3] Add some docs --- plugin/README| 40 +

[virt-tools-list] virt-viewer: set glade dir for plugin

2010-02-02 Thread Guido Günther
So the plugin can find the glade files. Otherwise it woun't load. Cheers, -- Guido >From 50c85fbd57cf77115f771d18d4f93d109814f9f0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Guido=20G=C3=BCnther?= Date: Tue, 2 Feb 2010 20:44:38 +0100 Subject: [PATCH 2/2] Define GLADE_DIR so the plugin can find the