[virt-tools-list] [virt-manager] [PATCH 3/7] virtinst/guest: Use tpm 1.2 if 2.0 isn't in domcapabilities

), Otherwise it fails with this error message: libvirt.libvirtError: unsupported configuration: TPM version '2.0' is not supported Signed-off-by: Lin Ma --- tests/data/cli/compare/virt-install-amd-sev.xml | 4 ++-- virtinst/guest.py | 2 ++ 2 files changed, 4

[virt-tools-list] [virt-manager] [PATCH 2/7] domcaps: tpm: Add function supports_tpm_v2()

It returns true if libvirt advertises tpm 2.0 in domcaps. Signed-off-by: Lin Ma --- virtinst/domcapabilities.py | 8 1 file changed, 8 insertions(+) diff --git a/virtinst/domcapabilities.py b/virtinst/domcapabilities.py index db08bf65..34d762ae 100644 --- a/virtinst/domcapabilities.py

[virt-tools-list] [virt-manager] [PATCH 7/7] cli: Add --disk driver.discard_no_unref=on option

E.g. virt-install \ ... \ --disk /tmp/disk0.qcow2,size=16,driver.type=qcow2,driver.discard=unmap,\ driver.discard_no_unref=on It results in the following domain xml: Signed-off-by: Lin Ma --- tests/data/cli/compare/virt-install-many-devices.xml | 5

[virt-tools-list] [virt-manager] [PATCH 6/7] cli: Add 'blob' to virtio video device

Libvirt enables blob resources for the virtio video device since 9.2.0. It accelerates the display path due to less or no copying of pixel data. E.g. virt-install \ ... \ --video model.type=virtio,blob=on It results in the following domain xml: Signed-off-by: Lin Ma

[virt-tools-list] [virt-manager] [PATCH 0/7] Some improvements for virt-install

This patchset adds some features for virt-install Lin Ma (7): tests: Check missing_xorriso in osinfo-netinst-unattended test case domcaps: tpm: Add function supports_tpm_v2() virtinst/guest: Use tpm 1.2 if 2.0 isn't in domcapabilities cli: Add kvm.pv-ipi.state to --features cli: Add

[virt-tools-list] [virt-manager] [PATCH 2/2] guest: Query availability of spicevmc channels in domcaps

Signed-off-by: Lin Ma --- virtinst/domcapabilities.py | 7 +++ virtinst/guest.py | 2 ++ 2 files changed, 9 insertions(+) diff --git a/virtinst/domcapabilities.py b/virtinst/domcapabilities.py index cb5fddbb..ab0bf2ab 100644 --- a/virtinst/domcapabilities.py +++ b/virtinst

[virt-tools-list] [virt-manager] [PATCH 1/2] guest: Query availability of usb redirdevs in domcaps

Signed-off-by: Lin Ma --- virtinst/domcapabilities.py | 7 +++ virtinst/guest.py | 2 ++ 2 files changed, 9 insertions(+) diff --git a/virtinst/domcapabilities.py b/virtinst/domcapabilities.py index d22ce6a2..cb5fddbb 100644 --- a/virtinst/domcapabilities.py +++ b/virtinst

[virt-tools-list] [virt-manager] [PATCH 0/2] Check availability of usb redirdevs and spicevmc channels in domcaps

Libvirt domcaps can advertise the redirect devices and spicevmc channel devices since v8.9.0. Virt-install adds usb redirdevs and spicevmc channels by default on x86. This patchset adds checks to avoid using redirect devices/spicevmc channel devices when not supported by the target qemu. Lin Ma

[virt-tools-list] [virt-manager] [PATCH] diskbackend: Drop support for sheepdog

The sheepdog project is no longer actively developed, Libvirt removed the support for sheepdog storage backend since v8.8.0, Let's drop it. Signed-off-by: Lin Ma --- tests/data/testdriver/testdriver.xml | 40 ++-- virtManager/object/storagepool.py| 2 -- virtinst

[virt-tools-list] [virt-manager] [PATCH 2/2] domain: Remove the pcie-root and ports for i440fx in customized dialog

t;, line 4442, in createXML raise libvirtError('virDomainCreateXML() failed') libvirt.libvirtError: XML error: The PCI controller with index='0' must be model='pci-root' for this machine type, but model='pcie-root' was found instead This patch fixes it by removing the pcie-root and ports for i440fx in apply_

[virt-tools-list] [virt-manager] [PATCH 0/2] Remove the pre-defined pcie-root controllers for i440fx in customized dialog

Lin Ma (2): guest: Drop the '_' prefix for _add_q35_pcie_controllers domain: Remove the pcie-root and ports for i440fx in customized dialog virtManager/object/domain.py | 12 virtinst/guest.py| 4 ++-- 2 files changed, 14 insertions(+), 2 deletions(-) -- 2.37.3

[virt-tools-list] [virt-manager] [PATCH 7/7] details: Add new checkbox to control shared memory access

the value of access mode of memoryBacking is because access mode of memoryBacking will be overridden per numa node by memAccess attribute. - Although the checkbox is disabled, the checked checkbox presents actual status about shared memory access to users. Signed-off-by: Lin Ma --- ui

[virt-tools-list] [virt-manager] [PATCH 3/7] domcapabilities: Add supports_memorybacking_memfd()

Linux memfd memory backend doesn't require any host setup, We prefer to use it as the simplest memory XML adjustments to make virtiofs works. Signed-off-by: Lin Ma --- virtinst/domcapabilities.py | 12 1 file changed, 12 insertions(+) diff --git a/virtinst/domcapabilities.py b

[virt-tools-list] [virt-manager] [PATCH 2/7] domcapabilities: Add supports_filesystem_virtiofs()

Check whether virtiofs is exposed in domcapabilities, We can use it as a proxy for 'libvirt is new enough to allow bare memory access mode=shared' as well. Signed-off-by: Lin Ma --- virtinst/domcapabilities.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/virtinst

[virt-tools-list] [virt-manager] [PATCH 0/7] Add a checkbox in memory details to control memory access mode

Future patches about virtiofs addhw support relies on shared memory access. Lin Ma (7): domcapabilities: Get filesystem devices domcapabilities: Add supports_filesystem_virtiofs() domcapabilities: Add supports_memorybacking_memfd() domain: memorybacking: Add function is_shared_access

[virt-tools-list] [virt-manager] [PATCH 4/7] domain: memorybacking: Add function is_shared_access()

It returns true in case the memoryBacking element contains the "shared" access mode. Signed-off-by: Lin Ma --- virtinst/domain/memorybacking.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/virtinst/domain/memorybacking.py b/virtinst/domain/memorybacking.py index c883c57d

[virt-tools-list] [virt-manager] [PATCH 6/7] domain: cpu: Add function all_shared_memAccess_cells()

It returns true in case all of numa nodes have the "shared" memAccess attribute defined explicitly. Signed-off-by: Lin Ma --- virtinst/domain/cpu.py | 8 1 file changed, 8 insertions(+) diff --git a/virtinst/domain/cpu.py b/virtinst/domain/cpu.py index 01e6c9aa..76e69

[virt-tools-list] [virt-manager] [PATCH 1/7] domcapabilities: Get filesystem devices

Signed-off-by: Lin Ma --- virtinst/domcapabilities.py | 1 + 1 file changed, 1 insertion(+) diff --git a/virtinst/domcapabilities.py b/virtinst/domcapabilities.py index 8a6ac66c..65b984ce 100644 --- a/virtinst/domcapabilities.py +++ b/virtinst/domcapabilities.py @@ -101,6 +101,7 @@ class

[virt-tools-list] [virt-manager] [PATCH 5/7] domain: cpu: Add function has_private_memAccess_cells()

It returns true in case any of numa nodes has the "private" memAccess attribute. Signed-off-by: Lin Ma --- virtinst/domain/cpu.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/virtinst/domain/cpu.py b/virtinst/domain/cpu.py index 55def91f..01e6c9aa 100644 --- a/virti

[virt-tools-list] [virt-manager 7/8] addhardware: Automatically set mem access to shared for virtiofs

Signed-off-by: Lin Ma --- virtManager/addhardware.py | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/virtManager/addhardware.py b/virtManager/addhardware.py index 13b899c3..463410ab 100644 --- a/virtManager/addhardware.py +++ b/virtManager/addhardware.py

[virt-tools-list] [virt-manager 6/8] details: Automatically set mem access to shared for virtiofs

The virtio-fs device needs shared access of memory for talking to its vhost-user backend. We need to set memory access mode manually in the XML editor. After the patch, The memory access mode will be set automatically in memory backing element or in numa node element. Signed-off-by: Lin Ma

[virt-tools-list] [virt-manager 5/8] domain: cpu: Add function all_shared_memAccess_cells()

It returns true in case all of numa nodes have the "shared" memAccess attribute. Signed-off-by: Lin Ma --- virtinst/domain/cpu.py | 8 1 file changed, 8 insertions(+) diff --git a/virtinst/domain/cpu.py b/virtinst/domain/cpu.py index 01e6c9aa..76e69bb5 100644 --- a/virti

[virt-tools-list] [virt-manager 2/8] fsdetails: Add support for driver="virtiofs"

Signed-off-by: Lin Ma --- virtManager/device/fsdetails.py | 18 -- virtinst/devices/filesystem.py | 1 + 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/virtManager/device/fsdetails.py b/virtManager/device/fsdetails.py index c3ecbfab..1650e1b8 100644

[virt-tools-list] [virt-manager 0/8] filesystem: Add support for virtiofs

, That means I need to modify the access mode attribue which belongs memorybacking or numa in filesystem code, This perhaps looks not good, Any comments are appreciated. Lin Ma (8): fsdetails: Show the 'driver' combo for qemu fsdetails: Add support for driver="virtiofs" domain: memoryba

[virt-tools-list] [virt-manager 8/8] filesystem: Add a checkbox for setting shared memory access for virtiofs

Signed-off-by: Lin Ma --- ui/fsdetails.ui | 14 ++ virtManager/addhardware.py | 6 ++ virtManager/details/details.py | 5 + virtManager/device/fsdetails.py | 13 + 4 files changed, 30 insertions(+), 8 deletions(-) diff --git a/ui

[virt-tools-list] [virt-manager 4/8] domain: cpu: Add function has_private_memAccess_cells()

It returns true in case any of numa nodes has the "private" memAccess attribute. Signed-off-by: Lin Ma --- virtinst/domain/cpu.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/virtinst/domain/cpu.py b/virtinst/domain/cpu.py index 55def91f..01e6c9aa 100644 --- a/virti

[virt-tools-list] [virt-manager 1/8] fsdetails: Show the 'driver' combo for qemu

Driver combo for qemu was dropped from fsdetails (commit 41023192), Add it back due to the next patch needs it. Signed-off-by: Lin Ma --- tests/uitests/test_details.py | 1 + virtManager/device/fsdetails.py | 16 +++- virtinst/devices/filesystem.py | 2 ++ 3 files changed, 14

[virt-tools-list] [virt-manager 3/8] domain: memorybacking: Add function is_access_shared()

It returns true in case the memoryBacking element contains the "shared" access mode. Signed-off-by: Lin Ma --- virtinst/domain/memorybacking.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/virtinst/domain/memorybacking.py b/virtinst/domain/memorybacking.py index c883c57d

[virt-tools-list] [virt-manager PATCH v2] details: Fix showing the firmware type in case of firmware auto selection

For a shutoff VM, If user select uefi firmware auto selection, e.g. ... Its firmware information is set to 'BIOS' in details, This is incorrect. This fixes it. Signed-off-by: Lin Ma --- virtManager/details/details.py | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[virt-tools-list] [virt-manager] [PATCH] details: Fix showing the firmware type in case of firmware auto selection

For a shutoff VM, If user select uefi firmware auto selection, e.g. ... Its firmware information is set to 'BIOS' in details, This is incorrect. This fixes it. Signed-off-by: Lin Ma --- virtManager/details/details.py | 7 +-- virtinst/domain/os.py | 3 +++ 2 files changed, 8

[virt-tools-list] [virt-manager] [PATCH 4/4] uitests: Add genid tests

Signed-off-by: Lin Ma --- tests/uitests/details.py | 1 + tests/uitests/newvm.py | 5 + 2 files changed, 6 insertions(+) diff --git a/tests/uitests/details.py b/tests/uitests/details.py index 974ff403..4d6279e9 100644 --- a/tests/uitests/details.py +++ b/tests/uitests/details.py @@ -92,6

[virt-tools-list] [virt-manager] [PATCH 3/4] testdriver: Add genid example

Signed-off-by: Lin Ma --- tests/testdriver.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/testdriver.xml b/tests/testdriver.xml index f6d09123..2bedb5e4 100644 --- a/tests/testdriver.xml +++ b/tests/testdriver.xml @@ -61,6 +61,7 @@ http://fedoraproject.org/fedora/unknown

[virt-tools-list] [virt-manager] [PATCH 0/4] Add VM generation ID support

qemu supports it since 2.9.0, libvirt supports it since 4.4.0. The details of VM generation ID, Please refer to: http://go.microsoft.com/fwlink/?LinkId=260709 Lin Ma (4): cli: Add --genid option to support VM generation ID details: Add VM genid support testdriver: Add genid example

[virt-tools-list] [virt-manager] [PATCH 1/4] cli: Add --genid option to support VM generation ID

generation ID: http://go.microsoft.com/fwlink/?LinkId=260709 Signed-off-by: Lin Ma --- .../compare/virt-install-many-devices.xml | 1 + tests/clitest.py | 2 ++ virt-install | 15 +++ virtinst/guest.py

[virt-tools-list] [virt-manager] [PATCH 2/4] details: Add VM genid support

Currently, It doesn't support manually specify the genid value in the details window, Only supports auto value. Signed-off-by: Lin Ma --- ui/details.ui | 38 -- virtManager/details.py | 17 - virtManager/domain.py | 7 ++- 3

[virt-tools-list] [virt-manager] [PATCH] Use changed instead of value-changed signal in spinbutton in vsockdetails ui

Signed-off-by: Lin Ma --- ui/vsockdetails.ui | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/vsockdetails.ui b/ui/vsockdetails.ui index 7f607b2b..2a8ee73a 100644 --- a/ui/vsockdetails.ui +++ b/ui/vsockdetails.ui @@ -67,7 +67,7 @@ True if-valid

[virt-tools-list] [virt-manager] [PATCH ] vsockdetails: Show CID for active VM if the attribute auto is set to yes

Signed-off-by: Lin Ma --- virtManager/vsockdetails.py | 5 + 1 file changed, 5 insertions(+) diff --git a/virtManager/vsockdetails.py b/virtManager/vsockdetails.py index 7e4e8134..a4920012 100644 --- a/virtManager/vsockdetails.py +++ b/virtManager/vsockdetails.py @@ -56,6 +56,11 @@ class

[virt-tools-list] [virt-manager] [PATCH v2 2/2] cli: Use function cli_flag_name to help to concatenate '--' and cli_arg_name

It can convert the underscore to minus for cli_arg_name in help output or error message. Signed-off-by: Lin Ma --- virt-xml| 2 +- virtinst/cli.py | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/virt-xml b/virt-xml index e839b294..43048cd9 100755

[virt-tools-list] [virt-manager] [PATCH v2 1/2] cli: Add function cli_flag_name to replace '_' from cli_arg_name with '-'

Signed-off-by: Lin Ma --- virtinst/cli.py | 4 1 file changed, 4 insertions(+) diff --git a/virtinst/cli.py b/virtinst/cli.py index 03b1b8e2..fcf3fee2 100644 --- a/virtinst/cli.py +++ b/virtinst/cli.py @@ -1198,6 +1198,10 @@ class VirtCLIParser(metaclass=InitClass): None

[virt-tools-list] [virt-manager] [PATCH v2 0/2] Bash completion bug fixes

v1 -> v2: * Drop original 2/2 due to a better fix exists in git master. * Add a new patch to introduce function cli_flag_name. * Use this function to convert underscore to minus in cli_arg_name. Lin Ma (2): cli: Add function cli_flag_name to replace '_' from cli_arg_name with '-' cli:

[virt-tools-list] [virt-manager] [PATCH 2/2] cli: Register parser for ParseCLICheck

The completion of --check subprops needs it work. Signed-off-by: Lin Ma --- virtinst/cli.py | 1 + 1 file changed, 1 insertion(+) diff --git a/virtinst/cli.py b/virtinst/cli.py index 3ba81861..2996dbc3 100644 --- a/virtinst/cli.py +++ b/virtinst/cli.py @@ -1321,6 +1321,7 @@ class ParseCLICheck

[virt-tools-list] [virt-manager] [PATCH 1/2] cli: Replace '_' from cli_arg_name with '-' before saving to parsernames

The patch makes --qemu-commandline subprops completion works. Signed-off-by: Lin Ma --- virtinst/cli.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/virtinst/cli.py b/virtinst/cli.py index 21586b19..3ba81861 100644 --- a/virtinst/cli.py +++ b/virtinst/cli.py @@ -494,7

[virt-tools-list] [virt-manager] [PATCH 0/2] bash completion bug fixes

Lin Ma (2): cli: Replace '_' from cli_arg_name with '-' before saving to parsernames cli: Register parser for ParseCLICheck virtinst/cli.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.19.0 ___ virt-tools-list mailing list

[virt-tools-list] [PATCH] .gitignore: Remove the outdated path info of bashcompletion files

Commit 73f07c5 generates the bashcompletion files in build folder, The '/data/bash-completion' no longer exists, So remove it in .gitignore. Signed-off-by: Lin Ma --- .gitignore | 1 - 1 file changed, 1 deletion(-) diff --git a/.gitignore b/.gitignore index 945433f5..dd2404e0 100644

[virt-tools-list] [virt-manager] [PATCH v2 05/10] virt-xml: Add auto complete support for the general options

Signed-off-by: Lin Ma --- virt-xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/virt-xml b/virt-xml index 39abd297..89cd0336 100755 --- a/virt-xml +++ b/virt-xml @@ -393,6 +393,8 @@ def parse_args(): misc = parser.add_argument_group(_("Miscellaneous Op

[virt-tools-list] [virt-manager] [PATCH v2 09/10] Don't track bash completion files due to they are generated dynamically

Signed-off-by: Lin Ma --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index dd2404e0..5f67705d 100644 --- a/.gitignore +++ b/.gitignore @@ -19,3 +19,4 @@ po/virt-manager.pot /virt-manager.spec /virtcli/cli.cfg +/data/bash-completion/virt

[virt-tools-list] [virt-manager] [PATCH v2 08/10] Bash completion template

completion in bash. ex: $ virt-xml -- $ virt-install --disk $ virt-install --panic model=isa, $ virt-install --controller model=virtio-scsi,ty Signed-off-by: Lin Ma --- data/bash-completion/virtmanager | 37 + 1 file changed, 37 insertions(+) create mode

[virt-tools-list] [virt-manager] [PATCH v2 07/10] cli: Add auto complete support about sub options

'bus' will be auto completed with a '=' $ virt-install --disk bus= Signed-off-by: Lin Ma --- virtinst/cli.py | 84 - 1 file changed, 42 insertions(+), 42 deletions(-) diff --git a/virtinst/cli.py b/virtinst/cli.py index 95e54efc..2f1f5bda

[virt-tools-list] [virt-manager] [PATCH v2 04/10] virt-clone: Add auto complete support for the general options

Signed-off-by: Lin Ma --- virt-clone | 2 ++ 1 file changed, 2 insertions(+) diff --git a/virt-clone b/virt-clone index d1eedeea..6f86732a 100755 --- a/virt-clone +++ b/virt-clone @@ -138,6 +138,8 @@ def parse_args(): cli.add_misc_options(misc, prompt=True, replace=True, printxml=True

[virt-tools-list] [virt-manager] [PATCH v2 00/10] Tab completion in bash shell via the argcomplete

irt-bootstrap will be posted to upstream after these patches were accepted. Lin Ma (10): Update docs to reflect the argcomplete dependency cli: Add the generic completer function and validator function virt-install: Add auto complete support for the general options virt-clone: Add auto compl

[virt-tools-list] [virt-manager] [PATCH v2 10/10] setup.py: Install the bash completion files

Signed-off-by: Lin Ma --- setup.py | 27 +++ 1 file changed, 27 insertions(+) diff --git a/setup.py b/setup.py index 658e6503..2d3446cd 100755 --- a/setup.py +++ b/setup.py @@ -20,6 +20,13 @@ import distutils.dist import distutils.log import distutils.sysconfig +from

[virt-tools-list] [virt-manager] [PATCH v2 03/10] virt-install: Add auto complete support for the general options

With this patchset, the general options completion is available. ex: $ virt-install - ... --arch --check --cpu --dry-run -h --autostart --clock --cputune --events--help ... $ virt-install --a --arch --autostart Signed-off-by: Lin Ma --- virt-install | 2 ++ 1

Re: [virt-tools-list] [virt-manager] [RFC PATCH 9/9] setup.py: Install and link the bash completion scripts

On 11/18/18 10:24 AM, Cole Robinson wrote: On 11/14/2018 03:12 AM, Lin Ma wrote: Signed-off-by: Lin Ma ---   setup.py | 10 ++   1 file changed, 10 insertions(+) diff --git a/setup.py b/setup.py index 658e6503..1c4b4340 100755 --- a/setup.py +++ b/setup.py @@ -273,6 +273,15 @@ class

Re: [virt-tools-list] [virt-manager] [RFC PATCH 8/9] Bash completion file

On 11/18/18 10:21 AM, Cole Robinson wrote: On 11/14/2018 03:12 AM, Lin Ma wrote: The most of content of this file comes from the output of the command ' register-python-argcomplete $MY-SCRIPT', plus some changes. For the details about argcomplete, Please refer to https://pypi.org/project

Re: [virt-tools-list] [virt-manager] [RFC PATCH 7/9] cli: Add auto complete support about sub options

On 11/18/18 9:53 AM, Cole Robinson wrote: On 11/14/2018 03:12 AM, Lin Ma wrote: With this patchset, the sub options completion is available. ex: $ virt-install --disk ... bus=    cache=  format= path=   serial= size= ... $ virt-install --disk path=test.qcow2,cache=none, ... bus

Re: [virt-tools-list] [virt-manager] [RFC PATCH 3/9] virt-install: Add auto complete support for the general options

On 11/18/18 9:45 AM, Cole Robinson wrote: On 11/14/2018 03:12 AM, Lin Ma wrote: With this patchset, the general options completion is available. ex: $ virt-install - ... --arch  --check --cpu   --dry-run   -h --autostart --clock --cputune   --events    --help ... $ virt

[virt-tools-list] [virt-manager] [RFC PATCH 6/9] virt-convert: Add auto complete support for the general options

Signed-off-by: Lin Ma --- virt-convert | 4 1 file changed, 4 insertions(+) diff --git a/virt-convert b/virt-convert index 1b7b7963..204481e1 100755 --- a/virt-convert +++ b/virt-convert @@ -12,6 +12,8 @@ import sys +import argcomplete + from virtinst import cli from virtinst import

[virt-tools-list] [virt-manager] [RFC PATCH 4/9] virt-clone: Add auto complete support for the general options

Signed-off-by: Lin Ma --- virt-clone | 3 +++ 1 file changed, 3 insertions(+) diff --git a/virt-clone b/virt-clone index d1eedeea..7b805aa5 100755 --- a/virt-clone +++ b/virt-clone @@ -7,6 +7,7 @@ import argparse +import argcomplete import logging import sys @@ -138,6 +139,8 @@ def

[virt-tools-list] [virt-manager] [RFC PATCH 0/9] Tab completion in bash shell via the argcomplete

. The completion support for virt-bootstrap will be posted to upstream after these patches were accepted. Lin Ma (9): Update docs to reflect the argcomplete dependency cli: Add the generic completer function and validator function virt-install: Add auto complete support for the general options

Re: [virt-tools-list] [virt-manager] [RFC PATCH 0/9] Tab completion in bash shell via the argcomplete

On 11/14/18 4:12 PM, Lin Ma wrote: Hi all, These draft patches add the tab completion in bash for virt-* utilities. We've been using the argparse to help parse handling, So I think that the argcomplete is a good option to deal with argument/sub-options completion in bash shell for virt

[virt-tools-list] [virt-manager] [RFC PATCH 3/9] virt-install: Add auto complete support for the general options

With this patchset, the general options completion is available. ex: $ virt-install - ... --arch --check --cpu --dry-run -h --autostart --clock --cputune --events--help ... $ virt-install --a --arch --autostart Signed-off-by: Lin Ma --- virt-install | 3 +++ 1

[virt-tools-list] [virt-manager] [RFC PATCH 5/9] virt-xml: Add auto complete support for the general options

Signed-off-by: Lin Ma --- virt-xml | 4 1 file changed, 4 insertions(+) diff --git a/virt-xml b/virt-xml index 39abd297..4a70206f 100755 --- a/virt-xml +++ b/virt-xml @@ -12,6 +12,8 @@ import os import re import sys +import argcomplete + import libvirt import virtinst @@ -393,6

[virt-tools-list] [virt-manager] [RFC PATCH 8/9] Bash completion file

completion in bash. ex: $ virt-xml -- $ virt-install --disk $ virt-install --panic model=isa, $ virt-install --controller model=virtio-scsi,ty Signed-off-by: Lin Ma --- bash-completion/virtmanager | 40 + 1 file changed, 40 insertions(+) create mode 100644

[virt-tools-list] [virt-manager] [RFC PATCH 9/9] setup.py: Install and link the bash completion scripts

Signed-off-by: Lin Ma --- setup.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/setup.py b/setup.py index 658e6503..1c4b4340 100755 --- a/setup.py +++ b/setup.py @@ -273,6 +273,15 @@ class my_install_data(distutils.command.install_data.install_data): "

[virt-tools-list] [virt-manager] [RFC PATCH 2/9] cli: Add the generic completer function and validator function

The patch adds the generic completer and validator, Further patches use them as completer/validator. The completer won't add already specified options to the list. Signed-off-by: Lin Ma --- virtinst/cli.py | 37 + 1 file changed, 37 insertions(+) diff --git

[virt-tools-list] [virt-manager] [RFC PATCH 7/9] cli: Add auto complete support about sub options

'bus' will be auto completed with a '=' $ virt-install --disk bus= Signed-off-by: Lin Ma --- virtinst/cli.py | 84 - 1 file changed, 42 insertions(+), 42 deletions(-) diff --git a/virtinst/cli.py b/virtinst/cli.py index d46155f7..267997b3 100644

[virt-tools-list] [virt-manager] [RFC PATCH 1/9] Update docs to reflect the argcomplete dependency

Signed-off-by: Lin Ma --- INSTALL.md | 1 + 1 file changed, 1 insertion(+) diff --git a/INSTALL.md b/INSTALL.md index 983e32ce..efe73cf7 100644 --- a/INSTALL.md +++ b/INSTALL.md @@ -35,6 +35,7 @@ Minimum version requirements of major components: - libvirt-python >= 0.6.0 - pygobje

[virt-tools-list] [virt-manager PATCH v2 1/3] cli: disk: Add options to support SCSI persistent reservation

Create the managed or the unmanaged PR object to enable SCSI persistent reservation for LUN Passthrough Signed-off-by: Lin Ma --- tests/cli-test-xml/compare/virt-install-many-devices.xml | 9 + tests/clitest.py | 1 + virtinst/cli.py

[virt-tools-list] [virt-manager PATCH v2 0/3] Add SCSI persistent reservation support for LUN Passthrough

v2: * Only support pr managed mode in virt-manager, drop the unmanaged mode support. * Drop the help info in manpage. * make the name style match libvirt XML naming. Thank Michal and Cole for review and suggestions. Lin Ma (3): cli: disk: Add options to support SCSI persistent reservation

[virt-tools-list] [virt-manager PATCH v2 2/3] details: Add SCSI persistent reservation support for LUN Passthrough

It's a common requirement for VMs to send SCSI PR commands in VM cluster environment. This patch adds the managed mode support of scsi persistent reservation in details page. Signed-off-by: Lin Ma --- ui/details.ui | 25 + virtManager/details.py | 10

[virt-tools-list] [virt-manager PATCH v2 3/3] addhardware: Add SCSI persistent reservation support for LUN Passthrough

Signed-off-by: Lin Ma --- ui/addhardware.ui | 24 virtManager/addhardware.py | 9 + 2 files changed, 33 insertions(+) diff --git a/ui/addhardware.ui b/ui/addhardware.ui index dffcf8c6..b6ac8912 100644 --- a/ui/addhardware.ui +++ b/ui/addhardware.ui

Re: [virt-tools-list] [ [PATCH 0/3] Add SCSI persistent reservation support for LUN Passthrough

On 10/2/18 11:03 PM, Cole Robinson wrote: On 09/26/2018 08:36 AM, Michal Privoznik wrote: On 09/25/2018 11:12 AM, Lin Ma wrote: Lin Ma (3):    cli: disk: add pr.managed=, pr.type=, pr.path= and pr.mode= support    details: Add disk pr.managed and pr.path options to support SCSI PR

Re: [virt-tools-list] [ [PATCH 1/3] cli: disk: add pr.managed=, pr.type=, pr.path= and pr.mode= support

On 10/2/18 11:00 PM, Cole Robinson wrote: On 09/25/2018 05:12 AM, Lin Ma wrote: Enable the managed or unmanaged PR configuration to enable SCSI persistent reservation for LUN Passthrough. Signed-off-by: Lin Ma ---   man/virt-install.pod    | 13

[virt-tools-list] [ [PATCH 2/3] details: Add disk pr.managed and pr.path options to support SCSI PR

unmanaged PR, user only needs to provide the value of pr.path in this case. Signed-off-by: Lin Ma --- ui/details.ui | 57 ++ virtManager/addhardware.py | 7 + virtManager/details.py | 47 ++- virtManager

[virt-tools-list] [ [PATCH 3/3] addhardware: Add disk pr.managed and pr.path options to support SCSI PR

Signed-off-by: Lin Ma --- ui/addhardware.ui | 56 ++ virtManager/addhardware.py | 35 2 files changed, 91 insertions(+) diff --git a/ui/addhardware.ui b/ui/addhardware.ui index dffcf8c6..aa9e0339 100644 --- a/ui

[virt-tools-list] [ [PATCH 1/3] cli: disk: add pr.managed=, pr.type=, pr.path= and pr.mode= support

Enable the managed or unmanaged PR configuration to enable SCSI persistent reservation for LUN Passthrough. Signed-off-by: Lin Ma --- man/virt-install.pod| 13 + .../compare/virt-install-many-devices.xml | 9 + tests/clitest.py

[virt-tools-list] [virt-manager PATCH 1/2] addhardware: Use consistent combo init for disk io mode option

Signed-off-by: Lin Ma --- virtManager/addhardware.py | 7 +++ virtManager/details.py | 11 ++- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/virtManager/addhardware.py b/virtManager/addhardware.py index d8146bf3..9a517b74 100644 --- a/virtManager/addhardware.py

[virt-tools-list] [virt-manager PATCH 0/2] Add support for disk io mode option while adding disks

Lin Ma (2): addhardware: Use consistent combo init for disk io mode option addhardware: Add support for disk io mode option ui/addhardware.ui | 32 virtManager/addhardware.py | 12 virtManager/details.py | 11 ++- 3 files

[virt-tools-list] [virt-manager PATCH 3/3] Try to get ip of vm's nic only when the vm is active

Signed-off-by: Lin Ma --- virtManager/details.py | 15 +-- virtManager/domain.py | 4 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/virtManager/details.py b/virtManager/details.py index 0d02805f..64bed185 100644 --- a/virtManager/details.py +++ b/virtManager

[virt-tools-list] [virt-manager PATCH 1/3] Fix error while refreshing ip if the virtual nic doesn't have any ip

Signed-off-by: Lin Ma --- virtManager/domain.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/virtManager/domain.py b/virtManager/domain.py index 3b1b43d1..b628b5cd 100644 --- a/virtManager/domain.py +++ b/virtManager/domain.py @@ -1200,6 +1200,8 @@ class vmmDomain(vmmLibvirtObject

[virt-tools-list] [virt-manager PATCH 0/3] Some fixes for refreshing ip feature

Lin Ma (3): Fix error while refreshing ip if the virtual nic doesn't have any ip Fix error while refreshing ip if the virtual nic only has ipv6 Try to get ip of vm's nic only when the vm is active virtManager/details.py | 15 +-- virtManager/domain.py | 6 ++ 2 files

[virt-tools-list] [virt-manager PATCH 2/3] Fix error while refreshing ip if the virtual nic only has ipv6

Signed-off-by: Lin Ma --- virtManager/details.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virtManager/details.py b/virtManager/details.py index 1e619e78..0d02805f 100644 --- a/virtManager/details.py +++ b/virtManager/details.py @@ -2756,7 +2756,7 @@ class vmmDetails

Re: [virt-tools-list] [virt-manager PATCH 0/2] show ip in details page of domain interface

On 09/06/2018 03:13 AM, Cole Robinson wrote: On 08/31/2018 06:37 AM, Lin Ma wrote: Uses lease, agent and arp to try to get ipv4 and ipv6 address of given interface Lin Ma (2):    domain: Add function interface_addresses to return ipv4 and ipv6    details: Show ipv4 and ipv6 address

[virt-tools-list] [virt-manager PATCH 2/2] addhardware: Add support for disk detect zeroes option

Complete this part of feature for commit e6c7e46a Signed-off-by: Lin Ma --- virtManager/addhardware.py | 5 + 1 file changed, 5 insertions(+) diff --git a/virtManager/addhardware.py b/virtManager/addhardware.py index 87b0d918..556524d2 100644 --- a/virtManager/addhardware.py +++ b

[virt-tools-list] [virt-manager PATCH 1/2] addhardware: Add support for disk discard option

Complete this part of feature for commit d13b793b. Signed-off-by: Lin Ma --- virtManager/addhardware.py | 5 + 1 file changed, 5 insertions(+) diff --git a/virtManager/addhardware.py b/virtManager/addhardware.py index 2981e465..87b0d918 100644 --- a/virtManager/addhardware.py +++ b

[virt-tools-list] [virt-manager PATCH 0/2] Add support for disk discard option disk detect zeroes option while adding disk

Lin Ma (2): addhardware: Add support for disk discard option addhardware: Add support for disk detect zeroes option virtManager/addhardware.py | 10 ++ 1 file changed, 10 insertions(+) -- 2.15.1 ___ virt-tools-list mailing list virt

[virt-tools-list] [virt-manager PATCH 0/2] show ip in details page of domain interface

Uses lease, agent and arp to try to get ipv4 and ipv6 address of given interface Lin Ma (2): domain: Add function interface_addresses to return ipv4 and ipv6 details: Show ipv4 and ipv6 address in details page of interface ui/details.ui | 79

[virt-tools-list] [virt-manager PATCH 1/2] domain: Add function interface_addresses to return ipv4 and ipv6

It returns a dict that consisting of ipv4 and ipv6 which only match the given mac, it returns None in exception. Signed-off-by: Lin Ma --- virtManager/domain.py | 27 +++ 1 file changed, 27 insertions(+) diff --git a/virtManager/domain.py b/virtManager/domain.py index

[virt-tools-list] [virt-manager PATCH 2/2] details: Show ipv4 and ipv6 address in details page of interface

If the interface's type is 'network', then code uses lease as one of parameters of interface_addresses to get ipv4 and ipv6 address. If the result is negative, then uses agent to try again, If the result is still negative, uses arp for final try. Signed-off-by: Lin Ma --- ui/details.ui

[virt-tools-list] [virt-manager PATCH v2] details: Use _disable_device_remove helper to set the remove tooltip

Signed-off-by: Lin Ma --- virtManager/details.py | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/virtManager/details.py b/virtManager/details.py index 34bd35b3..e9ca5bda 100644 --- a/virtManager/details.py +++ b/virtManager/details.py @@ -2998,6

[virt-tools-list] [virt-manager PATCH 5/5] details: Set tooltip on config-remove while it's not available

It informs users that why the device can't be removed. Signed-off-by: Lin Ma --- virtManager/details.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/virtManager/details.py b/virtManager/details.py index cb298f3f..7308cde3 100644 --- a/virtManager/details.py +++ b/virtManager

[virt-tools-list] [virt-manager PATCH 4/5] details: Fix the tooltip error on config-remove

visor does not support to removing this device" 3. Click a nic item. 4. Observe the tooltip of the 'Remove' button. Expected: "Remove this device from the virtual machine" Actual: "Hypervisor does not support to removing this device" Signed-off-by: Lin Ma --

[virt-tools-list] [virt-manager PATCH 0/5] some minor improvements and fix

Lin Ma (5): details: Show attached disk info in sata, ide and floppy controller page details: Disallow removing video device if graphics devices exist details: Disallow removing virtio-serial controller if devices attach to it details: Fix the tooltip error on config-remove

[virt-tools-list] [virt-manager PATCH 1/5] details: Show attached disk info in sata, ide and floppy controller page

Reflect controllers <-> disks mapping relationship for not only scsi, But other storage controllers. As a bonus, These controllers are not allowed to be removed if there are disks attached to them. Signed-off-by: Lin Ma --- virtManager/details.py | 2 +- 1 file changed, 1 insertion

[virt-tools-list] [virt-manager PATCH 2/5] details: Disallow removing video device if graphics devices exist

Signed-off-by: Lin Ma --- virtManager/details.py | 5 + 1 file changed, 5 insertions(+) diff --git a/virtManager/details.py b/virtManager/details.py index 4b145602..e3edbe86 100644 --- a/virtManager/details.py +++ b/virtManager/details.py @@ -3001,6 +3001,11 @@ class vmmDetails(vmmGObjectUI

[virt-tools-list] [virt-manager PATCH 3/5] details: Disallow removing virtio-serial controller if devices attach to it

Signed-off-by: Lin Ma --- virtManager/details.py | 13 + 1 file changed, 13 insertions(+) diff --git a/virtManager/details.py b/virtManager/details.py index e3edbe86..00e18949 100644 --- a/virtManager/details.py +++ b/virtManager/details.py @@ -3041,6 +3041,19 @@ class vmmDetails

[virt-tools-list] [virt-manager] [PATCH v2 2/4] libvirtenummap: Map state vals of agent event to libvirt enum names

Signed-off-by: Lin Ma --- virtManager/libvirtenummap.py | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/virtManager/libvirtenummap.py b/virtManager/libvirtenummap.py index eaad0374..71e4a5eb 100644 --- a/virtManager/libvirtenummap.py +++ b/virtManager

[virt-tools-list] [virt-manager] [PATCH v2 3/4] Output the qemu guest agent lifecycle events in debug mode

Signed-off-by: Lin Ma --- virtManager/connection.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/virtManager/connection.py b/virtManager/connection.py index 8efcca77..8539be7e 100644 --- a/virtManager/connection.py +++ b/virtManager/connection.py @@ -763,6 +763,14 @@ class

[virt-tools-list] [virt-manager] [PATCH v2 1/4] connection: Add callback parameter for function _add_domain_xml_event

Further patches will pass in the callback instead of the default one. Signed-off-by: Lin Ma --- virtManager/connection.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/virtManager/connection.py b/virtManager/connection.py index 76e78c49..8efcca77 100644

[virt-tools-list] [virt-manager] [PATCH v2 0/4] Track the state of virtio channels

v1->v2: * new patch 1/4 for adding callback parameter to _add_domain_xml_event. * combine original patch 3/4 and patch 4/4 to new patch 4/4. * avoid pylint warn. * Register agent events through _add_domain_xml_event. Lin Ma (4): connection: Add callback parameter for funct

  1   2   >