nshots, right? Anyways, I'd just say "a few screenshots (...)".
> It can be changed before pushing.
Oh right, Daniel added one screenshot.
Forgot to change the commit.
Yes few is better word here.
Thanks
--
Lukas Venhoda
___
virt-tools
berr/
> :|
> |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc
> :|
>
Thanks
--
Lukas Venhoda
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list
l.in
> > data/remote-viewer.desktop.in
> > data/virt-viewer-mime.xml.in
> > src/remote-viewer-main.c
> > diff --git a/virt-viewer.spec.in b/virt-viewer.spec.in
> > index ed0b14d..4fb649c 100644
> > --- a/virt-viewer.spec.in
> >
Hardcoded UI removed in favor of XML.
Added the new XML file for translation.
---
Changes since v2
- Removed the error state response
- It's not really needed, it's OK to just return FALSE and quit
remote-viewer
Changes since v1
- New patch
- Contains change to XML only
---
po/POTFILES.in
Recent chooser didn't unselect on loosing focus.
Selecting recent connection, then modifying address in entry and
doubleclicking on the same recent connection caused remote-viewer to
connect to address in the entry,
Recent chooser now unselects on loosing focus, forcing to re-select when
doublecli
Changed connect dialog from GtkDialog to a GtkWindow.
Added the necessary signals and buttons, to keep the
behaviour of a dialog. (ESC to close, ENTER to submit)
---
Changes since v2
- Fixed missing space
- Changed response type from GtkResponseType to gboolean
Changes since v1
- Now only conta
nse
- Adressed some more issues
---
Lukas Venhoda (7):
remote-viewer: Connect dialog moved to its own file
remote-viewer-connect: Changed response to gboolean
remote-viewer-connect: Check if uri is NULL
remote-viewer-connect: Changed dialog into a window
remote-viewer-connect: Changed h
URI should be NULL before passing it to remote_viewer_connect_dialog.
---
Changes since v2
- Check for NULL instead of free
Changes since v1
- New patch
- Free uri before using it. Just to be sure
---
src/remote-viewer-connect.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --
Connect button is now non-sensitive when address entry is empty.
Pressing enter will now also NOT connect, when address entry is empty.
---
Changes since v2
- Changed response type from GtkResponseType to gboolean
Changes since v1
- New patch
- Split from the v1 patch as requested
---
src/remo
Connect dialog from remote-viewer is now in its own file.
Most other dialog also have their own files.
This will make changing the dialog into a window easier.
Renamed connect_dialog to remote_viewer_connect_dialog.
---
Changes since v2
- Changed Makefile change to one file per line
- Added ment
remote_viewer_connect_dialog now returns TRUE and FALSE, instead of 0 and -1.
Added a doxygen style comment to document this in code also.
---
Changes since v2
- Changed return type from GtkResponseType to simpler gboolean
Changes since v1
- New patch
- Added some documentation about the retur
Hi,
>I see that you're just following the example of the previous line, but I
>prefer to have a single file per line.
Should I also change the previous line?
As commit No. 8 perhaps?
Lukas
- Original Message -
From: "Jonathon Jongsma"
To: "Lukas Ven
Before writing the connection address to uri, g_free() it.
Not freeing wouldn't cause an issue now, because uri is always NULL, but
this could change in the future.
---
Changes since v1
- New patch
- Free uri before using it. Just to be sure
---
src/remote-viewer-connect.c | 2 ++
1 file changed
Hopefully this new split makes more sense
- Adressed some more issues
---
Lukas Venhoda (7):
remote-viewer: Connect dialog moved to its own file
remote-viewer-connect: Changed response to GtkResponseType
remote-viewer-connect: Free uri before writing to it
remote-viewer-connect: Change
remote_viewer_connect_dialog now return meaningful GTK_RESPONSE_OK
and GTK_RESPONSE_CANCEL, instead of "magical" 0 and -1.
Added a doxygen style comment to document this in code also.
---
Changes since v1
- New patch
- Added some documentation about the return value of the connect dialog.
---
s
Connect button is now non-sensitive when address entry is empty.
Pressing enter will now also NOT connect, when address entry is empty.
---
Changes since v1
- New patch
- Split from the v1 patch as requested
---
src/remote-viewer-connect.c | 27 +--
1 file changed, 21 ins
Hardcoded UI removed in favor of XML.
Added the new XML file for translation.
---
Changes since v1
- New patch
- Contains change to XML only
---
po/POTFILES.in| 1 +
src/Makefile.am | 1 +
src/remote-viewer-connect.c | 89 +
src/remote
Recent chooser didn't unselect on loosing focus.
Selecting recent connection, then modifying address in entry and
doubleclicking on the same recent connection caused remote-viewer to
connect to address in the entry,
Recent chooser now unselects on loosing focus, forcing to re-select when
doublecli
Connect dialog from remote-viewer is now in its own file.
Most other dialog also have their own files.
This will make changing the dialog into a window easier.
---
Changes since v1
- New patch
- Reversed order of patches. Now create a moduel first, modify after.
- Renamed the function from conne
Changed connect dialog from GtkDialog to a GtkWindow.
Added the necessary signals and buttons, to keep the
behaviour of a dialog. (ESC to close, ENTER to submit)
---
Changes since v1
- Now only contains changing dialog to window
- Change to XML in later patch
---
src/remote-viewer-connect.c |
---
Aditional patch
- Forgot to add the new XML file for translation.
---
po/POTFILES.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/po/POTFILES.in b/po/POTFILES.in
index 111e8b5..9dcc6a3 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -3,6 +3,7 @@ data/virt-viewer-mime.xml.in
src/gb
Added connect module source files and new XML file to Makefile.am
---
src/Makefile.am | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/Makefile.am b/src/Makefile.am
index c06ba85..70e6d59 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -11,6 +11,7 @@ builderxml_DATA =
Removed original connect dialog code from remote-viewer.c
Changed retval check of connect dialog from 0 to GTK_RESPONSE_ACCEPT
---
src/remote-viewer.c | 162 +---
1 file changed, 2 insertions(+), 160 deletions(-)
diff --git a/src/remote-viewer.c b/s
Connect dialog was hardcoded, and sometimes didn't have a parent window.
Changed dialog to a window.
Moved UI definition from code to XML.
Moved the "dialog" code to its own module.
Lukas Venhoda (3):
remote-viewer: Connect dialog changed to window
remote-viewer: Added new
Sometimes the connect dialog didn't get a parent.
It didn't make much sense for it to be a dialog.
Changed the connect dialog to a window.
Moved the dialog code to its own module.
Moved the UI definiton into an XML.
Changed response ID from ambiguous -1 and 0 to GTK_RESPONSE_ACCEPT
and GTK_RESPON
Choose VM dialog was not visible in taskbar and alt-tab when running on
system with gnome2.
rhbz#1223285
---
src/virt-viewer-vm-connection.xml | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/virt-viewer-vm-connection.xml
b/src/virt-viewer-vm-connection.xml
index 04797fa..62319b6 100644
New property in virt-viewer-app: "can_reconnect".
Will be set to TRUE when constructing virt-viewer.
Default value is FALSE.
This property will be used to determine whether to show Reconnect button
in the new General tab under preferences or not. This will be probably
only shown int virt-viewer.
-
Reconnect field in virt-viewer.c changed to property.
This will be used in virt-viewer-window for binding a "Reconnect" check
button to it.
---
Changes since v2:
- Reverted back to version 1
- Removed object_notify
Changes since v1:
- Moved the reconnect property from virt-viewer.c into virt
Added a new preferences tab, and a check button "Reconnect" into
virt-viewer-preferences.xml. They are implicitly set to hidden.
If can_reconnect is set to true (while constructing virt-viewer-app),
both the tab and the button will be shown.
---
Changes since v2:
- Moved the visibility and bindin
Moved preferences from virt-viewer-app to virt-viewer-window.
Makes more sense to have all of the GUI in virt-viewer-window.
This also makes it possible to implement virt-viewer/remote-viewer
specific settings in preferences.
---
New commit in version 3
Moving preferences into window is better th
Reconnect field in virt-viewer moved into virt-viewer-app and changed to
property. New getter function implemented for it.
This will be used in virt-viewer-window.c for implementing
a "reconnect" button in the GUI.
---
Changes since v1:
- Moved the reconnect property from virt-viewer.c into virt-v
Added a new preferences tab, and a reconnect CheckButton into
virt-viewer-preferences.xml. They are implicitly set to hidden.
If compiling virt-viewer, USING_VIRT_VIEWER is defined and their
visibility is set to true in virt_viewer_app_get_preferences().
---
Changes since v1:
- Added a new prefer
Added define USING_VIRT_VIEWER when compiling virt-viewer. This will be
needed when compiling virt-viewer with the "Reconnect" GUI button,
because it can be only implemented in virt-viewer and not remote-viewer.
---
I thought of many other ways around this, but ultimately, ifdef seemed
like the cle
Added a reconnect CheckMenuItem into virt-viewer.xml.
This button is implicitly set to hidden.
If compiling virt-viewer, USING_VIRT_VIEWER is defined and
visibility of the button is set to true in virt_viewer_window_init.
The reconnect button callback gets the button state (true/false) and set
the
Reconnect field in virt-viewer.c changed to property.
This will be used in virt-viewer-window.c for implementing a "reconnect"
button in the GUI.
---
In virt_viewer_new() function, there's comment "/* should probably be
properties instead */".
If someone thinks it's a good idea, I can change all o
If it's not already set, set guest name field in virt-viewer-app when using VNC.
Wait for VNC to be initialized (virt_viewer_display_vnc_initialized()).
In this callback get field guest name from app and check whether it
was already set before (FE from libvirt).
If not, set the guest name to name
Notify user, that VNC does not provide uuid.
Set uuid to string "VNC does not provide guid".
This is more informative then just plain "Unknown".
User will now know WHY the GUID is unknown, when using remote-viewer.
---
Changes since v2:
- Changed char to gchar.
- Added file src/virt-viewer-displ
Notify user, that VNC does not provide uuid.
Set uuid to string "VNC does not provide guid".
This is more informative then just plain "Unknown".
User will now know WHY the GUID is unknown, when using remote-viewer.
---
Changes since v1:
- No longer calling g_strdup() on _("VNC does not provide GU
If it's not already set, set guest name field in virt-viewer-app when using VNC.
Wait for VNC to be initialized (virt_viewer_display_vnc_initialized()).
In this callback get field guest name from app and check whether it
was already set before (FE from libvirt).
If not, set the guest name to name
Notify user, that VNC does not provide uuid.
Set uuid to string "VNC does not provide guid".
This is more informative then just plain "Unknown".
User will now know WHY the GUID is unknown, when using remote-viewer.
---
src/virt-viewer-display-vnc.c | 7 ++-
1 file changed, 6 insertions(+), 1
If it's not already set, set guest name field in virt-viewer-app when using VNC.
Wait for VNC to be initialized (virt_viewer_display_vnc_initialized()).
In this callback get field guest name from app and check whether it
was already set before (FE from libvirt).
If not, set the guest name to name
File->Screenshot, File->Preferences, View->Zoom and Send keys are now
sensitive only while quest is connected.
Changed behaviour of zoom:
Previously, zoom could be set while quest wasn't connected. The zoom
would then be set on connection. There was no indication of current zoom
level while not c
Displays menu must be sensitive only when at least one display is
enabled.
---
v2:
Removed ternary operator from line 33.
sensitive = (keys != NULL) is enough here.
---
src/virt-viewer-app.c| 6 +-
src/virt-viewer-window.c | 13 +
src/virt-viewer-window.h | 1 +
3 files cha
File/Screenshot button, View/Zoom menu and Send keys menu must be
sensitive only when there is a guest is connected.
---
src/virt-viewer-app.c| 13 +
src/virt-viewer-app.h| 1 +
src/virt-viewer-window.c | 22 ++
src/virt-viewer-window.h | 1 +
src/virt-vie
Displays menu must be sensitive only when at least one display is
enabled.
---
src/virt-viewer-app.c| 6 +-
src/virt-viewer-window.c | 13 +
src/virt-viewer-window.h | 1 +
3 files changed, 19 insertions(+), 1 deletion(-)
diff --git a/src/virt-viewer-app.c b/src/virt-viewer-
45 matches
Mail list logo
