Re: [PATCH] virtManager: Folder sharing implementation for SPICE session

2020-08-13 Thread Marc-André Lureau
Hi On Thu, Aug 13, 2020 at 8:24 PM Cole Robinson wrote: > > On 8/13/20 11:44 AM, Victor Toso wrote: > > On Thu, Aug 13, 2020 at 10:34:52AM +0800, dianlujitao wrote: > >> Thanks for reviewing. > >> > >> I agree that it's a big mess to maintain its availability, do > >> you have connections with

Re: virt-manager and virgl / Spice / OpenGL

2020-05-19 Thread Marc-André Lureau
Hi On Tue, May 19, 2020 at 6:13 PM Scott Talbert wrote: > > On Tue, 19 May 2020, Marc-André Lureau wrote: > > >>>> Hi, > >>>> > >>>> Is virgl/OpenGL support through virt-manager supposed to work and perform > >>>> well? >

Re: virt-manager and virgl / Spice / OpenGL

2020-05-19 Thread Marc-André Lureau
Hi On Tue, May 19, 2020 at 5:40 PM Scott Talbert wrote: > > On Tue, 19 May 2020, Marc-André Lureau wrote: > > >> Hi, > >> > >> Is virgl/OpenGL support through virt-manager supposed to work and perform > >> well? > >> > >> I ha

Re: virt-manager and virgl / Spice / OpenGL

2020-05-19 Thread Marc-André Lureau
Hi On Fri, May 15, 2020 at 5:36 PM Scott Talbert wrote: > > Hi, > > Is virgl/OpenGL support through virt-manager supposed to work and perform > well? > > I have the following: > Host OS: Fedora 32 > Guest OS: Debian Unstable > > In virt-manager, I have the following: > Display Spice >Type:

Re: Permanent folder share with virt-viewer/manager?

2020-05-15 Thread Marc-André Lureau
Hi On Fri, May 15, 2020 at 1:42 PM Phil Kulak wrote: > > I've got folder sharing to a Windows VM working, but only if I start up > virt-viewer and edit preferences to select the folder every time. The next > time the machine starts, the setting is reset and the network drive won't > mount. Is

Re: Re: shm as domain to virt-viewer protocol? (Daniel P. Berrang?)

2020-03-27 Thread Marc-André Lureau
Hi David On Fri, Mar 27, 2020 at 9:52 PM David Geise wrote: [..] > I'm still just skimming & sizing things but it appears the options are: > > 1. Fork viewer at some level and become a downstream source code consumer; > don't worry about compatibility, etc but don't expect pull requests to be

Re: [virt-tools-list] [PATCH virt-viewer v2] Fix a regression when initial connection fails

2019-04-10 Thread Marc-André Lureau
> > *s, > > g_signal_emit_by_name(self, "session-disconnected", error ? > > error->message : NULL); > > } > > > > +/* called when the spice session indicates that a session has been > > destroyed */ > &g

Re: [virt-tools-list] [PATCH v4] remote-viewer: Allow toggling shared clipboard

2019-03-07 Thread Marc-André Lureau
Hi On Thu, Mar 7, 2019 at 12:36 PM Aleksei Nikiforov wrote: > > 04.03.2019 19:38, Marc-André Lureau пишет: > > On Mon, Mar 4, 2019 at 3:39 PM Aleksei Nikiforov > > wrote: > >> > >> Signed-off-by: Aleksei Nikiforov > > > > Reviewed-by: Marc-André

Re: [virt-tools-list] [PATCH v4] remote-viewer: Allow toggling shared clipboard

2019-03-04 Thread Marc-André Lureau
On Mon, Mar 4, 2019 at 3:39 PM Aleksei Nikiforov wrote: > > Signed-off-by: Aleksei Nikiforov Reviewed-by: Marc-André Lureau > --- > man/remote-viewer.pod | 3 + > src/resources/ui/virt-viewer-preferences.ui | 16 +++- > src/virt-viewer-app.c

Re: [virt-tools-list] [PATCH v3] remote-viewer: Allow toggling shared clipboard

2019-03-04 Thread Marc-André Lureau
Hi Aleksei, On Mon, Mar 4, 2019 at 1:13 PM Aleksei Nikiforov wrote: > > Signed-off-by: Aleksei Nikiforov > --- > man/remote-viewer.pod | 3 + > src/resources/ui/virt-viewer-preferences.ui | 16 +++- > src/virt-viewer-app.c | 93 +

Re: [virt-tools-list] [PATCH] remote-viewer: Allow toggling shared clipboard

2019-02-26 Thread Marc-André Lureau
Hi On Tue, Feb 26, 2019 at 3:08 PM Aleksei Nikiforov wrote: > > Hi > > 26.02.2019 15:42, Marc-André Lureau пишет: > > Hi > > > > On Tue, Feb 26, 2019 at 1:19 PM Aleksei Nikiforov > > wrote: > >> > >> Signed-off-by: Aleksei Nikiforov >

Re: [virt-tools-list] [PATCH] remote-viewer: Allow toggling shared clipboard

2019-02-26 Thread Marc-André Lureau
Hi On Tue, Feb 26, 2019 at 1:19 PM Aleksei Nikiforov wrote: > > Signed-off-by: Aleksei Nikiforov looks good overall, please update the man page for the new key > --- > src/resources/ui/virt-viewer.ui | 11 +++ > src/virt-viewer-app.c | 25 + >

Re: [virt-tools-list] [virt-viewer PATCH] msi: record full build environment in MSI installer

2019-02-19 Thread Marc-André Lureau
key implication of this is that formal release builds should always > be done in a pristine build root populated with the minimal content > required for the build. > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Marc-André Lureau > --- > data/Makefile.am| 8 &g

Re: [virt-tools-list] [virt-viewer PATCH] Add a git-publish configuration file

2019-02-19 Thread Marc-André Lureau
Hi On Tue, Feb 19, 2019 at 4:03 PM Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > --- > .gitpublish | 4 > 1 file changed, 4 insertions(+) > create mode 100644 .gitpublish > > diff --git a/.gitpublish b/.gitpublish > new file mode 100644 > index 000..bf82571 > ---

Re: [virt-tools-list] [virt-viewer PATCH 5/5] Switch to gnulib's compiler warning flags

2019-02-13 Thread Marc-André Lureau
d-off-by: Daniel P. Berrangé Reviewed-by: Marc-André Lureau But soon we will switch to meson :) oh well! > --- > acinclude.m4 | 98 --- > configure.ac | 2 +- > m4/manywarnings.m4 | 334 + >

Re: [virt-tools-list] [virt-viewer PATCH 4/5] Declare VirtViewerFile variable at start of method

2019-02-13 Thread Marc-André Lureau
On Wed, Feb 13, 2019 at 6:06 PM Daniel P. Berrangé wrote: > > virt_viewer_session_vnc_auth_credential uses gotos which jump over the > declaration of 'file', meaning its contents are uninitialized in the > jump target. > > Signed-off-by: Daniel P. Berrangé Reviewed-by:

Re: [virt-tools-list] [virt-viewer PATCH 3/5] Fix prototype of function with no arguments

2019-02-13 Thread Marc-André Lureau
On Wed, Feb 13, 2019 at 6:06 PM Daniel P. Berrangé wrote: > > Modern C standard requires the function to be "void" > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Marc-André Lureau > --- > src/virt-viewer-app.c | 2 +- > 1 file changed, 1 insertion(+), 1 d

Re: [virt-tools-list] [virt-viewer PATCH 2/5] Annotate message dialog helpers with format(gnu_printf)

2019-02-13 Thread Marc-André Lureau
Hi On Wed, Feb 13, 2019 at 6:05 PM Daniel P. Berrangé wrote: > > This allows the compiler to validate the format string and args passed > to the function. > > Signed-off-by: Daniel P. Berrangé Could we consider the slightly less uglier and foreign compiler-friendly G_GNUC_PRINTF? > --- >

Re: [virt-tools-list] [virt-viewer PATCH 1/5] Fix signed/unsigned mixup in format args

2019-02-13 Thread Marc-André Lureau
Hi On Wed, Feb 13, 2019 at 6:05 PM Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Marc-André Lureau > --- > src/ovirt-foreign-menu.c | 2 +- > src/remote-viewer.c| 6 +++--- > src/virt-viewer-file-tra

Re: [virt-tools-list] [PATCH] build-sys: lower spice-gtk requirement to 0.35 again

2019-02-04 Thread Marc-André Lureau
Hi Subject should be "[PATCH virt-viewer]..." On Mon, Feb 4, 2019 at 10:05 AM wrote: > > From: Marc-André Lureau > > Compile out QMP channel support if spice-gtk version < 0.36. > > (note: I didn't bother adding configure switch to enable it > explicitly, this

Re: [virt-tools-list] [PATCH virt-viewer v2] Add missing G_MODULE_EXPORT to signal handler

2019-01-18 Thread Marc-André Lureau
On Fri, Jan 18, 2019 at 11:53 PM Eduardo Lima (Etrunko) wrote: > > Fixes the Windows case where the dialog fails to show with the following > message: > > warning: "Could not find signal handler > 'virt_viewer_window_menu_change_cd_activate'" > > Signed-off-by: Eduardo Lima (Etrunko) ack >

Re: [virt-tools-list] [PATCH virt-viewer] Add missing G_MODULE_EXPORT to signal handler

2019-01-18 Thread Marc-André Lureau
On Fri, Jan 18, 2019 at 6:58 PM Eduardo Lima (Etrunko) wrote: > > Fixes the Windows case where the dialog fails to show with the following > message: > > warning: "Could not find signal handler > 'virt_viewer_window_menu_change_cd_activate'" > > Signed-off-by: Eduardo Lima (Etrunko) ack > ---

Re: [virt-tools-list] [PATCH virt-viewer] Spice: listen for new 'SpiceSession::disconnected' signal

2019-01-16 Thread Marc-André Lureau
Hi On Fri, Jan 4, 2019 at 11:08 PM Marc-André Lureau wrote: > > Hi > > On Tue, Sep 18, 2018 at 8:25 PM Jonathon Jongsma wrote: > > > > Previously we were emitting the VirtViewerSession::session-disconnected > > when we got the Spice::session::channel-destroy s

Re: [virt-tools-list] [PATCH 1/2] Report gtk_accel_map_change_entry() failures

2019-01-05 Thread Marc-André Lureau
Hi On Mon, Aug 6, 2018 at 1:09 AM Paul Donohue wrote: > > Signed-off-by: Paul Donohue Sorry for the late review, Reviewed-by: Marc-André Lureau > --- > src/virt-viewer-app.c | 30 +++--- > 1 file changed, 19 insertions(+), 11 deletions(-) > >

Re: [virt-tools-list] [PATCH virt-viewer] Spice: listen for new 'SpiceSession::disconnected' signal

2019-01-04 Thread Marc-André Lureau
->message : NULL); > +if (error) { > +g_warning("Channel error: %s", error->message); > +if (self->priv->disconnect_error == NULL) { > +self->priv->disconnect_error = g_error_copy(error); > +} > +} > } > > VirtViewerSession * > -- > 2.14.4 > > ___ > virt-tools-list mailing list > virt-tools-list@redhat.com > https://www.redhat.com/mailman/listinfo/virt-tools-list -- Marc-André Lureau ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] [PATCH v2 11/16] session: do not take VTE display into account for geometry changes

2018-12-21 Thread Marc-André Lureau
Hi On Thu, Dec 20, 2018 at 8:51 PM Victor Toso wrote: > > Hi, > > On Wed, Sep 26, 2018 at 07:26:34PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Signed-off-by: Marc-André Lureau > > --- > > src/virt-viewer-session.c |

Re: [virt-tools-list] [PATCH v2 16/16] spice: hook into QMP port

2018-12-21 Thread Marc-André Lureau
Hi On Fri, Dec 21, 2018 at 5:35 PM Victor Toso wrote: > > Hi, > > On Wed, Sep 26, 2018 at 07:26:39PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > If the "org.qemu.monitor.qmp.0" port is available: > > - enab

Re: [virt-tools-list] [PATCH v2 12/16] app: create a window for VTE displays

2018-12-21 Thread Marc-André Lureau
Hi On Fri, Dec 21, 2018 at 3:31 PM Victor Toso wrote: > > Hi, > > On Wed, Sep 26, 2018 at 07:26:35PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > virt_viewer_app_display_added() now handles VTE displays. They should > >

Re: [virt-tools-list] [PATCH v2 13/16] spice: hook into port channel to create VTE terminals

2018-12-21 Thread Marc-André Lureau
Hi On Fri, Dec 21, 2018 at 4:03 PM Victor Toso wrote: > > Hi, > > On Wed, Sep 26, 2018 at 07:26:36PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > QEMU defines a few Spice port channel names in > > docs/spice-port-fqdn.txt th

Re: [virt-tools-list] [PATCH] spice: add unix-path in .vv file support

2018-12-21 Thread Marc-André Lureau
Hi On Fri, Dec 21, 2018 at 4:33 PM Christophe Fergeau wrote: > > On Fri, Dec 21, 2018 at 03:27:59PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > This will allow to connect to a Spice server using a unix socket path, > > for example

Re: [virt-tools-list] [PATCH v2 10/16] display: allow display without associated monitor number

2018-12-21 Thread Marc-André Lureau
Hi On Thu, Dec 20, 2018 at 8:45 PM Victor Toso wrote: > > Hi, > > On Wed, Sep 26, 2018 at 07:26:33PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > The VTE display will have monitor id -1. > > > > Eventually, having a bas

Re: [virt-tools-list] [PATCH v2 09/16] app: append VTE consoles to display submenu

2018-12-21 Thread Marc-André Lureau
Hi On Thu, Dec 20, 2018 at 8:43 PM Victor Toso wrote: > > Hi, > > On Wed, Sep 26, 2018 at 07:26:32PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Get the name of the console, and set the subtitle with it. > > > >

Re: [virt-tools-list] [PATCH v2 05/16] window/zoom: deal with VTE display differently

2018-12-21 Thread Marc-André Lureau
Hi On Thu, Dec 20, 2018 at 8:14 PM Victor Toso wrote: > > Hi, > > On Wed, Sep 26, 2018 at 07:26:28PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > VTE display doesn't use the desktop / window aspect ratio, let's just > > call

Re: [virt-tools-list] [PATCH v2 07/16] session: skip monitor changes if there is no sized monitors

2018-12-21 Thread Marc-André Lureau
Hi On Thu, Dec 20, 2018 at 8:25 PM Victor Toso wrote: > > Hi, > > On Wed, Sep 26, 2018 at 07:26:30PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > spice-gtk discards configurations without any sized monitors. > > > &g

Re: [virt-tools-list] [PATCH v2 00/16] Add QEMU-like UI: VT console & basic VM state

2018-11-28 Thread Marc-André Lureau
Hi On Wed, Sep 26, 2018 at 7:26 PM wrote: > > From: Marc-André Lureau > > Hi, > > QEMU provides multiple display backend, with different set of > features. One of the richest UI is the -display gtk. It is quite > minimal, and comparable to remote-viewer UI wrt fullscreen

Re: [virt-tools-list] [PATCH v2 00/16] Add QEMU-like UI: VT console & basic VM state

2018-11-16 Thread Marc-André Lureau
Hi On Tue, Oct 30, 2018 at 8:40 PM Marc-André Lureau wrote: > > Hi > On Wed, Sep 26, 2018 at 7:27 PM wrote: > > > > From: Marc-André Lureau > > > > Hi, > > > > QEMU provides multiple display backend, with different set of > > features. One

Re: [virt-tools-list] [PATCH v2 00/16] Add QEMU-like UI: VT console & basic VM state

2018-10-30 Thread Marc-André Lureau
Hi On Wed, Sep 26, 2018 at 7:27 PM wrote: > > From: Marc-André Lureau > > Hi, > > QEMU provides multiple display backend, with different set of > features. One of the richest UI is the -display gtk. It is quite > minimal, and comparable to remote-viewer UI wrt fullscreen

Re: [virt-tools-list] [PATCH v2 00/16] Add QEMU-like UI: VT console & basic VM state

2018-10-03 Thread Marc-André Lureau
Hi On Wed, Sep 26, 2018 at 7:27 PM wrote: > > From: Marc-André Lureau > > Hi, > > QEMU provides multiple display backend, with different set of > features. One of the richest UI is the -display gtk. It is quite > minimal, and comparable to remote-viewer UI wrt fullscreen

Re: [virt-tools-list] [PATCH] cli: add memory backing access_mode & source_type

2018-10-01 Thread Marc-André Lureau
Hi On Mon, Oct 1, 2018 at 9:20 PM Cole Robinson wrote: > > On 09/17/2018 06:59 AM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Allow to set some memory backing options, ex: > > --memorybacking access_mode=shared,source_type=anonymous >

Re: [virt-tools-list] [PATCH 22/22] spice: hook into QMP port

2018-09-05 Thread Marc-André Lureau
Hi On Mon, Sep 3, 2018 at 8:53 AM, Victor Toso wrote: > Hi, > > On Tue, Jul 31, 2018 at 03:41:25PM +0200, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> If the "org.qemu.monitor.qmp.0" port is available: >> - enable the VM UI

Re: [virt-tools-list] [PATCH 07/22] window: set sensitivity based on display capability

2018-08-31 Thread Marc-André Lureau
Hi On Fri, Aug 31, 2018 at 8:43 AM, Victor Toso wrote: > Hi, > > On Tue, Jul 31, 2018 at 03:41:10PM +0200, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau > > I take this is a preparatory patch for VTE, could you please add > some rationale in the commit lo

Re: [virt-tools-list] [PATCH 06/22] window: do not reset sensitivity of menu-send in rebuild

2018-08-31 Thread Marc-André Lureau
Hi On Fri, Aug 31, 2018 at 8:32 AM, Victor Toso wrote: > Hi, > > On Tue, Jul 31, 2018 at 03:41:09PM +0200, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> A mere app::enable-accel notification shouldn't modify the >> sensitivity, which is han

Re: [virt-tools-list] [PATCH 22/22] spice: hook into QMP port

2018-08-07 Thread Marc-André Lureau
Hi On Tue, Aug 7, 2018 at 1:28 PM, Daniel P. Berrangé wrote: > On Tue, Aug 07, 2018 at 01:13:38PM +0200, Marc-André Lureau wrote: >> Hi >> >> On Tue, Aug 7, 2018 at 1:02 PM, Daniel P. Berrangé >> wrote: >> > On Tue, Aug 07, 2018 at 12:52:46PM +020

Re: [virt-tools-list] [PATCH 22/22] spice: hook into QMP port

2018-08-07 Thread Marc-André Lureau
Hi On Tue, Aug 7, 2018 at 1:02 PM, Daniel P. Berrangé wrote: > On Tue, Aug 07, 2018 at 12:52:46PM +0200, Marc-André Lureau wrote: >> Hi >> >> On Tue, Aug 7, 2018 at 12:01 PM, Daniel P. Berrangé >> wrote: >> > I would suggest it should use libvirt f

Re: [virt-tools-list] [PATCH 22/22] spice: hook into QMP port

2018-08-07 Thread Marc-André Lureau
Hi On Tue, Aug 7, 2018 at 12:01 PM, Daniel P. Berrangé wrote: > On Tue, Jul 31, 2018 at 03:41:25PM +0200, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> If the "org.qemu.monitor.qmp.0" port is available: >> - enable the VM UI >&

Re: [virt-tools-list] [PATCH 00/22] Add QEMU-like UI: VT console VM state

2018-08-02 Thread Marc-André Lureau
Hi Xiaodai On Thu, Aug 2, 2018 at 10:56 AM, Xiaodai Wang wrote: > > - Original Message - >> From: "Marc-André Lureau" >> To: "Xiaodai Wang" >> Cc: "virt-tools-list" >> Sent: Wednesday, August 1, 2018 9:46:47 PM >>

Re: [virt-tools-list] [PATCH 00/22] Add QEMU-like UI: VT console VM state

2018-08-01 Thread Marc-André Lureau
opy/paste. I guess we could have a similar UI in remote-viewer. thanks > - Original Message - >> From: "marcandre lureau" >> To: virt-tools-list@redhat.com >> Sent: Tuesday, July 31, 2018 9:24:40 PM >> Subject: [virt-tools-list] [PATCH 00/22] Add QEMU

Re: [virt-tools-list] [virt-viewer PATCH] Bump min spice to 0.35 and address deprecation warnings

2018-07-27 Thread Marc-André Lureau
On Fri, Jul 27, 2018 at 1:39 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé Reviewed-by: Marc-André Lureau > --- > README.md | 2 +- > configure.ac| 2 +- > src/virt-viewer-display-spice.c | 2 +- > src/v

Re: [virt-tools-list] [PATCH] tpm: allow hotplug operation so error is reported by libvirt

2018-06-12 Thread Marc-André Lureau
rger Reviewed-by: Marc-André Lureau > --- > virtManager/domain.py | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/virtManager/domain.py b/virtManager/domain.py > index 3eb860ec..8688f282 100644 > --- a/virtManager/domain.py > +++ b/virtManager

Re: [virt-tools-list] [virt-manager PATCH 0/5] WIP: Various TPM improvements

2018-05-24 Thread Marc-André Lureau
Hi On Thu, May 24, 2018 at 6:01 PM, Stefan Berger <stef...@linux.vnet.ibm.com> wrote: > On 05/24/2018 06:39 AM, marcandre.lur...@redhat.com wrote: >> >> From: Marc-André Lureau <marcandre.lur...@redhat.com> >> >> Hi, >> >> The following seri

Re: [virt-tools-list] [virt-manager PATCH] git: add a git publish configuration file

2018-04-24 Thread Marc-André Lureau
On Tue, Apr 24, 2018 at 8:11 PM, Daniel P. Berrangé <berra...@redhat.com> wrote: > Provide a config file for git-publish that sets the right mailing list > and patch subject prefix. > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> Reviewed-by: Marc-And

Re: [virt-tools-list] [PATCH] virtinst: add feature support

2018-02-21 Thread Marc-André Lureau
Hi On Wed, Feb 21, 2018 at 4:08 PM, Cole Robinson <crobi...@redhat.com> wrote: > On 02/20/2018 02:30 PM, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau <marcandre.lur...@redhat.com> >> >> The feature allows a guest to provide debug details wh

Re: [virt-tools-list] [PATCH v2 1/3] remote-viewer: learn '-' as URI for standard input connection file

2017-11-16 Thread Marc-André Lureau
On Tue, Nov 14, 2017 at 5:46 PM, Victor Toso <victort...@redhat.com> wrote: > Hi, > > On Tue, Nov 14, 2017 at 11:39:54AM -0500, Marc-André Lureau wrote: >> Hi >> >> - Original Message - >> > Hi, >> > >> > On Tue, Nov 14, 2017

Re: [virt-tools-list] [PATCH v2 1/3] remote-viewer: learn '-' as URI for standard input connection file

2017-11-14 Thread Marc-André Lureau
Hi - Original Message - > Hi, > > On Tue, Nov 14, 2017 at 04:56:01PM +0100, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > > > Some users want the ability to set connection details without writing >

Re: [virt-tools-list] [PATCH 1/2] RFC: remote-viewer: learn '-' as URI for standard input connection file

2017-11-14 Thread Marc-André Lureau
- Original Message - > Hi, > > On Fri, Jul 28, 2017 at 08:43:44PM +0200, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > > > Some users want the ability to set connection details without writing >

Re: [virt-tools-list] [PATCH 2/2] remote-viewer: remove --spice-controller

2017-07-31 Thread Marc-André Lureau
Hi - Original Message - > On Fri, Jul 28, 2017 at 08:43:45PM +0200, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > > > spice controller interface is being removed from spice-gtk. > > Is this fallout from

Re: [virt-tools-list] Time for a new virt-viewer release ?

2017-07-31 Thread Marc-André Lureau
Hi - Original Message - > On Mon, Jul 10, 2017 at 10:34:27AM -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > On 07/07/17 09:15, Daniel P. Berrange wrote: > > > > Our last release was in Nov last year

Re: [virt-tools-list] [PATCH virt-viewer 0/6] RFC: add dbus-controller, remove spice-controller

2017-07-28 Thread Marc-André Lureau
Hi On Fri, Jun 23, 2017 at 5:34 PM <marcandre.lur...@redhat.com> wrote: > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > Hi, > > For the reasons explained in this spice-gtk patch series: > https://patchwork.freedesktop.org/patch/161676/, spice-controller

Re: [virt-tools-list] [PATCH virt-viewer] msi: Do not escape '$' for wixl-heat

2017-07-24 Thread Marc-André Lureau
Hi - Original Message - > wixl-heat does it itself since its commit 9273514c95e343340d18067b4f1 > > otherwise msi generation fails with: > Couldn't find file > $/tmp/tmp.1MYrxTLd1U/usr/x86_64-w64-mingw32/sys-root/mingw/bin/debug-helper.exe > --- > data/Makefile.am | 2 +- > 1 file

Re: [virt-tools-list] [PATCH virt-viewer 1/1] window: Allow to control zoom using keypad

2017-04-07 Thread Marc-André Lureau
N_ELEMENTS(keypad_action_entries); i++) { > +gchar *detailed_name = g_strdup_printf("win.%s", > keypad_action_entries[i].name); > +gtk_application_set_accels_for_action(GTK_APPLICATION(priv->app), > + detailed_name, > + keypad_action_accels[i]); > +g_free(detailed_name); > +} > + > priv->accel_enabled = TRUE; > } > > -- > 2.12.2 > > ___ > virt-tools-list mailing list > virt-tools-list@redhat.com > https://www.redhat.com/mailman/listinfo/virt-tools-list > -- Marc-André Lureau ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] [PATCH v4 1/2] virt-manager: add opengl graphics option

2016-12-19 Thread Marc-André Lureau
Hi - Original Message - > On 11/28/2016 05:47 AM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau <marcandre.lur...@gmail.com> > > > > Add an OpenGL checkbox to the Spice graphics options (only available if > > SUPPORT_CONN_SPICE_GL). >

Re: [virt-tools-list] [PATCH 4/4] gfxdetails: add listen "None" option

2016-11-14 Thread Marc-André Lureau
Hi Pavel, - Original Message - > On Mon, Nov 14, 2016 at 09:49:33AM +0100, Pavel Hrdina wrote: > > On Wed, Nov 09, 2016 at 11:21:35AM +0400, marcandre.lur...@redhat.com > > wrote: > > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > > &

Re: [virt-tools-list] RFC: time for a 5.0 release ?

2016-10-10 Thread Marc-André Lureau
Hi - Original Message - > The 4.0 release was in June, and there have not been very many changes > since then, but there are a couple of significant ones > > - Fix resizing of windows when using CSDs (relevant for Wayland) > - Fix virt-viewer not exiting on broken connection to guest >

Re: [virt-tools-list] [PATCH 2/5] virtinst: check minimum qemu/libvirt for spice+gl

2016-10-06 Thread Marc-André Lureau
Hi Cole On Sun, May 8, 2016 at 3:36 AM Cole Robinson <crobi...@redhat.com> wrote: > On 04/28/2016 08:22 AM, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > > --- > > virtinst/guest.py | 5 + > > virtins

Re: [virt-tools-list] [PATCH virt-install 2/2] Don't generate port and tlsport parameters in xml if spice gl is enabled

2016-05-04 Thread Marc-André Lureau
Hi - Original Message - > spice gl + tcp port is disallowed by qemu commit 569a93c, So in this > case we don't generate port and tlsport parameters in domain xml. > > Signed-off-by: Lin Ma > --- > tests/cli-test-xml/compare/virt-install-spice-gl.xml | 2 +- >

Re: [virt-tools-list] [PATCH 3/5] virtinst: add listen=none graphics option

2016-04-28 Thread Marc-André Lureau
Hi - Original Message - > On Thu, Apr 28, 2016 at 10:14:27AM -0400, Marc-André Lureau wrote: > > > > I like it, let me know how I can help. I hope we can have it in next > > libvirt release, since it's not possible to setup a spice+virgl VM > > anymore sin

Re: [virt-tools-list] [PATCH 3/5] virtinst: add listen=none graphics option

2016-04-28 Thread Marc-André Lureau
Hi - Original Message - > On Thu, Apr 28, 2016 at 09:39:40AM -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > On Thu, Apr 28, 2016 at 02:22:09PM +0200, Marc-André Lureau wrote: > > > > Add a special listen

Re: [virt-tools-list] [PATCH 3/5] virtinst: add listen=none graphics option

2016-04-28 Thread Marc-André Lureau
Hi - Original Message - > On Thu, Apr 28, 2016 at 02:22:09PM +0200, Marc-André Lureau wrote: > > Add a special listen value to disable any extra display server listening > > socket. This is necessary now that qemu prevents starting a spice+virgl > > VM with listening

[virt-tools-list] [PATCH 3/5] virtinst: add listen=none graphics option

2016-04-28 Thread Marc-André Lureau
Add a special listen value to disable any extra display server listening socket. This is necessary now that qemu prevents starting a spice+virgl VM with listening sockets (until spice allows remoting with virgl). Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- ma

[virt-tools-list] [PATCH 0/5] virt-manager: more spice+virgl support

2016-04-28 Thread Marc-André Lureau
switch the video device to "virtio". To setup a new VM, you'll do similarly during a customize installation. The Fedora 24 pre-release works out of the box and allows easy testing. (notes: a few patches are resent from older series. I didn't try to manually "simplify" glade 3.20

[virt-tools-list] [PATCH 5/5] gfxdetails: add local-only option

2016-04-28 Thread Marc-André Lureau
Similarly to virt-install --listen=none, add a checkbox to disable all extra display server listening interface/ports. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- ui/gfxdetails.ui | 106 + virtManager/addhardw

[virt-tools-list] [PATCH 1/5] ConnectionInfo: console is active if fd can be provided

2016-04-28 Thread Marc-André Lureau
A domain doesn't need to have TCP socket listening, virt-manager can now connect to it as long as libvirt can provide some fd (through local unix sockets). Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- virtManager/sshtunnels.py | 4 1 file changed, 4 insertions(+)

[virt-tools-list] [PATCH 4/5] virt-manager: add opengl graphics option

2016-04-28 Thread Marc-André Lureau
From: Marc-André Lureau <marcandre.lur...@gmail.com> Add a OpenGl checkbox to the Spice graphics option (only available if SUPPORT_CONN_SPICE_GL). Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- ui/gfxdetails.ui | 29 +

[virt-tools-list] [PATCH 2/5] virtinst: check minimum qemu/libvirt for spice+gl

2016-04-28 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- virtinst/guest.py | 5 + virtinst/support.py | 1 + 2 files changed, 6 insertions(+) diff --git a/virtinst/guest.py b/virtinst/guest.py index ab6dcba..5824e87 100644 --- a/virtinst/guest.py +++ b/virtinst/gu

[virt-tools-list] [PATCH virt-manager] ConnectionInfo: console is active if fd can be provided

2016-04-26 Thread Marc-André Lureau
A domain doesn't need to have TCP socket listening, virt-manager can now connect to it as long as libvirt can provide some fd (through local unix sockets). Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- virtManager/sshtunnels.py | 4 1 file changed, 4 insertions(+)

Re: [virt-tools-list] [PATCH v2 5/5] virt-manager: add opengl graphics option

2016-03-10 Thread Marc-André Lureau
Hi Cole - Original Message - > On 03/04/2016 06:31 AM, Marc-André Lureau wrote: > > From: Marc-André Lureau <marcandre.lur...@gmail.com> > > > > Add a OpenGl checkbox to the Spice graphics option. > > > > Signed-off-by: Marc-André Lureau <m

[virt-tools-list] [PATCH v2 5/5] virt-manager: add opengl graphics option

2016-03-04 Thread Marc-André Lureau
From: Marc-André Lureau <marcandre.lur...@gmail.com> Add a OpenGl checkbox to the Spice graphics option. Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> --- ui/gfxdetails.ui | 29 + virtManager/details.py| 9 +++--

[virt-tools-list] [PATCH v2 0/5] virt-manager: add spice+virgl support

2016-03-04 Thread Marc-André Lureau
pice gl parameter (changed during libvirt patches review) - fix gfx.gl usage after Cole review Marc-André Lureau (5): virtinst: add --graphics gl option virtinst: add virtio device model and accel3d attribute virtinst: use virtio if spice+gl virt-manager: connect with openGraphicsFD virt-

[virt-tools-list] [PATCH v2 3/5] virtinst: use virtio if spice+gl

2016-03-04 Thread Marc-André Lureau
From: Marc-André Lureau <marcandre.lur...@gmail.com> Use virtio+accel3d by default whenever spice+gl is chosen. This allows to easily set up accelerated gpu VM. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- .../cli-test-xml/compare/virt-install-spice

[virt-tools-list] [PATCH v2 4/5] virt-manager: connect with openGraphicsFD

2016-03-04 Thread Marc-André Lureau
From: Marc-André Lureau <marcandre.lur...@gmail.com> This allows to connect to VM without any display listening socket, the fd passing is done through libvirt connection. Furthermore, since it uses unix socket, spice can use virgl locally with texture sharing. This effectively enables spi

[virt-tools-list] [PATCH v2 2/5] virtinst: add virtio device model and accel3d attribute

2016-03-04 Thread Marc-André Lureau
From: Marc-André Lureau <marcandre.lur...@gmail.com> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- man/virt-install.pod | 2 +- tests/xmlparse-xml/change-videos-out.xml | 4 +++- tests/xmlparse.py| 1 + virtinst/de

[virt-tools-list] [PATCH v2 1/5] virtinst: add --graphics gl option

2016-03-04 Thread Marc-André Lureau
From: Marc-André Lureau <marcandre.lur...@gmail.com> Add a --graphics option to enable accelarated rendering using OpenGl. This is used only by Spice (and for local only guests atm). Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- man/virt

[virt-tools-list] [PATCH 1/5] virtinst: add --graphics gl option

2016-02-18 Thread Marc-André Lureau
From: Marc-André Lureau <marcandre.lur...@gmail.com> Add a --graphics option to enable accelarated rendering using OpenGl. This is used only by Spice (and for local only guests atm). Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- man/virt

[virt-tools-list] [PATCH 0/5] RFC: virt-manager: add spice+virgl support

2016-02-18 Thread Marc-André Lureau
erver, libvirt openGraphicsFD does the job just fine, so I opted for that. review and help welcome, Marc-André Lureau (5): virtinst: add --graphics gl option virtinst: add virtio device model and accel3d attribute virtinst: use virtio if spice+gl virt-manager: connect with openGraphicsFD

[virt-tools-list] [PATCH 4/5] virt-manager: connect with openGraphicsFD

2016-02-18 Thread Marc-André Lureau
From: Marc-André Lureau <marcandre.lur...@gmail.com> This allows to connect to VM without any listening socket. Furthermore, since it uses unix socket, spice can use virgl locally with texture sharing. This effectively enables spice-gtk to display local virgl rendering. Signed-off-by

Re: [virt-tools-list] [PATCH] msi: use the correct id for remote-viewer.exe

2015-10-08 Thread Marc-André Lureau
- Original Message - > As, in theory, file ids are stables, seems that we have been using the > wrong id for remote-viewer,exe since forever. I don't think so, file association used to work. More likely the path changed. > That's what msidump shows: > > ffidenci@cat

Re: [virt-tools-list] [virt-viewer PATCH V2] Add InstallScope=perMachine to virt-viewer.wxs.in

2015-06-10 Thread Marc-André Lureau
, and the current wxs was designed and tested only perMachine, so let's fix it to work properly that way. ack -- Marc-André Lureau ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] [virt-viewer PATCH V2] Add InstallScope=perMachine to virt-viewer.wxs.in

2015-06-09 Thread Marc-André Lureau
hi - Original Message - From: Sandy Stutsman sstut...@redhat.com Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1146016 Without this parameter the installer will place the start menu icon in the Admin users path rather than the 'AllUsers'. Unprivileged users are unable to

Re: [virt-tools-list] [virt-viewer PATCH V2] Add InstallScope=perMachine to virt-viewer.wxs.in

2015-06-09 Thread Marc-André Lureau
Hi Sandy - Original Message - The default installation (say double clicking the .msi file) results in an inconsistent installation state, part perMachine/part perUser. (The situation that raised the bug.) The expected behavior is that the default installation be consistent. If other

Re: [virt-tools-list] [virt-viewer PATCH V2] Add InstallScope=perMachine to virt-viewer.wxs.in

2015-06-09 Thread Marc-André Lureau
Hi - Original Message - Hi Mark, A perUser install puts all the package contents in the User's path; the start menu items and executable will be places under the installer's user paths. A perMachine install puts the packages under directories that are accessible by all users.

Re: [virt-tools-list] [virt-viewer PATCH V2] Add InstallScope=perMachine to virt-viewer.wxs.in

2015-06-09 Thread Marc-André Lureau
- Original Message - Hi - Original Message - Hi Mark, A perUser install puts all the package contents in the User's path; the start menu items and executable will be places under the installer's user paths. A perMachine install puts the packages under directories

Re: [virt-tools-list] [virt-viewer PATCH] Add ALLUSERS to virt-viewer.wxs.in

2015-06-08 Thread Marc-André Lureau
) IncludeMinimum=yes IncludeMaximum=no Property=OLDERVERSIONBEINGUPGRADED/ -- 1.9.5.msysgit.0 ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list -- Marc-André Lureau

Re: [virt-tools-list] [PATCH virt-manager 0/5] Disable vmport with Spice

2015-05-04 Thread Marc-André Lureau
Hi Cole On Fri, Apr 3, 2015 at 5:23 PM, Cole Robinson crobi...@redhat.com wrote: Thanks for the patches! I'll push when the libvirt patches land. just landed cheers -- Marc-André Lureau ___ virt-tools-list mailing list virt-tools-list@redhat.com

Re: [virt-tools-list] [PATCH virt-viewer v2 4/7] Fullscreen auto-conf: wait for server to be configured

2015-04-22 Thread Marc-André Lureau
-- Marc-André Lureau ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] Windows 7 VM doesn't go full screen

2015-04-22 Thread Marc-André Lureau
Hi - Original Message - I'm currently using Mint but will go back to Ubuntu once I find the time. I've got Windows 7 in a VM, but I can never get it to be full screen. What can I do about this? I've tried a few things I found, like changing VM resolution or using VMVGA instead of VGA,

[virt-tools-list] [PATCH virt-manager 1/5] virtinst: add new vmport domain feature

2015-04-02 Thread Marc-André Lureau
This should be available with libvirt 1.2.15 --- virtinst/domainfeatures.py | 3 +++ virtinst/support.py| 2 ++ 2 files changed, 5 insertions(+) diff --git a/virtinst/domainfeatures.py b/virtinst/domainfeatures.py index bec538b..16d8ee2 100644 --- a/virtinst/domainfeatures.py +++

[virt-tools-list] [PATCH virt-manager 2/5] virtinst: add features.vmport option

2015-04-02 Thread Marc-André Lureau
--- virtinst/cli.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/virtinst/cli.py b/virtinst/cli.py index 93aae3d..44504b0 100644 --- a/virtinst/cli.py +++ b/virtinst/cli.py @@ -1406,6 +1406,8 @@ class ParserFeatures(VirtCLIParser):

[virt-tools-list] [PATCH virt-manager 0/5] Disable vmport with Spice

2015-04-02 Thread Marc-André Lureau
-André Lureau (5): virtinst: add new vmport domain feature virtinst: add features.vmport option virtinst: set_graphics_defaults() first virtinst: set vmport off by default when has_spice() tests: add some vmport tests tests/cli-test-xml/compare/virt-install-singleton-config-2.xml | 2

[virt-tools-list] [PATCH virt-manager 3/5] virtinst: set_graphics_defaults() first

2015-04-02 Thread Marc-André Lureau
Some later options may require Spice (or other) to be enabled, so call set_graphics_defaults() earlier. --- virtinst/guest.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/virtinst/guest.py b/virtinst/guest.py index 678f675..6f42775 100644 --- a/virtinst/guest.py +++

[virt-tools-list] [PATCH virt-manager 4/5] virtinst: set vmport off by default when has_spice()

2015-04-02 Thread Marc-André Lureau
Spice is better off without vmport enabled, to be able to switch between absolute and relative mouse mode easily. --- virtinst/guest.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/virtinst/guest.py b/virtinst/guest.py index 6f42775..9eb53b5 100644 --- a/virtinst/guest.py +++

  1   2   3   4   5   6   7   8   >