event emitted by libvirt
is not listened to.
Signed-off-by: Michal Privoznik
---
virtManager/connection.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/virtManager/connection.py b/virtManager/connection.py
index 68a37ea6..6585fef6 100644
--- a/virtManager/connection.py
+++ b/virtManager
There are two domain XML knobs specific to NVDIMMs that
virt-install doesn't allow to set: and .
Implement them.
Closes: https://github.com/virt-manager/virt-manager/issues/267
Signed-off-by: Michal Privoznik
---
v2 of:
https://listman.redhat.com/archives/virt-tools-list/2021-June/msg00023
There are two domain XML knobs specific to NVDIMMs that
virt-install doesn't allow to set: and .
Implement them.
Closes: https://github.com/virt-manager/virt-manager/issues/267
Signed-off-by: Michal Privoznik
---
tests/data/cli/compare/virt-install-singleton-config-3.xml | 2 ++
tests
On 2/17/20 8:20 PM, Yuri Weinstein wrote:
Thanks Michal!
See comments in line
On Mon, Feb 17, 2020 at 9:23 AM Michal Privoznik <mailto:mpriv...@redhat.com>> wrote:
On 2/16/20 10:20 PM, Yuri Weinstein wrote:
> I used to have QEMU/KVM and Virtual Machine Manager running o
On 2/16/20 10:20 PM, Yuri Weinstein wrote:
I used to have QEMU/KVM and Virtual Machine Manager running on ubuntu
16.04 and used to start my VM from crontab as:
@reboot sleep 30 && virsh start WINDOWS10
Libvirt has an autostart feature, which can start your domain on the
first time libvirtd
Upstream qemu installs
/usr/share/qemu/edk2-$ARCH-(?secure-)code.fd FW images. Whitelist
them too.
Signed-off-by: Michal Privoznik
---
This can be verified by running the following:
qemu.git $ git clean -fxd; \
./configure --prefix=/usr && \
mkdir
-viewer will have virsh
available too. If they don't, nothing breaks and no error message
is printed.
The completer script is inspired by libvirt.
Signed-off-by: Michal Privoznik
Reviewed-by: Fabiano Fidêncio
---
diff to v2:
- Fixed --display completer. Problem was that a colon is viewed by bash
On 5/9/19 10:50 AM, Michal Privoznik wrote:
On 5/7/19 8:32 PM, Jonathon Jongsma wrote:
On Mon, 2019-05-06 at 13:27 +0200, Michal Privoznik wrote:
With this change one can get list of domains on the command line:
$ virt-viewer -c qemu:///system
dom1 dom2 ... domN
The list
On 5/7/19 8:32 PM, Jonathon Jongsma wrote:
On Mon, 2019-05-06 at 13:27 +0200, Michal Privoznik wrote:
With this change one can get list of domains on the command line:
$ virt-viewer -c qemu:///system
dom1 dom2 ... domN
The list of domains is fetched using virsh, hence
-viewer will have virsh
available too. If they don't, nothing breaks and no error message
is printed.
The completer script is inspired by libvirt.
Signed-off-by: Michal Privoznik
---
diff to v1:
- Fixed 'make syntax-check' issue
- Introduced support for completing domain IDs
- Introduced --display
On 3/26/19 4:26 PM, Michal Privoznik wrote:
With this change one can get list of domains on the command line:
$ virt-viewer -c qemu:///system
dom1 dom2 ... domN
The list of domains is fetched using virsh, hence the dependency
on libvirt-client recorded in the spec file. I think it's
-viewer will have virsh
available too. If they don't, nothing breaks and no error message
is printed.
The completer script is inspired by libvirt.
Signed-off-by: Michal Privoznik
---
Makefile.am | 2 +-
bash-completion/Makefile.am | 20 +
bash-completion/virt-viewer | 90
On 09/25/2018 11:12 AM, Lin Ma wrote:
> Lin Ma (3):
> cli: disk: add pr.managed=, pr.type=, pr.path= and pr.mode= support
> details: Add disk pr.managed and pr.path options to support SCSI PR
> addhardware: Add disk pr.managed and pr.path options to support SCSI
> PR
>
>
On 04/11/2018 12:43 PM, Radostin Stoyanov wrote:
> Hi Michal,
>
> This commit was also created as a pull request by @z3ntu on github
> https://github.com/virt-manager/virt-manager/pull/29
Ah, haven't noticed because we don't use github pull requests. I don't
care which patch gets merged.
Michal
In fe9ed2340cd5b6 and 3909c10441a5f4eb two new virtinst/
subdirectories were introduced. However, we forget to distribute
them therefore installed virt-manager fails to start.
Signed-off-by: Michal Privoznik <mpriv...@redhat.com>
---
setup.py | 2 ++
1 file changed, 2 insertions(+)
diff
On 03/02/2018 03:58 PM, Dylan Stephano-Shachter wrote:
> That is interesting. Could you possibly run virt-manager with --debug and
> send me any stacktraces you see?
[Please don't top post on technical lists.]
>
> On Mar 2, 2018 7:55 AM, "Michal Privoznik" <m
On 12/11/2017 07:00 PM, Anthony Serna wrote:
> Patch attached.
>
> Just a small thing I noticed when spinning up an LXC container.
Hey,
welcome to the list. Just a couple of hints for your patch:
>
>
> 0001-strings-fix-typo.patch
a) We usually send patches directly, not as attachments. You
or directory
#include "virt-viewer-enums.h"
^
compilation terminated.
The fix is to include builddir into paths where header files are
looked for.
Signed-off-by: Michal Privoznik <mpriv...@redhat.com>
---
tests/Makefile.am | 1 +
1 file changed, 1 in
Just fixes for some of the problems I ran into lately.
Michal Privoznik (2):
virt-viewer-display-vnc: Include virt-viewer-util.h
tests: Fix VPATH build
src/virt-viewer-display-vnc.c | 1 +
tests/Makefile.am | 1 +
2 files changed, 2 insertions(+)
--
2.8.3
ng: nested extern declaration of
'virt_viewer_signal_connect_object' [-Wnested-externs]
Signed-off-by: Michal Privoznik <mpriv...@redhat.com>
---
src/virt-viewer-display-vnc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/virt-viewer-display-vnc.c b/src/virt-viewer-display-vnc.c
index
On 02.02.2016 17:16, Matwey V. Kornilov wrote:
> 2016-02-01 16:19 GMT+03:00 Michal Privoznik <mpriv...@redhat.com>:
>> On 30.01.2016 17:10, Matwey V. Kornilov wrote:
>>> Hello,
>>>
>>> Is it possible to configure virt-manager to show guest IP somewhere?
On 30.01.2016 17:10, Matwey V. Kornilov wrote:
> Hello,
>
> Is it possible to configure virt-manager to show guest IP somewhere?
>
> I am running qemu with qemu-guest tools and the following command works
> good:
>
> virsh # qemu-agent-command 5 '{"execute":"guest-network-get-interfaces"}'
>
In libvirt commit 36785c7e775f3 the input devices are no longer
added by default in XML parsing phase rather than on domain
startup. However, we are not starting a domain just merely
playing around with its definition. Therefore we should adjust
expected outputs.
Signed-off-by: Michal Privoznik
On 15.01.2016 17:48, Cole Robinson wrote:
> On 01/15/2016 02:27 AM, Michal Privoznik wrote:
>> Finally, I've managed to find time to fix the tests.
>>
>
> Are you running these locally, or did the test failures come from CI
> somewhere? I know there was libvirt CI a
Finally, I've managed to find time to fix the tests.
Michal Privoznik (3):
tests: Update virt-install-many-devices.xml
virt-convert: Don't detect existing paths in test suite
virtconvtest: Fix vmx2libvirt test
tests/cli-test-xml/compare/virt-install-many-devices.xml | 4
Libvirt started to put type='raw' to element to disks
when no type has been provided. We should reflect that change in
our tests too.
Signed-off-by: Michal Privoznik <mpriv...@redhat.com>
---
tests/cli-test-xml/compare/virt-install-many-devices.xml | 4 ++--
1 file changed, 2 insertions
on other hosts.
Signed-off-by: Michal Privoznik <mpriv...@redhat.com>
---
tests/virtconv-files/libvirt_output/vmx2libvirt_test-vmx-zip.libvirt | 2 +-
tests/virtconvtest.py| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
a
ran under test suite.
Signed-off-by: Michal Privoznik <mpriv...@redhat.com>
---
virtconv/formats.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/virtconv/formats.py b/virtconv/formats.py
index ed8a66e..a7f88cb 100644
--- a/virtconv/formats.py
+++ b/virtconv/
On 11.12.2014 03:27, Chun Yan Liu wrote:
On 12/5/2014 at 09:54 PM, in message 5481b907.4040...@redhat.com, Cole
Robinson crobi...@redhat.com wrote:
On 12/05/2014 03:40 AM, Chunyan Liu wrote:
snip/
+# Refresh pools before poll_helper. For those
+# 'active' but target path
On 21.09.2014 16:58, Laszlo Ersek wrote:
Hi Cole and Michal,
I'm attaching three patches:
snip/
(2) Unfortunately, even libvirtd needs to be modified, in addition.
My patch for (1) *does* pass VIR_DOMAIN_UNDEFINE_NVRAM to libvirtd (I
verified that with gdb), but libvirtd doesn't act upon
On 16.09.2014 13:17, Laszlo Ersek wrote:
On 09/15/14 23:10, Cole Robinson wrote:
On 09/11/2014 12:56 PM, Giuseppe Scrivano wrote:
Signed-off-by: Giuseppe Scrivano gscri...@redhat.com
---
ui/create.ui | 325 +++---
virtManager/create.py |
On 07.04.2014 17:43, Michal Privoznik wrote:
On 07.04.2014 17:12, Cole Robinson wrote:
On 04/04/2014 02:43 PM, Roman Bogorodskiy wrote:
Allow connection to bhyve using bhyve:///system URI.
---
virtManager/connect.py | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
On 26.01.2014 19:24, Cole Robinson wrote:
I've just pushed a new tool to virt-manager.git called virt-xml. virt-xml uses
virt-install's command line options to allow building and editing domain XML.
Best way to describe what it can do is with a bunch of examples:
See a list of all suboptions
On 29.08.2013 08:02, Martin Kletzander wrote:
On 08/29/2013 12:07 AM, Vadim Bartko wrote:
hi,
I am trying to run Virt Manager and every time during VM creation i get
these two errors:
1. (for kvm):
libvirtError: Unable to read from monitor: Connection reset by peer
2. (for qemu):
On 21.02.2013 06:27, Chen Hanxiao wrote:
From: Chen Hanxiao chenhanx...@cn.fujitsu.com
As discussed in:
https://www.redhat.com/archives/virt-tools-list/2013-February/msg00154.html
There is a bug when creating disk image as qcow2, enable
fully allocating but get the minimal sparse image.
On 19.02.2013 13:19, Peter Velas wrote:
Hello guys,
My environment
Fedora 18 with kernel 3.7.8-202.fc18.x86_64
Virtual Machine Manager 0.9.4
when creating New Storage Volume in virt-manager
newVM.img with qcow2 format for example with following settings:
Max Capacity: 10240 MB
On 13.02.2013 16:05, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Rather than trying to manually keep track of authors,
just auto-generate the list from GIT logs
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
AUTHORS | 77
On 04.02.2013 14:51, Marc-André Lureau wrote:
a classic by now, ack
- Mensaje original -
Just one thing needs to be changed for virt-viewer to build with
automake 1.13, AM_CONFIG_HEADER is deprecated and should be
AC_CONFIG_HEADERS.
---
configure.ac | 2 +-
1 file changed, 1
If the _FORTIFY_SOURCE has been already defined, we unconditionally
redefine it, leaving us with warning/error thrown at compilation time.
---
acinclude.m4 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/acinclude.m4 b/acinclude.m4
index 0c308bc..625413f 100644
---
The g_message() and g_warning functions expect printf style of
arguments. That is, whenever we want to print a string, it has
to be preceded with %s format.
---
src/remote-viewer.c| 2 +-
src/virt-viewer-auth.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
If the _FORTIFY_SOURCE has been already defined, we unconditionally
redefine it, leaving us with warning/error thrown at compilation time.
---
acinclude.m4 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/acinclude.m4 b/acinclude.m4
index 0c308bc..625413f 100644
---
---
configure.ac | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/configure.ac b/configure.ac
index 28c7bd3..30c2042 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,5 +1,5 @@
-AC_INIT(virt-viewer, 0.5.4)
+AC_INIT([virt-viewer],[0.5.4])
On 04.02.2013 15:45, Christophe Fergeau wrote:
ACK to the 3 patches in this series.
Christophe
On Mon, Feb 04, 2013 at 03:30:43PM +0100, Michal Privoznik wrote:
If the _FORTIFY_SOURCE has been already defined, we unconditionally
redefine it, leaving us with warning/error thrown
On 07.12.2012 09:30, Christophe Fergeau wrote:
This is a follow-up to my previous series fixing leaks as a similar
one was just introduced.
---
osinfo/osinfo_loader.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/osinfo/osinfo_loader.c b/osinfo/osinfo_loader.c
On 07.12.2012 09:46, Christophe Fergeau wrote:
libosinfo.syms contains the osinfo_install_config_param_new symbol
twice. Reorder the LIBOSINFO_0.2.0 section to make this obvious,
and remove the duplicated symbol.
---
osinfo/libosinfo.syms | 5 ++---
1 file changed, 2 insertions(+), 3
On 07.12.2012 09:46, Christophe Fergeau wrote:
Fabiano made significant work in the installer code, this commit
adds his copyright to the files where he is listed in the 'Authors'
section, this makes things clearer.
---
osinfo/osinfo_avatar_format.c| 1 +
On 07.12.2012 09:46, Christophe Fergeau wrote:
---
osinfo/osinfo_install_script.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/osinfo/osinfo_install_script.c b/osinfo/osinfo_install_script.c
index b891aaf..c752434 100644
--- a/osinfo/osinfo_install_script.c
+++
On 07.12.2012 09:46, Christophe Fergeau wrote:
Some newly added tags were missing from the description
---
osinfo/osinfo_loader.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/osinfo/osinfo_loader.c b/osinfo/osinfo_loader.c
index 62b92f9..5d92df4 100644
---
On 07.12.2012 09:46, Christophe Fergeau wrote:
A few static methods were prefixed with osinfo_os_ instead of
osinfo_install_script_
---
osinfo/osinfo_install_script.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/osinfo/osinfo_install_script.c
Each public visible struct and enum must have documented
items. If it hasn't, gtk-doc produces a lot of warnings.
However, things it's complaining about doesn't have any
interesting attributes, so mark them as private.
---
osinfo/osinfo_avatar_format.h|1 +
osinfo/osinfo_db.h
On 07.12.2012 13:16, Christophe Fergeau wrote:
osinfo_loader_install_config_params.h defines
OSINFO_INSTALL_CONFIG_PARAMS_* constants, better to use these
rather than string literals.
---
osinfo/osinfo_loader.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
When generating documentation I've noticed couple of warnings produced
by gtk-doc like missing field description or incorrect format of enum
items description and so on.
Michal Privoznik (4):
Suppress gtk-doc warnings on missing field description
osinfo_install_config.c: Describe function
---
osinfo/osinfo_install_config_param.h |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/osinfo/osinfo_install_config_param.h
b/osinfo/osinfo_install_config_param.h
index dfed04e..fae6cc4 100644
--- a/osinfo/osinfo_install_config_param.h
+++
These files were still missing function arguments description:
* osinfo/osinfo_install_script.c
* osinfo/osinfo_os.c
---
osinfo/osinfo_install_script.c | 14 ++
osinfo/osinfo_os.c |1 +
2 files changed, 15 insertions(+), 0 deletions(-)
diff --git
On 06.12.2012 10:54, Christophe Fergeau wrote:
---
osinfo/osinfo_loader.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/osinfo/osinfo_loader.c b/osinfo/osinfo_loader.c
index bb7949e..b392a43 100644
--- a/osinfo/osinfo_loader.c
+++ b/osinfo/osinfo_loader.c
@@ -982,6 +982,7 @@ static
On 05.12.2012 15:02, Zeeshan Ali (Khattak) wrote:
These patches add means for apps to find and fetch device drivers and to tell
installer about where to find pre- and post-installation device drivers.
Also included is the first implementation: virtio storage device drivers for
Windows XP and
On 06.12.2012 16:47, Martin Kletzander wrote:
I added the generation of manpages to the build stage and removed the
manpages that are now being generated there.
Martin Kletzander (2):
setup: rebuild manpages in build phase
Remove and ignore build-generated files
.gitignore
On 04.12.2012 23:23, Doug Goldstein wrote:
The .desktop file did not comply with the Desktop Entry spec as checked
with desktop-file-validate. Boolean keys are defined as taking only
'true' or 'false', the entry Terminal had False. MimeType is a string
list and therefore must be terminated
SpiceSession has 'ca' property which is type of GByteArray*.
However, when we read the property from file, we read it as
string. For conversion g_byte_array_new_take() is used which
takes given pointer as guint8* so we need to do the cast.
---
src/virt-viewer-session-spice.c |2 +-
1 files
make syntax-check is producing some errors about empty line at EOF
and missing #include config.h in src/windows-cmdline-wrapper.c
* cfg.mk: add a syntax-rule exception
* data/virt-viewer-debug.nsis.in: remove empty line at EOF
---
cfg.mk |4 ++--
make syntax-check is producing some errors about empty line at EOF
and missing #include config.h in src/windows-cmdline-wrapper.c
* cfg.mk: add a syntax-rule exception
* data/virt-viewer-debug.nsis.in: remove empty line at EOF
---
cfg.mk |4 ++--
On 05.12.2012 15:13, Michal Privoznik wrote:
make syntax-check is producing some errors about empty line at EOF
and missing #include config.h in src/windows-cmdline-wrapper.c
* cfg.mk: add a syntax-rule exception
* data/virt-viewer-debug.nsis.in: remove empty line at EOF
---
cfg.mk
make syntax-check is producing some errors about empty line at EOF
and missing #include config.h in src/virt-viewer-file.c
* src/virt-viewer-file.c: add #include config.h
* data/virt-viewer-debug.nsis.in: remove empty line at EOF
---
data/virt-viewer-debug.nsis.in |1 -
On 05.12.2012 17:17, Marc-André Lureau wrote:
ack
Thanks, I've pushed the whole patchset.
Michal
- Mensaje original -
make syntax-check is producing some errors about empty line at EOF
and missing #include config.h in src/virt-viewer-file.c
* src/virt-viewer-file.c: add #include
On 21.11.2012 17:32, Martin Kletzander wrote:
On 11/14/2012 10:58 AM, Michal Privoznik wrote:
With current implementation, all binaries that need it call
bindtextdomain but not directly. They call a helper function
instead. This makes, however, syntax-check fail as it cannot
recognize
On 14.11.2012 03:40, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Document the format of the string returned by this function.
---
osinfo/osinfo_install_script.c | 23 +++
1 file changed, 23 insertions(+)
diff --git
On 14.11.2012 03:40, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
osinfo/osinfo_entity.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/osinfo/osinfo_entity.c b/osinfo/osinfo_entity.c
index 9fabc46..348981e 100644
--- a/osinfo/osinfo_entity.c
On 14.11.2012 03:40, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
data/install-scripts/fedora.xml | 84
+--
data/install-scripts/windows-cmd.xml | 14 +-
data/install-scripts/windows-unattend.xml | 32
On 14.11.2012 03:40, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Instead of hardcoding avatar path and disk, lets get those from
application.
---
data/install-scripts/fedora.xml | 26 +---
data/install-scripts/windows-cmd.xml | 4 ++-
On 14.11.2012 03:40, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
data/install-scripts/windows-cmd.xml | 14 +-
data/install-scripts/windows-sif.xml | 2 +-
osinfo/libosinfo.syms| 3 +++
osinfo/osinfo_install_config.c
On 14.11.2012 16:30, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
'filename' should be toplevel node under 'install-script' rather than
an attribute of its toplevel 'template' child. The reason this was
previously put in the incorrect place was that the first
On 14.11.2012 03:40, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Remove private structure and finalize implementation. This should have
been part of commit ee9e797.
---
osinfo/osinfo_install_config_param.c | 29 -
1 file
On 14.11.2012 16:30, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
test/test-xml-validate | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/test-xml-validate b/test/test-xml-validate
index e5be325..8f16f1c 100755
---
On 14.11.2012 16:30, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
* Expect 'install-script' node at toplevel in XML
* Interleave all child nodes of 'install-script' node
* Remove duplicate entries for 'id' nodes
* 'config' node has 'param' nodes under it and
On 13.11.2012 13:06, Christophe Fergeau wrote:
It makes sense for the screenshots to be saved in ~/Images,
especially as otherwise the filechooser will display
'recent documents' to which we cannot save. This commit also sets
the default screenshot name to 'Screenshot'.
---
With current implementation, all binaries that need it call
bindtextdomain but not directly. They call a helper function
instead. This makes, however, syntax-check fail as it cannot
recognize it.
Original patch proposed by Eric Blake ebl...@redhat.com
---
cfg.mk |4 ++--
1 files changed, 2
One of previous commits (74b1b62510d939) allowed us to connect to
localhost directly if ssh transport was used. However, if there's
not transport, we SIGSEGV'ed as g_str_equal doesn't like NULL as
one of arguments. Change this to g_strcmp0 which does the same
service but is more friendly to NULL
a559205..69718a7 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -23,6 +23,7 @@ With additional patches from:
Yann E. MORIN yann.morin.1...@anciens.enib.fr
Yonit Halperin yhalp...@redhat.com
Zeeshan Ali (Khattak) zeesha...@gnome.org
+Michal Privoznik mpriv...@redhat.com
...send patches
On 13.11.2012 11:42, Christophe Fergeau wrote:
The check that at least one of spice-gtk and gtk-vnc is present
uses a wrong variable name to check for spice-gtk presence, which
causes the check to think it's never present. This would make
gtk-vnc presence mandatory. This commit fixes the name
In order to make syntax-check pass.
These patches should be applied on the top of
https://www.redhat.com/archives/virt-tools-list/2012-November/msg00075.html
otherwise AUTHORS would need update (add /me).
Michal Privoznik (3):
cfg.mk: Don't require bindtextdomain directly
AUTHORS: add
With current implementation, all binaries that need it call
bindtextdomain but not directly. They call a helper function
instead. This makes, however, syntax-check fail as it cannot
recognize it.
---
cfg.mk |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/cfg.mk
On 13.11.2012 12:30, Christophe Fergeau wrote:
On Tue, Nov 13, 2012 at 11:57:31AM +0100, Michal Privoznik wrote:
Currently, if user wants to reconnect to a domain he can use
'-r' cmd line argument. This makes virt-viewer listen to
domain events. However, if connection to libvirtd breaks
On 12.11.2012 10:57, Christophe Fergeau wrote:
On Thu, Nov 08, 2012 at 05:13:09PM +0100, Michal Privoznik wrote:
Currently, if user wants to reconnect to a domain he can use
'-r' cmd line argument. This makes virt-viewer listen to
domain events. However, if connection to libvirtd breaks
On 08.11.2012 18:24, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
This commit adds the generation of osinfo_enum_types.[ch] using
glib-mkenums. These files will register the various enums that will get
added to osinfo header files with glib.
Commit message
On 08.11.2012 18:24, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Without entity params usage, there is no real benefit of deriving from
Entity class so this was very much intended from start.
This change also corrects the gobject property for 'policy':
Currently, if user wants to reconnect to a domain he can use
'-r' cmd line argument. This makes virt-viewer listen to
domain events. However, if connection to libvirtd breaks
somehow, we will receive no longer any event. Hence we must
reconnect to the libvirt.
---
configure.ac |2 +-
On 06.11.2012 15:56, Dave Allan wrote:
I'm having trouble with virt-viewer not connecting to a VM on a remote
host over SSH. It connects, briefly gives me a black VM display, and
then says that the remote disconnected. I've noticed a few paches on
review that seem to reference misbehavior
On 30.10.2012 03:50, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Make some strings more translator-friendly at the same time.
---
osinfo/osinfo_deployment.c | 5 ++-
osinfo/osinfo_devicelink.c | 3 +-
osinfo/osinfo_devicelinkfilter.c
On 30.10.2012 03:50, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Make some strings more translator-friendly at the same time.
---
osinfo/osinfo_deployment.c | 5 ++-
osinfo/osinfo_devicelink.c | 3 +-
osinfo/osinfo_devicelinkfilter.c
One of previous patches (96ce9ac0b125) invented this feature. However,
in options object it is called testfirstrun not test_first_run.
This produces a runtime error.
---
src/virt-manager.py.in |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/virt-manager.py.in
On 30.10.2012 13:50, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
This is meant for including headers needed by many .c files.
---
osinfo/Makefile.am | 1 +
osinfo/osinfo_db.c | 4 +---
osinfo/osinfo_deployment.c
On 30.10.2012 14:52, Zeeshan Ali (Khattak) wrote:
On Tue, Oct 30, 2012 at 3:42 PM, Michal Privoznik mpriv...@redhat.com wrote:
On 30.10.2012 13:50, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
This is meant for including headers needed by many .c files
On 29.10.2012 15:43, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Mark 'name' and 'vendor' in oses and hypervisor, and 'name' in devices
for translation.
This implies that now we generate the actual XML files to automatically
get translations inserted into
On 29.10.2012 15:43, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Note that we are calling bindtextdomain() from Loader's class init.
AFAICT, its a common practice in libraries without any main _init()
function to make this call in init of the most
On 29.10.2012 15:43, Zeeshan Ali (Khattak) wrote:
From: Eric Blake ebl...@redhat.com
AUTHORS: Add myself.
---
AUTHORS | 1 +
maint.mk | 402
++-
2 files changed, 273 insertions(+), 130 deletions(-)
ACK
Michal
gaowanl...@cn.fujitsu.com
Michal Privoznik mpriv...@redhat.com
+ David Zeuthen dav...@redhat.com
...send patches to get your name here...
-- End
--
1.7.8.6
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com
On 19.10.2012 05:49, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
data/oses/centos.xml.in | 12 +--
data/oses/debian.xml.in | 72 +++---
data/oses/dos.xml.in | 6 +-
data/oses/fedora.xml.in | 108 ++---
On 19.10.2012 05:49, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
data/devices/Makefile.am | 14 +-
data/devices/qemu-pci.xml| 152 -
data/devices/qemu-pci.xml.in | 152 +
data/devices/qemu-ps2.xml| 20 -
On 19.10.2012 15:24, Zeeshan Ali (Khattak) wrote:
On Fri, Oct 19, 2012 at 4:19 PM, Zeeshan Ali (Khattak)
zeesha...@gnome.org wrote:
On Fri, Oct 19, 2012 at 1:15 PM, Christophe Fergeau cferg...@redhat.com
wrote:
On Fri, Oct 19, 2012 at 11:56:37AM +0200, Michal Privoznik wrote:
Or, are you
On 11.10.2012 18:59, Guido Günther wrote:
like in the other modules
---
virtinst/DistroInstaller.py | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/virtinst/DistroInstaller.py b/virtinst/DistroInstaller.py
index e559431..33efc31 100644
---
1 - 100 of 122 matches
Mail list logo
