Re: [virt-tools-list] [virt-manager PATCH 0/5] WIP: Various TPM improvements

2018-05-24 Thread Stefan Berger
On 05/24/2018 06:39 AM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Hi, The following series depend on the patches being reviewed for libvirt "[PATCH 00/12] Add support for TPM emulator" (currently at v6). They allow to configure a CRB device (more TPM 2.0 compliant), and to se

Re: [virt-tools-list] [virt-manager PATCH 0/5] WIP: Various TPM improvements

2018-05-24 Thread Stefan Berger
On 05/24/2018 12:34 PM, Marc-André Lureau wrote: Hi On Thu, May 24, 2018 at 6:01 PM, Stefan Berger wrote: On 05/24/2018 06:39 AM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Hi, The following series depend on the patches being reviewed for libvirt "[PATCH 00/12] Add su

Re: [virt-tools-list] [virt-manager PATCH 0/5] WIP: Various TPM improvements

2018-05-30 Thread Stefan Berger
On 05/24/2018 12:34 PM, Marc-André Lureau wrote: Hi On Thu, May 24, 2018 at 6:01 PM, Stefan Berger wrote: On 05/24/2018 06:39 AM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Hi, The following series depend on the patches being reviewed for libvirt "[PATCH 00/12] Add su

[virt-tools-list] [PATCH v2 1/6] addhardware: learn to choose a TPM model

2018-06-08 Thread Stefan Berger
From: Marc-André Lureau There is only one for now, but we are adding CRB next (and SPAPR is being added too in qemu/libvirt). Signed-off-by: Marc-André Lureau --- ui/addhardware.ui | 42 +- virtManager/addhardware.py | 6 ++ virtinst/device

[virt-tools-list] [PATCH v2 5/6] details: show TPM version

2018-06-08 Thread Stefan Berger
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/details.ui | 24 virtManager/details.py | 3 +++ 2 files changed, 27 insertions(+) diff --git a/ui/details.ui b/ui/details.ui index 2e7b253b..efc2748f 100644 --- a/ui/details.ui +++ b/ui/details.

[virt-tools-list] [PATCH v2 6/6] details: show TPM device model and allow updating it

2018-06-08 Thread Stefan Berger
Show the TPM device model and allow updating it. If a TPM 1.2 has been chosen, we only allow the TIS interface to be selected. In case of a TPM 2.0 we also enable the choice of the CRB interface. Signed-off-by: Stefan Berger --- ui/details.ui | 33

[virt-tools-list] [PATCH v2 3/6] tpm: add TPM emulator backend

2018-06-08 Thread Stefan Berger
From: Marc-André Lureau An emulated backend doesn't require any path, since libvirt will take care of finding the emulator and managing the storage. However, the version to emulate can be specified. Signed-off-by: Marc-André Lureau --- .../compare/virt-install-singleton-config-2.xml| 6 ++

[virt-tools-list] [PATCH v2 2/6] tpm: add CRB device model

2018-06-08 Thread Stefan Berger
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- tests/cli-test-xml/compare/virt-install-singleton-config-2.xml | 10 ++ tests/clitest.py | 1 + tests/xmlparse-xml/change-tpm-out.xml | 2 +- tests/xmlpa

[virt-tools-list] [PATCH v2 4/6] addhardware: learn to set emulated TPM version

2018-06-08 Thread Stefan Berger
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/addhardware.ui | 24 virtManager/addhardware.py | 20 +--- 2 files changed, 41 insertions(+), 3 deletions(-) diff --git a/ui/addhardware.ui b/ui/addhardware.ui index b4cc35ea..4c26

[virt-tools-list] [PATCH v2 0/6] Various TPM improvements

2018-06-08 Thread Stefan Berger
t; since it's a TPM 2.0 Marc-André Lureau (5): addhardware: learn to choose a TPM model tpm: add CRB device model tpm: add TPM emulator backend addhardware: learn to set emulated TPM version details: show TPM version Stefan Berger (1): details: show TPM device model and allow up

Re: [virt-tools-list] [PATCH v2 6/6] details: show TPM device model and allow updating it

2018-06-11 Thread Stefan Berger
On 06/11/2018 11:54 AM, Cole Robinson wrote: On 06/08/2018 05:42 PM, Stefan Berger wrote: Show the TPM device model and allow updating it. If a TPM 1.2 has been chosen, we only allow the TIS interface to be selected. In case of a TPM 2.0 we also enable the choice of the CRB interface. Patches

[virt-tools-list] [PATCH] tpm: allow hotplug operation so error is reported by libvirt

2018-06-12 Thread Stefan Berger
Perform a hotplug operation so that we get the error notification about unsupported TPM hotplug operation and we can alert the user that the change will only take effect upon domain shutdown. Signed-off-by: Stefan Berger --- virtManager/domain.py | 5 - 1 file changed, 4 insertions(+), 1

[virt-tools-list] [virt-manager PATCH 0/3] Add support for TPM passthrough

2013-06-24 Thread Stefan Berger
backend into QEMU. Since only one device model (tpm-tis) is supported and we do not currently have plans to implemented for example a virtio model, I did not provide the choice for the device model. Regards, Stefan Stefan Berger (3): Add TPM passthrough support to virtinst Add GUI elements

[virt-tools-list] [virt-manager PATCH 2/3] Add GUI elements for TPM passthrough

2013-06-24 Thread Stefan Berger
Signed-off-by: Stefan Berger --- ui/vmm-add-hardware.ui | 143 + ui/vmm-details.ui | 107 2 files changed, 250 insertions(+) diff --git a/ui/vmm-add-hardware.ui b/ui/vmm-add-hardware.ui index f079ea4

[virt-tools-list] [virt-manager PATCH 3/3] Add logic for GUI support for TPM passthrough

2013-06-24 Thread Stefan Berger
Add the code woking 'behind' the GUI. Signed-off-by: Stefan Berger --- virtManager/addhardware.py | 69 +- virtManager/details.py | 59 +-- virtManager/domain.py | 10 +++ virtManager/ui

[virt-tools-list] [virt-manager PATCH 1/3] Add TPM passthrough support to virtinst

2013-06-24 Thread Stefan Berger
Signed-off-by: Stefan Berger --- virtinst/Guest.py| 1 + virtinst/VirtualDevice.py| 4 +- virtinst/VirtualTPMDevice.py | 138 +++ virtinst/__init__.py | 1 + virtinst/cli.py | 25 5 files changed, 168

[virt-tools-list] [virt-manager PATCH v2 4/4] Add GUI elements for adding a TPM device to a guest

2013-06-25 Thread Stefan Berger
Signed-off-by: Stefan Berger --- ui/vmm-add-hardware.ui | 123 + virtManager/addhardware.py | 70 +- virtManager/uihelpers.py | 30 +++ 3 files changed, 222 insertions(+), 1 deletion(-) diff --git a/ui/vmm-add

[virt-tools-list] [virt-manager PATCH v2 3/4] Add GUI elements for TPM passthrough details

2013-06-25 Thread Stefan Berger
Signed-off-by: Stefan Berger --- tests/testdriver.xml | 24 ++ ui/vmm-details.ui | 120 + virtManager/details.py | 57 +-- virtManager/domain.py | 10 + 4 files changed, 208 insertions(+), 3 deletions

[virt-tools-list] [virt-manager PATCH v2 2/4] Add CLI support and CLI test cases

2013-06-25 Thread Stefan Berger
Signed-off-by: Stefan Berger --- man/virt-install.pod| 28 +++ tests/cli-test-xml/compare/many-devices.xml | 10 +++ tests/clitest.py| 11 +++- virt-install| 1 + virtinst/cli.py

[virt-tools-list] [virt-manager PATCH v2 0/4] Add support for TPM passthrough

2013-06-25 Thread Stefan Berger
QEMU. Since only one device model (tpm-tis) is supported and we do not currently have plans to implemented for example a virtio model, I did not provide the choice for the device model. Changes: v1->v2: Followed Cole's suggestions Regards, Stefan Stefan Berger (4): Add VirtualTPMDevi

[virt-tools-list] [virt-manager PATCH v2 1/4] Add VirtualTPMDevice class to virtinst

2013-06-25 Thread Stefan Berger
Add VirtualTPMDevice class and TPM test cases to xmlparse.py Signed-off-by: Stefan Berger --- tests/xmlparse-xml/change-tpm-in.xml | 63 tests/xmlparse-xml/change-tpm-out.xml | 63 tests/xmlparse.py | 13 virtinst/Guest.py

Re: [virt-tools-list] [virt-manager PATCH v2 0/4] Add support for TPM passthrough

2013-06-27 Thread Stefan Berger
On 06/26/2013 07:48 PM, Cole Robinson wrote: On 06/25/2013 09:45 PM, Stefan Berger wrote: Add support for the QEMU TPM passthrough device that is supported by libvirt: http://libvirt.org/formatdomain.html#elementsTpm I added the choice of the backend device even though only one backend type