Re: Virt-Viewer libspice-client-glib dependency

Hi, On Thu, Feb 17, 2022 at 01:09:18PM +0530, Sai Kiran Kumar Reddy wrote: > Hi, > > I am Sai Kiran. I am trying to build virt-viewer-11.0, on my LInux From > Scratch(LFS) machine. I have installed all the dependencies of virt-viewer. > I have built the virt-viewer, with spice enabled. When I

Re: Installing Gstreamer for SPICE

On Tue, Feb 15, 2022 at 04:07:50PM +0530, Sai Kiran Kumar Reddy wrote: > Hi, > > I am Sai Kiran. I am trying to install virt-viewer on my Linux > From Scratch(LFS) machine. I see that one of the dependencies > is Gstreamer. I have built and installed Gstreamer. When I > compile spice-gtk, I get

Re: Fedora 34 guests can no longer paste from host

Hi, There is nothing obvious to pinpoint here. I can see that spice-vdagent in Fedora is not using the gtk backend [0] but it is hard to tell what is happening so far. What version of spice-gtk you have? [0]

Re: Fedora 34 guests can no longer paste from host

On Wed, Apr 14, 2021 at 12:26 PM Germano Massullo wrote: > > I always used with success a Fedora 33 KDE host > (qemu/kvm/libvirt+virt-manager) and a F33 KDE guest, and I have always been > to copy paste from host to guest and viceversa > > Now I tested two Fedora 34 Beta guests: > - KDE spin >

Re: [PATCH] virtManager: Folder sharing implementation for SPICE session

On Thu, Aug 13, 2020 at 10:34:52AM +0800, dianlujitao wrote: > Thanks for reviewing. > > I agree that it's a big mess to maintain its availability, do > you have connections with the SPICE team so there's chance to > work together to improve the protocol? Essentially virt-viewer > suffers from

Re: Connection issues with virt-viewer 9.0 (win)

Hi, On Wed, May 20, 2020 at 12:19:59PM -0500, fletch b wrote: > Hi, > I just upgraded to virt-viever-9.0(win) and ran into issues I > never saw with ver 7,0 > > When trying to connect to my vm I would get to the point where > I would see this: > > "connected to graphic server" and nothing after

Re: [virt-tools-list] [PATCH] remote-viewer: add a default extension to screenshot filenames

ple? No, most likely I'm overcomplicating it. It is fine to fix the filename before checking the formats and error out if a bad format is given indeed. Merged: https://pagure.io/virt-viewer/c/e4bacb8fde16cd21b8b8f095be720ad1a6c2d0e5?branch=master Cheers, > > > Regards, > &

Re: [virt-tools-list] [PATCH] remote-viewer: add a default extension to screenshot filenames

Hi, On Fri, Jan 24, 2020 at 09:51:03AM +0100, Julien ROPE wrote: > Hi, > > Thanks for reviewing :) > > Le 21/01/2020 à 13:55, Victor Toso a écrit : > > Hi, > > > > On Fri, Dec 13, 2019 at 11:16:23AM +0100, Julien Ropé wrote: > >> From: Julien ROPE >

Re: [virt-tools-list] [PATCH] remote-viewer: add a default extension to screenshot filenames

Hi, On Fri, Dec 13, 2019 at 11:16:23AM +0100, Julien Ropé wrote: > From: Julien ROPE > > When doing a screenshot, if the user provides a filename without a file > extension, an error occurs because the image format could not be determined. > This patch adds a .png extension to such filenames,

Re: [virt-tools-list] [PATCH virt-viewer v2] remote-viewer: Prefer ca-cert from display instead of proxy

m the XML > gets precedence over the one from the command line, which is still kept > to keep compatibility of older versions of oVirt. > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1402909 > > Signed-off-by: Eduardo Lima (Etrunko) Much nicer! Many thanks for that,

Re: [virt-tools-list] [PATCH virt-viewer] remote-viewer: Prefer ca-cert from display instead of proxy

Hi, On Thu, Oct 03, 2019 at 03:40:29PM -0300, Eduardo Lima (Etrunko) wrote: > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1402909 > > Signed-off-by: Eduardo Lima (Etrunko) Could you please clarify a bit why display's ca-cert is preferred over the one in the proxy object? Based on

[virt-tools-list] [PATCH v4] remote-viewer: fix free on dangling pointer

From: Victor Toso On remote_viewer_session_connected() we are passing a dup of URI of connection and freeing it afterwards. Problem is, we don't disconnect from listening "session-connected" and on an eventual second emission of this signal, remote-viewer crashes as seen in the backt

Re: [virt-tools-list] [PATCH v2] remote-viewer: fix free on dangling pointer

Hi, On Tue, Oct 01, 2019 at 11:17:22AM -0300, Eduardo Lima (Etrunko) wrote: > On 10/1/19 7:09 AM, Victor Toso wrote: > > > Patch builds now, but I started getting some warning when > > > connecting to ovirt:// uri. > > > > > > (remote-viewer:16940)

Re: [virt-tools-list] [PATCH v2] remote-viewer: fix free on dangling pointer

Hi, On Mon, Sep 30, 2019 at 11:01:42AM -0300, Eduardo Lima (Etrunko) wrote: > On 9/30/19 5:08 AM, Victor Toso wrote: > > From: Victor Toso > > > > On remote_viewer_session_connected() we are passing a dup of URI of > > connection and freeing it afterwards. Prob

[virt-tools-list] [PATCH v3] remote-viewer: fix free on dangling pointer

From: Victor Toso On remote_viewer_session_connected() we are passing a dup of URI of connection and freeing it afterwards. Problem is, we don't disconnect from listening "session-connected" and on an eventual second emission of this signal, remote-viewer crashes as seen in the backt

[virt-tools-list] [PATCH v2] remote-viewer: fix free on dangling pointer

From: Victor Toso On remote_viewer_session_connected() we are passing a dup of URI of connection and freeing it afterwards. Problem is, we don't disconnect from listening "session-connected" and on an eventual second emission of this signal, remote-viewer crashes as seen in the backt

Re: [virt-tools-list] [remote-viewer v1] remote-viewer: fix free on dangling pointer

Hi, On Fri, Sep 27, 2019 at 04:21:58PM -0300, Eduardo Lima (Etrunko) wrote: > On 9/27/19 10:35 AM, Victor Toso wrote: > > static gboolean > > -create_ovirt_session(VirtViewerApp *app, const char *uri, GError **err) > > +create_ovirt_session(VirtViewerA

[virt-tools-list] [remote-viewer v1] remote-viewer: fix free on dangling pointer

From: Victor Toso On remote_viewer_session_connected() we are passing a dup of URI of connection and freeing it afterwards. Problem is, we don't disconnect from listening "session-connected" and on an eventual second emission of this signal, remote-viewer crashes as seen in the backt

Re: [virt-tools-list] [PATCH virt-viewer] ovirt-foreign-menu: Plug memory leak

On Thu, Aug 29, 2019 at 02:56:23PM -0300, Eduardo Lima (Etrunko) wrote: > On 8/29/19 12:50 PM, Victor Toso wrote: > > On Wed, Aug 28, 2019 at 06:18:02PM -0300, Eduardo Lima (Etrunko) wrote: > >> Error caught by valgrind, the OvirtCollection object c

Re: [virt-tools-list] [PATCH virt-viewer] ovirt-foreign-menu: Plug memory leak

On Wed, Aug 28, 2019 at 06:18:02PM -0300, Eduardo Lima (Etrunko) wrote: > Error caught by valgrind, the OvirtCollection object created in function > ovirt_foreign_menu_fetch_vm_async() was never freed. > > 433 (40 direct, 393 indirect) bytes in 1 blocks are definitely lost in loss > record

Re: [virt-tools-list] [PATCH virt-viewer] ovirt-foreign-menu: Factor out code to set file collection

Hi, On Mon, Aug 26, 2019 at 09:38:03AM -0300, Eduardo Lima (Etrunko) wrote: > On 8/26/19 4:15 AM, Victor Toso wrote: > > Hi, > > > > On Fri, Aug 23, 2019 at 11:38:05AM -0300, Eduardo Lima (Etrunko) wrote: > >> Signed-off-by: Eduardo Lima (Etrunko) > >>

Re: [virt-tools-list] [PATCH virt-viewer] ovirt-foreign-menu: Factor out code to set file collection

warning. If that's not intended, just return normally. IMHO, no need to send a v2, Acked-by: Victor Toso > + > +if (menu->priv->files) { > +g_object_unref(G_OBJECT(menu->priv->files)); > +} > +menu->priv->files = g_object_ref(G_OBJECT(file_co

Re: [virt-tools-list] [PATCH virt-viewer v2] ovirt-foreign-menu: Only set domain_valid once

lid = storage_domain_validate(menu, domain); > -if (!domain_valid) > +if (!storage_domain_validate(menu, domain)) just note: reverts yours 1c9a9c12050 > continue; > > +if (!domain_valid) > +domain_valid = T

Re: [virt-tools-list] [PATCH virt-viewer] ovirt-foreign-menu: Fix endpoint for storage domains query

bug("Start fetching iso file collection"); Because HAVE_OVIRT_DATA_CENTER depends on the ovirt's API existing or not, maybe it could help adding some prefix like "ovirt-data-center=%s", has_data_center ? "yes" : "no" kind of thing. If y

Re: [virt-tools-list] [PATCH] virt-viewer-file-transfer-dialog: improve error message

s or if I should change the commit log and push (in case you can't push it), imho this one works fine Acked-by: Victor Toso > --- > src/virt-viewer-file-transfer-dialog.c | 26 ++ > 1 file changed, 22 insertions(+), 4 deletions(-) > > diff --git a/sr

Re: [virt-tools-list] virt-viewer with Windows 10

Hi, On Wed, Jul 10, 2019 at 01:35:39PM +0300, Hetz Ben Hamo wrote: > Hi, > > Few days ago I reported here about a problem redirecting USB > devices with virt-viewer to a VM (KVM or oVirt - result is the > same) and I submitted a log. > > I just found out the 7.0 works well (after installing

Re: [virt-tools-list] USB redirection bug with remote viewer

Hi, On Mon, Jul 01, 2019 at 04:08:17PM +0300, Hetz Ben Hamo wrote: > On Mon, Jul 1, 2019 at 1:46 PM Victor Toso wrote: > > > Hi, > > > > On Sun, Jun 30, 2019 at 12:42:05PM +0300, Hetz Ben Hamo wrote: > > > Hi, > > > > > > I'm trying remote v

Re: [virt-tools-list] USB redirection bug with remote viewer

Hi, On Sun, Jun 30, 2019 at 12:42:05PM +0300, Hetz Ben Hamo wrote: > Hi, > > I'm trying remote viewer 8.0 on Windows 10 (1903 and earlier).(desktop > client is Windows, VM is Windows) > > Trying to redirect a USB device gives error, few devices gives different > errors: > > * Trying to connect

Re: [virt-tools-list] [PATCH virt-viewer] configure: Fix check for govirt functions

CFLAGS="$CFLAGS" > SAVED_LIBS="$LIBS" > - CFLAGS="$OVIRT_CFLAGS" > - LIBS="$OVIRT_LIBS" > + CFLAGS="$SAVED_CFLAGS $OVIRT_CFLAGS" > + LIBS="$SAVED_LIBS $OVIRT_LIBS" Acked-b

Re: [virt-tools-list] [PATCH virt-viewer v3 0/3] Add QEMU-like UI: VT console & basic VM state

On Fri, 2019-01-18 at 13:12 +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Hi, > > QEMU provides multiple display backend, with different set of > features. One of the richest UI is the -display gtk. It is quite > minimal, and comparable to remote-viewer UI wrt

Re: [virt-tools-list] [PATCH v2 16/16] spice: hook into QMP port

equires upcoming spice-gtk version 0.36 with SpiceQmpPort > helper. Patch is fine, problem is just doing spice-gtk release and builds. If you push it early on, it will break the build. > Signed-off-by: Marc-André Lureau Acked-by: Victor Toso > --- > configure.ac

Re: [virt-tools-list] [PATCH v2 14/16] app: add "machine" UI

the application quits, it will also send a quit action to the VM. > > This is a similar behaviour/UI as qemu -display gtk. > > Signed-off-by: Marc-André Lureau Acked-by: Victor Toso > --- > src/resources/ui/virt-viewer.ui | 46 ++ > src/virt-v

Re: [virt-tools-list] [PATCH v2 15/16] app: add "vm-running" property

Hi, On Wed, Sep 26, 2018 at 07:26:38PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Add "vm-running" property and modify "menu-vm-pause" check button > state when the running state changes. > > Signed-off-by: Marc-André Lur

Re: [virt-tools-list] [PATCH v2 12/16] app: create a window for VTE displays

> +g_hash_table_insert(self->priv->displays, GINT_TO_POINTER(nth), > g_object_ref(display)); > > -g_signal_connect(display, "notify::show-hint", > - G_CALLBACK(display_show_hint), NULL); > -g_object_noti

Re: [virt-tools-list] [PATCH v2 07/16] session: skip monitor changes if there is no sized monitors

Hi, On Thu, Dec 20, 2018 at 05:25:09PM +0100, Victor Toso wrote: > Hi, > > On Wed, Sep 26, 2018 at 07:26:30PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > spice-gtk discards configurations without any sized monitors. > > &

Re: [virt-tools-list] [PATCH v2 11/16] session: do not take VTE display into account for geometry changes

Hi, On Wed, Sep 26, 2018 at 07:26:34PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > src/virt-viewer-session.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/virt-viewer-session.c

Re: [virt-tools-list] [PATCH v2 10/16] display: allow display without associated monitor number

ot;Nth display", > "Nth display", > - 0, > + -1, I have a feeling that this should be commited before the vte introduction? Acked-by: Victor Toso >

Re: [virt-tools-list] [PATCH v2 09/16] app: append VTE consoles to display submenu

virt_viewer_signal_connect_object(G_OBJECT(item), "toggled", > +G_CALLBACK(menu_display_visible_toggled_cb), display, 0); > +gtk_check_menu_item_set_active(GTK_CHECK_MENU_ITEM(item), > + > gtk_widget_get_visible(GTK_WIDGET(virt_viewer_windo

Re: [virt-tools-list] [PATCH v2 08/16] app: set subtitle using VTE name

e.h" > + > gboolean doDebug = FALSE; > > /* Signal handlers for about dialog */ > @@ -701,15 +703,25 @@ virt_viewer_app_set_window_subtitle(VirtViewerApp *app, > { > gchar *subtitle = NULL; > const gchar *title = virt_viewer_app_get_title(app); > + VirtViewerDisplay *di

Re: [virt-tools-list] [PATCH v2 07/16] session: skip monitor changes if there is no sized monitors

g_hash_table_insert(monitors, GINT_TO_POINTER(nth), rect); > } > > +if (!n_sized_monitors) > + return; > + As non boolean, I'd go with full n_sized_monitors == 0, not sure what is preferred in virt-viewer code base tbh. Either way, Acked-by: Victor Toso

Re: [virt-tools-list] [PATCH v2 06/16] display: ignore display that do not have toplevel window

eing > shown, virt_viewer_session_update_displays_geometry() is called when > the visibility menu item is toggled). But the other displays may not > yet be associated with a window, ignore them. > > Signed-off-by: Marc-André Lureau Acked-by: Victor Toso > --- > src/virt-viewer-display.c | 5 +++-- > 1 file c

Re: [virt-tools-list] [PATCH v2 04/16] Add a VirtViewerDisplayVte display kind

eric "console" object, that could be either graphical or textual. > For now, this does work well enough for me. > > Signed-off-by: Marc-André Lureau Looks fine, Acked-by: Victor Toso > --- > src/Makefile.am | 4 + > src/virt-viewer-display-vte.c | 3

Re: [virt-tools-list] [PATCH v2 05/16] window/zoom: deal with VTE display differently

t to our new widget sizes */ > @@ -1521,7 +1534,10 @@ virt_viewer_window_set_zoom_level(VirtViewerWindow > *self, gint zoom_level) > > virt_viewer_display_set_zoom_level(VIRT_VIEWER_DISPLAY(priv->display), > priv->zoomlevel); Maybe move the virt_viewer_display_set_zoom_level() call too? > -

Re: [virt-tools-list] [PATCH v2 03/16] build-sys: check for VTE library

Hi, On Wed, Sep 26, 2018 at 07:26:26PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau Acked-by: Victor Toso > --- > configure.ac | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/con

Re: [virt-tools-list] [PATCH v2 02/16] window: set sensitivity based on display capability

crash. I chose to keep the UI consistent > for all display, but disable the menu sensitivity. > > Signed-off-by: Marc-André Lureau Acked-by: Victor Toso > --- > src/virt-viewer-display.h | 6 ++ > src/virt-viewer-window.c | 14 ++ > 2 files changed, 16 ins

Re: [virt-tools-list] [PATCH v2 01/16] window: do not reset sensitivity of menu-send in rebuild

_menus_sensitive(). The >default sensitivity is covered by previous .ui patch change. > > Signed-off-by: Marc-André Lureau Acked-by: Victor Toso > --- > src/virt-viewer-window.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/virt-viewer-window.c b/src/vi

Re: [virt-tools-list] [PATCH virt-viewer] Avoid potential memory leak in spice session

On Mon, Dec 03, 2018 at 03:38:30PM -0600, Jonathon Jongsma wrote: > If j == -1, the memory allocated for rect will leak. So move the > allocation after the test. > > Signed-off-by: Jonathon Jongsma Acked-by: Victor Toso > --- > src/virt-viewer-session-spice.c | 2 +- &g

Re: [virt-tools-list] virt-viewer raspberry pi monitor mapping

Hi, On Mon, Oct 22, 2018 at 10:48:06AM -0400, Jarrid Graham wrote: > Hi, > What I am trying to accomplish is using multiple raspberry pi > units , one for each monitor of a multi monitor windows VM. I > have read there is an option to allow more than one spice > connection per VM You mean

Re: [virt-tools-list] [PATCH virt-viewer] Spice: listen for new 'SpiceSession::disconnected' signal

t; destruction. By using the new SpiceSession::disconnected signal instead, > we can ensure that all channels have been disconnected and properly > destroyed before quitting the application. Acked-by: Victor Toso > --- > > NOTE: this is an older patch fell through the cracks. I

Re: [virt-tools-list] [PATCH 22/22] spice: hook into QMP port

Hi, On Tue, Jul 31, 2018 at 03:41:25PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > If the "org.qemu.monitor.qmp.0" port is available: > - enable the VM UI > - get and follow the VM state > - send the requested VM actions > > This adds a json-glib dependency on

Re: [virt-tools-list] [PATCH 06/22] window: do not reset sensitivity of menu-send in rebuild

Hi, On Fri, Aug 31, 2018 at 01:18:31PM +0200, Marc-André Lureau wrote: > Hi > > On Fri, Aug 31, 2018 at 1:14 PM, Marc-André Lureau > wrote: > > Hi > > > > On Fri, Aug 31, 2018 at 8:32 AM, Victor Toso wrote: > >> Hi, > >> > >>

Re: [virt-tools-list] [PATCH 08/22] display: make klass->close() optional

Hi, On Tue, Jul 31, 2018 at 03:41:11PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Spice and VTE display do not need to implement it. > > Signed-off-by: Marc-André Lureau Acked-by: Victor Toso > --- > src/virt-viewer-display-spice.c | 8

Re: [virt-tools-list] [PATCH 08/22] display: make klass->close() optional

Hi, On Tue, Jul 31, 2018 at 03:41:11PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Spice and VTE display do not need to implement it. > > Signed-off-by: Marc-André Lureau Acked-by: Victor Toso > --- > src/virt-viewer-display-spice.c | 8

Re: [virt-tools-list] [PATCH 07/22] window: set sensitivity based on display capability

Hi, On Tue, Jul 31, 2018 at 03:41:10PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau I take this is a preparatory patch for VTE, could you please add some rationale in the commit log on why this was needed? > Signed-off-by: Marc-André Lureau > --- >

Re: [virt-tools-list] [PATCH 06/22] window: do not reset sensitivity of menu-send in rebuild

Hi, On Tue, Jul 31, 2018 at 03:41:09PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > A mere app::enable-accel notification shouldn't modify the > sensitivity, which is handled for all menu items elsewhere, leave the > current state untouched. > > Signed-off-by:

Re: [virt-tools-list] [PATCH 05/22] window: move default sensitivity in .ui

priv->builder, > "menu-view-zoom")), FALSE); > - > gtk_widget_set_sensitive(GTK_WIDGET(gtk_builder_get_object(self->priv->builder, > "menu-file-screenshot")), FALSE); > - > gtk_widget_set_sensitive(GTK_WIDGET(gtk_builder_get_object(self->p

Re: [virt-tools-list] [PATCH 04/22] window: use virt_viewer_window_set_menus_sensitive()

t there too. > > Signed-off-by: Marc-André Lureau Acked-by: Victor Toso > --- > src/virt-viewer-window.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c > index af3441f..4b48e31 100644 >

Re: [virt-tools-list] [PATCH 03/22] app: simplify toggling visibility

ng" hack, only maintaining "active" on the last item. Out of curiosity, why we quit when disabling the last display instead of not allowing the last display to be toggled? I would say that might happen by mistake (disabling last display) instead of intentional desire to quit

Re: [virt-tools-list] [PATCH 02/22] Remove class signal handlers

-André Lureau Looks fine, Acked-by: Victor Toso > --- > src/virt-viewer-display.c | 10 +- > src/virt-viewer-display.h | 8 > src/virt-viewer-session.c | 26 +- > src/virt-viewer-session.h | 19 --- > 4 files

Re: [virt-tools-list] [PATCH 01/22] remote-viewer: add handling of spice+unix and spice+tls schemes

Spice URI with +unix or +tls. > > Signed-off-by: Marc-André Lureau Acked-by: Victor Toso > --- > data/remote-viewer.desktop.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/data/remote-viewer.desktop.in b/data/remote-viewer.desktop.in > inde

[virt-tools-list] [virt-viewer] app: Always add guest name comment

From: Victor Toso Even when the user adds comments, we should place the guest's name unless it is present already. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1623756 Signed-off-by: Victor Toso --- src/virt-viewer-app.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions

Re: [virt-tools-list] [Spice-devel] Ongoing migration: gitlab.com/spice -> gitlab.freedesktop.org/spice

Hi, On Thu, Jul 12, 2018 at 05:50:56PM +0200, Victor Toso wrote: > Hi, > > JFYI, CC'ing: > > * qemu-devel > * virt-tools-list > * de...@ovirt.org > > If nobody complains, I'll finish whatever is pending next Monday > morning (GMT+2). Migration is done. All Spice

Re: [virt-tools-list] [Spice-devel] Ongoing migration: gitlab.com/spice -> gitlab.freedesktop.org/spice

Hi, JFYI, CC'ing: * qemu-devel * virt-tools-list * de...@ovirt.org If nobody complains, I'll finish whatever is pending next Monday morning (GMT+2). Cheers, toso On Thu, Jul 12, 2018 at 02:12:43PM +0200, Victor Toso wrote: > Hi, > > The official repository for Spice componen

[virt-tools-list] [remote-viewer] remote-viewer-connect: centralize window

From: Victor Toso Instead of top-left corner. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1508274 Signed-off-by: Victor Toso --- src/resources/ui/remote-viewer-connect.ui | 1 + 1 file changed, 1 insertion(+) diff --git a/src/resources/ui/remote-viewer-connect.ui b/src/resources

Re: [virt-tools-list] [PATCH virt-viewer] doc: Adjust reference to spice-gtk man page for remote-viewer

mote-viewer.pod > @@ -382,6 +382,6 @@ to the extent permitted by law. > > =head1 SEE ALSO > > -C<virt-viewer(1)>, C<spice-gtk(1)>, the project website > C<http://virt-manager.org> > +C<virt-viewer(1)>, C<spice-client(1)>, the project website &

Re: [virt-tools-list] [PATCH virt-viewer] Fixes to spec file

Hi, On Fri, Nov 17, 2017 at 03:14:20PM -0200, Eduardo Lima (Etrunko) wrote: > On 17/11/17 11:39, Eduardo Lima (Etrunko) wrote: > > - Use macros for paths instead of absolute paths. > > - Fix scope of enable_autotools macro to avoid warning during build. > > warning: Macro %enable_autotools

Re: [virt-tools-list] [PATCH virt-viewer v3] remote-viewer: Pass guri to remote_viewer_session_connected

ed > instead. > > Resolves: https://bugzilla.redhat.com/1459792 > > Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> Reviewed-by: Victor Toso <victort...@redhat.com> Thanks, > --- > src/remote-viewer.c | 21 ++--- > 1 file changed, 10 inse

Re: [virt-tools-list] [PATCH v2 3/3] win32: remove debug-helper.exe

t; > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Looks fine, Reviewed-by: Victor Toso <victort...@redhat.com> > --- > mingw-virt-viewer.spec.in | 2 -- > src/Makefile.am | 5 --- > src/debug-helper.c| 83 > -

Re: [virt-tools-list] [PATCH v2 1/3] remote-viewer: learn '-' as URI for standard input connection file

t; > > > > This allows a parent process to set the connection details without > > > intermediary file. > > > > > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > > > Reviewed-by: Victor Toso <victort...@redhat.com> >

Re: [virt-tools-list] [PATCH virt-viewer v2] remote-viewer: Pass guri to remote_viewer_session_connected

Hi, On Tue, Nov 14, 2017 at 02:14:25PM -0200, Eduardo Lima (Etrunko) wrote: > On 14/11/17 13:47, Victor Toso wrote: > > On Thu, Oct 26, 2017 at 03:39:31PM +0200, Eduardo Lima (Etrunko) wrote: > >> When connecting to a VM via oVirt instance, the original uri can not be &g

Re: [virt-tools-list] [PATCH v2 1/3] remote-viewer: learn '-' as URI for standard input connection file

read the connection file from standard input for such use > case. > > This allows a parent process to set the connection details without > intermediary file. > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > Reviewed-by: Victor Toso <victo

Re: [virt-tools-list] [PATCH virt-viewer v2] remote-viewer: Pass guri to remote_viewer_session_connected

r *guri) > { > gchar *uri = virt_viewer_session_get_uri(session); > const gchar *mime = virt_viewer_session_mime_type(session); > > +if (uri == NULL) > +uri = g_strdup(guri); > + > remote_viewer_recent_add(uri, mime); Could you also change the if (u

Re: [virt-tools-list] [PATCH 2/2] remote-viewer: remove --spice-controller

ECK_MODULES(SPICE_CONTROLLER, [spice-controller])] Grep says that we still have some SPICE_CONTROLLER in src/Makefile.am virt-viewer-git (makepkg 5d882a46) $ grepi "SPICE_CONTROLLER" * src/Makefile.am:181:$(SPICE_CONTROLLER_LIBS)\ src/Makefile.am:185:$(SPICE_CONTR

Re: [virt-tools-list] [PATCH 1/2] RFC: remote-viewer: learn '-' as URI for standard input connection file

ile.h > index 6b783f9..15c61d0 100644 > --- a/src/virt-viewer-file.h > +++ b/src/virt-viewer-file.h > @@ -50,6 +50,8 @@ struct _VirtViewerFileClass > GType virt_viewer_file_get_type(void); > > VirtViewerFile* virt_viewer_file_new(const gchar* path, GError** error); > +Vi

Re: [virt-tools-list] [PATCH virt-viewer] remote-viewer: Pass guri to remote_viewer_session_connected

Hey, Patch does not apply, I guess there are extra changes before this patch On Fri, Oct 20, 2017 at 03:10:53PM -0200, Eduardo Lima (Etrunko) wrote: > When connecting to a VM via oVirt instance, the original uri can not be > retrieved using virt_viewer_session_get_uri(). Consequently, it was >

Re: [virt-tools-list] [PATCH virt-viewer v2 0/4] Support for ovirt data center related functions

Ack - Original Message - > v2: > - Check for new functions in configure. > - Added #ifdef guards for the new functions. > > Eduardo Lima (Etrunko) (4): > configure: check for new functions in libgovirt > foreign-menu: Use query for fetching virtual machines > ovirt-foreign-menu:

[virt-tools-list] [remote-viewer v2] remote-viewer-connect: Keep the 'dialog' window on top

From: Victor Toso <m...@victortoso.com> Otherwise, in kiosk mode, it'll be hidden from user. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1459800 Signed-off-by: Victor Toso <victort...@redhat.com> --- src/remote-viewer-connect.c | 3 ++- src/remote-viewer-connect.h | 2 +-

[virt-tools-list] [virt-viewer v1] remote-viewer-connect: Keep the 'dialog' window on top

From: Victor Toso <m...@victortoso.com> Otherwise, in kiosk mode, it'll be hidden from user. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1459800 Signed-off-by: Victor Toso <victort...@redhat.com> --- src/remote-viewer-connect.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [virt-tools-list] [PATCH virt-viewer v3] remote-viewer: Show authentication dialog again if in kiosk mode and connecting to ovirt

Hi, On Thu, Jun 08, 2017 at 06:51:01PM -0300, Eduardo Lima (Etrunko) wrote: > On 08/06/17 18:41, Victor Toso wrote: > > Hi, > > > > I would try to short a little bit the shortlog although is very clear. > > > > Maybe from > > "remote-viewer: Show

Re: [virt-tools-list] [PATCH virt-viewer v3] remote-viewer: Show authentication dialog again if in kiosk mode and connecting to ovirt

mit log ;) ~ Up to you too. They are: fb14a8b300ed8 6480e52f62bc7 > Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161 Better to change it to: Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1459808 > > Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> Ack

Re: [virt-tools-list] [PATCH virt-viewer] remote-viewer: Show authentication dialog again if in kiosk mode and connecting to ovirt

On Thu, Jun 08, 2017 at 06:00:39PM -0300, Eduardo Lima (Etrunko) wrote: > Similar to previous commits, but the case for connecting directly to > ovirt:// URIs was not dealt with. > > Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161 > > Signed-off-by: Eduardo Lima (Etrunko)

Re: [virt-tools-list] [PATCH virt-viewer] screenshot: Prefill filename suffix

Hi, On Thu, Jun 08, 2017 at 03:08:02PM +0200, Pavel Grunt wrote: > Use .png as the default > > Related: rhbz#1455832 Small clarification of the rationale behind would be good (#1455832) - Still, not a full solution, is it? This will check if we are replacing the image file at

Re: [virt-tools-list] [virt-viewer v2] vnc: do not show error on cancel/close of auth dialog

Hi, On Tue, Jun 06, 2017 at 12:03:59PM -0300, Eduardo Lima (Etrunko) wrote: > On 06/06/17 09:12, Victor Toso wrote: > > From: Victor Toso <m...@victortoso.com> > > > > Mainly a kiosk mode, similar to the spice fix in 6480e52f62b. "Mainly a kiosk mode issue, s

[virt-tools-list] [virt-viewer v1] vnc: only emit 'session-disconnect' if it was connected

From: Victor Toso <m...@victortoso.com> When user cancels an authentication dialog, virt-viewer-session-vnc.c will correctly emit "session-cancelled" and after that it will emit "session-disconnected" which is not correct as the session's connection was not establish at

Re: [virt-tools-list] [virt-viewer v3] spice: do not show error on cancel/close of auth dialog

On Fri, Jun 02, 2017 at 11:59:04AM -0300, Eduardo Lima (Etrunko) wrote: > On 02/06/17 09:57, Pavel Grunt wrote: > > On Fri, 2017-06-02 at 14:05 +0200, Victor Toso wrote: > >> From: Victor Toso <m...@victortoso.com> > >> > >> Mainly an issu

[virt-tools-list] [virt-viewer v2] vnc: do not show error on cancel/close of auth dialog

From: Victor Toso <m...@victortoso.com> Mainly a kiosk mode, similar to the spice fix in 6480e52f62b. This patch saves the cancel/close state of auth dialog from virt_viewer_auth_collect_credentials() in order to avoid an error dialog to pop up to user in kiosk mode. This happens due th

Re: [virt-tools-list] [virt-viewer v1] app: Only disconnect if it was connected previously

Hi, On Tue, Jun 06, 2017 at 11:03:11AM +0200, Victor Toso wrote: > From: Victor Toso <m...@victortoso.com> > > When user cancels an authentication dialog, virt-viewer-session-vnc.c > will correctly emit "session-cancelled" and after that it will emit > "sessio

[virt-tools-list] [virt-viewer v1] app: Only disconnect if it was connected previously

From: Victor Toso <m...@victortoso.com> When user cancels an authentication dialog, virt-viewer-session-vnc.c will correctly emit "session-cancelled" and after that it will emit "session-disconnected" which is not correct as the connect was not establish at that moment

Re: [virt-tools-list] [virt-viewer v3] spice: do not show error on cancel/close of auth dialog

Hi, On Mon, Jun 05, 2017 at 10:35:30AM -0300, Eduardo Lima (Etrunko) wrote: > On 05/06/17 09:12, Victor Toso wrote: > > On Fri, Jun 02, 2017 at 11:59:04AM -0300, Eduardo Lima (Etrunko) wrote: > >> On 02/06/17 09:57, Pavel Grunt wrote: > >>> On Fri, 2017-06-02 at

Re: [virt-tools-list] [PATCH 0/2] Do not show auth error dialog on cancel/close

Hi, Self nack those two patches. Following proposal is enough and much simpler: https://www.redhat.com/archives/virt-tools-list/2017-June/msg00014.html On Fri, Jun 02, 2017 at 12:40:34PM +0200, Victor Toso wrote: > From: Victor Toso <m...@victortoso.com> > > In kiosk mode, we wil

[virt-tools-list] [virt-viewer v3] spice: do not show error on cancel/close of auth dialog

From: Victor Toso <m...@victortoso.com> Mainly an issue for kiosk mode. Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161 Signed-off-by: Victor Toso <victort...@redhat.com> --- src/virt-viewer-session-spice.c | 4 1 file changed, 4 insertions(+) diff --git a/src

[virt-tools-list] [virt-viewer v2 1/2] Return full response from virt_viewer_auth_collect_credentials()

From: Victor Toso <m...@victortoso.com> For whom is trying to collect the credentials, it might be necessary to know if a failure is due bad user input of credentials or if the user has cancelled or closed the dialog. Prior to this patch anything but GTK_RESPONSE_OK was considered a f

[virt-tools-list] [PATCH 0/2] Do not show auth error dialog on cancel/close

From: Victor Toso <m...@victortoso.com> In kiosk mode, we will see the error dialog on cancel/close which is not expected as we are not really trying to connect with given user/pass. Cheers, toso Victor Toso (2): Return full response from virt_viewer_auth_collect_credentials() spi

[virt-tools-list] [PATCH 2/2] spice: do not show error on cancel/close of auth dialog

From: Victor Toso <m...@victortoso.com> Mainly an issue for kiosk mode. Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161 Signed-off-by: Victor Toso <victort...@redhat.com> --- src/virt-viewer-session-spice.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src

[virt-tools-list] [PATCH 1/2] Return full response from virt_viewer_auth_collect_credentials()

From: Victor Toso <m...@victortoso.com> Who is trying to collect the credentials might need to know if a given failure is due bad user input of credentionals or if the user has cancel/closed the dialog (which is also consider failure prior this patch) Related: https://bugzilla.redh

Re: [virt-tools-list] [PATCH virt-viewer v2 2/2] kiosk: Show authentication dialog again if cancelled

Hi, On Wed, May 31, 2017 at 10:23:16AM -0300, Eduardo Lima (Etrunko) wrote: > Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161 > > Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> Works fine, Acked-by: Victor Toso <victort...@redhat.com> > --- &g

Re: [virt-tools-list] [PATCH virt-viewer v2 1/2] window: Do not show fullscreen toolbar if in kiosk mode

On Wed, May 31, 2017 at 10:23:15AM -0300, Eduardo Lima (Etrunko) wrote: > Regression since commit cc455b7f916110d7cfae6b7af753349e070c9494. > > Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161 > > Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com>

Re: [virt-tools-list] [PATCH virt-viewer 2/2] Quit application if in kiosk mode and authentication has been cancelled

On Mon, May 22, 2017 at 10:39:15AM -0300, Eduardo Lima (Etrunko) wrote: > On 21/05/17 04:23, Xiaodai Wang wrote: > > > > - Original Message ----- > >> From: "Victor Toso" <li...@victortoso.com> > >> To: "Eduardo Lima (Etrunko)&quo

Re: [virt-tools-list] [PATCH virt-viewer 2/2] Quit application if in kiosk mode and authentication has been cancelled

Hi, On Fri, May 19, 2017 at 05:16:53PM -0300, Eduardo Lima (Etrunko) wrote: > Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161 > > Signed-off-by: Eduardo Lima (Etrunko) I'm not 100% sure that this would be the desirable behavior. If one runs the app in -k, isn't

Re: [virt-tools-list] [PATCH virt-viewer 1/2] window: Do not show fullscreen toolbar if in kiosk mode

Hi, On Fri, May 19, 2017 at 05:16:52PM -0300, Eduardo Lima (Etrunko) wrote: > Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161 > > Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> Acked-by: Victor Toso <victort...@redhat.com> Seems to be a reg

  1   2   >