[virt-tools-list] [PATCH v2] Make the progress bar smooth during file-transfer

2017-05-11 Thread Victor Toso
From: Victor Toso <m...@victortoso.com> When the transfer of a file finishes we stop considering that file's size in the progress bar which makes it move back due the new 'transfer size' and 'transferred bytes' - for all the other files. This patch aims to keep the progress smooth when

[virt-tools-list] [remote-viewer] Make the progress bar smooth during file-transfer

2017-05-10 Thread Victor Toso
From: Victor Toso <m...@victortoso.com> When the transfer of a file finishes we stop considering that file's size in the progress bar which makes it move back due the new 'transfer size' and 'transferred bytes' - for all the other files. This patch aims to keep the progress smooth when

Re: [virt-tools-list] [PATCH virt-viewer v2] window: Allow to control zoom using keypad

2017-05-05 Thread Victor Toso
quot;, action_zoom_in,}, -{"zoom-out", action_zoom_out,}, -{"zoom-reset", action_zoom_reset,}, +{ .name = "zoom-in", .activate = action_zoom_in }, + { .name = "zoom-out", .activate = action_zoom_out }, +{ .name = "zoom-re

[virt-tools-list] [virt-viewer v1] Fix implicit fallthrough warning on new gcc

2017-04-18 Thread Victor Toso
From: Victor Toso <m...@victortoso.com> The option -Wimplicit-fallthrough was added to -Wall recently which generates a few warnings. Based on the comment above the switch, the fallthrough is on purpose so let's add a comment to avoid the following warnings. ovirt-foreign-menu.c: In fu

Re: [virt-tools-list] No Sound on Win 7 VM using RHEL 7 Linux workstaiton

2017-03-31 Thread Victor Toso
Hi Roland, On Thu, Mar 30, 2017 at 08:39:09PM -0400, Roland wrote: > All, I have a RHEL 7 Workstation, I used the Virtual Machine Manager and > created a Windows 7 VM. The audio is not working, the Win 7 Sound Icon is > available in the task bar, the drivers seem to be associated in device >

[virt-tools-list] [virt-viewer v1] Avoid harmless warnings due lack of oVirt on build

2017-03-03 Thread Victor Toso
From: Victor Toso <m...@victortoso.com> > remote-viewer.c: In function 'remote_viewer_get_property': > remote-viewer.c:227:26: warning: unused variable 'priv' [-Wunused-variable] > RemoteViewerPrivate *priv = self->priv; > ^~~~ > remote-

[virt-tools-list] [virt-viewer v1 1/2] Fix build when building without oVirt

2017-03-03 Thread Victor Toso
From: Victor Toso <m...@victortoso.com> As remote_viewer_iso_list_dialog_new() is defined on remote-viewer-iso-list-dialog.h which is only build with oVirt integration. > undefined reference to `remote_viewer_iso_list_dialog_new' Note that the

Re: [virt-tools-list] failed to auto usb redirect ....

2016-11-22 Thread Victor Toso
Hi, On Tue, Nov 22, 2016 at 03:13:44PM +, 张 余歌 wrote: > recently,i meet some issues: when i try to install remote-viewer in > debian8.6(i see remoteviewer version is 1.0.0) to use my win7 vm,it is > strange that the parameter auto usb redirect didn't work but on > connect,it confused me

Re: [virt-tools-list] [PATCH virt-viewer v3] RFC: Simplify file transfer dialog UI

2016-10-14 Thread Victor Toso
Hi, On Wed, Aug 31, 2016 at 12:15:24PM -0500, Jonathon Jongsma wrote: > On Tue, 2016-08-30 at 21:28 +0200, Fabiano Fidêncio wrote: > > On Wed, Aug 17, 2016 at 8:21 PM, Jonathon Jongsma > m> wrote: > > > > > > When transferring a large number of files, the file transfer

Re: [virt-tools-list] [PATCH virt-viewer v3] RFC: Simplify file transfer dialog UI

2016-08-16 Thread Victor Toso
Hi, On Tue, Aug 16, 2016 at 10:30:57AM -0500, Jonathon Jongsma wrote: > When transferring a large number of files, the file transfer dialog > was unusable because the window size would be larger than the client > desktop. To solve this, remove the list of individual files (and the > ability to

[virt-tools-list] [virt-viewer v1] Fix filename leak on transfer dialog

2016-08-03 Thread Victor Toso
spice_file_transfer_task_get_filename() was wrongly annotated as transfer none. We can safely free this string after usage. --- src/virt-viewer-file-transfer-dialog.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/virt-viewer-file-transfer-dialog.c

Re: [virt-tools-list] [virt-viewer v1] Take reference to monitor the file transfer task

2016-07-12 Thread Victor Toso
Hi, On Tue, Jul 12, 2016 at 03:38:52PM +0200, Christophe Fergeau wrote: > On Tue, Jul 12, 2016 at 02:19:02PM +0200, Victor Toso wrote: > > Documentation states that: > > "Client applications may take a reference on the @task object and use > > it to monitor the status

[virt-tools-list] [virt-viewer v1] Take reference to monitor the file transfer task

2016-07-12 Thread Victor Toso
after task is finished (on task_finished_remove) leading to critical warnings when task original reference has been freed already. Signed-off-by: Victor Toso <victort...@redhat.com> --- src/virt-viewer-session-spice.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [virt-tools-list] [PATCH virt-viewer v2] Add some timeouts to file transfer dialog

2016-04-26 Thread Victor Toso
he client for quite some time now although we have the ping/pong messages in spice-gtk. Booth patches look good to me Reviewed-by: Victor Toso <victort...@redhat.com> > --- > Changes: > - Previous patch didn't actually work to avoid showing a dialog when >transferring very

Re: [virt-tools-list] [PATCH virt-viewer] display: Allocate size for parent

2016-04-25 Thread Victor Toso
Hi, On Fri, Apr 22, 2016 at 03:06:27PM +0200, Pavel Grunt wrote: > Silence runtime warning with Gtk+3.20 > Gtk-WARNING **: Drawing a gadget with negative dimensions. > Did you forget to allocate a size? (node box owner ViewAutoDrawer) > > Related: rhbz#1327269 It did not work for me. gtk is

Re: [virt-tools-list] [virt-viewer 0/3] Bring back libvirt-glib dependency

2016-02-25 Thread Victor Toso
Hi, Series looks good! Acked-by: Victor Toso <victort...@redhat.com> On Tue, Feb 23, 2016 at 03:32:04PM +0100, Fabiano Fidêncio wrote: > A long time ago we used to depend on libvirt-glib for the glib event > loop integration. On commit 296f91c it got dropped in favor of > kee

Re: [virt-tools-list] [virt-viewer] nsis: update nettle to 3.2.1

2016-02-23 Thread Victor Toso
Looks good, Acked-by: Victor Toso <victort...@redhat.com> On Tue, Feb 23, 2016 at 03:33:59PM +0100, Fabiano Fidêncio wrote: > Use version 3.2.1, matching what currently is in f23. > --- > data/virt-viewer.nsis.in | 8 > 1 file changed, 4 insertions(+), 4 deletions(

Re: [virt-tools-list] Re:Re: [help] Does spice support Camera or Printer ?

2015-11-26 Thread Victor Toso
ll usbclerk in the windows client machine. Note that, I'm not sure webcam is supported by usbclerk... [0] http://lists.freedesktop.org/archives/spice-devel/2015-October/022851.html Cheers, Victor Toso ___ virt-tools-list mailing list virt-tools-list@redh

Re: [virt-tools-list] [help] Does spice support Camera or Printer ?

2015-11-24 Thread Victor Toso
Hi, On Wed, Nov 25, 2015 at 11:34:28AM +0800, hongzhen_...@sina.com wrote: > Dear everyone > If i connected Camera or Printer in my host , Does spice support > Camera or Printer ? spice supports usb redirection between the client and the guest. If you connect a usb camera in your client, you can

Re: [virt-tools-list] how to get virt-viewer log trace at windows 7 32bit

2015-09-22 Thread Victor Toso
Hi, On Mon, Sep 21, 2015 at 08:52:48AM +0800, 骆宏震 wrote: > Now I am doing development of virt-viewer on Windows7 for > Virtualization Technology . But i don't know how to get virt-viewer > log information at Win7 32bit ..It's really a worest problem to > myself .. So if you know , could you tell

Re: [virt-tools-list] [virt-viewer][PATCH 4/6] events: protect handles and timeouts agins concurrent access

2015-07-17 Thread Victor Toso
Typo in the short commit message: against On Fri, Jul 17, 2015 at 04:01:21PM +0200, Fabiano Fidêncio wrote: Timeout and Handle operations are done from an idle callback. However, we cannot assume that all libvirt event calls (the callbacks passed to virEventRegisterImpl) will be done from the

Re: [virt-tools-list] [PATCH] nsis: add libepoxy-0.dll (a new gtk3 dependency)

2015-06-22 Thread Victor Toso
} == True -- 2.4.4 Yes, since gtk+ 3.15.3 it seems. Patch looks good to me. Best, Victor Toso ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] [PATCH] webdav support is not available for Windows

2015-06-15 Thread Victor Toso
Hi, On Mon, Jun 15, 2015 at 11:01:03PM +0200, Fabiano Fidêncio wrote: As there is no Phodav support for Windows, spice-gtk ends up being built without webdav support, what can cause a build breakage on virt-viewer when compiled using mingw. The build failure is: virt-viewer-session-spice.c:

Re: [virt-tools-list] Compiling for USB Redirection support in Windows

2015-05-22 Thread Victor Toso
a version of virt-viewer for windows that does have usb redirection compiled in? Christophe provided the spice-gtk rpm with usbredirection enable. I hope this steps can help you, Victor Toso ___ virt-tools-list mailing list virt-tools-list@redhat.com

Re: [virt-tools-list] Compiling for USB Redirection support in Windows

2015-05-21 Thread Victor Toso
redirection on windows client... not sure if it will work. [0] http://blog.fidencio.org/2014/11/virt-viewer-using-gtk3-for-windows.html Best, Victor Toso ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo

Re: [virt-tools-list] Compiling for USB Redirection support in Windows

2015-05-21 Thread Victor Toso
spice-gtk with --enable-usbredir and then build virt-viewer with this new spice-gtk (--with-spice-gtk). There is mingw package for usbredir, so I believe it will works. Best, Victor Toso ___ virt-tools-list mailing list virt-tools-list@redhat.com https

Re: [virt-tools-list] [virt-viewer][PATCH 1/3] virt-viewer: Changed reconnect field to property

2015-05-12 Thread Victor Toso
Hi, Just one comment below, On Tue, May 12, 2015 at 12:21:02PM +0200, Lukas Venhoda wrote: Reconnect field in virt-viewer.c changed to property. This will be used in virt-viewer-window.c for implementing a reconnect button in the GUI. --- In virt_viewer_new() function, there's comment /*

Re: [virt-tools-list] [virt-viewer][PATCH 2/2] virt-viewer-display-vnc: Set uuid when using VNC

2015-04-29 Thread Victor Toso
Hi, On Wed, Apr 29, 2015 at 02:39:51PM +0200, Lukas Venhoda wrote: Notify user, that VNC does not provide uuid. Set uuid to string VNC does not provide guid. This is more informative then just plain Unknown. User will now know WHY the GUID is unknown, when using remote-viewer. ---

Re: [virt-tools-list] Windows 7 VM doesn't go full screen

2015-04-22 Thread Victor Toso
On Wed, Apr 22, 2015 at 03:18:16PM +0300, Muzaffer Tolga Ozses wrote: I used virt-manager. Can I still use spice-guest-tools? Yes, you can check the Guest session in: http://www.spice-space.org/download.html On 22 April 2015 at 15:17, Marc-André Lureau mlur...@redhat.com wrote: Hi

[virt-tools-list] [PATCH] nsis: use gstreamer-1.0 instead of gstreamer-0.10

2015-01-05 Thread Victor Toso
Spice-gtk now is able to use gstreamer-1.0 for playback and record audio. This patch updates the installer to use the latest version. --- data/virt-viewer.nsis.in | 114 +-- 1 file changed, 52 insertions(+), 62 deletions(-) diff --git

<    1   2