Re: [PATCH remote-viewer] Fix potential file descriptor leaks found by Coverity.

2020-04-01 Thread Daniel P . Berrangé
On Wed, Apr 01, 2020 at 09:25:18AM +0200, Julien Ropé wrote: > The error code returned by virt_viewer_session_open_fd() and > virt_viewer_session_channel_open_fd() were not checked. The file descriptor > passed to them could then be left opened even if the function failed, causing > a leak of re

[PATCH remote-viewer] Fix potential file descriptor leaks found by Coverity.

2020-04-01 Thread Julien Ropé
The error code returned by virt_viewer_session_open_fd() and virt_viewer_session_channel_open_fd() were not checked. The file descriptor passed to them could then be left opened even if the function failed, causing a leak of resources. This was reported by a Coverity scan, logged under https:/