Re: [virt-tools-list] [PATCH] timed-revealer: Inherit from GtkEventBox

2016-06-28 Thread Christophe Fergeau
Hey, On Tue, Jun 28, 2016 at 04:18:30PM +0200, Fabiano FidĂȘncio wrote: > As suggested by Christophe, inheritting from GtkEventBox instead of > having one instance of it as a member can help us to get rid of > virt_viewer_timed_revealer_get_overlay_widget() and also makes more > natural that we

[virt-tools-list] [PATCH] timed-revealer: Inherit from GtkEventBox

2016-06-28 Thread Fabiano FidĂȘncio
As suggested by Christophe, inheritting from GtkEventBox instead of having one instance of it as a member can help us to get rid of virt_viewer_timed_revealer_get_overlay_widget() and also makes more natural that we take ownership of the GtkToolbar floating ref. This change also fixes the crash