Re: [virt-tools-list] [PATCH 4/5] window: Replace toolbar with headerbar (fullscreen)

2016-12-24 Thread Fabiano Fidêncio
t;Fabiano Fidêncio" >>>> Cc: "virt" >>>> Sent: Tuesday, December 20, 2016 5:30:47 PM >>>> Subject: Re: [virt-tools-list] [PATCH 4/5] window: Replace toolbar with >>>> headerbar (fullscreen) >>>> >>>>

Re: [virt-tools-list] [PATCH 4/5] window: Replace toolbar with headerbar (fullscreen)

2016-12-23 Thread Sagar Ghuge
;> To: "Fabiano Fidêncio" >>> Cc: "virt" >>> Sent: Tuesday, December 20, 2016 5:30:47 PM >>> Subject: Re: [virt-tools-list] [PATCH 4/5] window: Replace toolbar with >>> headerbar (fullscreen) >>> >>> Hello everyone, >>>

Re: [virt-tools-list] [PATCH 4/5] window: Replace toolbar with headerbar (fullscreen)

2016-12-20 Thread Fabiano Fidêncio
On Tue, Dec 20, 2016 at 11:43 AM, Xiaodai Wang wrote: > > - Original Message - >> From: "Sagar Ghuge" >> To: "Fabiano Fidêncio" >> Cc: "virt" >> Sent: Tuesday, December 20, 2016 5:30:47 PM >> Subject: Re: [virt-

Re: [virt-tools-list] [PATCH 4/5] window: Replace toolbar with headerbar (fullscreen)

2016-12-20 Thread Xiaodai Wang
- Original Message - > From: "Sagar Ghuge" > To: "Fabiano Fidêncio" > Cc: "virt" > Sent: Tuesday, December 20, 2016 5:30:47 PM > Subject: Re: [virt-tools-list] [PATCH 4/5] window: Replace toolbar with > headerbar (fullscreen) > >

Re: [virt-tools-list] [PATCH 4/5] window: Replace toolbar with headerbar (fullscreen)

2016-12-20 Thread Sagar Ghuge
Hello everyone, Here is the screenshots of header bar in fullscreen mode : http://imgur.com/a/ZgbS2 Comments and Suggestions most welcome. Thank you. On Mon, Dec 19, 2016 at 4:34 AM, Fabiano Fidêncio wrote: > On Mon, Dec 19, 2016 at 1:26 PM, Daniel P. Berrange > wrote: >> On Sat, Dec 17, 2016

Re: [virt-tools-list] [PATCH 4/5] window: Replace toolbar with headerbar (fullscreen)

2016-12-19 Thread Pavel Grunt
On Mon, 2016-12-19 at 13:32 +0100, Fabiano Fidêncio wrote: > On Mon, Dec 19, 2016 at 1:05 PM, Pavel Grunt > wrote: > > Hey, would you mind splitting the usb icon change ? > > I really don't see a good reason for that. The commit would be shorter The change of the icon would not be hidden It coul

Re: [virt-tools-list] [PATCH 4/5] window: Replace toolbar with headerbar (fullscreen)

2016-12-19 Thread Fabiano Fidêncio
On Mon, Dec 19, 2016 at 1:05 PM, Pavel Grunt wrote: > Hey, would you mind splitting the usb icon change ? I really don't see a good reason for that. We would end up somewhere with an icon different of the rest for one commit, but yeah, could be done. > The icon is provided by some icon package

Re: [virt-tools-list] [PATCH 4/5] window: Replace toolbar with headerbar (fullscreen)

2016-12-19 Thread Fabiano Fidêncio
On Mon, Dec 19, 2016 at 1:26 PM, Daniel P. Berrange wrote: > On Sat, Dec 17, 2016 at 05:50:11PM +0100, Fabiano Fidêncio wrote: >> From: Sagar Ghuge >> >> In order to give a modern look to {virt,remote}-viewer let's replace the >> old toolbar for a headerbar (it's the widget shown when the app is

Re: [virt-tools-list] [PATCH 4/5] window: Replace toolbar with headerbar (fullscreen)

2016-12-19 Thread Daniel P. Berrange
On Sat, Dec 17, 2016 at 05:50:11PM +0100, Fabiano Fidêncio wrote: > From: Sagar Ghuge > > In order to give a modern look to {virt,remote}-viewer let's replace the > old toolbar for a headerbar (it's the widget shown when the app is > fullscreen). > > The items in the headerbar are exactly the sa

Re: [virt-tools-list] [PATCH 4/5] window: Replace toolbar with headerbar (fullscreen)

2016-12-19 Thread Pavel Grunt
Hey, would you mind splitting the usb icon change ? The icon is provided by some icon package or gtk ? Pavel On Sat, 2016-12-17 at 17:50 +0100, Fabiano Fidêncio wrote: > From: Sagar Ghuge > > In order to give a modern look to {virt,remote}-viewer let's replace > the > old toolbar for a headerba

[virt-tools-list] [PATCH 4/5] window: Replace toolbar with headerbar (fullscreen)

2016-12-17 Thread Fabiano Fidêncio
From: Sagar Ghuge In order to give a modern look to {virt,remote}-viewer let's replace the old toolbar for a headerbar (it's the widget shown when the app is fullscreen). The items in the headerbar are exactly the same ones present in the old toolbar. Signed-off-by: Sagar Ghuge --- icons/24x2