Re: [virt-tools-list] [PATCH v3 3/5] Port to GtkApplication API's

2016-02-15 Thread Fabiano Fidêncio
On Mon, Feb 15, 2016 at 2:57 PM, Eduardo Lima (Etrunko) wrote: > On 02/15/2016 11:47 AM, Fabiano Fidêncio wrote: > [snip] > >>> >>> cleanup: >>> -g_free(uri); >>> -if (viewer) >>> -g_object_unref(viewer); >>> -g_strfreev(args); >>> -g_clear_error(&error); >>> - >>> +g

Re: [virt-tools-list] [PATCH v3 3/5] Port to GtkApplication API's

2016-02-15 Thread Eduardo Lima (Etrunko)
On 02/15/2016 11:47 AM, Fabiano Fidêncio wrote: [snip] >> >> cleanup: >> -g_free(uri); >> -if (viewer) >> -g_object_unref(viewer); >> -g_strfreev(args); >> -g_clear_error(&error); >> - >> +g_object_unref(viewer); > > g_object_unref() shouldn't be called with a NULL

Re: [virt-tools-list] [PATCH v3 3/5] Port to GtkApplication API's

2016-02-15 Thread Fabiano Fidêncio
On Fri, 2016-02-12 at 09:35 -0200, Eduardo Lima (Etrunko) wrote: > Most of this patch consists in code being shuffled around to fit the > expected flow while using the new APIs. I tried my best to make this > patch the less intrusive as possible. Main changes are: > > - Updated build requirements

Re: [virt-tools-list] [PATCH v3 3/5] Port to GtkApplication API's

2016-02-12 Thread Eduardo Lima (Etrunko)
On 02/12/2016 03:26 PM, Eduardo Lima (Etrunko) wrote: > On 02/12/2016 10:09 AM, Eduardo Lima (Etrunko) wrote: >> Running remote-viewer will throw some warnings: >> >> (remote-viewer:546): Gtk-CRITICAL **: gtk_application_get_app_menu: >> assertion 'GTK_IS_APPLICATION (application)' failed >> >> (re

Re: [virt-tools-list] [PATCH v3 3/5] Port to GtkApplication API's

2016-02-12 Thread Eduardo Lima (Etrunko)
On 02/12/2016 10:09 AM, Eduardo Lima (Etrunko) wrote: > Running remote-viewer will throw some warnings: > > (remote-viewer:546): Gtk-CRITICAL **: gtk_application_get_app_menu: > assertion 'GTK_IS_APPLICATION (application)' failed > > (remote-viewer:546): Gtk-CRITICAL **: gtk_application_get_menub

Re: [virt-tools-list] [PATCH v3 3/5] Port to GtkApplication API's

2016-02-12 Thread Eduardo Lima (Etrunko)
Running remote-viewer will throw some warnings: (remote-viewer:546): Gtk-CRITICAL **: gtk_application_get_app_menu: assertion 'GTK_IS_APPLICATION (application)' failed (remote-viewer:546): Gtk-CRITICAL **: gtk_application_get_menubar: assertion 'GTK_IS_APPLICATION (application)' failed This does

[virt-tools-list] [PATCH v3 3/5] Port to GtkApplication API's

2016-02-12 Thread Eduardo Lima (Etrunko)
Most of this patch consists in code being shuffled around to fit the expected flow while using the new APIs. I tried my best to make this patch the less intrusive as possible. Main changes are: - Updated build requirements * glib version 2.38 * gtk+ version 3.10 * gio - VirtViewerApp is