Re: [virt-tools-list] [PATCH v5 1/3] Port to GtkApplication API's

2016-02-17 Thread Eduardo Lima (Etrunko)
On 02/17/2016 01:22 PM, Jonathon Jongsma wrote: >>> I disagree, but again, I think it is basically a matter of >>> preference. >> >> It is. From the macro name it is not clear for me how is different >> "GOTO_END" from "goto end" > > For what it's worth, I agree with Pavel here. I think it

Re: [virt-tools-list] [PATCH v5 1/3] Port to GtkApplication API's

2016-02-17 Thread Jonathon Jongsma
On Tue, 2016-02-16 at 17:17 +0100, Pavel Grunt wrote: > On Tue, 2016-02-16 at 13:21 -0200, Eduardo Lima (Etrunko) wrote: > > On 02/16/2016 10:41 AM, Pavel Grunt wrote: > > > Hi, > > > > > > On Mon, 2016-02-15 at 19:22 -0200, Eduardo Lima (Etrunko) wrote: > > > > Most of this patch consists in

Re: [virt-tools-list] [PATCH v5 1/3] Port to GtkApplication API's

2016-02-16 Thread Pavel Grunt
On Tue, 2016-02-16 at 13:21 -0200, Eduardo Lima (Etrunko) wrote: > On 02/16/2016 10:41 AM, Pavel Grunt wrote: > > Hi, > > > > On Mon, 2016-02-15 at 19:22 -0200, Eduardo Lima (Etrunko) wrote: > > > Most of this patch consists in code being shuffled around to fit > > > the > > > expected flow while

Re: [virt-tools-list] [PATCH v5 1/3] Port to GtkApplication API's

2016-02-16 Thread Fabiano Fidêncio
On Tue, Feb 16, 2016 at 1:41 PM, Pavel Grunt wrote: > Hi, > > On Mon, 2016-02-15 at 19:22 -0200, Eduardo Lima (Etrunko) wrote: >> Most of this patch consists in code being shuffled around to fit the >> expected flow while using the new APIs. I tried my best to make this >>

Re: [virt-tools-list] [PATCH v5 1/3] Port to GtkApplication API's

2016-02-16 Thread Eduardo Lima (Etrunko)
On 02/16/2016 10:41 AM, Pavel Grunt wrote: > Hi, > > On Mon, 2016-02-15 at 19:22 -0200, Eduardo Lima (Etrunko) wrote: >> Most of this patch consists in code being shuffled around to fit the >> expected flow while using the new APIs. I tried my best to make this >> patch the less intrusive as

Re: [virt-tools-list] [PATCH v5 1/3] Port to GtkApplication API's

2016-02-16 Thread Pavel Grunt
Hi, On Mon, 2016-02-15 at 19:22 -0200, Eduardo Lima (Etrunko) wrote: > Most of this patch consists in code being shuffled around to fit the > expected flow while using the new APIs. I tried my best to make this > patch the less intrusive as possible. Main changes are: > > - Updated build

[virt-tools-list] [PATCH v5 1/3] Port to GtkApplication API's

2016-02-15 Thread Eduardo Lima (Etrunko)
Most of this patch consists in code being shuffled around to fit the expected flow while using the new APIs. I tried my best to make this patch the less intrusive as possible. Main changes are: - Updated build requirements * glib version 2.38 * gtk+ version 3.10 * gio - VirtViewerApp is