Re: [virt-tools-list] [PATCH virt-viewer] display: Do not override size-allocate handler

2016-08-10 Thread Pavel Grunt
On Wed, 2016-08-10 at 09:35 -0300, Eduardo Lima (Etrunko) wrote: > On 08/10/2016 07:41 AM, Pavel Grunt wrote: > > > > On Tue, 2016-08-09 at 17:44 +0200, Christophe Fergeau wrote: > > > > > > On Tue, Aug 09, 2016 at 05:17:31PM +0200, Pavel Grunt wrote: > > > > > > > > > > > > Just connect to

Re: [virt-tools-list] [PATCH virt-viewer] display: Do not override size-allocate handler

2016-08-10 Thread Eduardo Lima (Etrunko)
On 08/10/2016 07:41 AM, Pavel Grunt wrote: > On Tue, 2016-08-09 at 17:44 +0200, Christophe Fergeau wrote: >> On Tue, Aug 09, 2016 at 05:17:31PM +0200, Pavel Grunt wrote: >>> >>> Just connect to the signal >> >> I'm tempted to ask "why?". I think it's recommended (more efficient) to >> just

Re: [virt-tools-list] [PATCH virt-viewer] display: Do not override size-allocate handler

2016-08-10 Thread Eduardo Lima (Etrunko)
On 08/09/2016 12:44 PM, Christophe Fergeau wrote: > On Tue, Aug 09, 2016 at 05:17:31PM +0200, Pavel Grunt wrote: >> Just connect to the signal > > I'm tempted to ask "why?". I think it's recommended (more efficient) to > just override the vfunc directly when you can (ie when you derive a new >

Re: [virt-tools-list] [PATCH virt-viewer] display: Do not override size-allocate handler

2016-08-10 Thread Pavel Grunt
On Tue, 2016-08-09 at 17:44 +0200, Christophe Fergeau wrote: > On Tue, Aug 09, 2016 at 05:17:31PM +0200, Pavel Grunt wrote: > > > > Just connect to the signal > > I'm tempted to ask "why?". I think it's recommended (more efficient) to > just override the vfunc directly when you can (ie when you

Re: [virt-tools-list] [PATCH virt-viewer] display: Do not override size-allocate handler

2016-08-09 Thread Christophe Fergeau
On Tue, Aug 09, 2016 at 05:17:31PM +0200, Pavel Grunt wrote: > Just connect to the signal I'm tempted to ask "why?". I think it's recommended (more efficient) to just override the vfunc directly when you can (ie when you derive a new widget) rather than connecting to a signal. Christophe

[virt-tools-list] [PATCH virt-viewer] display: Do not override size-allocate handler

2016-08-09 Thread Pavel Grunt
Just connect to the signal --- src/virt-viewer-display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/virt-viewer-display.c b/src/virt-viewer-display.c index 2dbaba1..20ae9af 100644 --- a/src/virt-viewer-display.c +++ b/src/virt-viewer-display.c @@ -91,7 +91,6 @@