Re: [virt-tools-list] [PATCH virt-viewer] iso-dialog: Avoid crash when closing dialog early

2017-02-09 Thread Eduardo Lima (Etrunko)
Looks like this v2 never made to the list? I am sending it again. On 03/02/17 15:28, Eduardo Lima (Etrunko) wrote: > We must take into account that users can close the dialog at anytime, > even during an operation of fetch or set ISO has not been finished. This > will cause the callbacks for

Re: [virt-tools-list] [PATCH virt-viewer] iso-dialog: Avoid crash when closing dialog early

2017-02-06 Thread Pavel Grunt
On Mon, 2017-02-06 at 18:04 +0100, Christophe Fergeau wrote: > On Mon, Feb 06, 2017 at 05:55:58PM +0100, Pavel Grunt wrote: > > On Fri, 2017-02-03 at 14:42 -0200, Eduardo Lima (Etrunko) wrote: > > > On 03/02/17 14:34, Christophe Fergeau wrote: > > > > Hey, > > > > > > > > On Thu, Jan 26, 2017 at

Re: [virt-tools-list] [PATCH virt-viewer] iso-dialog: Avoid crash when closing dialog early

2017-02-06 Thread Christophe Fergeau
On Mon, Feb 06, 2017 at 05:55:58PM +0100, Pavel Grunt wrote: > On Fri, 2017-02-03 at 14:42 -0200, Eduardo Lima (Etrunko) wrote: > > On 03/02/17 14:34, Christophe Fergeau wrote: > > > Hey, > > > > > > On Thu, Jan 26, 2017 at 06:01:23PM -0200, Eduardo Lima (Etrunko) > > > wrote: > > > > We must

Re: [virt-tools-list] [PATCH virt-viewer] iso-dialog: Avoid crash when closing dialog early

2017-02-06 Thread Pavel Grunt
On Fri, 2017-02-03 at 14:42 -0200, Eduardo Lima (Etrunko) wrote: > On 03/02/17 14:34, Christophe Fergeau wrote: > > Hey, > > > > On Thu, Jan 26, 2017 at 06:01:23PM -0200, Eduardo Lima (Etrunko) > > wrote: > > > We must take into account that users can close the dialog at > > > anytime, > > > even

[virt-tools-list] [PATCH virt-viewer] iso-dialog: Avoid crash when closing dialog early

2017-02-03 Thread Eduardo Lima (Etrunko)
We must take into account that users can close the dialog at anytime, even during an operation of fetch or set ISO has not been finished. This will cause the callbacks for those operations to be invoked with an invalid object, crashing the application. To fix this issue we need to pass a

Re: [virt-tools-list] [PATCH virt-viewer] iso-dialog: Avoid crash when closing dialog early

2017-02-03 Thread Eduardo Lima (Etrunko)
On 03/02/17 14:34, Christophe Fergeau wrote: > Hey, > > On Thu, Jan 26, 2017 at 06:01:23PM -0200, Eduardo Lima (Etrunko) wrote: >> We must take into account that users can close the dialog at anytime, >> even during an operation of fetch or set ISO has not been finished. This >> will cause the

Re: [virt-tools-list] [PATCH virt-viewer] iso-dialog: Avoid crash when closing dialog early

2017-02-03 Thread Christophe Fergeau
Hey, On Thu, Jan 26, 2017 at 06:01:23PM -0200, Eduardo Lima (Etrunko) wrote: > We must take into account that users can close the dialog at anytime, > even during an operation of fetch or set ISO has not been finished. This > will cause the callbacks for those operations to be invoked with an >

[virt-tools-list] [PATCH virt-viewer] iso-dialog: Avoid crash when closing dialog early

2017-01-26 Thread Eduardo Lima (Etrunko)
We must take into account that users can close the dialog at anytime, even during an operation of fetch or set ISO has not been finished. This will cause the callbacks for those operations to be invoked with an invalid object, crashing the application. To fix this issue we need to pass a