Re: [virt-tools-list] [PATCH virt-viewer] window: Factor out common code for toolbar items

On Tue, 2016-06-28 at 16:30 -0300, Eduardo Lima (Etrunko) wrote: > On 06/28/2016 12:16 PM, Fabiano Fidêncio wrote: > > > > On Tue, Jun 28, 2016 at 5:10 PM, Pavel Grunt wrote: > > > > > > Create toolbar widget in the loop > > > > NACK from my side. > > There is any gain on

Re: [virt-tools-list] [PATCH virt-viewer] window: Factor out common code for toolbar items

On 06/28/2016 12:16 PM, Fabiano Fidêncio wrote: > On Tue, Jun 28, 2016 at 5:10 PM, Pavel Grunt wrote: >> Create toolbar widget in the loop > > NACK from my side. > There is any gain on re-factoring a code that will be removed as soon > as we do the release. > Actually, it just

Re: [virt-tools-list] [PATCH virt-viewer] window: Factor out common code for toolbar items

On Tue, Jun 28, 2016 at 5:10 PM, Pavel Grunt wrote: > Create toolbar widget in the loop NACK from my side. There is any gain on re-factoring a code that will be removed as soon as we do the release. Actually, it just makes my life harder in order to rebase Sagar's patches on

[virt-tools-list] [PATCH virt-viewer] window: Factor out common code for toolbar items

Create toolbar widget in the loop --- src/virt-viewer-window.c | 121 --- 1 file changed, 83 insertions(+), 38 deletions(-) diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c index 1ebb423..b276ae8 100644 --- a/src/virt-viewer-window.c