Re: [virt-tools-list] [PATCH virt-viewer 2/3] ovirt-foreign-menu: Fetch host, cluster and data center information

2017-09-08 Thread Christophe Fergeau
Hey, It would be nice to have an explanation in the commit log explaining *why* we need that. This might be explained in these bug reports, but we should not expect people to follow these links to understand why we needed to add this. Apart from this, the patch looks good to me. Christophe On Fr

[virt-tools-list] [PATCH virt-viewer 2/3] ovirt-foreign-menu: Fetch host, cluster and data center information

2017-08-04 Thread Eduardo Lima (Etrunko)
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1427467 https://bugzilla.redhat.com/show_bug.cgi?id=1428401 Signed-off-by: Eduardo Lima (Etrunko) --- src/ovirt-foreign-menu.c | 141 +++ 1 file changed, 141 insertions(+) diff --git a/src/