Re: [virt-tools-list] [PATCH virt-viewer 6/9] iso-dialog: Implement functionality provided by oVirt foreign menu

2017-01-19 Thread Christophe Fergeau
On Thu, Jan 19, 2017 at 12:44:15PM -0200, Eduardo Lima (Etrunko) wrote: > On 19/01/17 10:48, Christophe Fergeau wrote: > > The issues pointed out in > > https://www.redhat.com/archives/virt-tools-list/2017-January/msg00039.html > > do not seem to have been addressed? > > > > True, I did overlook

Re: [virt-tools-list] [PATCH virt-viewer 6/9] iso-dialog: Implement functionality provided by oVirt foreign menu

2017-01-19 Thread Eduardo Lima (Etrunko)
On 19/01/17 10:48, Christophe Fergeau wrote: > The issues pointed out in > https://www.redhat.com/archives/virt-tools-list/2017-January/msg00039.html > do not seem to have been addressed? > True, I did overlook that message, thanks for the reminder. I changed the code so the spinner stops and set

Re: [virt-tools-list] [PATCH virt-viewer 6/9] iso-dialog: Implement functionality provided by oVirt foreign menu

2017-01-19 Thread Christophe Fergeau
The issues pointed out in https://www.redhat.com/archives/virt-tools-list/2017-January/msg00039.html do not seem to have been addressed? Did you try merging the patches from "Introduce ISO List dialog" to "Run iso-dialog when 'Change CD' menu is activated" (without the headerbar change)? I think t

[virt-tools-list] [PATCH virt-viewer 6/9] iso-dialog: Implement functionality provided by oVirt foreign menu

2017-01-18 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- src/remote-viewer-iso-list-dialog.c| 204 - src/resources/ui/remote-viewer-iso-list.ui | 5 +- 2 files changed, 205 insertions(+), 4 deletions(-) diff --git a/src/remote-viewer-iso-list-dialog.c b/src/remote-viewer-