Re: [virt-tools-list] [PATCH virt-viewer v2] Update usage of GObject private structures

2019-02-13 Thread Eduardo Lima (Etrunko)
On 2/11/19 3:31 PM, Daniel P. Berrangé wrote: > On Mon, Feb 11, 2019 at 06:24:37PM +0100, Christophe Fergeau wrote: >> Hey, >> >> Looks good to me, 2 comments below: >> >> On Thu, Feb 07, 2019 at 10:54:58AM -0200, Eduardo Lima (Etrunko) wrote: >> >>> diff --git a/src/remote-viewer-iso-list-dialog.c

Re: [virt-tools-list] [PATCH virt-viewer v2] Update usage of GObject private structures

2019-02-11 Thread Daniel P . Berrangé
On Mon, Feb 11, 2019 at 06:24:37PM +0100, Christophe Fergeau wrote: > Hey, > > Looks good to me, 2 comments below: > > On Thu, Feb 07, 2019 at 10:54:58AM -0200, Eduardo Lima (Etrunko) wrote: > > > diff --git a/src/remote-viewer-iso-list-dialog.c > > b/src/remote-viewer-iso-list-dialog.c > > ind

Re: [virt-tools-list] [PATCH virt-viewer v2] Update usage of GObject private structures

2019-02-11 Thread Christophe Fergeau
Hey, Looks good to me, 2 comments below: On Thu, Feb 07, 2019 at 10:54:58AM -0200, Eduardo Lima (Etrunko) wrote: > diff --git a/src/remote-viewer-iso-list-dialog.c > b/src/remote-viewer-iso-list-dialog.c > index 3505211..8e25b72 100644 > --- a/src/remote-viewer-iso-list-dialog.c > +++ b/src/rem

[virt-tools-list] [PATCH virt-viewer v2] Update usage of GObject private structures

2019-02-07 Thread Eduardo Lima (Etrunko)
New functions and macros have been added in glib 2.38 to better handle this case. https://gitlab.gnome.org/GNOME/glib/blob/c8de2b11bbbf5705ee20bf68d0c11e455b441312/NEWS The old method is being deprecated as of version 2.58. https://gitlab.gnome.org/GNOME/glib/merge_requests/7/commits Signed-off