Re: [virt-tools-list] [PATCH virt-viewer v3] remote-viewer: Show authentication dialog again if in kiosk mode and connecting to ovirt

2017-06-08 Thread Victor Toso
Hi, On Thu, Jun 08, 2017 at 06:51:01PM -0300, Eduardo Lima (Etrunko) wrote: > On 08/06/17 18:41, Victor Toso wrote: > > Hi, > > > > I would try to short a little bit the shortlog although is very clear. > > > > Maybe from > > "remote-viewer: Show authentication dialog again if in kiosk mode and

Re: [virt-tools-list] [PATCH virt-viewer v3] remote-viewer: Show authentication dialog again if in kiosk mode and connecting to ovirt

2017-06-08 Thread Eduardo Lima (Etrunko)
On 08/06/17 18:41, Victor Toso wrote: > Hi, > > I would try to short a little bit the shortlog although is very clear. > > Maybe from > "remote-viewer: Show authentication dialog again if in kiosk mode and > connecting to ovirt" > > to > > "remote-viewer: Show auth dialog on kiosk mode if conne

Re: [virt-tools-list] [PATCH virt-viewer v3] remote-viewer: Show authentication dialog again if in kiosk mode and connecting to ovirt

2017-06-08 Thread Victor Toso
Hi, I would try to short a little bit the shortlog although is very clear. Maybe from "remote-viewer: Show authentication dialog again if in kiosk mode and connecting to ovirt" to "remote-viewer: Show auth dialog on kiosk mode if connecting to ovirt" Up to you if you want to change it. On Thu

[virt-tools-list] [PATCH virt-viewer v3] remote-viewer: Show authentication dialog again if in kiosk mode and connecting to ovirt

2017-06-08 Thread Eduardo Lima (Etrunko)
Similar to previous commits, but the case for connecting directly to ovirt:// URIs was not dealt with. Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161 Signed-off-by: Eduardo Lima (Etrunko) --- v3: *Really* fix loop conditional. --- src/remote-viewer.c | 14 ++ 1 file ch