Re: [virt-tools-list] [remote-viewer v1] remote-viewer: fix free on dangling pointer

2019-09-30 Thread Victor Toso
Hi, On Fri, Sep 27, 2019 at 04:21:58PM -0300, Eduardo Lima (Etrunko) wrote: > On 9/27/19 10:35 AM, Victor Toso wrote: > > static gboolean > > -create_ovirt_session(VirtViewerApp *app, const char *uri, GError **err) > > +create_ovirt_session(VirtViewerApp *app, GError **err) > > { > >

Re: [virt-tools-list] [remote-viewer v1] remote-viewer: fix free on dangling pointer

2019-09-27 Thread Eduardo Lima (Etrunko)
On 9/27/19 10:35 AM, Victor Toso wrote: From: Victor Toso On remote_viewer_session_connected() we are passing a dup of URI of connection and freeing it afterwards. Problem is, we don't disconnect from listening "session-connected" and on an eventual second emission of this signal,

[virt-tools-list] [remote-viewer v1] remote-viewer: fix free on dangling pointer

2019-09-27 Thread Victor Toso
From: Victor Toso On remote_viewer_session_connected() we are passing a dup of URI of connection and freeing it afterwards. Problem is, we don't disconnect from listening "session-connected" and on an eventual second emission of this signal, remote-viewer crashes as seen in the backtrace below.