Cole Robinson writes:
> On 04/01/2015 09:13 AM, Giuseppe Scrivano wrote:
>> Cole Robinson writes:
>>
>>> ACK, but I'm surprised the test suite doesn't need tweaking. maybe we should
>>> extend a clone test to use the fake qemu URI so we can validate format
>>> copying
>>> in the output disk XM
On 04/01/2015 09:13 AM, Giuseppe Scrivano wrote:
> Cole Robinson writes:
>
>> ACK, but I'm surprised the test suite doesn't need tweaking. maybe we should
>> extend a clone test to use the fake qemu URI so we can validate format
>> copying
>> in the output disk XML
>
> as follow-up, I've added
Cole Robinson writes:
> ACK, but I'm surprised the test suite doesn't need tweaking. maybe we should
> extend a clone test to use the fake qemu URI so we can validate format copying
> in the output disk XML
as follow-up, I've added a test for the cloned disks. OK to push it?
Thanks,
Giuseppe
Cole Robinson writes:
> ACK, but I'm surprised the test suite doesn't need tweaking. maybe we should
> extend a clone test to use the fake qemu URI so we can validate format copying
> in the output disk XML
thanks for the review. I've pushed this for now, I'll take a look at a
possible test cas
On 03/31/2015 12:00 PM, Giuseppe Scrivano wrote:
> Signed-off-by: Giuseppe Scrivano
> ---
> virtinst/cloner.py | 6 --
> virtinst/storage.py | 8 +---
> 2 files changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/virtinst/cloner.py b/virtinst/cloner.py
> index 68a5786..c533e7e 100
Signed-off-by: Giuseppe Scrivano
---
virtinst/cloner.py | 6 --
virtinst/storage.py | 8 +---
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/virtinst/cloner.py b/virtinst/cloner.py
index 68a5786..c533e7e 100644
--- a/virtinst/cloner.py
+++ b/virtinst/cloner.py
@@ -1,5 +1,
