Re: [virt-tools-list] [virt-manager PATCH 5/5] details: Set tooltip on config-remove while it's not available

2018-08-05 Thread Cole Robinson
Thanks for the patch. We can simplify code here and make this mistake more obvious with a helper function. I'm pushing the attached commit to add a _disable_device_remove helper that takes only a tooltip as an argument, will save having to track can_remove. Please adapt patch #2 and this one

[virt-tools-list] [virt-manager PATCH 5/5] details: Set tooltip on config-remove while it's not available

2018-07-18 Thread Lin Ma
It informs users that why the device can't be removed. Signed-off-by: Lin Ma --- virtManager/details.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/virtManager/details.py b/virtManager/details.py index cb298f3f..7308cde3 100644 --- a/virtManager/details.py +++