On Fri, 2017-02-10 at 19:18 +0100, Christophe de Dinechin wrote:
> > On 10 Feb 2017, at 15:50, Pavel Grunt wrote:
> >
> > On Thu, 2017-02-09 at 18:46 +0100, Christophe de Dinechin wrote:
> > > I tend to agree. I don’t see how any legitimate GError * (from
> > > g_error_new or
> On 10 Feb 2017, at 15:50, Pavel Grunt wrote:
>
> On Thu, 2017-02-09 at 18:46 +0100, Christophe de Dinechin wrote:
>> I tend to agree. I don’t see how any legitimate GError * (from
>> g_error_new or the like) would have a NULL message. So this is
>> really defensive coding.
On Fri, Feb 10, 2017 at 03:50:36PM +0100, Pavel Grunt wrote:
> On Thu, 2017-02-09 at 18:46 +0100, Christophe de Dinechin wrote:
> > I tend to agree. I don’t see how any legitimate GError * (from
> > g_error_new or the like) would have a NULL message. So this is
> > really defensive coding.
> >
>
On Thu, 2017-02-09 at 18:46 +0100, Christophe de Dinechin wrote:
> I tend to agree. I don’t see how any legitimate GError * (from
> g_error_new or the like) would have a NULL message. So this is
> really defensive coding.
>
nothing prevents calling g_error_new with a NULL message :) I know it
is
I tend to agree. I don’t see how any legitimate GError * (from g_error_new or
the like) would have a NULL message. So this is really defensive coding.
Alternate solution would be to assert, but I don’t like killing the viewer if
this ever happens.
Christophe
> On 9 Feb 2017, at 17:44,
...now I see that this was discussed in the review thread for your
other patch. I still think this should not be necessary. If error is
non-NULL, it should be guaranteed to have a non-NULL message.
Jonathon
On Thu, 2017-02-09 at 10:40 -0600, Jonathon Jongsma wrote:
> Out of curiosity, what was
Out of curiosity, what was the situation where you encountered a non-
NULL error with a NULL error->message? It doesn't seem like this should
be necessary.
Jonathon
On Thu, 2017-02-09 at 13:02 +0100, Christophe de Dinechin wrote:
> ---
> src/ovirt-foreign-menu.c | 14
---
src/ovirt-foreign-menu.c | 14 +++---
src/remote-viewer.c| 22 --
src/virt-viewer-app.c | 14 +++---
src/virt-viewer-file-transfer-dialog.c | 2 +-
src/virt-viewer-file.c | 6 +++---