Similar to the previous commit, the ISO dialog will fetch the result
asynchronously, rather than relying on the "notify::files" signal from
OvirtForeignMenu object. It also enables error to be shown if anything
goes wrong.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-fore
From: Christophe Fergeau
This is done with the new ovirt_foreign_menu_set_current_iso_name_async
function. Also, an error dialog will be shown in case anything goes
wrong with the async method.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c| 40
Signed-off-by: Eduardo Lima (Etrunko)
---
po/POTFILES.in | 2 +
src/Makefile.am| 3 +
src/remote-viewer-iso-list-dialog.c| 106
src/remote-viewer-iso-list-dialog.h| 58 +++
src/resources/ui
Signed-off-by: Eduardo Lima (Etrunko)
---
src/resources/ui/virt-viewer.ui | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui
index 6e3c5ad..af3ae46 100644
--- a/src/resources/ui/virt-viewer.ui
With the new ISO dialog, the user triggers the refresh manually.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 23 +++
1 file changed, 3 insertions(+), 20 deletions(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index a51f2c9
Back to work on this feature after some time away. In this version we
replace the notify signals with asynchronous callbacks using GTask API.
Christophe Fergeau (1):
ovirt-foreign-menu: Set new ISO name using GTask API
Eduardo Lima (Etrunko) (11):
ovirt-foreign-menu: Remove timer used to
Signed-off-by: Eduardo Lima (Etrunko)
---
src/resources/ui/virt-viewer.ui | 1 +
src/virt-viewer-window.c| 24
2 files changed, 25 insertions(+)
diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui
index af3ae46..e9609ec 100644
--- a
When user presses the Refresh button in ISO dialog, the list is cleared, and
currently, the only way it is informed of the new list is by the notify signal.
The same applies when an error occurs while trying to change the current ISO.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer-iso-list-dialog.c| 180 -
src/resources/ui/remote-viewer-iso-list.ui | 5 +-
2 files changed, 181 insertions(+), 4 deletions(-)
diff --git a/src/remote-viewer-iso-list-dialog.c
b/src/remote-viewer
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 49 ++--
src/ovirt-foreign-menu.h | 5 -
2 files changed, 39 insertions(+), 15 deletions(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index 565ef22
With this commit, we finish cleaning up ovirt foreign menu code, which
only deals with data, leaving the UI bits to be handled properly in the
new ISO list dialog.
This patch also updates remote-viewer to reflect the change.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c
s gone too.
Signed-off-by: Eduardo Lima (Etrunko)
---
configure.ac | 4 +-
src/remote-viewer-iso-list-dialog.c| 31 +--
src/resources/ui/remote-viewer-iso-list.ui | 87 +++---
3 files changed, 60 insertions(+), 62 deletions(-)
di
On 11/02/2016 03:20 PM, Christophe Fergeau wrote:
> On Wed, Nov 02, 2016 at 06:15:45PM +0100, Christophe Fergeau wrote:
>> This does not seem to apply on top of git master.
>
> Ah, just minor merge conflict in src/Makefile.am, easy to fix locally ;)
>
The file transfer dialog has been merged aft
On 11/01/2016 06:33 PM, Eduardo Lima (Etrunko) wrote:
> From: Christophe Fergeau
>
> This is done with the new ovirt_foreign_menu_set_current_iso_name_async
> function. Also, an error dialog will be shown in case anything goes
> wrong with the async method.
>
> Signed
From: Christophe Fergeau
This is done with the new ovirt_foreign_menu_set_current_iso_name_async
function. Also, an error dialog will be shown in case anything goes
wrong with the async method.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c| 53
The OvirtForeignMenu pointer is needed by the new ISO list dialog, and
we make it acessible via property to avoid interdependency between
objects.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer-iso-list-dialog.c | 31 +++
src/remote-viewer-iso-list
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 9 -
src/ovirt-foreign-menu.h | 2 ++
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index 6892f0d..e244719 100644
--- a/src/ovirt-foreign-menu.c
+++ b
Similar to the previous commit, the ISO dialog will fetch the result
asynchronously, rather than relying on the "notify::files" signal from
OvirtForeignMenu object. It also enables error to be shown if anything
goes wrong.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-me
With this commit, we finish cleaning up ovirt foreign menu code, which
only deals with data, leaving the UI bits to be handled properly in the
new ISO list dialog.
This patch also updates remote-viewer to reflect the change.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c
The #endif is closing a #ifdef HAVE_OVIRT block, while another one is
opened right next, so there is no need to have those lines. Also, due to
the large amount of source code in between, add a small comment on the
last #endif to identify what it refers to.
Signed-off-by: Eduardo Lima (Etrunko
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer-iso-list-dialog.c| 205 -
src/resources/ui/remote-viewer-iso-list.ui | 5 +-
2 files changed, 206 insertions(+), 4 deletions(-)
diff --git a/src/remote-viewer-iso-list-dialog.c
b/src/remote-viewer
s gone too.
Signed-off-by: Eduardo Lima (Etrunko)
---
configure.ac | 4 +-
src/remote-viewer-iso-list-dialog.c| 31 +--
src/resources/ui/remote-viewer-iso-list.ui | 87 +++---
3 files changed, 60 insertions(+), 62 deletions(-)
di
Also makes 'Change CD' menu item a submenu under 'File' toplevel menu
Signed-off-by: Eduardo Lima (Etrunko)
---
src/resources/ui/virt-viewer.ui | 19 ++-
src/virt-viewer-window.c| 37 +
2 files changed, 47 insert
This is done with the new ovirt_foreign_menu_set_current_iso_name_async
function.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 117 ++-
src/ovirt-foreign-menu.h | 10
2 files changed, 96 insertions(+), 31 deletions
Signed-off-by: Eduardo Lima (Etrunko)
---
po/POTFILES.in | 2 +
src/Makefile.am| 3 +
src/remote-viewer-iso-list-dialog.c| 106
src/remote-viewer-iso-list-dialog.h| 58 +++
src/resources/ui
Final version of this series, this time I changed the order of the patches
so that the set/get ISO names port to GTask API will come first, and only
after that the dialog is introduced. Finally, the last patch will remove
the old code.
Eduardo Lima (Etrunko) (10):
remote-viewer: Extend #ifdef
On 17/01/17 13:57, Christophe Fergeau wrote:
> On Fri, Jan 13, 2017 at 07:11:05PM -0200, Eduardo Lima (Etrunko) wrote:
>> Similar to the previous commit, the ISO dialog will fetch the result
>> asynchronously, rather than relying on the "notify::files" signal from
>&
Similar to the previous commit, the ISO dialog will fetch the result
asynchronously, rather than relying on the "notify::files" signal from
OvirtForeignMenu object. It also enables error to be shown if anything
goes wrong.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-me
On 17/01/17 14:00, Christophe Fergeau wrote:
> On Fri, Jan 13, 2017 at 07:11:07PM -0200, Eduardo Lima (Etrunko) wrote:
>> The OvirtForeignMenu pointer is needed by the new ISO list dialog, and
>> we make it acessible via property to avoid interdependency between
>> objects
On 18/01/17 09:53, Eduardo Lima (Etrunko) wrote:
> On 17/01/17 14:00, Christophe Fergeau wrote:
>> On Fri, Jan 13, 2017 at 07:11:07PM -0200, Eduardo Lima (Etrunko) wrote:
>>> The OvirtForeignMenu pointer is needed by the new ISO list dialog, and
>>> we make it aces
On 17/01/17 14:01, Christophe Fergeau wrote:
> On Fri, Jan 13, 2017 at 07:11:09PM -0200, Eduardo Lima (Etrunko) wrote:
>> Signed-off-by: Eduardo Lima (Etrunko)
>> ---
>> src/remote-viewer-iso-list-dialog.c| 205
>> -
>> s
On 18/01/17 10:53, Christophe Fergeau wrote:
> On Wed, Jan 18, 2017 at 10:08:42AM -0200, Eduardo Lima (Etrunko) wrote:
>> On 18/01/17 09:53, Eduardo Lima (Etrunko) wrote:
>>> On 17/01/17 14:00, Christophe Fergeau wrote:
>>>> On Fri, Jan 13, 2017 at 07:11:07PM -0200
On 18/01/17 11:06, Christophe Fergeau wrote:
> On Wed, Jan 18, 2017 at 10:56:59AM -0200, Eduardo Lima (Etrunko) wrote:
>> On 18/01/17 10:53, Christophe Fergeau wrote:
>>> On Wed, Jan 18, 2017 at 10:08:42AM -0200, Eduardo Lima (Etrunko) wrote:
>>>> On 18/01/17 09:53
On 17/01/17 13:51, Christophe Fergeau wrote:
> Acked-by: Christophe Fergeau
Pushed, thanks
>
> On Fri, Jan 13, 2017 at 07:11:03PM -0200, Eduardo Lima (Etrunko) wrote:
>> The #endif is closing a #ifdef HAVE_OVIRT block, while another one is
>> opened right next, so there is
Signed-off-by: Eduardo Lima (Etrunko)
---
po/POTFILES.in | 2 +
src/Makefile.am| 3 +
src/remote-viewer-iso-list-dialog.c| 121 ++
src/remote-viewer-iso-list-dialog.h| 58 +++
src/resources
The OvirtForeignMenu pointer is needed by the new ISO list dialog, and
we make it acessible via property to avoid interdependency between
objects.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer.c | 37 +
1 file changed, 37 insertions(+)
diff
This is done with the new ovirt_foreign_menu_set_current_iso_name_async
function.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 117 ++-
src/ovirt-foreign-menu.h | 10
2 files changed, 96 insertions(+), 31 deletions
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer-iso-list-dialog.c| 204 -
src/resources/ui/remote-viewer-iso-list.ui | 5 +-
2 files changed, 205 insertions(+), 4 deletions(-)
diff --git a/src/remote-viewer-iso-list-dialog.c
b/src/remote-viewer
Similar to the previous commit, the ISO dialog will fetch the result
asynchronously, rather than relying on the "notify::files" signal from
OvirtForeignMenu object. It also enables error to be shown if anything
goes wrong.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-me
s gone too.
Signed-off-by: Eduardo Lima (Etrunko)
---
configure.ac | 4 +-
src/remote-viewer-iso-list-dialog.c| 31 +--
src/resources/ui/remote-viewer-iso-list.ui | 87 +++---
3 files changed, 60 insertions(+), 62 deletions(-)
di
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 11 +--
src/ovirt-foreign-menu.h | 2 ++
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index 50a8ea6..e2216a2 100644
--- a/src/ovirt-foreign-menu.c
Also makes 'Change CD' menu item a submenu under 'File' toplevel menu
Signed-off-by: Eduardo Lima (Etrunko)
---
src/resources/ui/virt-viewer.ui | 19 ++-
src/virt-viewer-window.c| 37 +
2 files changed, 47 insert
With this commit, we finish cleaning up ovirt foreign menu code, which
only deals with data, leaving the UI bits to be handled properly in the
new ISO list dialog.
This patch also updates remote-viewer to reflect the change.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c
rdingly.
Finally, I split the code in "Make ovirt-foreign-menu a property" and
moved that one patch before the "Introduce ISO List dialog".
Regards, Eduardo.
Eduardo Lima (Etrunko) (9):
ovirt-foreign-menu: Set new ISO name using GTask API
ovirt-foreign-menu: Fetch ISO nam
On 18/01/17 15:45, Christophe Fergeau wrote:
> On Wed, Jan 18, 2017 at 12:16:53PM -0200, Eduardo Lima (Etrunko) wrote:
>> Similar to the previous commit, the ISO dialog will fetch the result
>> asynchronously, rather than relying on the "notify::files" signal from
>&
On 19/01/17 10:55, Christophe Fergeau wrote:
> On Wed, Jan 18, 2017 at 12:16:56PM -0200, Eduardo Lima (Etrunko) wrote:
>> Signed-off-by: Eduardo Lima (Etrunko)
>> ---
>> src/ovirt-foreign-menu.c | 11 +--
>> src/ovirt-foreign-menu.h | 2 ++
>> 2 f
tches without problems.
> Christophe
>
> On Wed, Jan 18, 2017 at 12:16:57PM -0200, Eduardo Lima (Etrunko) wrote:
>> Signed-off-by: Eduardo Lima (Etrunko)
>> ---
>> src/remote-viewer-iso-list-dialog.c| 204
>> -
>> src/res
an 18, 2017 at 12:16:54PM -0200, Eduardo Lima (Etrunko) wrote:
>> The OvirtForeignMenu pointer is needed by the new ISO list dialog, and
>> we make it acessible via property to avoid interdependency between
>> objects.
>>
>> Signed-off-by
On 19/01/17 11:06, Christophe Fergeau wrote:
> On Wed, Jan 18, 2017 at 12:16:59PM -0200, Eduardo Lima (Etrunko) wrote:
>> Also makes 'Change CD' menu item a submenu under 'File' toplevel menu
>>
>> Signed-off-by: Eduardo Lima (Etrunko)
>&g
On 18/01/17 14:31, Christophe Fergeau wrote:
> On Wed, Jan 18, 2017 at 12:16:52PM -0200, Eduardo Lima (Etrunko) wrote:
>> This is done with the new ovirt_foreign_menu_set_current_iso_name_async
>> function.
>>
>> Signed-off-by: Eduardo Lima (Etrunko)
>> ---
&
On 18/01/17 15:45, Christophe Fergeau wrote:
> On Wed, Jan 18, 2017 at 12:16:53PM -0200, Eduardo Lima (Etrunko) wrote:
>> Similar to the previous commit, the ISO dialog will fetch the result
>> asynchronously, rather than relying on the "notify::files" signal from
>&
Signed-off-by: Eduardo Lima (Etrunko)
---
po/POTFILES.in | 2 +
src/Makefile.am| 3 +
src/remote-viewer-iso-list-dialog.c| 365 +
src/remote-viewer-iso-list-dialog.h| 58 +
src/resources
s gone too.
Signed-off-by: Eduardo Lima (Etrunko)
---
configure.ac | 4 +-
src/remote-viewer-iso-list-dialog.c| 31 +--
src/resources/ui/remote-viewer-iso-list.ui | 87 +++---
3 files changed, 60 insertions(+), 62 deletions(-)
di
Also addressed some comments, in special better UI behavior when there
is error fetching the ISO list.
Eduardo Lima (Etrunko) (5):
ovirt-foreign-menu: Add accessors for current iso and iso list
Introduce ISO List dialog
iso-dialog: Use header bar for buttons
Run ISO dialog when 'Change CD&
Also, to keep consistency around the codebase, changed the return value
of ovirt_foreign_menu_get_current_iso_name() from char * to gchar *.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 11 +--
src/ovirt-foreign-menu.h | 2 ++
2 files changed, 11 insertions
as an opaque GObject.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer.c | 37 +
src/resources/ui/virt-viewer.ui | 19 ++-
src/virt-viewer-window.c| 37 +
3 files changed, 84 insert
With this commit, we finish cleaning up ovirt foreign menu code, which
only deals with data, leaving the UI bits to be handled properly in the
new ISO list dialog.
This patch also updates remote-viewer to reflect the change.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c
On 20/01/17 13:16, Christophe Fergeau wrote:
>
> Acked-by: Christophe Fergeau
Pushed, thanks.
>
> On Thu, Jan 19, 2017 at 01:42:10PM -0200, Eduardo Lima (Etrunko) wrote:
>> Also, to keep consistency around the codebase, changed the return value
>> of ovirt_foreign_m
, 2017 at 01:42:11PM -0200, Eduardo Lima (Etrunko) wrote:
>> Signed-off-by: Eduardo Lima (Etrunko)
>> ---
>> po/POTFILES.in | 2 +
>> src/Makefile.am| 3 +
>> src/remote-viewer-iso-list-dialog.c| 365
&g
On 20/01/17 13:26, Fabiano Fidêncio wrote:
> On Fri, Jan 20, 2017 at 4:21 PM, Christophe Fergeau
> wrote:
>> I haven't looked at this patch at all, as I don't know what the plan is
>> for virt-viewer regarding gtk+ versions. It's easy to move last in the
>> series though. Would be nice if someone
In this version, I have addressed the comments on the ISO dialog code,
also providing a better message for that commit. Also, put the headerbar
patch at the end, as others were already acked and should be ready to
merge.
Eduardo Lima (Etrunko) (4):
Introduce ISO List dialog
Run ISO dialog
files in a treeview.
Signed-off-by: Eduardo Lima (Etrunko)
---
po/POTFILES.in | 2 +
src/Makefile.am| 3 +
src/remote-viewer-iso-list-dialog.c| 365 +
src/remote-viewer-iso-list-dialog.h| 58
With this commit, we finish cleaning up ovirt foreign menu code, which
only deals with data, leaving the UI bits to be handled properly in the
new ISO list dialog.
This patch also updates remote-viewer to reflect the change.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c
s gone too.
Signed-off-by: Eduardo Lima (Etrunko)
---
configure.ac | 4 +-
src/remote-viewer-iso-list-dialog.c| 31 +--
src/resources/ui/remote-viewer-iso-list.ui | 87 +++---
3 files changed, 60 insertions(+), 62 deletions(-)
di
as an opaque GObject.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer.c | 37 +
src/resources/ui/virt-viewer.ui | 19 ++-
src/virt-viewer-window.c| 37 +
3 files changed, 84 insert
On 24/01/17 09:11, Christophe Fergeau wrote:
> On Mon, Jan 23, 2017 at 05:28:14PM -0200, Eduardo Lima (Etrunko) wrote:
>> Also moves 'Change CD' menu item from the toplevel menu to a subitem
>> under 'File' toplevel menu.
>>
>> In order to avoid obje
GCancellable to the asynchronous
operations, so they can be cancelled if the dialog happens to get closed
before they complete.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer-iso-list-dialog.c | 30 +++---
1 file changed, 27 insertions(+), 3 deletions(-)
diff --git a
On 03/02/17 14:34, Christophe Fergeau wrote:
> Hey,
>
> On Thu, Jan 26, 2017 at 06:01:23PM -0200, Eduardo Lima (Etrunko) wrote:
>> We must take into account that users can close the dialog at anytime,
>> even during an operation of fetch or set ISO has not been finished. T
GCancellable to the asynchronous
operations, so they can be cancelled if the dialog happens to get closed
before they complete.
Signed-off-by: Eduardo Lima (Etrunko)
---
v2:
* Move call to g_cancellable_cancel() to response handler.
* Don't leak error objects if operation is cancelled.
---
src/r
With this patch the dialog now shows the host we are trying to connect to.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/virt-viewer-session-spice.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/virt-viewer-session-spice.c b/src/virt-viewer-session-spice.c
Acked-by: Eduardo Lima (Etrunko)
On 06/02/17 10:02, Pavel Grunt wrote:
> Fixes -Werror=format-security used when creating the rpm
> ---
> see:
> https://copr-be.cloud.fedoraproject.org/results/pgrunt/spice-upstream/fedora-25-x86_64/00507878-virt-viewer/build.log.gz
> ---
>
On 06/02/17 09:20, Pavel Grunt wrote:
> On Fri, 2017-02-03 at 16:11 -0200, Eduardo Lima (Etrunko) wrote:
>> With this patch the dialog now shows the host we are trying to
>> connect to.
>
> I would mention that we use the "host" property of SpiceSession
Okay, w
On 07/02/17 17:06, Pavel Grunt wrote:
> On Tue, 2017-02-07 at 16:29 -0200, Eduardo Lima (Etrunko) wrote:
>> On 06/02/17 09:20, Pavel Grunt wrote:
>>> On Fri, 2017-02-03 at 16:11 -0200, Eduardo Lima (Etrunko) wrote:
>>>> With this patch the dialog now shows the host we
check for error->message
before dereferencing it, but I don't really know what others think about it.
Reviewed-by: Eduardo Lima (Etrunko)
--
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etru...@redhat.com
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list
Looks like this v2 never made to the list? I am sending it again.
On 03/02/17 15:28, Eduardo Lima (Etrunko) wrote:
> We must take into account that users can close the dialog at anytime,
> even during an operation of fetch or set ISO has not been finished. This
> will cause the call
GCancellable to the asynchronous
operations, so they can be cancelled if the dialog happens to get closed
before they complete.
Signed-off-by: Eduardo Lima (Etrunko)
---
v2:
* Move call to g_cancellable_cancel() to response handler.
* Don't leak error objects if operation is cancelled.
---
src/r
On 09/02/17 15:13, Eduardo Lima (Etrunko) wrote:
> We must take into account that users can close the dialog at anytime,
> even during an operation of fetch or set ISO has not been finished. This
> will cause the callbacks for those operations to be invoked with an
> invalid object,
With this patch the dialog now shows the host we are connecting to.
Signed-off-by: Eduardo Lima (Etrunko)
---
v2: Use proper uri if connecting via proxy.
---
src/virt-viewer-session-spice.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/virt-viewer-session
For this one, we use the application version as the subtitle.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/resources/ui/virt-viewer-about.ui | 20 ++--
src/virt-viewer-window.c | 9 ++---
2 files changed, 20 insertions(+), 9 deletions(-)
diff --git a/src
distro.
Using GtkHeaderBar makes dialogs look cleaner and more 'modern', also
follow the style used by GNOME applications. In the near future,
virt-viewer main window could also make use of it, as we recently saw in
a series sent to this mailing list.
Eduardo Lima (Etrunko) (10):
This is the simplest dialog on the application, there was not much to
change here. In order to not leave a big amount of unused space on the
HeaderBar, we set the guest name as the subtitle.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/resources/ui/virt-viewer-guest-details.ui | 64
Just like the virt-viewer-connect dialog, the connect button has been
moved to the header bar. Additionally, the example text is now presented
as the subtitle.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer-connect.c | 20 +---
src/resources/ui/remote-viewer
Here we moved the connect button to the header bar. Unfortunately, I
could not find a "connect-symbolic" icon to be used here, so I ended up
with the stock icon.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/resources/ui/virt-viewer-vm-connection.ui | 83 +--
This is new version ships with GtkHeaderBar code, which we will require
for the dialogs on the application. In the future the main window could
also make use of this widget, following the style of other applications.
Signed-off-by: Eduardo Lima (Etrunko)
---
configure.ac | 4 ++--
1 file
We now display the current ISO as subtitle on the HeaderBar. On the
glade UI file, we get rid of the GtkAlignment object that was used to
put some space between the tree view and dialog buttons. The "Select
ISO" label is gone too.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-
This dialog changed very little when compared to the old version. I did
change the way widgets are organized within the dialog, as it now groups
the file selector together with the read-only checkbox.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/resources/ui/virt-viewer-preferences.ui | 103
We could get rid of the auxiliary text and present it as the subtitle of
the dialog, but this is handled by the widget itself. In this case, all
we have to do is to set the "use-headerbar" property, and like other
dialogs, the close button is not necessary anymore.
Signed-off-by: Ed
This dialog now presents the progress as a level bar, and also shows the
percentage as on the text. The cancel button is not necessary anymore,
because the all transfers are cancelled automatically when the dialog is
closed before they finish.
Signed-off-by: Eduardo Lima (Etrunko)
---
.../ui
The auxiliary text is now presented as the subtitle of the dialog
Signed-off-by: Eduardo Lima (Etrunko)
---
src/resources/ui/virt-viewer-auth.ui | 148 ---
src/virt-viewer-auth.c | 35 +
2 files changed, 86 insertions(+), 97 deletions
On 09/02/17 17:19, Pavel Grunt wrote:
> Hi Eduardo,
>
> On Thu, 2017-02-09 at 15:13 -0200, Eduardo Lima (Etrunko) wrote:
>> We must take into account that users can close the dialog at
>> anytime,
>> even during an operation of fetch or set ISO has not been finished
On 09/02/17 17:22, Pavel Grunt wrote:
> On Thu, 2017-02-09 at 15:32 -0200, Eduardo Lima (Etrunko) wrote:
>> With this patch the dialog now shows the host we are connecting to.
>>
>> Signed-off-by: Eduardo Lima (Etrunko)
> Acked-by: Pavel Grunt
Thanks, pushed.
>>
> goto retry_dialog;
> }
>
Sorry for starting this endless discussion about checking for
error->message, it has been shown that it is not necessary (TIL). As
this version addresses the comments of explicit checking, from Pavel,
it's an Ack.
On 16/02/17 10:06, Pavel Grunt wrote:
> Hi,
>
> On Thu, 2017-02-09 at 17:22 -0200, Eduardo Lima (Etrunko) wrote:
>> This whole series is the result of the initial idea of having the
>> new
>> iso-dialog to use this widget. Having it done only for the iso-
>> di
On 16/02/17 20:57, Daniel P. Berrange wrote:
> On Thu, Feb 16, 2017 at 11:05:13AM -0200, Eduardo Lima (Etrunko) wrote:
>> On 16/02/17 10:06, Pavel Grunt wrote:
>>> Hi,
>>>
>>> On Thu, 2017-02-09 at 17:22 -0200, Eduardo Lima (Etrunko) wrote:
>>>> Thi
On 16/02/17 20:57, Daniel P. Berrange wrote:
> On Thu, Feb 16, 2017 at 11:05:13AM -0200, Eduardo Lima (Etrunko) wrote:
>> On 16/02/17 10:06, Pavel Grunt wrote:
>>> Hi,
>>>
>>> On Thu, 2017-02-09 at 17:22 -0200, Eduardo Lima (Etrunko) wrote:
>>>> Thi
On 22/02/17 08:15, Daniel P. Berrange wrote:
> On Thu, Feb 16, 2017 at 10:57:52PM +, Daniel P. Berrange wrote:
>> On Thu, Feb 16, 2017 at 11:05:13AM -0200, Eduardo Lima (Etrunko) wrote:
>>> On 16/02/17 10:06, Pavel Grunt wrote:
>>>> Hi,
>>>>
>>&g
Hi Uri,
Victor has already sent and merged patches fixing those warnings. Can
you try with latest upstream if you still have warnings? By the way, I
like some parts of your patches a bit better than his, but as the
patches are already in, I am not sure if it is worth to change the code
once again.
https://twitter.com/codinghorror/status/506010907021828096
Acked-by: Eduardo Lima (Etrunko)
On 15/03/17 14:12, Pavel Grunt wrote:
> Related: rhbz#1399077
> ---
> src/virt-viewer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/virt-viewer.c b
On 29/03/17 07:36, Pavel Grunt wrote:
> It will enable some functionality, like zoom.
>
You could maybe elaborate a bit better, as you are also setting enabled
to FALSE it when the session gets disconnected.
Acked-by: Eduardo Lima (Etrunko)
> Regress
_set_hotkeys(VirtViewerApp *self, const gchar *hotkeys);
>
Acked-by: Eduardo Lima (Etrunko)
--
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etru...@redhat.com
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list
201 - 300 of 429 matches
Mail list logo
