On 04/04/17 08:55, Pavel Grunt wrote:
> On Wed, 2017-03-29 at 14:39 -0300, Eduardo Lima (Etrunko) wrote:
>> On 29/03/17 07:36, Pavel Grunt wrote:
>>> It will enable some functionality, like zoom.
>>>
>>
>> You could maybe elaborate a bit better, as you are
> warnings.
Meh, it seems that babysitting compilers are the rule nowadays. :/
Acked-by: Eduardo Lima (Etrunko)
>
> ovirt-foreign-menu.c: In function 'ovirt_foreign_menu_next_async_step':
> ovirt-foreign-menu.c:293:12: warning: this statement may fall thro
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161
Signed-off-by: Eduardo Lima (Etrunko)
---
src/virt-viewer-window.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c
index 867a7b0..ff22ded 100644
--- a/src
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161
Signed-off-by: Eduardo Lima (Etrunko)
---
src/virt-viewer-app.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
index f0fcf21..1975af0 100644
--- a/src/virt-viewer-app.c
+++ b/src
On 21/05/17 04:23, Xiaodai Wang wrote:
>
> - Original Message -
>> From: "Victor Toso"
>> To: "Eduardo Lima (Etrunko)"
>> Cc: virt-tools-list@redhat.com
>> Sent: Saturday, May 20, 2017 5:26:29 AM
>> Subject: Re: [virt-tools-list]
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161
Signed-off-by: Eduardo Lima (Etrunko)
---
v2: Retry authentication dialog if cancelled instead of quitting the
application.
---
src/virt-viewer-app.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/virt-viewer-app.c b
Regression since commit cc455b7f916110d7cfae6b7af753349e070c9494.
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161
Signed-off-by: Eduardo Lima (Etrunko)
---
src/virt-viewer-window.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/virt-viewer-window.c
Pushed, thanks
On 31/05/17 10:40, Victor Toso wrote:
> Hi,
>
> On Wed, May 31, 2017 at 10:23:16AM -0300, Eduardo Lima (Etrunko) wrote:
>> Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161
>>
>> Signed-off-by: Eduardo Lima (Etrunko)
>
> Wo
Pushed, thanks.
On 31/05/17 10:27, Victor Toso wrote:
> On Wed, May 31, 2017 at 10:23:15AM -0300, Eduardo Lima (Etrunko) wrote:
>> Regression since commit cc455b7f916110d7cfae6b7af753349e070c9494.
>>
>> Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161
>>
>
On 02/06/17 09:57, Pavel Grunt wrote:
> On Fri, 2017-06-02 at 14:05 +0200, Victor Toso wrote:
>> From: Victor Toso
>>
>> Mainly an issue for kiosk mode.
>>
>> Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161
>> Signed-off-by: Victor Toso
>> ---
>> src/virt-viewer-session-spice.c | 4
On 05/06/17 09:12, Victor Toso wrote:
> On Fri, Jun 02, 2017 at 11:59:04AM -0300, Eduardo Lima (Etrunko) wrote:
>> On 02/06/17 09:57, Pavel Grunt wrote:
>>> On Fri, 2017-06-02 at 14:05 +0200, Victor Toso wrote:
>>>> From: Victor Toso
>>>>
>>>
time.
I did really not see anything wrong in showing the message dialog if
authentication is canceled, but now that we have this feature in, we
should make the behavior consistent for both SPICE and VNC.
Acked-by: Eduardo Lima (Etrunko)
--
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedH
On 08/06/17 10:38, Victor Toso wrote:
> Hi,
>
> On Thu, Jun 08, 2017 at 03:08:02PM +0200, Pavel Grunt wrote:
>> Use .png as the default
>>
>> Related: rhbz#1455832
>
> Small clarification of the rationale behind would be good (#1455832) -
> Still, not a full solution, is it?
>
> This will check
Similar to previous commits, but the case for connecting directly to
ovirt:// URIs was not dealt with.
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions
On 08/06/17 18:00, Eduardo Lima (Etrunko) wrote:
> Similar to previous commits, but the case for connecting directly to
> ovirt:// URIs was not dealt with.
NACK! While it does work for kiosk mode, it will never get past from the
dialog in non-kiosk.
--
Eduardo de Barros Lima (Etrunko)
So
Similar to previous commits, but the case for connecting directly to
ovirt:// URIs was not dealt with.
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161
Signed-off-by: Eduardo Lima (Etrunko)
---
v2: Fix loop conditional
---
src/remote-viewer.c | 14 ++
1 file changed, 10
On 08/06/17 18:21, Eduardo Lima (Etrunko) wrote:
> Similar to previous commits, but the case for connecting directly to
> ovirt:// URIs was not dealt with.
>
> Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161
>
> Signed-off-by: Eduardo Lima (Etrunko)
> ---
>
Similar to previous commits, but the case for connecting directly to
ovirt:// URIs was not dealt with.
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161
Signed-off-by: Eduardo Lima (Etrunko)
---
v3: *Really* fix loop conditional.
---
src/remote-viewer.c | 14 ++
1 file
On 08/06/17 18:19, Victor Toso wrote:
> On Thu, Jun 08, 2017 at 06:00:39PM -0300, Eduardo Lima (Etrunko) wrote:
>> Similar to previous commits, but the case for connecting directly to
>> ovirt:// URIs was not dealt with.
>>
>> Related: https://bugzilla.redhat.
remote-viewer: Show auth dialog on kiosk mode if connecting to ovirt"
>
> Up to you if you want to change it.
I would like to keep "again" word, but I could indeed actually use
"auth" instead of "authentication".
>
> On Thu, Jun 08, 2017 at 06:30:19PM -
On 09/06/17 13:07, Victor Toso wrote:
> From: Victor Toso
>
> Otherwise, in kiosk mode, it'll be hidden from user.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1459800
>
> Signed-off-by: Victor Toso
Acked-by: Eduardo Lima (Etrunko)
> ---
>
On 23/06/17 12:30, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> We are going to make empty/fake VirtViewerFile.
>
> Signed-off-by: Marc-André Lureau
> ---
> src/virt-viewer-file.c | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/src/virt-vie
On 23/06/17 12:30, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The function was removed in commit
> 05333f0e93fb988c2fd9302e67671490941aedb0.
Acked-by: Eduardo Lima (Etrunko)
>
> Signed-off-by: Marc-André Lureau
> ---
> src/virt-viewer-session.h
On 23/06/17 12:30, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> If the dbus-ctrl property is set, we should call open_uri() without
> guri set.
>
My general feeling is that this patch could be merged with the option
parsing on the follow up patch, while that one should split
On 23/06/17 12:30, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
Acked-by: Eduardo Lima (Etrunko)
> Signed-off-by: Marc-André Lureau
> ---
> src/remote-viewer.c | 70
> -
> 1 file changed, 43 insert
On 23/06/17 12:30, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Allow to set connection details via DBus, and add a Connect method.
> This is intended to replace the Spice controller.
>
> Sample usage:
>
> DEST=`remote-viewer --dbus-controller`
>
> gdbus call --session --de
On 07/07/17 09:15, Daniel P. Berrange wrote:
> Our last release was in Nov last year and there's a bunch of accumulated
> patches. It would also be desirable to include the fix for libvirt on
> Windows which should make virt-viewer work properly again.
>
ACK with it, at least from my side, there
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1427467
https://bugzilla.redhat.com/show_bug.cgi?id=1428401
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 141 +++
1 file changed, 141 insertions(+)
diff --git a/src
This can save us some bandwidth, as we are searching for the specific
virtual machine instead of retrieving the collection with all VMs, and
then iterating over the results after the transfer finishes.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 6 +-
1 file changed
Signed-off-by: Eduardo Lima (Etrunko)
---
src/Makefile.am | 2 ++
src/glib-compat.c| 35 +++
src/glib-compat.h| 39 +++
src/ovirt-foreign-menu.c | 22 ++
4 files changed, 98 insertions
On 06/08/17 18:53, Pavel Grunt wrote:
> Hi,
>
> 2017-08-04 23:53 GMT+02:00 Eduardo Lima (Etrunko) <mailto:etru...@redhat.com>>:
>
> This can save us some bandwidth, as we are searching for the specific
> virtual machine instead of retrieving the collection w
.
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1427467
https://bugzilla.redhat.com/show_bug.cgi?id=1428401
Signed-off-by: Eduardo Lima (Etrunko)
---
src/Makefile.am | 2 ++
src/glib-compat.c| 35 +++
src/glib-compat.h| 39
Lima (Etrunko)
---
configure.ac | 4
1 file changed, 4 insertions(+)
diff --git a/configure.ac b/configure.ac
index 9ca6cb6..61374fa 100644
--- a/configure.ac
+++ b/configure.ac
@@ -190,6 +190,10 @@ AS_IF([test "x$with_ovirt" = "xyes"],
void *fun = re
that scenario. We fix
this problem by making use of new functions in libgovirt, adding support
or hosts, clusters and data centers.
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1427467
https://bugzilla.redhat.com/show_bug.cgi?id=1428401
Signed-off-by: Eduardo Lima (Etrunko
This can save us some bandwidth, as we are searching for the specific
virtual machine instead of retrieving the collection with all VMs, and
then iterating over the results after the transfer finishes.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 7 +++
1 file
v2:
- Check for new functions in configure.
- Added #ifdef guards for the new functions.
Eduardo Lima (Etrunko) (4):
configure: check for new functions in libgovirt
foreign-menu: Use query for fetching virtual machines
ovirt-foreign-menu: Fetch host, cluster and data center information
On 06/10/17 09:43, Victor Toso wrote:
> Ack
>
Pushed, thanks
> - Original Message -
>> v2:
>> - Check for new functions in configure.
>> - Added #ifdef guards for the new functions.
>>
>> Eduardo Lima (Etrunko) (4):
>> configure: chec
solve this problem, we always pass a copy of the guri as user-data
parameter for the callback, and if the call to
virt_viewer_session_get_uri() returns NULL, the parameter is used
instead.
Resolves: https://bugzilla.redhat.com/1459792
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer.c | 8 +
On 20/10/17 15:10, Eduardo Lima (Etrunko) wrote:
> When connecting to a VM via oVirt instance, the original uri can not be
> retrieved using virt_viewer_session_get_uri(). Consequently, it was
> never saved, even though the connection succeeds and the actual callback
> for "
solve this problem, we always pass a copy of the guri as user-data
parameter for the callback, and if the call to
virt_viewer_session_get_uri() returns NULL, the parameter is used
instead.
Resolves: https://bugzilla.redhat.com/1459792
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-vie
On 31/10/17 16:13, Daniel P. Berrange wrote:
> On Mon, Oct 30, 2017 at 08:27:46PM +, Wow Zaza wrote:
>> I want to bring to your attention that the virt-viewer 6.0 (x86 and x64)
>> download aren't currently accessible via the download link. When you
>> click on the download link, all you see is
On 31/10/17 17:32, Wow Zaza wrote:
> Thank you for the replies. I was able to download using Firefox. I tried
> using Chrome, Edge, and Internet Explorer. None of them worked. Although
> my problem is solved, could it be a compilation issue on your end? Only
> one of the major browser is able to do
On 14/11/17 13:47, Victor Toso wrote:
> On Thu, Oct 26, 2017 at 03:39:31PM +0200, Eduardo Lima (Etrunko) wrote:
>> When connecting to a VM via oVirt instance, the original uri can not be
>> retrieved using virt_viewer_session_get_uri(). Consequently, it was
>> never s
On 14/11/17 14:38, Victor Toso wrote:
> Hi,
>
> On Tue, Nov 14, 2017 at 02:14:25PM -0200, Eduardo Lima (Etrunko) wrote:
>> On 14/11/17 13:47, Victor Toso wrote:
>>> On Thu, Oct 26, 2017 at 03:39:31PM +0200, Eduardo Lima (Etrunko) wrote:
>>>> When connec
solve this problem, we always pass a copy of the guri as user-data
parameter for the callback, and if the call to
virt_viewer_session_get_uri() returns NULL, the parameter is used
instead.
Resolves: https://bugzilla.redhat.com/1459792
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-vie
On 14/11/17 15:01, Victor Toso wrote:
> Hi,
>
> On Tue, Nov 14, 2017 at 02:54:30PM -0200, Eduardo Lima (Etrunko) wrote:
>> When connecting to a VM via oVirt instance, the original uri can not be
>> retrieved using virt_viewer_session_get_uri(). Consequently, it was
>> n
- Use macros for paths instead of absolute paths.
- Fix scope of enable_autotools macro to avoid warning during build.
warning: Macro %enable_autotools defined but not used within scope
- Remove references to spice-xpi-client
Signed-off-by: Eduardo Lima (Etrunko)
---
virt-viewer.spec.in | 31
On 17/11/17 11:45, Daniel P. Berrange wrote:
> A while ago now we had patches going through review that switched over to
> use Gtk HeaderBar concept. I was wondering what the status of that is, as
> I think it would be a nice step forward for virt-viewer UI.
>
As far as I remember, the idea was to
On 17/11/17 11:39, Eduardo Lima (Etrunko) wrote:
> - Use macros for paths instead of absolute paths.
> - Fix scope of enable_autotools macro to avoid warning during build.
> warning: Macro %enable_autotools defined but not used within scope
> - Remove references to spice-xpi-clien
On 21/09/17 06:12, Daniel P. Berrange wrote:
> On Thu, Sep 21, 2017 at 10:16:56AM +0200, Christophe Fergeau wrote:
>> The man page spice-gtk ships is named "spice-client", not "spice-gtk"
>>
>> Signed-off-by: Christophe Fergeau
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=1477966
>> ---
>> m
Similar to last commit, as noticed by reporter in bugzilla:
https://bugzilla.redhat.com/show_bug.cgi?id=1477966
Man page should reference spice-client, not spice-gtk.
Signed-off-by: Eduardo Lima (Etrunko)
---
man/remote-viewer.pod | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
- Use macros for paths instead of absolute paths.
- Fix scope of enable_autotools macro to avoid warning during build.
warning: Macro %enable_autotools defined but not used within scope
Signed-off-by: Eduardo Lima (Etrunko)
---
virt-viewer.spec.in | 23 ---
1 file changed
On 22/11/17 16:35, Christophe Fergeau wrote:
> On Wed, Nov 22, 2017 at 04:21:49PM -0200, Eduardo Lima (Etrunko) wrote:
>> - Use macros for paths instead of absolute paths.
>> - Fix scope of enable_autotools macro to avoid warning during build.
>> warning: Macro %enable_auto
- Use macros for paths instead of absolute paths.
- Remove dangling %{gtk_arg} macro in configure.
- Fix scope of enable_autotools macro to avoid warning during build.
warning: Macro %enable_autotools defined but not used within scope
Signed-off-by: Eduardo Lima (Etrunko)
---
virt
On 27/11/17 07:37, Christophe Fergeau wrote:
>
> Acked-by: Christophe Fergeau
Pushed, Thanks.
>
> On Thu, Nov 23, 2017 at 11:52:53AM -0200, Eduardo Lima (Etrunko) wrote:
>> - Use macros for paths instead of absolute paths.
>> - Remove dangling %{gtk_arg} macro in conf
On 30/05/18 09:47, Victor Toso wrote:
> From: Victor Toso
>
> Instead of top-left corner.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1508274
>
> Signed-off-by: Victor Toso
Acked-by: Eduardo Lima (Etrunko)
> ---
> src/resources/ui/remote-viewer
wer-remote-viewer.o: undefined reference to symbol
'rest_proxy_auth_cancel'
/home/elima/install/govirt-usr/lib/librest-0.7.so.0: error adding symbols: DSO
missing from command line
collect2: error: ld returned 1 exit status
Signed-off-by: Eduardo Lima (Etrunko)
---
configure.ac| 3 ++-
Acked-by: Eduardo Lima (Etrunko)
On 14/06/18 13:01, Christophe Fergeau wrote:
> This is no longer needed since 140cb84
> 'remote-viewer: remove --spice-controller'
>
> Signed-off-by: Christophe Fergeau
> ---
> src/virt-viewer-app.c | 44 -
Acked-by: Eduardo Lima (Etrunko)
On 14/06/18 13:01, Christophe Fergeau wrote:
> This adds an unused parameter, but lets us get rid of this new warning
> with gcc 8:
>
> virt-viewer-window.c: In function 'get_image_format':
> virt-viewer-window.c:930:33: warning:
or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 59 Temp
On 14/06/18 13:01, Christophe Fergeau wrote:
> spice_main_set_display and spice_main_set_display_enabled have been
> superseded by spice_main_channel_update_display and
> spice_main_channel_update_display_enabled
>
May I ask the reasoning for keeping compatibility with older version
instead of si
Acked-by: Eduardo Lima (Etrunko)
On 29/06/18 05:13, Christophe Fergeau wrote:
> The ovirt code uses g_strv_contains() with fallback code in
> glib-compat.h when we are using a glib version where it's not available.
> However, when we use a glib version where g_strv_contains is a
On 29/06/18 05:12, Christophe Fergeau wrote:
> On Thu, Jun 28, 2018 at 05:09:48PM -0300, Eduardo Lima (Etrunko) wrote:
>> On 14/06/18 13:01, Christophe Fergeau wrote:
>>> spice_main_set_display and spice_main_set_display_enabled have been
>>> superseded by spice_main
With these new values, 0.3.3 for libgovirt and 0.8 for librest, we can
remove checks for OVIRT_REST_CALL_ERROR_CANCELLED and correspondent
rest_proxy_auth_cancel().
Signed-off-by: Eduardo Lima (Etrunko)
---
configure.ac| 11 ---
src/remote-viewer.c | 4
2 files changed, 4
Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 43 +++
1 file changed, 31 insertions(+), 12 deletions(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index 70a0b50..8ed08c9 100644
--- a/src/ovirt-foreign-menu.c
+++ b/src/ovirt-foreign
It may be useful to know why the storage domain has not been listed,
given that there are different reasons for that. To make it easier to
provide more detailed debug messages, we move code from the callback
function to this new one.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign
On 30/07/18 05:05, Andrea Bolognani wrote:
> On Fri, 2018-07-27 at 12:39 +0100, Daniel P. Berrangé wrote:
>> Signed-off-by: Daniel P. Berrangé
>> ---
>> README.md | 2 +-
>> configure.ac| 2 +-
>> src/virt-viewer-display-spice.c | 2 +-
>> src/virt-vie
ith .qcow2 files in it, which can't be assigned to a VM either.
> This commit filters every file which does not have a .iso extension as
> it's unlikely to be possible to use it.
>
> Signed-off-by: Christophe Fergeau
Acked-by: Eduardo Lima (Etrunko)
> ---
> src
Signed-off-by: Eduardo Lima (Etrunko)
---
data/meson.build | 16
icons/meson.build | 14
man/meson.build | 16
meson.build | 206 ++
meson_options.txt | 25 ++
po/meson.build| 2 +
src/meson.build | 116
,
which I don't really know how to implement, but should not be difficult.
Eduardo Lima (Etrunko) (2):
build: Keep original type name as generated from glib-mkenums
Add support for building with meson/ninja
data/meson.build | 16 +++
icons/meson.build | 14 +++
man/meson.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/Makefile.am | 4 ++--
src/virt-viewer-display.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 0a3cbbf..0472908 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -40,8
---
meson.build | 2 +-
subprojects/spice-single.wrap | 4
2 files changed, 5 insertions(+), 1 deletion(-)
create mode 100644 subprojects/spice-single.wrap
diff --git a/meson.build b/meson.build
index 4c6729d..3b7ed7e 100644
--- a/meson.build
+++ b/meson.build
@@ -1,7 +1,7
On 09/14/2018 09:47 AM, Eduardo Lima (Etrunko) wrote:
> ---
> meson.build | 2 +-
> subprojects/spice-single.wrap | 4
> 2 files changed, 5 insertions(+), 1 deletion(-)
> create mode 100644 subprojects/spice-single.wrap
>
> diff --git a/meson.build
Signed-off-by: Eduardo Lima (Etrunko)
---
In v2:
- Add meson.build files to EXTRA_DIST
- Fix typo meson meson_vesrion -> meson_version
- Minimal cleanups
---
Makefile.am | 3 +
data/Makefile.am | 1 +
data/meson.build | 16
icons/Makefile.am | 2 +
icons/meson.bu
On 10/4/18 7:48 AM, Daniel P. Berrangé wrote:
> On Wed, Sep 12, 2018 at 11:07:57AM +0200, Eduardo Lima (Etrunko) wrote:
>> The first patch is a preparation for the new build system. As it uses
>> a built in function provided by meson for generating the enum files, it
>> is no
On 10/4/18 9:41 AM, Eduardo Lima (Etrunko) wrote:
> On 10/4/18 7:48 AM, Daniel P. Berrangé wrote:
>> On Wed, Sep 12, 2018 at 11:07:57AM +0200, Eduardo Lima (Etrunko) wrote:
>>> The first patch is a preparation for the new build system. As it uses
>>> a built in fun
> gdk_screen_get_default(), monitor);
> }
> +#else
> +gtk_window_fullscreen(GTK_WINDOW(priv->window));
> +#endif /* GTK_CHECK_VERSION */
> }
>
> #define MAX_KEY_COMBO 4
>
Acked-by: Eduardo Lima (Etrunko)
--
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etru...@redhat.com
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list
for (i = 0 ; i < ncred ; i++) {
> -const char *cred_type_to_str[] = {
> -[VIR_CRED_USERNAME] = "Identity to act as",
> -[VIR_CRED_AUTHNAME] = "Identify to authorize as",
> -[VIR_CRED_PASSPHRASE] = "Passphrase secret
}
> -} else
> -#endif
> -{
> -if (!remote_viewer_initial_connect(self, type, guri, vvfile,
> &error))
> - goto cleanup;
> -}
> +if (!remote_viewer_initial_conne
Fixes the Windows case where the dialog fails to show with the following
message:
warning: "Could not find signal handler
'virt_viewer_window_menu_change_cd_activate'"
Signed-off-by: Eduardo Lima (Etrunko)
---
src/virt-viewer-window.c | 2 +-
1 file changed, 1 inse
On 1/18/19 5:30 PM, Marc-André Lureau wrote:
> On Fri, Jan 18, 2019 at 6:58 PM Eduardo Lima (Etrunko)
> wrote:
>>
>> Fixes the Windows case where the dialog fails to show with the following
>> message:
>>
>> warning: "Could not find signal handler
>&
Fixes the Windows case where the dialog fails to show with the following
message:
warning: "Could not find signal handler
'virt_viewer_window_menu_change_cd_activate'"
Signed-off-by: Eduardo Lima (Etrunko)
---
in v2:
- Apply similar fix to handlers in remote-view
f->priv->disconnect_error;
> +g_signal_emit_by_name(self, "session-disconnected", error ?
> error->message : NULL);
> }
>
> static void
>
Acked-by: Eduardo Lima (Etrunko)
--
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etru...@redhat.c
On 7/17/18 11:48 AM, Christophe Fergeau wrote:
> On Fri, Jul 06, 2018 at 09:59:23AM -0300, Eduardo Lima (Etrunko) wrote:
>> When accessing ovirt as a regular user, it may happen that queries to
>> Hosts, Clusters and Data Centers return errors due to insufficient
>> permiss
Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 46 +---
1 file changed, 34 insertions(+), 12 deletions(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index d234a27..36ec2ed 100644
--- a/src/ovirt-foreign-menu.c
+++ b/src/ovirt-foreign-menu.c
G_ADD_PRIVATE was added in 2.38 and older functions are getting deprecated:
https://gitlab.gnome.org/GNOME/glib/merge_requests/7/commits
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c| 6 ++
src/remote-viewer-iso-list-dialog.c | 12 +---
src/remote
-off-by: Eduardo Lima (Etrunko)
---
in v2:
- Replace GET_PRIVATE macros with appropriate _get_instance_private()
---
src/ovirt-foreign-menu.c | 8 ++--
src/remote-viewer-iso-list-dialog.c| 14 +-
src/remote-viewer.c| 8 ++--
src/virt
On 2/12/19 12:36 PM, Daniel P. Berrangé wrote:
> We use GLIB_VERSION_MAX_ALLOWED to prevent use of functions from
> GTK >= 3.12. When we do conditional compilation based on a GTK
> version check, we must thus suppress the warning:
>
> CC libvirt_viewer_la-virt-viewer-window.lo
> ../../src/
On 2/13/19 7:28 AM, Daniel P. Berrangé wrote:
> On Tue, Feb 12, 2019 at 05:34:44PM -0200, Eduardo Lima (Etrunko) wrote:
>> On 2/12/19 12:36 PM, Daniel P. Berrangé wrote:
>>> We use GLIB_VERSION_MAX_ALLOWED to prevent use of functions from
>>> GTK >= 3.12. When we do
Signed-off-by: Eduardo Lima (Etrunko)
---
src/virt-viewer-window.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c
index 96b35f6..cbf3f29 100644
--- a/src/virt-viewer-window.c
+++ b/src/virt-viewer-window.c
@@ -600,11
Signed-off-by: Eduardo Lima (Etrunko)
---
src/virt-viewer-window.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c
index 96b35f6..4bbe2ca 100644
--- a/src/virt-viewer-window.c
+++ b/src/virt-viewer-window.c
@@ -600,11
Please ignore this one, using the wrong define, it was sent from a wrong
branch.
On 2/13/19 11:00 AM, Eduardo Lima (Etrunko) wrote:
> Signed-off-by: Eduardo Lima (Etrunko)
> ---
> src/virt-viewer-window.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> dif
-off-by: Eduardo Lima (Etrunko)
---
v2: Removed iso-list dialog patch which is dealt separately.
---
src/ovirt-foreign-menu.c | 8 ++--
src/remote-viewer.c| 8 ++--
src/virt-viewer-app.c | 8 ++--
src/virt-viewer-display-spice.c
There is no reason for this object to define a private structure, so it
is fine to make everything private to the dialog itself.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer-iso-list-dialog.c | 108 +---
src/remote-viewer-iso-list-dialog.h | 13
2
On 2/11/19 3:31 PM, Daniel P. Berrangé wrote:
> On Mon, Feb 11, 2019 at 06:24:37PM +0100, Christophe Fergeau wrote:
>> Hey,
>>
>> Looks good to me, 2 comments below:
>>
>> On Thu, Feb 07, 2019 at 10:54:58AM -0200, Eduardo Lima (Etrunko) wrote:
>>
>
On 2/13/19 3:27 PM, Marc-André Lureau wrote:
> Hi
>
> On Wed, Feb 13, 2019 at 6:05 PM Daniel P. Berrangé
> wrote:
>>
>> This enables many more compiler warnings than the current code. It also
>> ensures that -Werror is enabled by default when building from GIT so
>> that maintainers see regressi
ping
On 2/13/19 12:46 PM, Eduardo Lima (Etrunko) wrote:
> New functions and macros have been added in glib 2.38 to better handle
> this case.
>
> https://gitlab.gnome.org/GNOME/glib/blob/c8de2b11bbbf5705ee20bf68d0c11e455b441312/NEWS
>
> The old method is being deprecated
On 2/20/19 12:13 PM, Christophe Fergeau wrote:
> Series looks good to me,
> Reviewed-by: Christophe Fergeau
Pushed, thanks
>
> On Wed, Feb 20, 2019 at 11:05:36AM -0300, Eduardo Lima (Etrunko) wrote:
>> ping
>>
>> On 2/13/19 12:46 PM, Eduardo Lima (Etrunko) wrote
Ouch, it looks like I missed this mail in my Inbox, somehow it slipped
through the filters and was not moved to the folder.
On 2/6/19 8:15 AM, Christophe Fergeau wrote:
> On Tue, Feb 05, 2019 at 03:38:35PM -0200, Eduardo Lima (Etrunko) wrote:
>> On 7/17/18 11:48 AM, Christophe Ferg
Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 51 ++--
1 file changed, 39 insertions(+), 12 deletions(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index 59c3d48..83bdf5b 100644
--- a/src/ovirt-foreign-menu.c
+++ b/src/ovirt-foreign-menu.c
301 - 400 of 429 matches
Mail list logo
