dialog = gtk_file_chooser_dialog_new(_("Save screenshot"),
> NULL,
> GTK_FILE_CHOOSER_ACTION_SAVE,
> _("_Cancel"), GTK_RESPONSE_CANCEL,
>
Acked-by: Edu
ping
On 4/10/19 5:20 PM, Eduardo Lima (Etrunko) wrote:
> When accessing ovirt as a regular user, it may happen that queries to
> Hosts, Clusters and Data Centers return errors due to insufficient
> permissions, while they will work fine if access is done by admin user.
> In this case,
Use saved CFLAGS and LIBS to avoid errors in the check programs.
Signed-off-by: Eduardo Lima (Etrunko)
---
configure.ac | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index 7b61821..c787e1e 100644
--- a/configure.ac
+++ b/configure.ac
at all and break in the
middle with an error message about insufficient permissions.
Regards, Eduardo.
> A few small comments below,
>
Fixed all leaks.
> On Tue, May 28, 2019 at 11:11:41AM -0300, Eduardo Lima (Etrunko) wrote:
>> ping
>>
>> On 4/10/19 5:20 PM, Edu
On 6/7/19 10:37 AM, Christophe Fergeau wrote:
> On Fri, Jun 07, 2019 at 10:04:19AM -0300, Eduardo Lima (Etrunko) wrote:
>> On 6/6/19 1:22 PM, Christophe Fergeau wrote:
>>> Hey,
>>>
>>> I'm not really comfortable with that patch, which ignores some errors,
Instead of fetching toplevel REST API query, we use the one relative
from the data center, which returns more detailed information,
especially the status of the storage domain.
This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1427467
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt
Instead of fetching toplevel REST API query, we use the one relative
from the data center, which returns more detailed information,
especially the status of the storage domain.
This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1427467
Signed-off-by: Eduardo Lima (Etrunko)
---
in V2
On 8/12/19 6:38 AM, Victor Toso wrote:
> Hi,
>
> On Fri, Aug 09, 2019 at 04:51:07PM -0300, Eduardo Lima (Etrunko) wrote:
>> Instead of fetching toplevel REST API query, we use the one relative
>> from the data center, which returns more detailed information,
>> e
On 8/12/19 9:48 AM, Victor Toso wrote:
> On Mon, Aug 12, 2019 at 09:36:39AM -0300, Eduardo Lima (Etrunko) wrote:
>> Instead of fetching toplevel REST API query, we use the one relative
>> from the data center, which returns more detailed information,
>> especially the status
g_debug("%s", msg);
> + g_task_return_new_error(task, OVIRT_ERROR, OVIRT_ERROR_FAILED, "%s",
> msg);
> g_object_unref(task);
> }
> }
>
Acked-by: Eduardo Lima (Etrunko)
--
Eduardo de Barros Lima (Etrunko)
Software Engineer - Red Hat
etru...@redhat.com
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list
In the case of having a valid storage domain without any ISO files, this
variable can be reset to FALSE again in the next iteration of the loop,
resulting in a misleading error message presented to the user.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 6 --
1 file
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index 4ec0858..48b7b34 100644
--- a/src/ovirt-foreign-menu.c
+++ b/src/ovirt-foreign-menu.c
@@ -669,6 +669,7 @@ static
This patch series has been sent from a wrong branch, please disregard.
There should be only one patch which is a squashed version of both
On 8/16/19 2:44 PM, Eduardo Lima (Etrunko) wrote:
> Signed-off-by: Eduardo Lima (Etrunko)
> ---
> src/ovirt-foreign-menu.c | 1 +
> 1 fil
In the case of having a valid storage domain without any ISO files, this
variable can be reset to FALSE again in the next iteration of the loop,
resulting in a misleading error message presented to the user.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 7 +--
1 file
On 8/19/19 6:51 AM, Victor Toso wrote:
> Hi,
>
> On Fri, Aug 16, 2019 at 03:25:54PM -0300, Eduardo Lima (Etrunko) wrote:
>> In the case of having a valid storage domain without any ISO files, this
>> variable can be reset to FALSE again in the next iteration of the lo
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index c2f43e6..190bb3b 100644
--- a/src/ovirt-foreign-menu.c
+++ b/src/ovirt
On 8/26/19 4:15 AM, Victor Toso wrote:
> Hi,
>
> On Fri, Aug 23, 2019 at 11:38:05AM -0300, Eduardo Lima (Etrunko) wrote:
>> Signed-off-by: Eduardo Lima (Etrunko)
>> ---
>> src/ovirt-foreign-menu.c | 25 +
>> 1 file changed, 17 inserti
On 8/26/19 9:47 AM, Victor Toso wrote:
> Hi,
>
> On Mon, Aug 26, 2019 at 09:38:03AM -0300, Eduardo Lima (Etrunko) wrote:
>> On 8/26/19 4:15 AM, Victor Toso wrote:
>>> Hi,
>>>
>>> On Fri, Aug 23, 2019 at 11:38:05AM -0300, Eduardo Lima (Etrunko) wrote:
)
by 0x570BC19: ??? (in /usr/lib64/libgio-2.0.so.0.6000.6)
by 0x570C7EC: ??? (in /usr/lib64/libgio-2.0.so.0.6000.6)
by 0x559005D: call_async_cb (ovirt-proxy.c:279)
by 0x55B5A07: ??? (in /usr/lib64/librest-0.7.so.0.0.0)
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 5
On 8/29/19 12:50 PM, Victor Toso wrote:
> On Wed, Aug 28, 2019 at 06:18:02PM -0300, Eduardo Lima (Etrunko) wrote:
>> Error caught by valgrind, the OvirtCollection object created in function
>> ovirt_foreign_menu_fetch_vm_async() was never freed.
>>
>> 433 (40 direc
On 8/30/19 5:53 AM, Victor Toso wrote:
> On Thu, Aug 29, 2019 at 02:56:23PM -0300, Eduardo Lima (Etrunko) wrote:
>> On 8/29/19 12:50 PM, Victor Toso wrote:
>>> On Wed, Aug 28, 2019 at 06:18:02PM -0300, Eduardo Lima (Etrunko) wrote:
>>>> Error caught by valgrind, the
On 9/27/19 10:35 AM, Victor Toso wrote:
From: Victor Toso
On remote_viewer_session_connected() we are passing a dup of URI of
connection and freeing it afterwards. Problem is, we don't disconnect
from listening "session-connected" and on an eventual second emission
of this signal, remote-viewer
On 9/30/19 5:08 AM, Victor Toso wrote:
From: Victor Toso
On remote_viewer_session_connected() we are passing a dup of URI of
connection and freeing it afterwards. Problem is, we don't disconnect
from listening "session-connected" and on an eventual second emission
of this signal, remote-viewer
On 10/1/19 7:09 AM, Victor Toso wrote:
Hi,
On Mon, Sep 30, 2019 at 11:01:42AM -0300, Eduardo Lima (Etrunko) wrote:
On 9/30/19 5:08 AM, Victor Toso wrote:
From: Victor Toso
On remote_viewer_session_connected() we are passing a dup of URI of
connection and freeing it afterwards. Problem is
On 10/1/19 12:51 PM, Victor Toso wrote:
Hi,
On Tue, Oct 01, 2019 at 11:17:22AM -0300, Eduardo Lima (Etrunko) wrote:
On 10/1/19 7:09 AM, Victor Toso wrote:
Patch builds now, but I started getting some warning when
connecting to ovirt:// uri.
(remote-viewer:16940): virt-viewer-CRITICAL **: 11
r_session_get_uri(session);
const gchar *mime = virt_viewer_session_mime_type(session);
-if (uri == NULL)
-uri = g_strdup(guri);
-
-remote_viewer_recent_add(uri, mime);
+remote_viewer_recent_add(uri != NULL ? uri : (char *) guri, mime);
Acked-by: Eduardo Lima (Etrunko)
IMO, re
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1402909
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/remote-viewer.c b/src/remote-viewer.c
index 5c7a379..71f9a23 100644
--- a/src/remote-viewer.c
compatibility of older versions of oVirt.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1402909
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/remote-viewer.c b/src/remote-viewer.c
index 8eaa72e
On 10/11/19 12:35 PM, Victor Toso wrote:
Hi,
On Fri, Oct 11, 2019 at 11:07:25AM -0300, Eduardo Lima (Etrunko) wrote:
Since oVirt engine version 4.3.2.1, the API returns certificate data for
display connection in the VM XML, so users do not need to specify it
from the command line anymore. The
401 - 429 of 429 matches
Mail list logo
