On 11/03/2015 10:57 AM, Christophe Fergeau wrote:
> Hey,
>
> On Tue, Nov 03, 2015 at 09:38:24AM -0200, Eduardo Lima (Etrunko) wrote:
>>
>> Yes, you can find those in the final Makefile, but test-driver is the
>> only one missing. Maybe a bug in autom
On 04/11/15 11:39, Fabiano Fidêncio wrote:
> On Tue, Nov 3, 2015 at 3:20 PM, Fabiano Fidêncio wrote:
>> On Tue, Nov 3, 2015 at 12:14 PM, Eduardo Lima (Etrunko)
>> wrote:
>>> On 02/11/15 04:08, Fabiano Fidêncio wrote:
>>>> Hey!
>>>>
>>>
Makefile.am: Use helper variables from git.mk
man/Makefile.am: This should be $(dist_man_MANS) instead of $(man_MANS)
Signed-off-by: Eduardo Lima (Etrunko)
---
Makefile.am | 18 +++---
man/Makefile.am | 2 +-
2 files changed, 4 insertions(+), 16 deletions(-)
diff --git a
Signed-off-by: Eduardo Lima (Etrunko)
---
git.mk | 221 -
1 file changed, 178 insertions(+), 43 deletions(-)
diff --git a/git.mk b/git.mk
index 0b26b23..bd39ae1 100644
--- a/git.mk
+++ b/git.mk
@@ -1,14 +1,19 @@
-# git.mk
+# git.mk
Signed-off-by: Eduardo Lima (Etrunko)
---
src/virt-viewer.c | 22 --
1 file changed, 22 deletions(-)
diff --git a/src/virt-viewer.c b/src/virt-viewer.c
index dd8dbba..10f624d 100644
--- a/src/virt-viewer.c
+++ b/src/virt-viewer.c
@@ -74,26 +74,6 @@ static void
Signed-off-by: Eduardo Lima (Etrunko)
---
src/virt-viewer.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/virt-viewer.c b/src/virt-viewer.c
index ca264c8..dd8dbba 100644
--- a/src/virt-viewer.c
+++ b/src/virt-viewer.c
@@ -71,6 +71,7 @@ static gboolean
'/usr/share/aclocal/intltool.m4' to 'm4/intltool.m4'
The problem is that intltoolize requires te m4/ directory to be present,
and this directory is actually created by running autoreconf, so it
should be called before intltoolize.
Signed-off-by: Eduardo Lima (Etrunko)
---
autog
All .gitignore files are handled by git.mk and should not be part of the
repository.
Signed-off-by: Eduardo Lima (Etrunko)
---
m4/.gitignore | 0
1 file changed, 0 insertions(+), 0 deletions(-)
delete mode 100644 m4/.gitignore
diff --git a/m4/.gitignore b/m4/.gitignore
deleted file mode
Resend of my cleanup series, please take a look. In this new version,
I have found what was causing the errors running autogen.sh and updated
git.mk from upstream.
Eduardo Lima (Etrunko) (6):
Remove m4/.gitignore file
Call intltoolize after autoreconf
Update git.mk from latest upstream
Daniel,
On 11/05/2015 12:27 PM, Daniel P. Berrange wrote:
> On Wed, Nov 04, 2015 at 12:32:41PM -0200, Eduardo Lima (Etrunko) wrote:
>> Resend of my cleanup series, please take a look. In this new version,
>> I have found what was causing the errors running autogen.sh and updated
Signed-off-by: Eduardo Lima (Etrunko)
---
src/virt-viewer-app.c | 14 --
src/virt-viewer-app.h | 1 -
2 files changed, 15 deletions(-)
diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
index 653b30c..b14b509 100644
--- a/src/virt-viewer-app.c
+++ b/src/virt-viewer-app.c
Here are a couple more clean-up patches I had on my staging area that
I think could be merged as they are independent of any feature. Please
take a look.
Regards, Eduardo
Eduardo Lima (Etrunko) (2):
Remove unused 'window-removed' signal
Fix spice includes
src/remote-vie
Wcpp]
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer-main.c| 2 +-
src/virt-viewer-display-spice.c | 2 +-
src/virt-viewer-display-spice.h | 3 +--
src/virt-viewer-main.c | 2 +-
src/virt-viewer-session-spice.c | 5 +
src/virt-viewer-session-spice.h | 3 +--
On 11/11/2015 05:11 AM, Pavel Grunt wrote:
> Hi Eduardo,
>
> these warnings were introduced after spice-gtk v0.30 release, virt-viewer
> currently depends on spice-gtk v0.29.35. You can make the code conditional or
> wait for the spice-gtk v0.31 release.
>
Alright, I guess it is better to wait t
From: Fabiano Fidêncio
The 3.0 release was the last one that still supports GTK2. For the
Windows builds the support to GTK2 was dropped in the previous release.
Let's do the same for the entire project now.
---
configure.ac | 39 +++
src/view/autoDrawer.c | 10 -
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/remote-viewer.c b/src/remote-viewer.c
index 8e4754f..3f530a3 100644
--- a/src/remote-viewer.c
+++ b/src/remote-viewer.c
@@ -617,10 +617,13
branch in my github
repository, in case you are interested in trying it easier, without the
need to apply the patches on your tree.
http://github.com/etrunko/virt-viewer
Regards, Eduardo.
Eduardo Lima (Etrunko) (3):
Move variable declaration to the top of the function
Port to GtkApplication API&#
tion by the time gtk_application_add_window() is
called. The 'window-removed' signal has also been removed, as it was
not being used anyway.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer-main.c | 122 +-
src/remote-viewer.c | 137 ++--
GtkMenuBar, in a following patch.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/virt-viewer-app.c| 1 -
src/virt-viewer-window.c | 57 ---
src/virt-viewer.xml | 416 +++
3 files changed, 234 insertions(+), 240 deletions(-)
diff --git
On 11/30/2015 05:44 PM, Jonathon Jongsma wrote:
> On Fri, 2015-11-27 at 17:23 -0200, Eduardo Lima (Etrunko) wrote:
>> The subject says it all, and you will find more details in each commit
>> message. Unfortunately I was not able to test some options on
>> remote-vie
On 11/30/2015 07:29 PM, Jonathon Jongsma wrote:
>> - All Window objects must be associated with the Application, and with
>> this, there is no need to emit our own 'window-added' signal, it will
>> be done by GtkApplication by the time gtk_application_add_window() is
>> called. The 'window-r
On 12/02/2015 09:21 AM, Christophe Fergeau wrote:
> On Mon, Nov 30, 2015 at 03:29:37PM -0600, Jonathon Jongsma wrote:
>>> +app_class->add_main_options = remote_viewer_add_main_options;
>>> +app_class->handle_options = remote_viewer_handle_options;
>>> +app_class->version_string = remote
On 12/02/2015 09:09 AM, Christophe Fergeau wrote:
> Hey,
>
> On Fri, Nov 27, 2015 at 05:24:00PM -0200, Eduardo Lima (Etrunko) wrote:
>> Most of this patch consists in code being shuffled around to fit the
>> expected flow while using the new APIs. I tried my best to make t
On 12/01/2015 03:17 PM, Jonathon Jongsma wrote:
> Hmm, I don't quite understand most of these changes.
>
> Why are you removing the window from the xml file instead of just changing the
> 'class' attribute to GtkApplicationWindow? (Of course, we can't set the
> 'application' property of the windo
On 12/02/2015 11:25 PM, Jim Fehlig wrote:
> On 12/02/2015 04:15 AM, Daniel P. Berrange wrote:
>> Yep, we need to agree which min platform we're targetting. It is nice
>> to see RHEL7 rebasing GTK, as that makes life easier. We should not
>> only consider RHEL though. It would be desirable if someon
On 12/07/2015 10:43 AM, Eduardo Lima (Etrunko) wrote:
> On 12/02/2015 11:25 PM, Jim Fehlig wrote:
>> On 12/02/2015 04:15 AM, Daniel P. Berrange wrote:
>>> Yep, we need to agree which min platform we're targetting. It is nice
>>> to see RHEL7 rebasing GTK, as that
Ideally, glib was required to be at least 2.40.0, but due to the fact
that SLES still uses 2.38, we need to backport the code that is
available only in glib version 2.40.0 onwards.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/virt-glib-compat.c | 368
Signed-off-by: Eduardo Lima (Etrunko)
---
configure.ac | 2 +-
src/remote-viewer.c| 9 +
src/virt-glib-compat.c | 29 +
src/virt-viewer-app.c | 15 +++
src/virt-viewer-app.h | 8
src/virt-viewer.c | 9 +
6
- Reuse #ifdef HAVE_SPICE_GTK block for include.
- Move declaration of vfunc together with others of the same class.
- Move variable declaration to the top of the function.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer.c | 13 +++--
1 file changed, 7 insertions(+), 6
Same case as last GApplication patch, but kept split for easier understanding.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/virt-glib-compat.c | 204 +
src/virt-glib-compat.h | 32
2 files changed, 236 insertions(+)
diff --git a/src
Signed-off-by: Eduardo Lima (Etrunko)
---
src/virt-glib-compat.c | 97 +++---
1 file changed, 68 insertions(+), 29 deletions(-)
diff --git a/src/virt-glib-compat.c b/src/virt-glib-compat.c
index a61a3a6..0118e45 100644
--- a/src/virt-glib-compat.c
x27;window-
removed' signals, as those will be emited by GtkApplication whenever
gtk_application_add_window() and gtk_application_remove_window() are
called. Also, 'window-removed' was not being used anywhere.
Signed-off-by: Eduardo Lima (Etrunko)
---
configure.ac
adaptations of the glib code to build outside of the
tree and integrate with virt-viewer.
Eduardo Lima (Etrunko) (6):
Minor code cleanups
Port to GtkApplication API's
Backport GApplication code from glib 2.40
Backport GVariantDict code from glib 2.40
Adapt glib code to build out of the
From: Fabiano Fidêncio
The 3.0 release was the last one that still supports GTK2. For the
Windows builds the support to GTK2 was dropped in the previous release.
Let's do the same for the entire project now.
---
configure.ac | 39 +++
src/view/autoDrawer.c | 10 -
Hi Jonathon,
It seems I got a bit lost with the all comments on the previous series
and some of them became were not addressed. Once again, thanks for the
review. My comments follow inline. I am working on the new version of
this series.
On 12/14/2015 08:46 PM, Jonathon Jongsma wrote:
>> @@ -238,
On 12/14/2015 07:42 PM, Jonathon Jongsma wrote:
> On Fri, 2015-12-11 at 17:11 +, Daniel P. Berrange wrote:
>> On Fri, Dec 11, 2015 at 02:40:36PM -0200, Eduardo Lima (Etrunko) wrote:
>>> Signed-off-by: Eduardo Lima (Etrunko)
>>> ---
>>> configure.ac
-guint zoom =
> virt_viewer_display_get_zoom_level(VIRT_VIEWER_DISPLAY(self));
> +if (virt_viewer_display_get_zoom(self)) {
> +guint zoom = virt_viewer_display_get_zoom_level(self);
>
> preferred->width = round(preferred->width * NORMAL_ZOOM_LEVEL /
> (do
On 01/27/2016 03:33 PM, Pavel Grunt wrote:
> Avoid calling gtk_widget_queue_resize() and emitting
> the "display-desktop-resize" signal.
Just curious about why this change is necessary? I mean, isn't this
signal necessary somewhere else? I see it is handled in VirtViewerWindow.
If so, please prov
On 01/27/2016 03:03 PM, Pavel Grunt wrote:
> ---
> src/virt-viewer-display.c | 18 +++---
> 1 file changed, 7 insertions(+), 11 deletions(-)
>
> diff --git a/src/virt-viewer-display.c b/src/virt-viewer-display.c
> index 72ec56a..d1b088e 100644
> --- a/src/virt-viewer-display.c
> +++ b
On 02/02/2016 10:59 AM, Pavel Grunt wrote:
> Hi,
>
> On Tue, 2016-02-02 at 09:47 -0200, Eduardo Lima (Etrunko) wrote:
>> On 01/27/2016 03:33 PM, Pavel Grunt wrote:
>>> Avoid calling gtk_widget_queue_resize() and emitting
>>> the "display-desktop-resize"
ht = g_value_get_int(value);
> break;
> case PROP_NTH_DISPLAY:
> priv->nth_display = g_value_get_int(value);
>
Acked-by: Eduardo Lima (Etrunko)
--
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etru...@redhat.com
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list
ocation.width,
> child_allocation.height);
> - gtk_widget_size_allocate(child, &child_allocation);
> -}
> +g_debug("Child allocate %dx%d", child_allocation.width,
> child_allocation.height);
> +gtk_widget_size_allocate(child, &child_allocation);
>
; +guint zoom_level = virt_viewer_display_get_zoom_level(display);
The functions you removed access these fields directly? Any reason for
not doing it?
Acked-by: Eduardo Lima (Etrunko)
> +*preferred_dim = round(desktop_dim * zoom_level / (double)
> NORMAL_ZOOM_LEVEL);
> +
I guess this change answers the question I asked in the previous email. :)
Acked-by: Eduardo Lima (Etrunko)
On 02/05/2016 01:27 PM, Pavel Grunt wrote:
> It is possible to get the same info from the "zoom-level" property.
> virt_viewer_display_get_zoom() now returns TRUE if z
From: Fabiano Fidêncio
The 3.0 release was the last one that still supports GTK2. For the
Windows builds the support to GTK2 was dropped in the previous release.
Let's do the same for the entire project now.
---
configure.ac | 39 +++
src/view/autoDrawer.c | 10 -
nd it would be good to have those pushed, avoiding the maintenance
burden outside of the tree.
Eduardo Lima (Etrunko) (4):
Minor code cleanups
Port to GtkApplication API's
remote-viewer: Remove unused properties
Drop old compatibility code
Fabiano Fidêncio (1):
Drop suppo
The reason for using properties to access those members was to ensure
that they would only be set during the creation of the object. Now that
we removed that restriction, we set private members directly.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer.c | 101
x27;window-
removed' signals, as those will be emited by GtkApplication whenever
gtk_application_add_window() and gtk_application_remove_window() are
called. Also, 'window-removed' was not being used anywhere.
Signed-off-by: Eduardo Lima (Etrunko)
---
configure.ac
With glib requirements now being 2.38, these functions do not make sense anymore
Signed-off-by: Eduardo Lima (Etrunko)
---
src/virt-glib-compat.c | 15 ---
src/virt-glib-compat.h | 27 ---
2 files changed, 42 deletions(-)
diff --git a/src/virt-glib-compat.c
- Reuse #ifdef HAVE_SPICE_GTK block for include.
- Move declaration of vfunc together with others of the same class.
- Move variable declaration to the top of the function.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer.c | 13 +++--
1 file changed, 7 insertions(+), 6
)' failed
This does not happen with virt-viewer. I attached the gdb backtrace to
this mail.
On 02/12/2016 09:35 AM, Eduardo Lima (Etrunko) wrote:
[snip]
> diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
> index 653b30c..5b0e720 100644
> --- a/src/virt-viewer-app.c
On 02/12/2016 10:09 AM, Eduardo Lima (Etrunko) wrote:
> Running remote-viewer will throw some warnings:
>
> (remote-viewer:546): Gtk-CRITICAL **: gtk_application_get_app_menu:
> assertion 'GTK_IS_APPLICATION (application)' failed
>
> (remo
On 02/12/2016 03:26 PM, Eduardo Lima (Etrunko) wrote:
> On 02/12/2016 10:09 AM, Eduardo Lima (Etrunko) wrote:
>> Running remote-viewer will throw some warnings:
>>
>> (remote-viewer:546): Gtk-CRITICAL **: gtk_application_get_app_menu:
>> assertion 'GTK_IS_A
On 02/15/2016 11:48 AM, Fabiano Fidêncio wrote:
>
> This patch got already ACKed in one of the previous iterations?
> If yes, I'll push it. If it's not the case, I cannot ACK my own patch
> though :-)
>
I can ack it for you :P. But this one is already outdated due to Pavel's
recent changes in v
On 02/15/2016 11:51 AM, Fabiano Fidêncio wrote:
>
> Acked-by: Fabiano Fidêncio
>
> Anyways. was this patch already ACKed in the previous iterations, no?
>
It might have, but I don't have write permissions to the repositories,
so I can't push.
--
Eduardo de Barros Lima (Etrunko)
Software Engi
On 02/15/2016 11:47 AM, Fabiano Fidêncio wrote:
[snip]
>>
>> cleanup:
>> -g_free(uri);
>> -if (viewer)
>> -g_object_unref(viewer);
>> -g_strfreev(args);
>> -g_clear_error(&error);
>> -
>> +g_object_unref(viewer);
>
> g_object_unref() shouldn't be called with a NULL
On 02/15/2016 11:57 AM, Fabiano Fidêncio wrote:
>
> NACK from me.
> There is no reason for keeping an empty virt-glib-compat.c file.
> virt-glib-compat.h also could be removed entirely as g_clear_pointer()
> was introduced in 2.34. So, please, remove both files from the tree.
>
> Reviewed-by: Fab
- Reuse #ifdef HAVE_SPICE_GTK block for include.
- Move declaration of vfunc together with others of the same class.
- Move variable declaration to the top of the function.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer.c | 13 +++--
1 file changed, 7 insertions(+), 6
With glib requirements now being 2.38, these functions do not make sense
anymore.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/Makefile.am | 2 -
src/ovirt-foreign-menu.c| 1 -
src/virt-glib-compat.c | 34 -
src/virt-glib-compat.h
From: Fabiano Fidêncio
The 3.0 release was the last one that still supports GTK2. For the
Windows builds the support to GTK2 was dropped in the previous release.
Let's do the same for the entire project now.
Signed-off-by: Eduardo Lima (Etrunko)
---
configure.ac
The reason for using properties to access those members was to ensure
that they would only be set during the creation of the object. Now that
we removed that restriction, we set private members directly.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer.c | 101
In this version:
Rebased to latest master, fixed conflicts in virt-viewer-display.c.
Fix patch #3 according to review by Fabiano Fidencio.
Remove virt-glib-compat.[ch] files entirely from the tree. All functions
are now covered with new version requirements.
Eduardo Lima (Etrunko) (4):
Minor
x27;window-
removed' signals, as those will be emited by GtkApplication whenever
gtk_application_add_window() and gtk_application_remove_window() are
called. Also, 'window-removed' was not being used anywhere.
Signed-off-by: Eduardo Lima (Etrunko)
---
configure.ac
On 02/15/2016 12:31 PM, Eduardo Lima (Etrunko) wrote:
> diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c
> index 3a958f0..14549fd 100644
> --- a/src/virt-viewer-window.c
> +++ b/src/virt-viewer-window.c
> @@ -346,8 +346,7 @@ virt_viewer_window_init (VirtVie
With glib requirements now being 2.38, these functions do not make sense
anymore.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/Makefile.am | 2 -
src/ovirt-foreign-menu.c| 1 -
src/virt-glib-compat.c | 34 -
src/virt-glib-compat.h
The reason for using properties to access those members was to ensure
that they would only be set during the creation of the object. Now that
we removed that restriction, we set private members directly.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer.c | 101
In this version: Rebased to latest master
Eduardo Lima (Etrunko) (3):
Port to GtkApplication API's
remote-viewer: Remove unused properties
Drop old compatibility code
configure.ac| 6 +-
src/Makefile.am | 2 -
src/ovirt-foreign-menu.c
x27;window-
removed' signals, as those will be emited by GtkApplication whenever
gtk_application_add_window() and gtk_application_remove_window() are
called. Also, 'window-removed' was not being used anywhere.
Signed-off-by: Eduardo Lima (Etrunko)
---
configure.ac
On 02/16/2016 10:41 AM, Pavel Grunt wrote:
> Hi,
>
> On Mon, 2016-02-15 at 19:22 -0200, Eduardo Lima (Etrunko) wrote:
>> Most of this patch consists in code being shuffled around to fit the
>> expected flow while using the new APIs. I tried my best to make this
>>
On 02/16/2016 03:25 PM, Jonathon Jongsma wrote:
> Looks pretty good. Comments inline.
>
>> diff --git a/src/remote-viewer-main.c b/src/remote-viewer-main.c
>> index 81cf736..b05f27b 100644
>> --- a/src/remote-viewer-main.c
>> +++ b/src/remote-viewer-main.c
>> @@ -22,184 +22,29 @@
>>
>> #include
x27;window-
removed' signals, as those will be emited by GtkApplication whenever
gtk_application_add_window() and gtk_application_remove_window() are
called. Also, 'window-removed' was not being used anywhere.
Signed-off-by: Eduardo Lima (Etrunko)
---
configure.ac
g_object_new()
directly.
Eduardo Lima (Etrunko) (3):
Port to GtkApplication API's
remote-viewer: Remove unused properties
Drop old compatibility code
configure.ac| 6 +-
src/Makefile.am | 2 -
src/ovirt-foreign-menu.c| 1 -
src/r
With glib requirements now being 2.38, these functions do not make sense
anymore.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/Makefile.am | 2 -
src/ovirt-foreign-menu.c| 1 -
src/virt-glib-compat.c | 34 -
src/virt-glib-compat.h
The reason for using properties to access those members was to ensure
that they would only be set during the creation of the object. Now that
we removed that restriction, we set private members directly.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer.c | 101
On 02/17/2016 01:22 PM, Jonathon Jongsma wrote:
>>> I disagree, but again, I think it is basically a matter of
>>> preference.
>>
>> It is. From the macro name it is not clear for me how is different
>> "GOTO_END" from "goto end"
>
> For what it's worth, I agree with Pavel here. I think it actual
On 02/25/2016 04:21 AM, Fabiano Fidêncio wrote:
> The function was a bit hard to read and, mainly, hard to expand in a
> readable way when adding one more directory to try to load the ui file
> from.
>
> Signed-off-by: Fabiano Fidêncio
> ---
> src/virt-viewer-util.c | 60
> +
On 02/25/2016 04:20 AM, Fabiano Fidêncio wrote:
> The goal of these two patches are the $(subject).
> The first one is just doing a small refactoring in the _load_ui() in the way
> that introducing a new path to load a file from wouldn't be too confusing.
>
> As always, the most dificult part of w
UIRED])]
> + [PKG_CHECK_MODULES(LIBVIRT_GLIB, [libvirt-glib-1.0 >=
> $LIBVIRT_GLIB_REQUIRED])]
Maybe you could join the two checks into one, like:
[PKG_CHECK_MODULES(LIBVIRT, [libvirt >= $LIBVIRT_REQUIRED
libvirt-glib-1.0 >= $LIBVIRT_GLIB_REQUIRED])]
This would remove the need
On 02/24/2016 04:04 AM, Fabiano Fidêncio wrote:
> In order to avoid using a too new GLib API.
>
> Signed-off-by: Fabiano Fidêncio
> ---
> acinclude.m4 | 2 +-
> configure.ac | 10 +-
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/acinclude.m4 b/acinclude.m4
> inde
On 02/25/2016 06:11 PM, Fabiano Fidêncio wrote:
> On Thu, Feb 25, 2016 at 3:04 PM, Eduardo Lima (Etrunko)
> wrote:
>> On 02/23/2016 11:32 AM, Fabiano Fidêncio wrote:
>>> libvirt-glib dependency was dropped in commit 296f91c in favor to
>>> maintain the full glib ev
t; $(COMMON_LIBS) \
> $(LIBVIRT_LIBS) \
> - $(LIBVIRT_GLIB_LIBS)\
> $(NULL)
> virt_viewer_CFLAGS = \
> $(COMMON_CFLAGS)\
> $(LIBVIRT_CFLAG
Since commit a9ce19f it has not been possible to check app version from
a tty without X session running. The issue is that gtk_get_option_group
function opens the default display if passed TRUE as argument.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/virt-viewer-app.c | 2 +-
1 file changed
a/src/virt-viewer-about.xml
> +++ b/src/virt-viewer-about.xml
> @@ -4,7 +4,7 @@
>
> False
> 5
> -About Glade
> +About Virt-Viewer
> False
> True
> center-on-parent
>
Funny :)
Acked-by: Eduardo Lima (Etrunko)
--
Eduardo de Barros Lima
g to listen from more experienced people.
Reviewed-by: Eduardo Lima (Etrunko)
> Signed-off-by: Fabiano Fidêncio
> ---
> src/Makefile.am | 25 ++
> src/virt-viewer-about.xml | 1 -
> src/virt-viewer-app.c
On 03/01/2016 10:36 AM, Christophe Fergeau wrote:
> oVirt storage domains can be in various states (inactive, in
> maintainance, ...). We only want to show the ISOs it contains in the
> foreign menu when the storage domain is actually active, not in the
> other states.
> ---
> src/ovirt-foreign-me
On 03/01/2016 01:18 PM, Christophe Fergeau wrote:
> On Tue, Mar 01, 2016 at 12:55:48PM -0300, Eduardo Lima (Etrunko) wrote:
>> On 03/01/2016 10:36 AM, Christophe Fergeau wrote:
>>> oVirt storage domains can be in various states (inactive, in
>>> maintainance, ...). We on
On 02/29/2016 03:01 PM, Fabiano Fidêncio wrote:
> On Mon, Feb 29, 2016 at 6:27 PM, Eduardo Lima (Etrunko)
> wrote:
>> On 02/26/2016 07:38 PM, Fabiano Fidêncio wrote:
>>> Let's take advantage of GResource for loading ui files in a better and
>>> cleaner way
- added new condition to an existing if() block
>>
>> Fwiw, I prefer the v1 way which I find much easier to read.
>
> Same here.
V1 it is then :)
Acked-by: Eduardo Lima (Etrunko)
--
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etru...@redhat.com
virt-viewer.xml
> + alias="icons/16x16/virt-viewer.png">../icons/16x16/virt-viewer.png
> + alias="icons/22x22/virt-viewer.png">../icons/22x22/virt-viewer.png
> + alias="icons/24x24/virt-viewer.png">../icons/24x24/virt-viewer.png
> + alias="icons/24x24/virt-viewer-usb.png">../icons/24x24/virt-viewer-usb.png
> + alias="icons/32x32/virt-viewer.png">../icons/32x32/virt-viewer.png
> + alias="icons/48x48/virt-viewer.png">../icons/48x48/virt-viewer.png
> + alias="icons/256x256/virt-viewer.png">../icons/256x256/virt-viewer.png
> +
> +
> diff --git a/virt-viewer.spec.in b/virt-viewer.spec.in
> index 274e7e7..3c483ea 100644
> --- a/virt-viewer.spec.in
> +++ b/virt-viewer.spec.in
> @@ -122,15 +122,6 @@ fi
> %doc README COPYING AUTHORS ChangeLog NEWS
> %{_bindir}/%{name}
> %{_bindir}/remote-viewer
> -%dir %{_datadir}/%{name}
> -%dir %{_datadir}/%{name}/ui/
> -%{_datadir}/%{name}/ui/virt-viewer.xml
> -%{_datadir}/%{name}/ui/virt-viewer-auth.xml
> -%{_datadir}/%{name}/ui/virt-viewer-about.xml
> -%{_datadir}/%{name}/ui/virt-viewer-guest-details.xml
> -%{_datadir}/%{name}/ui/virt-viewer-vm-connection.xml
> -%{_datadir}/%{name}/ui/virt-viewer-preferences.xml
> -%{_datadir}/%{name}/ui/remote-viewer-connect.xml
> %{_datadir}/icons/hicolor/*/apps/*
> %{_datadir}/icons/hicolor/*/devices/*
> %{_datadir}/applications/remote-viewer.desktop
>
Looking good from my side. :)
Acked-by: Eduardo Lima (Etrunko)
--
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etru...@redhat.com
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list
On 03/02/2016 02:46 PM, Eduardo Lima (Etrunko) wrote:
> On 03/02/2016 12:23 PM, Fabiano Fidêncio wrote:
>> Let's take advantage of GResource for loading ui files in a better and
>> cleaner way than virt_viewer_util_load_ui() was doing.
>> It also brings the benefit, a
On 03/02/2016 05:24 PM, Fabiano Fidêncio wrote:
> On Wed, Mar 2, 2016 at 8:05 PM, Eduardo Lima (Etrunko)
> wrote:
>> On 03/02/2016 02:46 PM, Eduardo Lima (Etrunko) wrote:
>>> On 03/02/2016 12:23 PM, Fabiano Fidêncio wrote:
>>>> Let's take advantage of GRes
r-app.c
> @@ -36,9 +36,6 @@
> #include
> #include
>
> -#include
> -#include
> -
> #ifdef HAVE_SYS_SOCKET_H
> #include
> #endif
>
Acked-by: Eduardo Lima (Etrunko)
--
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etru...@redhat.com
__
On 03/11/2016 11:44 AM, Fabiano Fidêncio wrote:
[snip]
>> diff --git a/tests/Makefile.am b/tests/Makefile.am
>> new file mode 100644
>> index 000..470733b
>> --- /dev/null
>> +++ b/tests/Makefile.am
>> @@ -0,0 +1,30 @@
>> +NULL =
>> +
>> +AM_CPPFLAGS =
libvirt-viewer.la \
>> $(NULL)
>> endif
>> @@ -205,6 +218,7 @@ remote_viewer_CFLAGS = \
>> $(SPICE_CONTROLLER_CFLAGS) \
>> $(NULL)
>> remote_viewer_LDADD = \
>> + libvirt-view
On 11/11/2015 09:09 AM, Eduardo Lima (Etrunko) wrote:
> On 11/11/2015 05:11 AM, Pavel Grunt wrote:
>> Hi Eduardo,
>>
>> these warnings were introduced after spice-gtk v0.30 release, virt-viewer
>> currently depends on spice-gtk v0.29.35. You can make the code condition
Wcpp]
Signed-off-by: Eduardo Lima (Etrunko)
---
src/virt-viewer-display-spice.c | 2 +-
src/virt-viewer-display-spice.h | 3 +--
src/virt-viewer-session-spice.c | 5 +
src/virt-viewer-session-spice.h | 3 +--
4 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/src/virt-viewer-displa
Also, remove unecessary AC_SUBST calls
Signed-off-by: Eduardo Lima (Etrunko)
---
configure.ac | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/configure.ac b/configure.ac
index 6d8475b..ee9dc73 100644
--- a/configure.ac
+++ b/configure.ac
@@ -102,10 +102,8
On 03/15/2016 11:08 AM, Pavel Grunt wrote:
> On Tue, 2016-03-15 at 10:57 -0300, Eduardo Lima (Etrunko) wrote:
>> On 11/11/2015 09:09 AM, Eduardo Lima (Etrunko) wrote:
>>>
>>> On 11/11/2015 05:11 AM, Pavel Grunt wrote:
>>>>
>>>> Hi Eduardo,
>&
On 03/22/2016 07:57 AM, Pavel Grunt wrote:
> Hi,
>
> you need to bump spice-gtk dependency to v0.31, because these headers
> are not in v0.30 and virt-viewer currently depends on v0.30.
>
Oh, I missed that. Thanks for the note, I will send a new version with
the new dependency.
--
Eduardo de B
On 03/22/2016 08:02 AM, Pavel Grunt wrote:
> Hi,
>
> imo with the change the line is too long
>
> About the AC_SUBST calls - iirc they are defined automatically when
> pkg-config is >= 0.24 (not the case of rhel6).
> Or is it about something else (why just _LIBS and not _CFLAGS) ?
>
About line
1 - 100 of 429 matches
Mail list logo
