Re: [virt-tools-list] [PATCH virt-viewer v3] ovirt-foreign-menu: Bypass errors from Host/Cluster/Data Center

2019-06-07 Thread Eduardo Lima (Etrunko)
On 6/7/19 10:37 AM, Christophe Fergeau wrote: > On Fri, Jun 07, 2019 at 10:04:19AM -0300, Eduardo Lima (Etrunko) wrote: >> On 6/6/19 1:22 PM, Christophe Fergeau wrote: >>> Hey, >>> >>> I'm not really comfortable with that patch, which ignores some errors, >>> and adds some code not to crash when

Re: [virt-tools-list] [PATCH virt-viewer v3] ovirt-foreign-menu: Bypass errors from Host/Cluster/Data Center

2019-06-07 Thread Christophe Fergeau
On Fri, Jun 07, 2019 at 10:04:19AM -0300, Eduardo Lima (Etrunko) wrote: > On 6/6/19 1:22 PM, Christophe Fergeau wrote: > > Hey, > > > > I'm not really comfortable with that patch, which ignores some errors, > > and adds some code not to crash when we do that, in the hope that the > > end result

Re: [virt-tools-list] [PATCH virt-viewer v3] ovirt-foreign-menu: Bypass errors from Host/Cluster/Data Center

2019-06-07 Thread Eduardo Lima (Etrunko)
On 6/6/19 1:22 PM, Christophe Fergeau wrote: > Hey, > > I'm not really comfortable with that patch, which ignores some errors, > and adds some code not to crash when we do that, in the hope that the > end result will make sense. I'm under the impression that if the oVirt > instance does not have

Re: [virt-tools-list] [PATCH virt-viewer v3] ovirt-foreign-menu: Bypass errors from Host/Cluster/Data Center

2019-06-06 Thread Christophe Fergeau
Hey, I'm not really comfortable with that patch, which ignores some errors, and adds some code not to crash when we do that, in the hope that the end result will make sense. I'm under the impression that if the oVirt instance does not have the permissions issues that you mention, but if instead

Re: [virt-tools-list] [PATCH virt-viewer v3] ovirt-foreign-menu: Bypass errors from Host/Cluster/Data Center

2019-05-28 Thread Eduardo Lima (Etrunko)
ping On 4/10/19 5:20 PM, Eduardo Lima (Etrunko) wrote: > When accessing ovirt as a regular user, it may happen that queries to > Hosts, Clusters and Data Centers return errors due to insufficient > permissions, while they will work fine if access is done by admin user. > In this case, we skip the

[virt-tools-list] [PATCH virt-viewer v3] ovirt-foreign-menu: Bypass errors from Host/Cluster/Data Center

2019-04-10 Thread Eduardo Lima (Etrunko)
When accessing ovirt as a regular user, it may happen that queries to Hosts, Clusters and Data Centers return errors due to insufficient permissions, while they will work fine if access is done by admin user. In this case, we skip the errors and fallback to the old method. Signed-off-by: Eduardo