RE: [virtio-dev] Re: [Qemu-devel] [virtio-dev] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

2017-02-09 Thread Gonglei (Arei)
Hi, > > > On 02/08/2017 07:24 AM, Gonglei (Arei) wrote: > > Hi Halil, > > > > Thanks for your comments firstly. > > > > You are welcome :). Sorry it took so long -- I'm currently > quite busy. > It's fine. > >> > >> On 01/18/2017 09:22 AM, Gonglei wrote: > >>> The virtio crypto device is a v

[virtio-dev] Re: packed ring layout proposal v2

2017-02-09 Thread Christian Borntraeger
On 02/09/2017 06:43 PM, Michael S. Tsirkin wrote: [...] >> [...] >>> Note: should this proposal be accepted and approved, one or more >>> claims disclosed to the TC admin and listed on the Virtio TC >>> IPR page https://www.oasis-open.org/committees/virtio/ipr.php >>> might becom

Re: [virtio-dev] packed ring layout proposal v2

2017-02-09 Thread Michael S. Tsirkin
On Thu, Feb 09, 2017 at 04:48:53PM +0100, Paolo Bonzini wrote: > > > On 08/02/2017 20:59, Michael S. Tsirkin wrote: > > We couldn't decide what's better for everyone in 1.0 days and I doubt > > we'll be able to now, but yes, benchmarking is needed to make > > sire it's required. Very easy to remo

[virtio-dev] Re: packed ring layout proposal v2

2017-02-09 Thread Michael S. Tsirkin
On Wed, Feb 08, 2017 at 02:37:57PM +0100, Christian Borntraeger wrote: > On 02/08/2017 04:20 AM, Michael S. Tsirkin wrote: > [...] > > * Prototype > > > > A partial prototype can be found under > > tools/virtio/ringtest/ring.c > > > > Test run: > > [mst@tuck ringtest]$ time ./ring > > real0m

Re: [virtio-dev] packed ring layout proposal v2

2017-02-09 Thread Cornelia Huck
On Thu, 9 Feb 2017 16:48:53 +0100 Paolo Bonzini wrote: > On 08/02/2017 20:59, Michael S. Tsirkin wrote: > > We couldn't decide what's better for everyone in 1.0 days and I doubt > > we'll be able to now, but yes, benchmarking is needed to make > > sire it's required. Very easy to remove or not to

Re: [virtio-dev] packed ring layout proposal v2

2017-02-09 Thread Paolo Bonzini
On 08/02/2017 20:59, Michael S. Tsirkin wrote: > We couldn't decide what's better for everyone in 1.0 days and I doubt > we'll be able to now, but yes, benchmarking is needed to make > sire it's required. Very easy to remove or not to use/support in > drivers/devices though. Fair enough, but of

Re: [virtio-dev] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

2017-02-09 Thread Cornelia Huck
On Wed, 8 Feb 2017 03:46:53 + "Gonglei (Arei)" wrote: > Hi Cornelia, > > > > > On Tue, 7 Feb 2017 12:39:44 +0100 > > Halil Pasic wrote: > > > > > On 01/18/2017 09:22 AM, Gonglei wrote: > > > > > +The following services are defined: > > > > + > > > > +\begin{lstlisting} > > > > +/* CIPHER