[virtio-dev] Add VIRTIO_NET_F_SPEED_DUPLEX (4) feature bit

2017-12-14 Thread Jason Baron
Hi, We have found it useful to have the virtio net device export a linkspeed and duplex setting, such that a guest linkspeed and duplex settings can be set automatically from the host side. We have some guest software that relies on this setting, and fails without a valid value provided. Thus, I w

Re: [virtio-dev] Re: [Qemu-devel] [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication

2017-12-14 Thread Stefan Hajnoczi
On Thu, Dec 14, 2017 at 05:50:22PM +0100, Maxime Coquelin wrote: > > > On 12/14/2017 05:40 PM, Michael S. Tsirkin wrote: > > On Thu, Dec 14, 2017 at 05:39:19PM +0100, Maxime Coquelin wrote: > > > > > > > > > On 12/14/2017 05:27 PM, Michael S. Tsirkin wrote: > > > > On Thu, Dec 14, 2017 at 03:46

[virtio-dev] Re: [Qemu-devel] [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication

2017-12-14 Thread Stefan Hajnoczi
On Thu, Dec 14, 2017 at 01:53:16PM +0800, Wei Wang wrote: > 3rd one: I'm not able to solve this one, as discussed, there are too many > differences and it's too complex. I prefer the direction of simply gating > the vhost-user protocol and deliver to the guest what it should see (just > what this p

[virtio-dev] Re: [PATCH v3 4/7] vhost-pci-slave: add vhost-pci slave implementation

2017-12-14 Thread Stefan Hajnoczi
On Tue, Dec 05, 2017 at 11:33:13AM +0800, Wei Wang wrote: > The vhost-pci slave implementation is added to support the creation of > the vhost-pci-net device. It follows the vhost-user protocol to get the > master VM's info (e.g. memory regions, vring address). How does the guest know when the QEM

[virtio-dev] Re: [Qemu-devel] [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication

2017-12-14 Thread Stefan Hajnoczi
On Thu, Dec 14, 2017 at 01:53:16PM +0800, Wei Wang wrote: > On 12/13/2017 08:35 PM, Stefan Hajnoczi wrote: > > On Wed, Dec 13, 2017 at 04:11:45PM +0800, Wei Wang wrote: > > > > I think the current approach is fine for a prototype but is not suitable > > for wider use by the community because it: >

[virtio-dev] Re: [PATCH v3 4/7] vhost-pci-slave: add vhost-pci slave implementation

2017-12-14 Thread Stefan Hajnoczi
On Tue, Dec 05, 2017 at 11:33:13AM +0800, Wei Wang wrote: > +static void vp_slave_set_vring_addr(VhostPCINet *vpnet, VhostUserMsg *msg) > +{ > +uint32_t index = msg->payload.addr.index; > + > +vpnet->metadata->vq[index].desc_gpa = msg->payload.addr.desc_user_addr; > +vpnet->metadata->vq

Re: [virtio-dev] Re: [Qemu-devel] [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication

2017-12-14 Thread Maxime Coquelin
On 12/14/2017 05:40 PM, Michael S. Tsirkin wrote: On Thu, Dec 14, 2017 at 05:39:19PM +0100, Maxime Coquelin wrote: On 12/14/2017 05:27 PM, Michael S. Tsirkin wrote: On Thu, Dec 14, 2017 at 03:46:56PM +, Stefan Hajnoczi wrote: On Wed, Dec 13, 2017 at 10:50:11PM +0100, Maxime Coquelin wr

Re: [virtio-dev] Re: [Qemu-devel] [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication

2017-12-14 Thread Michael S. Tsirkin
On Thu, Dec 14, 2017 at 05:39:19PM +0100, Maxime Coquelin wrote: > > > On 12/14/2017 05:27 PM, Michael S. Tsirkin wrote: > > On Thu, Dec 14, 2017 at 03:46:56PM +, Stefan Hajnoczi wrote: > > > On Wed, Dec 13, 2017 at 10:50:11PM +0100, Maxime Coquelin wrote: > > > > On 12/13/2017 09:08 PM, Stef

Re: [virtio-dev] Re: [Qemu-devel] [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication

2017-12-14 Thread Maxime Coquelin
On 12/14/2017 05:27 PM, Michael S. Tsirkin wrote: On Thu, Dec 14, 2017 at 03:46:56PM +, Stefan Hajnoczi wrote: On Wed, Dec 13, 2017 at 10:50:11PM +0100, Maxime Coquelin wrote: On 12/13/2017 09:08 PM, Stefan Hajnoczi wrote: On Wed, Dec 13, 2017 at 3:01 PM, Michael S. Tsirkin wrote: On W

Re: [virtio-dev] Re: [Qemu-devel] [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication

2017-12-14 Thread Michael S. Tsirkin
On Thu, Dec 14, 2017 at 03:46:56PM +, Stefan Hajnoczi wrote: > On Wed, Dec 13, 2017 at 10:50:11PM +0100, Maxime Coquelin wrote: > > On 12/13/2017 09:08 PM, Stefan Hajnoczi wrote: > > > On Wed, Dec 13, 2017 at 3:01 PM, Michael S. Tsirkin > > > wrote: > > > > On Wed, Dec 13, 2017 at 12:35:21PM

Re: [virtio-dev] Re: [Qemu-devel] [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication

2017-12-14 Thread Stefan Hajnoczi
On Wed, Dec 13, 2017 at 10:50:11PM +0100, Maxime Coquelin wrote: > On 12/13/2017 09:08 PM, Stefan Hajnoczi wrote: > > On Wed, Dec 13, 2017 at 3:01 PM, Michael S. Tsirkin wrote: > > > On Wed, Dec 13, 2017 at 12:35:21PM +, Stefan Hajnoczi wrote: > > > > I'm not saying that DPDK should use libvho

[virtio-dev] Re: [Qemu-devel] [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication

2017-12-14 Thread Stefan Hajnoczi
On Wed, Dec 13, 2017 at 10:59:10PM +0200, Michael S. Tsirkin wrote: > > * VHOST_USER_SET_VRING_KICK > > > >Set up vring kick doorbell (unless bit 8 is set) before sending > >VHOST_USER_SET_VRING_KICK to the guest. > > But guest can't use it, now can it? > > What guest needs is a mapping

Re: [virtio-dev] Re: [PATCH v19 3/7] xbitmap: add more operations

2017-12-14 Thread Wei Wang
On 12/14/2017 11:47 AM, Wei Wang wrote: On 12/13/2017 10:16 PM, Tetsuo Handa wrote: if (set) ret = find_next_bit(&tmp, BITS_PER_LONG, ebit); else ret = find_next_zero_bit(&