[virtio-dev] Re: [Qemu-devel] [PATCH v1 0/6] Extend vhost-user to support VFIO based accelerators

2018-01-25 Thread Tiwei Bie
On Thu, Jan 25, 2018 at 02:22:20PM +, Stefan Hajnoczi wrote: > On Thu, Jan 25, 2018 at 12:03:22PM +0800, Tiwei Bie wrote: > > Why extend vhost-user for vDPA > > == > > > > We have already implemented various virtual switches (e.g. OVS-DPDK) > > based on vhost-user f

Re: [virtio-dev] Re: [PATCH v1 6/6] vhost-user: add VFIO based accelerators support

2018-01-25 Thread Tiwei Bie
On Fri, Jan 26, 2018 at 11:41:27AM +0800, Jason Wang wrote: > On 2018年01月26日 07:59, Michael S. Tsirkin wrote: > > > The virtual IOMMU isn't supported by the accelerators for now. > > > Because vhost-user currently lacks of an efficient way to share > > > the IOMMU table in VM to vhost backend. That

Re: [virtio-dev] Re: [PATCH v1 6/6] vhost-user: add VFIO based accelerators support

2018-01-25 Thread Jason Wang
On 2018年01月26日 07:59, Michael S. Tsirkin wrote: The virtual IOMMU isn't supported by the accelerators for now. Because vhost-user currently lacks of an efficient way to share the IOMMU table in VM to vhost backend. That's why the software implementation of virtual IOMMU support in vhost-user ba

Re: [virtio-dev] Re: [PATCH v25 2/2] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-01-25 Thread Wei Wang
On 01/26/2018 10:42 AM, Michael S. Tsirkin wrote: On Fri, Jan 26, 2018 at 09:40:44AM +0800, Wei Wang wrote: On 01/25/2018 09:49 PM, Michael S. Tsirkin wrote: On Thu, Jan 25, 2018 at 05:14:06PM +0800, Wei Wang wrote: The controversy is that the free list is not static once the lock is droppe

[virtio-dev] Re: [PATCH v24 1/2] mm: support reporting free page blocks

2018-01-25 Thread Wei Wang
On 01/25/2018 09:41 PM, Michael S. Tsirkin wrote: On Wed, Jan 24, 2018 at 06:42:41PM +0800, Wei Wang wrote: This patch adds support to walk through the free page blocks in the system and report them via a callback function. Some page blocks may leave the free list after zone->lock is released, s

Re: [virtio-dev] Re: [PATCH v25 2/2] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-01-25 Thread Michael S. Tsirkin
On Fri, Jan 26, 2018 at 09:40:44AM +0800, Wei Wang wrote: > On 01/25/2018 09:49 PM, Michael S. Tsirkin wrote: > > On Thu, Jan 25, 2018 at 05:14:06PM +0800, Wei Wang wrote: > > > + > > > +static void report_free_page_func(struct work_struct *work) > > > +{ > > > + struct virtio_balloon *vb; > > > +

[virtio-dev] Re: [PATCH v25 1/2 RESEND] mm: support reporting free page blocks

2018-01-25 Thread Wei Wang
On 01/26/2018 06:41 AM, Andrew Morton wrote: On Thu, 25 Jan 2018 17:38:27 +0800 Wei Wang wrote: This patch adds support to walk through the free page blocks in the system and report them via a callback function. Some page blocks may leave the free list after zone->lock is released, so it is th

Re: [virtio-dev] Re: [PATCH v25 2/2] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-01-25 Thread Wei Wang
On 01/25/2018 09:49 PM, Michael S. Tsirkin wrote: On Thu, Jan 25, 2018 at 05:14:06PM +0800, Wei Wang wrote: + +static void report_free_page_func(struct work_struct *work) +{ + struct virtio_balloon *vb; + int ret; + + vb = container_of(work, struct virtio_balloon, report_free_p

[virtio-dev] Re: [PATCH v1 6/6] vhost-user: add VFIO based accelerators support

2018-01-25 Thread Michael S. Tsirkin
On Thu, Jan 25, 2018 at 12:03:28PM +0800, Tiwei Bie wrote: > This patch does some small extensions to vhost-user protocol to > support VFIO based accelerators, and makes it possible to get the > similar performance of VFIO based PCI passthru while keeping the > virtio device emulation in QEMU. > >

[virtio-dev] Re: [PATCH v24 1/2] mm: support reporting free page blocks

2018-01-25 Thread Michael S. Tsirkin
On Thu, Jan 25, 2018 at 09:56:01AM -0500, Pankaj Gupta wrote: > > > > > On Wed, Jan 24, 2018 at 06:42:41PM +0800, Wei Wang wrote: > > > This patch adds support to walk through the free page blocks in the > > > system and report them via a callback function. Some page blocks may > > > leave the fr

[virtio-dev] Re: [RFC virtio-net 1/1] content: net: Add VIRTIO_NET_F_CTRL_RSS feature

2018-01-25 Thread Sameeh Jubran
Please ignore the typos, I mistakenly sent the patch without the fixes. I'll resend the fixes along with v2. On Thu, Jan 25, 2018 at 6:27 PM, Sameeh Jubran wrote: > From: Sameeh Jubran > > Most modern high end network devices today support configurable hash > functions, > this commit introduces

[virtio-dev] [RFC virtio-net 1/1] content: net: Add VIRTIO_NET_F_CTRL_RSS feature

2018-01-25 Thread Sameeh Jubran
From: Sameeh Jubran Most modern high end network devices today support configurable hash functions, this commit introduces RSS - Receive Side Scaling - [1] to virtio net device. The RSS is a technology from Microsoft that boosts network device performance by efficiently distributing the traffic

[virtio-dev] [RFC virtio-net 0/1] introducing RSS into virtio-net

2018-01-25 Thread Sameeh Jubran
From: Sameeh Jubran Hi all, Most modern high end network devices today support configurable hash functions, the following commit introduces RSS - Receive Side Scaling - [1] into virtio net device. RSS is a technology developed by Microsoft that boosts network device performance by efficiently di

[virtio-dev] RE: [Qemu-devel] [PATCH v1 0/6] Extend vhost-user to support VFIO based accelerators

2018-01-25 Thread Liang, Cunming
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Thursday, January 25, 2018 10:22 PM > To: Bie, Tiwei > Cc: qemu-de...@nongnu.org; virtio-dev@lists.oasis-open.org; > m...@redhat.com; alex.william...@redhat.com; jasow...@redhat.com; > pbonz...@redhat.com;

[virtio-dev] Re: [PATCH v25 2/2] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-01-25 Thread Michael S. Tsirkin
On Thu, Jan 25, 2018 at 05:14:06PM +0800, Wei Wang wrote: > Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_HINT feature indicates the > support of reporting hints of guest free pages to host via virtio-balloon. > > Host requests the guest to report free pages by sending a new cmd > id to the guest

[virtio-dev] Re: [PATCH v25 1/2] mm: support reporting free page blocks

2018-01-25 Thread Michael S. Tsirkin
On Thu, Jan 25, 2018 at 05:14:05PM +0800, Wei Wang wrote: > This patch adds support to walk through the free page blocks in the > system and report them via a callback function. Some page blocks may > leave the free list after zone->lock is released, so it is the caller's > responsibility to either

[virtio-dev] Re: [PATCH v24 1/2] mm: support reporting free page blocks

2018-01-25 Thread Michael S. Tsirkin
On Wed, Jan 24, 2018 at 06:42:41PM +0800, Wei Wang wrote: > This patch adds support to walk through the free page blocks in the > system and report them via a callback function. Some page blocks may > leave the free list after zone->lock is released, so it is the caller's > responsibility to either

[virtio-dev] Re: [PATCH v24 2/2] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-01-25 Thread Wei Wang
On 01/25/2018 07:28 PM, Tetsuo Handa wrote: On 2018/01/25 12:32, Wei Wang wrote: On 01/25/2018 01:15 AM, Michael S. Tsirkin wrote: On Wed, Jan 24, 2018 at 06:42:42PM +0800, Wei Wang wrote: + +static void report_free_page_func(struct work_struct *work) +{ +struct virtio_balloon *vb; +uns

Re: [virtio-dev] [PATCH v25 1/2 RESEND] mm: support reporting free page blocks

2018-01-25 Thread Wei Wang
Hi Michal, On 01/25/2018 05:38 PM, Wei Wang wrote: This patch adds support to walk through the free page blocks in the system and report them via a callback function. Some page blocks may leave the free list after zone->lock is released, so it is the caller's responsibility to either detect or p

[virtio-dev] [PATCH v25 1/2 RESEND] mm: support reporting free page blocks

2018-01-25 Thread Wei Wang
This patch adds support to walk through the free page blocks in the system and report them via a callback function. Some page blocks may leave the free list after zone->lock is released, so it is the caller's responsibility to either detect or prevent the use of such pages. One use example of this

[virtio-dev] Re: [PATCH v24 2/2] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-01-25 Thread Wei Wang
On 01/25/2018 01:15 AM, Michael S. Tsirkin wrote: On Wed, Jan 24, 2018 at 06:42:42PM +0800, Wei Wang wrote: What is this doing? Basically handling the case where vq is broken? It's kind of ugly to tweak feature bits, most code assumes they never change. Please just return an error to caller

[virtio-dev] [PATCH v25 2/2] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-01-25 Thread Wei Wang
Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_HINT feature indicates the support of reporting hints of guest free pages to host via virtio-balloon. Host requests the guest to report free pages by sending a new cmd id to the guest via the free_page_report_cmd_id configuration register. When the gu

[virtio-dev] [PATCH v25 1/2] mm: support reporting free page blocks

2018-01-25 Thread Wei Wang
This patch adds support to walk through the free page blocks in the system and report them via a callback function. Some page blocks may leave the free list after zone->lock is released, so it is the caller's responsibility to either detect or prevent the use of such pages. One use example of this

[virtio-dev] [PATCH v25 0/2] Virtio-balloon: support free page reporting

2018-01-25 Thread Wei Wang
This patch series is separated from the previous "Virtio-balloon Enhancement" series. The new feature, VIRTIO_BALLOON_F_FREE_PAGE_HINT, implemented by this series enables the virtio-balloon driver to report hints of guest free pages to the host. It can be used to accelerate live migration of VMs.