[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

2018-03-12 Thread Siwei Liu
Apologies, still some comments going. Please see inline. On Thu, Mar 1, 2018 at 12:08 PM, Sridhar Samudrala wrote: > This patch enables virtio_net to switch over to a VF datapath when a VF > netdev is present with the same MAC address. It allows live migration > of a

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

2018-03-12 Thread Siwei Liu
On Sat, Mar 3, 2018 at 8:04 PM, Michael S. Tsirkin wrote: > On Fri, Mar 02, 2018 at 03:56:31PM -0800, Siwei Liu wrote: >> On Fri, Mar 2, 2018 at 1:36 PM, Michael S. Tsirkin wrote: >> > On Fri, Mar 02, 2018 at 01:11:56PM -0800, Siwei Liu wrote: >> >> On Thu, Mar

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

2018-03-12 Thread Samudrala, Sridhar
On 3/12/2018 1:12 PM, Jiri Pirko wrote: Thu, Mar 01, 2018 at 09:08:43PM CET, sridhar.samudr...@intel.com wrote: This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF

[virtio-dev] Re: [pci PATCH v5 1/4] pci: Add pci_sriov_configure_simple for PFs that don't manage VF resources

2018-03-12 Thread Alexander Duyck
On Mon, Mar 12, 2018 at 11:23 AM, Keith Busch wrote: > On Mon, Mar 12, 2018 at 11:09:34AM -0700, Alexander Duyck wrote: >> On Mon, Mar 12, 2018 at 10:40 AM, Keith Busch wrote: >> > On Mon, Mar 12, 2018 at 10:21:29AM -0700, Alexander Duyck wrote: >>

Re: [virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

2018-03-12 Thread Samudrala, Sridhar
On 3/7/2018 12:11 PM, Michael S. Tsirkin wrote: On Wed, Mar 07, 2018 at 10:06:30AM -0800, Stephen Hemminger wrote: On Wed, 7 Mar 2018 09:50:50 -0800 Alexander Duyck wrote: On Tue, Mar 6, 2018 at 6:38 PM, Michael S. Tsirkin wrote: On Tue, Mar 06,

[virtio-dev] Re: [pci PATCH v5 1/4] pci: Add pci_sriov_configure_simple for PFs that don't manage VF resources

2018-03-12 Thread Alexander Duyck
On Mon, Mar 12, 2018 at 10:40 AM, Keith Busch wrote: > On Mon, Mar 12, 2018 at 10:21:29AM -0700, Alexander Duyck wrote: >> diff --git a/include/linux/pci.h b/include/linux/pci.h >> index 024a1beda008..9cab9d0d51dc 100644 >> --- a/include/linux/pci.h >> +++

[virtio-dev] Re: [pci PATCH v5 0/4] Add support for unmanaged SR-IOV (was: Series short description)

2018-03-12 Thread Alexander Duyck
On Mon, Mar 12, 2018 at 10:20 AM, Alexander Duyck wrote: > This series is meant to add support for SR-IOV on devices when the VFs are > not managed by the kernel. Examples of recent patches attempting to do this > include: > virto -

[virtio-dev] [pci PATCH v5 4/4] nvme: Migrate over to unmanaged SR-IOV support

2018-03-12 Thread Alexander Duyck
From: Alexander Duyck Instead of implementing our own version of a SR-IOV configuration stub in the nvme driver we can just reuse the existing pci_sriov_configure_simple function. Signed-off-by: Alexander Duyck --- v5: Replaced call to

[virtio-dev] [pci PATCH v5 3/4] ena: Migrate over to unmanaged SR-IOV support

2018-03-12 Thread Alexander Duyck
From: Alexander Duyck Instead of implementing our own version of a SR-IOV configuration stub in the ena driver we can just reuse the existing pci_sriov_configure_simple function. Signed-off-by: Alexander Duyck --- v5: Replaced call to

[virtio-dev] [pci PATCH v5 2/4] virtio_pci: Add support for unmanaged SR-IOV on virtio_pci devices

2018-03-12 Thread Alexander Duyck
From: Alexander Duyck Hardware-realized virtio_pci devices can implement SR-IOV, so this patch enables its use. The device in question is an upcoming Intel NIC that implements both a virtio_net PF and virtio_net VFs. These are hardware realizations of what has been

[virtio-dev] [pci PATCH v5 1/4] pci: Add pci_sriov_configure_simple for PFs that don't manage VF resources

2018-03-12 Thread Alexander Duyck
From: Alexander Duyck This patch adds a common configuration function called pci_sriov_configure_simple that will allow for managing VFs on devices where the PF is not capable of managing VF resources. Signed-off-by: Alexander Duyck ---

[virtio-dev] [pci PATCH v5 0/4] Series short description

2018-03-12 Thread Alexander Duyck
This series is meant to add support for SR-IOV on devices when the VFs are not managed by the kernel. Examples of recent patches attempting to do this include: virto - https://patchwork.kernel.org/patch/10241225/ pci-stub - https://patchwork.kernel.org/patch/10109935/ vfio -

[virtio-dev] Re: [virtio-comment] [PATCH v3] virtio-blk: add discard and write zeroes features to specification

2018-03-12 Thread Paolo Bonzini
On 12/03/2018 17:19, Laszlo Ersek wrote: > virtio-scsi already supports discard and write zeroes, and virtio-scsi > can be backed by SSDs. Can you please describe the use case in the > commit message (in a few words) that needs discard / write zeroes but is > ill-served by virtio-scsi? > > I

[virtio-dev] Re: [pci PATCH v4 1/4] pci-iov: Add support for unmanaged SR-IOV

2018-03-12 Thread Alexander Duyck
On Mon, Mar 12, 2018 at 12:59 AM, Christoph Hellwig wrote: > On Sun, Mar 11, 2018 at 09:59:09PM -0600, Alex Williamson wrote: >> I still struggle to understand why we need this "unmanaged" >> complication and how a user of the sysfs API is expected to have any >> idea whether a PF is