Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

2018-04-18 Thread Siwei Liu
On Wed, Apr 18, 2018 at 11:10 PM, Samudrala, Sridhar wrote: > > On 4/18/2018 10:07 PM, Michael S. Tsirkin wrote: >> >> On Wed, Apr 18, 2018 at 10:00:51PM -0700, Samudrala, Sridhar wrote: >>> >>> On 4/18/2018 9:41 PM, Michael S. Tsirkin wrote: On Wed, Apr 18, 2018 at 04:33:34PM -0700, Sam

Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

2018-04-18 Thread Siwei Liu
On Wed, Apr 18, 2018 at 10:00 PM, Samudrala, Sridhar wrote: > On 4/18/2018 9:41 PM, Michael S. Tsirkin wrote: >> >> On Wed, Apr 18, 2018 at 04:33:34PM -0700, Samudrala, Sridhar wrote: >>> >>> On 4/17/2018 5:26 PM, Siwei Liu wrote: I ran this with a few folks offline and gathered some goo

Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

2018-04-18 Thread Samudrala, Sridhar
On 4/18/2018 10:07 PM, Michael S. Tsirkin wrote: On Wed, Apr 18, 2018 at 10:00:51PM -0700, Samudrala, Sridhar wrote: On 4/18/2018 9:41 PM, Michael S. Tsirkin wrote: On Wed, Apr 18, 2018 at 04:33:34PM -0700, Samudrala, Sridhar wrote: On 4/17/2018 5:26 PM, Siwei Liu wrote: I ran this with a fe

Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

2018-04-18 Thread Michael S. Tsirkin
On Wed, Apr 18, 2018 at 10:00:51PM -0700, Samudrala, Sridhar wrote: > On 4/18/2018 9:41 PM, Michael S. Tsirkin wrote: > > On Wed, Apr 18, 2018 at 04:33:34PM -0700, Samudrala, Sridhar wrote: > > > On 4/17/2018 5:26 PM, Siwei Liu wrote: > > > > I ran this with a few folks offline and gathered some go

Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

2018-04-18 Thread Samudrala, Sridhar
On 4/18/2018 9:41 PM, Michael S. Tsirkin wrote: On Wed, Apr 18, 2018 at 04:33:34PM -0700, Samudrala, Sridhar wrote: On 4/17/2018 5:26 PM, Siwei Liu wrote: I ran this with a few folks offline and gathered some good feedbacks that I'd like to share thus revive the discussion. First of all, as il

Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

2018-04-18 Thread Michael S. Tsirkin
On Wed, Apr 18, 2018 at 04:33:34PM -0700, Samudrala, Sridhar wrote: > On 4/17/2018 5:26 PM, Siwei Liu wrote: > > I ran this with a few folks offline and gathered some good feedbacks > > that I'd like to share thus revive the discussion. > > > > First of all, as illustrated in the reply below, clou

[virtio-dev] Re: [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

2018-04-18 Thread Michael S. Tsirkin
On Wed, Apr 18, 2018 at 10:32:06PM +0200, Jiri Pirko wrote: > >> >> > With regards to alternate names for 'active', you suggested 'stolen', > >> >> > but i > >> >> > am not too happy with it. > >> >> > netvsc uses vf_netdev, are you OK with this? Or another option is > >> >> > 'passthru' > >> >>

Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

2018-04-18 Thread Samudrala, Sridhar
On 4/17/2018 5:26 PM, Siwei Liu wrote: I ran this with a few folks offline and gathered some good feedbacks that I'd like to share thus revive the discussion. First of all, as illustrated in the reply below, cloud service providers require transparent live migration. Specifically, the main targe

[virtio-dev] Re: [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

2018-04-18 Thread Samudrala, Sridhar
On 4/18/2018 1:32 PM, Jiri Pirko wrote: You still use "active"/"backup" names which is highly misleading as it has completely different meaning that in bond for example. I noted that in my previous review already. Please change it. I guess the issue is with only the 'active'  name. 'backup' shou

Re: [virtio-dev] Re: [PATCH] content: document hugetlb page allocation counts

2018-04-18 Thread Jonathan Helman
On 04/18/2018 01:03 PM, Michael S. Tsirkin wrote: On Wed, Apr 18, 2018 at 10:10:19AM -0700, Jonathan Helman wrote: The Linux kernel exports the number of successful and failed hugetlb page allocations via the virtio balloon driver. These two counts need to be documented in this specification.

[virtio-dev] Re: [PATCH] content: document hugetlb page allocation counts

2018-04-18 Thread Michael S. Tsirkin
On Wed, Apr 18, 2018 at 10:10:19AM -0700, Jonathan Helman wrote: > The Linux kernel exports the number of successful and failed > hugetlb page allocations via the virtio balloon driver. These > two counts need to be documented in this specification. > > Signed-off-by: Jonathan Helman Thanks! Wou

[virtio-dev] Re: [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

2018-04-18 Thread Michael S. Tsirkin
On Wed, Apr 18, 2018 at 09:13:15PM +0200, Jiri Pirko wrote: > Wed, Apr 18, 2018 at 08:43:15PM CEST, sridhar.samudr...@intel.com wrote: > >On 4/18/2018 2:25 AM, Jiri Pirko wrote: > >> Wed, Apr 11, 2018 at 09:13:52PM CEST, sridhar.samudr...@intel.com wrote: > >> > On 4/11/2018 8:51 AM, Jiri Pirko wro

[virtio-dev] Re: [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

2018-04-18 Thread Samudrala, Sridhar
On 4/18/2018 2:25 AM, Jiri Pirko wrote: Wed, Apr 11, 2018 at 09:13:52PM CEST, sridhar.samudr...@intel.com wrote: On 4/11/2018 8:51 AM, Jiri Pirko wrote: Tue, Apr 10, 2018 at 08:59:48PM CEST, sridhar.samudr...@intel.com wrote: This provides a generic interface for paravirtual drivers to listen

[virtio-dev] [PATCH] content: document hugetlb page allocation counts

2018-04-18 Thread Jonathan Helman
The Linux kernel exports the number of successful and failed hugetlb page allocations via the virtio balloon driver. These two counts need to be documented in this specification. Signed-off-by: Jonathan Helman --- content.tex | 8 1 file changed, 8 insertions(+) diff --git a/content.te

[virtio-dev] Re: [PATCH v3 6/6] vhost-user: support registering external host notifiers

2018-04-18 Thread Michael S. Tsirkin
On Thu, Apr 12, 2018 at 11:12:32PM +0800, Tiwei Bie wrote: > This patch introduces VHOST_USER_PROTOCOL_F_HOST_NOTIFIER. > With this feature negotiated, vhost-user backend can register > memory region based host notifiers. And it will allow the guest > driver in the VM to notify the hardware acceler

Re: [virtio-dev] [PATCH v2 2/2] content: net: steering mode: Add RSS

2018-04-18 Thread Michael S. Tsirkin
On Wed, Apr 18, 2018 at 01:34:48PM +0300, Sameeh Jubran wrote: > Do you think that the Steering Mode should be in conformance?   Any conformance clauses must be linked to from the conformance chapter. -- MST - To unsubscribe, e

[virtio-dev] [PATCH v3 2/2] content: net: steering mode: Add RSS

2018-04-18 Thread Sameeh Jubran
From: Sameeh Jubran This commit introduces the RSS feature into virtio-net. It is introduced as a sub mode for a general command which configures the steering mode. Most modern high end network devices today support configurable hash functions, this commit introduces RSS - Receive Side Scaling -

[virtio-dev] [PATCH v3 1/2] content: net: Add VIRTIO_NET_F_CTRL_STEERING_MODE feature

2018-04-18 Thread Sameeh Jubran
From: Sameeh Jubran This commit introduces steering mode into network device. Steering mode is a general infrastructure for various steering modes that can be implemented on top of it such as Automatic and RSS. Signed-off-by: Sameeh Jubran --- content.tex | 61 +

[virtio-dev] [PATCH v3 0/2] Introducing RSS to virtio-net

2018-04-18 Thread Sameeh Jubran
From: Sameeh Jubran Please ignore the feature number value (60) in the patch, it is not final for now. Difference from v2: * Dropped RSS_HASH_FUNCTION_NONE flag from RSS as it seems to be useless. * Added more comments to the code. * Beautifications. * Fixed some sentences to make them clear

Re: [virtio-dev] [PATCH v2 2/2] content: net: steering mode: Add RSS

2018-04-18 Thread Sameeh Jubran
On Tue, Apr 17, 2018 at 5:14 PM, Michael S. Tsirkin wrote: > On Tue, Apr 17, 2018 at 02:50:15PM +0300, Sameeh Jubran wrote: > > > > > > On Tue, Apr 17, 2018 at 4:50 AM, Michael S. Tsirkin > wrote: > > > > On Mon, Apr 16, 2018 at 04:05:26PM +0300, Sameeh Jubran wrote: > > > From: Sameeh J