[virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-05 Thread Jason Wang
On 2018年06月05日 20:33, Michael S. Tsirkin wrote: I don't think this is sufficient. If both primary and standby devices are present, a legacy guest without support for the feature might see two devices with same mac and get confused. I think that we should only make primary visible after guest

Re: [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-05 Thread Siwei Liu
On Tue, Jun 5, 2018 at 2:32 PM, Michael S. Tsirkin wrote: > On Tue, Jun 05, 2018 at 02:16:44PM -0700, Siwei Liu wrote: >> Good to see this discussion going. I share the same feeling that the >> decision of plugging the primary (passthrough) should only be made >> until guest driver acknowledges DR

Re: [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-05 Thread Michael S. Tsirkin
On Tue, Jun 05, 2018 at 02:16:44PM -0700, Siwei Liu wrote: > Good to see this discussion going. I share the same feeling that the > decision of plugging the primary (passthrough) should only be made > until guest driver acknowledges DRIVER_OK and _F_STANDBY. > Architecturally this intelligence shou

Re: [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-05 Thread Siwei Liu
Good to see this discussion going. I share the same feeling that the decision of plugging the primary (passthrough) should only be made until guest driver acknowledges DRIVER_OK and _F_STANDBY. Architecturally this intelligence should be baken to QEMU itself rather than moving up to management stac

[virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-05 Thread Michael S. Tsirkin
On Tue, Jun 05, 2018 at 01:20:33PM -0700, Samudrala, Sridhar wrote: > > On 6/5/2018 5:33 AM, Michael S. Tsirkin wrote: > > I don't think this is sufficient. > > Sure. This is not sufficient for a complete solution, but is Qemu the right > place > to manage primary/standby interfaces? > > I thin

[virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-05 Thread Samudrala, Sridhar
On 6/5/2018 5:33 AM, Michael S. Tsirkin wrote: I don't think this is sufficient. Sure. This is not sufficient for a complete solution, but is Qemu the right place to manage primary/standby interfaces? I think the other steps including plugging/unplugging the primary interface needs to hand

[virtio-dev] Re: [Qemu-devel] [PATCH v7 0/5] virtio-balloon: free page hint reporting support

2018-06-05 Thread Michael S. Tsirkin
On Tue, Jun 05, 2018 at 02:42:40PM +0800, Peter Xu wrote: > > I think the answer is no - it doesn't matter; by telling the hypervisor > > the page is 'free' the kernel gives freedom to the hypervisor to > > discard the page contents. > > Yeh it seems so. Well not exactly. I replied to parent wit

[virtio-dev] Re: [Qemu-devel] [PATCH v7 0/5] virtio-balloon: free page hint reporting support

2018-06-05 Thread Michael S. Tsirkin
On Fri, Jun 01, 2018 at 04:33:29PM +0100, Dr. David Alan Gilbert wrote: > I think the answer is no - it doesn't matter; by telling the hypervisor > the page is 'free' the kernel gives freedom to the hypervisor to > discard the page contents. I'd like to call attention to this since it's easy to ge

[virtio-dev] Re: [PATCH v7 4/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-05 Thread Wei Wang
On 06/05/2018 02:58 PM, Peter Xu wrote: On Mon, Jun 04, 2018 at 04:04:51PM +0800, Wei Wang wrote: On 05/30/2018 08:47 PM, Michael S. Tsirkin wrote: On Wed, May 30, 2018 at 05:12:09PM +0800, Wei Wang wrote: On 05/29/2018 11:24 PM, Michael S. Tsirkin wrote: On Tue, Apr 24, 2018 at 02:13:47PM +0

[virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-05 Thread Michael S. Tsirkin
I don't think this is sufficient. If both primary and standby devices are present, a legacy guest without support for the feature might see two devices with same mac and get confused. I think that we should only make primary visible after guest acked the backup feature bit. And on reset or when

Re: [virtio-dev] Re: [PATCH v3] virtio_pci: support enabling VFs

2018-06-05 Thread Michael S. Tsirkin
On Tue, Jun 05, 2018 at 09:36:53AM +0800, Tiwei Bie wrote: > On Mon, Jun 04, 2018 at 07:32:25PM +0300, Michael S. Tsirkin wrote: > > On Fri, Jun 01, 2018 at 12:02:39PM +0800, Tiwei Bie wrote: > > > There is a new feature bit allocated in virtio spec to > > > support SR-IOV (Single Root I/O Virtuali