Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-22 Thread Siwei Liu
On Fri, Jun 22, 2018 at 4:40 PM, Siwei Liu wrote: > On Fri, Jun 22, 2018 at 3:25 PM, Michael S. Tsirkin wrote: >> On Fri, Jun 22, 2018 at 02:51:11PM -0700, Siwei Liu wrote: >>> On Fri, Jun 22, 2018 at 2:29 PM, Michael S. Tsirkin wrote: >>> > On Fri, Jun 22, 2018 at 01:03:04PM -0700, Siwei Liu wr

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-22 Thread Siwei Liu
On Fri, Jun 22, 2018 at 3:33 PM, Michael S. Tsirkin wrote: > On Fri, Jun 22, 2018 at 02:57:39PM -0700, Siwei Liu wrote: >> On Fri, Jun 22, 2018 at 2:32 PM, Michael S. Tsirkin wrote: >> > On Fri, Jun 22, 2018 at 01:21:45PM -0700, Siwei Liu wrote: >> >> On Fri, Jun 22, 2018 at 12:05 PM, Michael S.

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-22 Thread Siwei Liu
On Fri, Jun 22, 2018 at 3:25 PM, Michael S. Tsirkin wrote: > On Fri, Jun 22, 2018 at 02:51:11PM -0700, Siwei Liu wrote: >> On Fri, Jun 22, 2018 at 2:29 PM, Michael S. Tsirkin wrote: >> > On Fri, Jun 22, 2018 at 01:03:04PM -0700, Siwei Liu wrote: >> >> On Fri, Jun 22, 2018 at 1:00 PM, Siwei Liu w

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-22 Thread Michael S. Tsirkin
On Fri, Jun 22, 2018 at 02:57:39PM -0700, Siwei Liu wrote: > On Fri, Jun 22, 2018 at 2:32 PM, Michael S. Tsirkin wrote: > > On Fri, Jun 22, 2018 at 01:21:45PM -0700, Siwei Liu wrote: > >> On Fri, Jun 22, 2018 at 12:05 PM, Michael S. Tsirkin > >> wrote: > >> > On Fri, Jun 22, 2018 at 05:09:55PM +

Re: [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-22 Thread Michael S. Tsirkin
On Fri, Jun 22, 2018 at 03:25:19PM -0700, Siwei Liu wrote: > On Fri, Jun 22, 2018 at 2:47 PM, Michael S. Tsirkin wrote: > > On Fri, Jun 22, 2018 at 12:43:26PM -0700, Siwei Liu wrote: > >> > The semantics are that the primary is always used if present in > >> > preference to standby. > >> OK. If th

Re: [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-22 Thread Siwei Liu
On Fri, Jun 22, 2018 at 2:47 PM, Michael S. Tsirkin wrote: > On Fri, Jun 22, 2018 at 12:43:26PM -0700, Siwei Liu wrote: >> > The semantics are that the primary is always used if present in >> > preference to standby. >> OK. If this is the only semantics of what "standby" refers to in >> general, t

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-22 Thread Michael S. Tsirkin
On Fri, Jun 22, 2018 at 02:51:11PM -0700, Siwei Liu wrote: > On Fri, Jun 22, 2018 at 2:29 PM, Michael S. Tsirkin wrote: > > On Fri, Jun 22, 2018 at 01:03:04PM -0700, Siwei Liu wrote: > >> On Fri, Jun 22, 2018 at 1:00 PM, Siwei Liu wrote: > >> > On Thu, Jun 21, 2018 at 7:32 PM, Michael S. Tsirkin

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-22 Thread Siwei Liu
On Fri, Jun 22, 2018 at 2:32 PM, Michael S. Tsirkin wrote: > On Fri, Jun 22, 2018 at 01:21:45PM -0700, Siwei Liu wrote: >> On Fri, Jun 22, 2018 at 12:05 PM, Michael S. Tsirkin wrote: >> > On Fri, Jun 22, 2018 at 05:09:55PM +0200, Cornelia Huck wrote: >> >> On Thu, 21 Jun 2018 21:20:13 +0300 >> >>

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-22 Thread Siwei Liu
On Fri, Jun 22, 2018 at 2:29 PM, Michael S. Tsirkin wrote: > On Fri, Jun 22, 2018 at 01:03:04PM -0700, Siwei Liu wrote: >> On Fri, Jun 22, 2018 at 1:00 PM, Siwei Liu wrote: >> > On Thu, Jun 21, 2018 at 7:32 PM, Michael S. Tsirkin >> > wrote: >> >> On Thu, Jun 21, 2018 at 06:21:55PM -0700, Siwei

Re: [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-22 Thread Michael S. Tsirkin
On Fri, Jun 22, 2018 at 12:43:26PM -0700, Siwei Liu wrote: > > The semantics are that the primary is always used if present in > > preference to standby. > OK. If this is the only semantics of what "standby" refers to in > general, that is fine. > > I just don't want to limit the failover/standby

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-22 Thread Michael S. Tsirkin
On Fri, Jun 22, 2018 at 05:09:55PM +0200, Cornelia Huck wrote: > Would it be more helpful to focus on generic > migration support for vfio instead of going about it device by device? Just to note this approach is actually device by device *type*. It's mostly device agnostic for a given device typ

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-22 Thread Michael S. Tsirkin
On Fri, Jun 22, 2018 at 01:21:45PM -0700, Siwei Liu wrote: > On Fri, Jun 22, 2018 at 12:05 PM, Michael S. Tsirkin wrote: > > On Fri, Jun 22, 2018 at 05:09:55PM +0200, Cornelia Huck wrote: > >> On Thu, 21 Jun 2018 21:20:13 +0300 > >> "Michael S. Tsirkin" wrote: > >> > >> > On Thu, Jun 21, 2018 at

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-22 Thread Michael S. Tsirkin
On Fri, Jun 22, 2018 at 01:03:04PM -0700, Siwei Liu wrote: > On Fri, Jun 22, 2018 at 1:00 PM, Siwei Liu wrote: > > On Thu, Jun 21, 2018 at 7:32 PM, Michael S. Tsirkin wrote: > >> On Thu, Jun 21, 2018 at 06:21:55PM -0700, Siwei Liu wrote: > >>> On Thu, Jun 21, 2018 at 7:59 AM, Cornelia Huck wrote

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-22 Thread Siwei Liu
On Fri, Jun 22, 2018 at 12:05 PM, Michael S. Tsirkin wrote: > On Fri, Jun 22, 2018 at 05:09:55PM +0200, Cornelia Huck wrote: >> On Thu, 21 Jun 2018 21:20:13 +0300 >> "Michael S. Tsirkin" wrote: >> >> > On Thu, Jun 21, 2018 at 04:59:13PM +0200, Cornelia Huck wrote: >> > > OK, so what about the fol

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-22 Thread Siwei Liu
On Fri, Jun 22, 2018 at 1:00 PM, Siwei Liu wrote: > On Thu, Jun 21, 2018 at 7:32 PM, Michael S. Tsirkin wrote: >> On Thu, Jun 21, 2018 at 06:21:55PM -0700, Siwei Liu wrote: >>> On Thu, Jun 21, 2018 at 7:59 AM, Cornelia Huck wrote: >>> > On Wed, 20 Jun 2018 22:48:58 +0300 >>> > "Michael S. Tsirki

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-22 Thread Siwei Liu
On Thu, Jun 21, 2018 at 7:32 PM, Michael S. Tsirkin wrote: > On Thu, Jun 21, 2018 at 06:21:55PM -0700, Siwei Liu wrote: >> On Thu, Jun 21, 2018 at 7:59 AM, Cornelia Huck wrote: >> > On Wed, 20 Jun 2018 22:48:58 +0300 >> > "Michael S. Tsirkin" wrote: >> > >> >> On Wed, Jun 20, 2018 at 06:06:19PM

Re: [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-22 Thread Siwei Liu
On Thu, Jun 21, 2018 at 7:30 PM, Michael S. Tsirkin wrote: > On Thu, Jun 21, 2018 at 06:07:18PM -0700, Siwei Liu wrote: >> On Thu, Jun 21, 2018 at 11:14 AM, Michael S. Tsirkin wrote: >> > On Wed, Jun 13, 2018 at 01:40:59PM +0800, Jason Wang wrote: >> >> >> >> >> >> On 2018年06月13日 12:24, Samudrala

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-22 Thread Michael S. Tsirkin
On Fri, Jun 22, 2018 at 05:09:55PM +0200, Cornelia Huck wrote: > On Thu, 21 Jun 2018 21:20:13 +0300 > "Michael S. Tsirkin" wrote: > > > On Thu, Jun 21, 2018 at 04:59:13PM +0200, Cornelia Huck wrote: > > > OK, so what about the following: > > > > > > - introduce a new feature bit, VIRTIO_NET_F_ST

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-22 Thread Cornelia Huck
On Thu, 21 Jun 2018 21:20:13 +0300 "Michael S. Tsirkin" wrote: > On Thu, Jun 21, 2018 at 04:59:13PM +0200, Cornelia Huck wrote: > > OK, so what about the following: > > > > - introduce a new feature bit, VIRTIO_NET_F_STANDBY_UUID that indicates > > that we have a new uuid field in the virtio-n