[virtio-dev] Re: [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-25 Thread Michael S. Tsirkin
On Tue, Jun 26, 2018 at 11:46:35AM +0800, Wei Wang wrote: > On 06/26/2018 09:37 AM, Michael S. Tsirkin wrote: > > On Mon, Jun 25, 2018 at 08:05:10PM +0800, Wei Wang wrote: > > > > > @@ -326,17 +353,6 @@ static void stats_handle_request(struct > > > virtio_balloon *vb) > > > virtqueue_ki

[virtio-dev] Re: [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-25 Thread Wei Wang
On 06/26/2018 09:37 AM, Michael S. Tsirkin wrote: On Mon, Jun 25, 2018 at 08:05:10PM +0800, Wei Wang wrote: @@ -326,17 +353,6 @@ static void stats_handle_request(struct virtio_balloon *vb) virtqueue_kick(vq); } -static void virtballoon_changed(struct virtio_device *vdev) -{ -

[virtio-dev] Re: [PATCH v33 1/4] mm: add a function to get free page blocks

2018-06-25 Thread Michael S. Tsirkin
On Sat, Jun 16, 2018 at 08:08:53AM +0900, Linus Torvalds wrote: > On Fri, Jun 15, 2018 at 2:08 PM Wei Wang wrote: > > > > This patch adds a function to get free pages blocks from a free page > > list. The obtained free page blocks are hints about free pages, because > > there is no guarantee that

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-25 Thread Michael S. Tsirkin
On Mon, Jun 25, 2018 at 10:54:09AM -0700, Samudrala, Sridhar wrote: > > > > > Might not neccessarily be something wrong, but it's very limited to > > > > > prohibit the MAC of VF from changing when enslaved by failover. > > > > You mean guest changing MAC? I'm not sure why we prohibit that. > > > I

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-25 Thread Michael S. Tsirkin
On Mon, Jun 25, 2018 at 11:55:12AM +0200, Cornelia Huck wrote: > On Fri, 22 Jun 2018 22:05:50 +0300 > "Michael S. Tsirkin" wrote: > > > On Fri, Jun 22, 2018 at 05:09:55PM +0200, Cornelia Huck wrote: > > > On Thu, 21 Jun 2018 21:20:13 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Th

[virtio-dev] Re: [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-25 Thread Michael S. Tsirkin
On Mon, Jun 25, 2018 at 08:05:10PM +0800, Wei Wang wrote: > Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_HINT feature indicates the > support of reporting hints of guest free pages to host via virtio-balloon. > > Host requests the guest to report free page hints by sending a new cmd id > to the g

Re: [virtio-dev] [RFC] content: tweak VIRTIO_F_IO_BARRIER

2018-06-25 Thread Michael S. Tsirkin
On Mon, Jun 25, 2018 at 08:40:55PM +0200, Halil Pasic wrote: > > > On 06/25/2018 07:42 PM, Michael S. Tsirkin wrote: > > On Mon, Jun 25, 2018 at 06:07:17PM +0200, Halil Pasic wrote: > > > > > > > > > On 06/25/2018 02:24 PM, Tiwei Bie wrote: > > > > VIRTIO_F_IO_BARRIER was proposed recently to a

[virtio-dev] Re: [RFC] content: tweak VIRTIO_F_IO_BARRIER

2018-06-25 Thread Michael S. Tsirkin
On Mon, Jun 25, 2018 at 08:24:42PM +0800, Tiwei Bie wrote: > VIRTIO_F_IO_BARRIER was proposed recently to allow > drivers to do some optimizations when devices are > implemented in software. But it only covers barrier > related optimizations. Later investigations show > that, it could cover more. S

Re: [virtio-dev] [RFC] content: tweak VIRTIO_F_IO_BARRIER

2018-06-25 Thread Halil Pasic
On 06/25/2018 07:42 PM, Michael S. Tsirkin wrote: On Mon, Jun 25, 2018 at 06:07:17PM +0200, Halil Pasic wrote: On 06/25/2018 02:24 PM, Tiwei Bie wrote: VIRTIO_F_IO_BARRIER was proposed recently to allow [..] + \item[VIRTIO_F_REAL_DEVICE(36)] This feature indicates + that the device doe

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-25 Thread Samudrala, Sridhar
On 6/22/2018 5:17 PM, Siwei Liu wrote: On Fri, Jun 22, 2018 at 4:40 PM, Siwei Liu wrote: On Fri, Jun 22, 2018 at 3:25 PM, Michael S. Tsirkin wrote: On Fri, Jun 22, 2018 at 02:51:11PM -0700, Siwei Liu wrote: On Fri, Jun 22, 2018 at 2:29 PM, Michael S. Tsirkin wrote: On Fri, Jun 22, 2018 at

[virtio-dev] Re: [PATCH v2 2/5] iommu: Add virtio-iommu driver

2018-06-25 Thread Jean-Philippe Brucker
On 22/06/18 01:51, Michael S. Tsirkin wrote: >> +VIRTIO IOMMU DRIVER >> +M: Jean-Philippe Brucker >> +S: Maintained >> +F: drivers/iommu/virtio-iommu.c >> +F: include/uapi/linux/virtio_iommu.h >> + >> VIRTUAL BOX GUEST DEVICE DRIVER >> M: Hans de Goede >> M: Arnd Bergmann > > Please ad

[virtio-dev] Re: [PATCH v2 3/5] iommu/virtio: Add probe request

2018-06-25 Thread Jean-Philippe Brucker
On 22/06/18 01:55, Michael S. Tsirkin wrote: >> +#define VIRTIO_IOMMU_RESV_MEM_T_RESERVED0 >> +#define VIRTIO_IOMMU_RESV_MEM_T_MSI 1 >> + >> +struct virtio_iommu_probe_resv_mem { >> +__u8subtype; >> +__u8res

Re: [virtio-dev] [RFC] content: tweak VIRTIO_F_IO_BARRIER

2018-06-25 Thread Michael S. Tsirkin
On Mon, Jun 25, 2018 at 06:07:17PM +0200, Halil Pasic wrote: > > > On 06/25/2018 02:24 PM, Tiwei Bie wrote: > > VIRTIO_F_IO_BARRIER was proposed recently to allow > > drivers to do some optimizations when devices are > > implemented in software. But it only covers barrier > > related optimization

Re: [virtio-dev] [RFC] content: tweak VIRTIO_F_IO_BARRIER

2018-06-25 Thread Halil Pasic
On 06/25/2018 02:24 PM, Tiwei Bie wrote: VIRTIO_F_IO_BARRIER was proposed recently to allow drivers to do some optimizations when devices are implemented in software. But it only covers barrier related optimizations. Later investigations show that, it could cover more. So this patch tweaks thi

Re: [virtio-dev] Re: [PATCH v3 1/6] notifications: unify notifications wording in core

2018-06-25 Thread Halil Pasic
On 06/25/2018 04:45 PM, Cornelia Huck wrote: On Mon, 25 Jun 2018 14:21:27 +0200 Halil Pasic wrote: Let us unify the wording when talking about notifications. This change establishes the terms available buffer notification for what was usually [..] Device reports the number of bytes it

[virtio-dev] Re: [PATCH v3 1/6] notifications: unify notifications wording in core

2018-06-25 Thread Cornelia Huck
On Mon, 25 Jun 2018 14:21:27 +0200 Halil Pasic wrote: > Let us unify the wording when talking about notifications. This change > establishes the terms available buffer notification for what was usually > simply called notification or virtqueue notification in v1.0 and used > buffer notification f

[virtio-dev] Re: [PATCH v3 2/6] notifications: notifications as basic virtio facility

2018-06-25 Thread Cornelia Huck
On Mon, 25 Jun 2018 14:21:28 +0200 Halil Pasic wrote: > Let's introduce notifications as basic virtio facility early on. This > shall not only increase the cohesion between core and transport > description by having a well-defined place where notifications are > introduced, but also give us the

[virtio-dev] Re: [PATCH v3 5/6] mmio: map common notifications terminology to MMIO

2018-06-25 Thread Cornelia Huck
On Mon, 25 Jun 2018 14:21:31 +0200 Halil Pasic wrote: > The various notifications are introduced and specified in the common > (i.e. transport agnostic) portion of this specification. How > notifications are realised for a given transport is something each > transport has to specify. > > Let's m

[virtio-dev] [PATCH v34 1/4] mm: support to get hints of free page blocks

2018-06-25 Thread Wei Wang
This patch adds support to get free page blocks from a free page list. The physical addresses of the blocks are stored to the arrays passed from the caller. The obtained free page blocks are hints about free pages, because there is no guarantee that they are still on the free page list after the fu

[virtio-dev] [PATCH v34 0/4] Virtio-balloon: support free page reporting

2018-06-25 Thread Wei Wang
This patch series is separated from the previous "Virtio-balloon Enhancement" series. The new feature, VIRTIO_BALLOON_F_FREE_PAGE_HINT, implemented by this series enables the virtio-balloon driver to report hints of guest free pages to the host. It can be used to accelerate live migration of VMs.

[virtio-dev] [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-25 Thread Wei Wang
Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_HINT feature indicates the support of reporting hints of guest free pages to host via virtio-balloon. Host requests the guest to report free page hints by sending a new cmd id to the guest via the free_page_report_cmd_id configuration register. As the

[virtio-dev] [PATCH v34 3/4] mm/page_poison: expose page_poisoning_enabled to kernel modules

2018-06-25 Thread Wei Wang
In some usages, e.g. virtio-balloon, a kernel module needs to know if page poisoning is in use. This patch exposes the page_poisoning_enabled function to kernel modules. Signed-off-by: Wei Wang Cc: Andrew Morton Cc: Michal Hocko Cc: Michael S. Tsirkin Acked-by: Andrew Morton --- mm/page_pois

[virtio-dev] [PATCH v34 4/4] virtio-balloon: VIRTIO_BALLOON_F_PAGE_POISON

2018-06-25 Thread Wei Wang
The VIRTIO_BALLOON_F_PAGE_POISON feature bit is used to indicate if the guest is using page poisoning. Guest writes to the poison_val config field to tell host about the page poisoning value that is in use. Suggested-by: Michael S. Tsirkin Signed-off-by: Wei Wang Cc: Michael S. Tsirkin Cc: Mich

[virtio-dev] [PATCH v3 1/6] notifications: unify notifications wording in core

2018-06-25 Thread Halil Pasic
Let us unify the wording when talking about notifications. This change establishes the terms available buffer notification for what was usually simply called notification or virtqueue notification in v1.0 and used buffer notification for what was usually called interrupt. The term configuration ch

[virtio-dev] [RFC] content: tweak VIRTIO_F_IO_BARRIER

2018-06-25 Thread Tiwei Bie
VIRTIO_F_IO_BARRIER was proposed recently to allow drivers to do some optimizations when devices are implemented in software. But it only covers barrier related optimizations. Later investigations show that, it could cover more. So this patch tweaks this feature bit to tell the driver whether it ca

[virtio-dev] [PATCH v3 2/6] notifications: notifications as basic virtio facility

2018-06-25 Thread Halil Pasic
Let's introduce notifications as basic virtio facility early on. This shall not only increase the cohesion between core and transport description by having a well-defined place where notifications are introduced, but also give us the opportunity to explain some discrepancies. Namely notifications

[virtio-dev] [PATCH v3 6/6] notifications: update notifications terminology for devices

2018-06-25 Thread Halil Pasic
The specifications of some virtio device types are still using the old terminology for used buffer notifications and configuration change notifications calling these interrupts. Let us fix that. Signed-off-by: Halil Pasic Reviewed-by: Cornelia Huck Reviewed-by: Stefan Hajnoczi --- content.tex

[virtio-dev] [PATCH v3 5/6] mmio: map common notifications terminology to MMIO

2018-06-25 Thread Halil Pasic
The various notifications are introduced and specified in the common (i.e. transport agnostic) portion of this specification. How notifications are realised for a given transport is something each transport has to specify. Let's make the relationship between the virtio over MIIO terms and the comm

[virtio-dev] [PATCH v3 4/6] pci: map common notifications terminology to PCI

2018-06-25 Thread Halil Pasic
The various notifications are introduced and specified in the common (i.e. transport agnostic) portion of this specification. How notifications are realised for a given transport is something each transport has to specify. Let's make the relationship between the PCI terms and the common terms more

[virtio-dev] [PATCH v3 3/6] ccw: map common notifications terminology to ccw

2018-06-25 Thread Halil Pasic
The various notifications are introduced and specified in the common (i.e. transport agnostic) portion of this specification. How notifications are realised for a given transport is something each transport has to specify. Let's make the relationship between the virtio-ccw terms and the common ter

[virtio-dev] [PATCH v3 0/6] rework notifications terminology

2018-06-25 Thread Halil Pasic
Abstract The terminology around notifications is currently somewhat fragmented. Unify notifications terminology using available and used buffer notification consistently for the virtqueue notifications. Consistent use of the term configuration change notification is of concern. Changelog

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-25 Thread Cornelia Huck
On Fri, 22 Jun 2018 22:05:50 +0300 "Michael S. Tsirkin" wrote: > On Fri, Jun 22, 2018 at 05:09:55PM +0200, Cornelia Huck wrote: > > On Thu, 21 Jun 2018 21:20:13 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Jun 21, 2018 at 04:59:13PM +0200, Cornelia Huck wrote: > > > > OK, so what