[virtio-dev] Device-to-driver notification management for hardware implementations

2018-09-12 Thread David Riddoch
All, The VIRTIO_F_NOTIFICATION_DATA feature helps hardware implementations by telling them directly how many descriptors are available in the ring, saving speculative reads.  There is a related issue with interrupts: As things stand, after writing 'used' descriptors into the ring (packed or s

[virtio-dev] Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-09-12 Thread Michael S. Tsirkin
On Wed, Jul 11, 2018 at 10:27:09AM +0800, Tiwei Bie wrote: > This commit introduces the support (without EVENT_IDX) for > packed ring. > > Signed-off-by: Tiwei Bie > --- > drivers/virtio/virtio_ring.c | 495 ++- > 1 file changed, 487 insertions(+), 8 deletions(-)

Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-09-12 Thread Michael S. Tsirkin
On Tue, Sep 11, 2018 at 01:37:26PM +0800, Tiwei Bie wrote: > On Mon, Sep 10, 2018 at 11:33:17AM +0800, Jason Wang wrote: > > On 2018年09月10日 11:00, Tiwei Bie wrote: > > > On Fri, Sep 07, 2018 at 09:00:49AM -0400, Michael S. Tsirkin wrote: > > > > On Fri, Sep 07, 2018 at 09:22:25AM +0800, Tiwei Bie w

[virtio-dev] Re: [PATCH net-next v2 2/5] virtio_ring: support creating packed ring

2018-09-12 Thread Michael S. Tsirkin
On Wed, Sep 12, 2018 at 03:51:40PM +0800, Tiwei Bie wrote: > On Mon, Sep 10, 2018 at 10:28:37AM +0800, Tiwei Bie wrote: > > On Fri, Sep 07, 2018 at 10:03:24AM -0400, Michael S. Tsirkin wrote: > > > On Wed, Jul 11, 2018 at 10:27:08AM +0800, Tiwei Bie wrote: > > > > This commit introduces the support

Re: [virtio-dev] [PATCH v11] VIRTIO_F_NOTIFICATION_DATA: extra data to devices

2018-09-12 Thread Michael S. Tsirkin
Sounds good, I will rebase this and start voting. On Wed, Sep 12, 2018 at 04:20:20PM +0100, David Riddoch wrote: > All, > > Sorry for resurrecting an old thread.  I implement the sort of devices that > would benefit from this feature, so just want to express my support.  It > will simplify implem

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-12 Thread Michael S. Tsirkin
On Wed, Sep 12, 2018 at 08:17:45AM -0700, Samudrala, Sridhar wrote: > > > On 9/7/2018 2:34 PM, Michael S. Tsirkin wrote: > > On Wed, Aug 15, 2018 at 11:49:15AM -0700, Sridhar Samudrala wrote: > > > VIRTIO_NET_F_STANDBY feature enables hypervisor to indicate virtio_net > > > device to act as a sta

Re: [virtio-dev] [PATCH v11] VIRTIO_F_NOTIFICATION_DATA: extra data to devices

2018-09-12 Thread David Riddoch
All, Sorry for resurrecting an old thread.  I implement the sort of devices that would benefit from this feature, so just want to express my support.  It will simplify implementation and improve performance.  The mechanism proposed below works for me. David On Tue, 27 Mar 2018 05:59:27 +0

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-09-12 Thread Samudrala, Sridhar
On 9/7/2018 2:34 PM, Michael S. Tsirkin wrote: On Wed, Aug 15, 2018 at 11:49:15AM -0700, Sridhar Samudrala wrote: VIRTIO_NET_F_STANDBY feature enables hypervisor to indicate virtio_net device to act as a standby for another device with the same MAC address. Signed-off-by: Sridhar Samudrala

Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-09-12 Thread Michael S. Tsirkin
On Mon, Sep 10, 2018 at 11:00:53AM +0800, Tiwei Bie wrote: > On Fri, Sep 07, 2018 at 09:00:49AM -0400, Michael S. Tsirkin wrote: > > On Fri, Sep 07, 2018 at 09:22:25AM +0800, Tiwei Bie wrote: > > > On Mon, Aug 27, 2018 at 05:00:40PM +0300, Michael S. Tsirkin wrote: > > > > Are there still plans to

[virtio-dev] Re: [PATCH net-next v2 1/5] virtio: add packed ring definitions

2018-09-12 Thread Michael S. Tsirkin
On Mon, Sep 10, 2018 at 10:13:22AM +0800, Tiwei Bie wrote: > On Fri, Sep 07, 2018 at 09:51:23AM -0400, Michael S. Tsirkin wrote: > > On Wed, Jul 11, 2018 at 10:27:07AM +0800, Tiwei Bie wrote: > > > Signed-off-by: Tiwei Bie > > > --- > > > include/uapi/linux/virtio_config.h | 3 +++ > > > include

[virtio-dev] Re: [PATCH net-next v2 2/5] virtio_ring: support creating packed ring

2018-09-12 Thread Michael S. Tsirkin
On Mon, Sep 10, 2018 at 10:28:37AM +0800, Tiwei Bie wrote: > On Fri, Sep 07, 2018 at 10:03:24AM -0400, Michael S. Tsirkin wrote: > > On Wed, Jul 11, 2018 at 10:27:08AM +0800, Tiwei Bie wrote: > > > This commit introduces the support for creating packed ring. > > > All split ring specific functions

[virtio-dev] Re: [PATCH net-next v2 2/5] virtio_ring: support creating packed ring

2018-09-12 Thread Tiwei Bie
On Mon, Sep 10, 2018 at 10:28:37AM +0800, Tiwei Bie wrote: > On Fri, Sep 07, 2018 at 10:03:24AM -0400, Michael S. Tsirkin wrote: > > On Wed, Jul 11, 2018 at 10:27:08AM +0800, Tiwei Bie wrote: > > > This commit introduces the support for creating packed ring. > > > All split ring specific functions

Re: [virtio-dev] [PATCH 2/2] drm/virtio: add iommu support.

2018-09-12 Thread Gerd Hoffmann
Hi, > I attempted to fix it in the ttm layer and here is the discussion > https://lore.kernel.org/lkml/b44280d7-eb13-0996-71f5-3fbdeb466...@amd.com/ > > The ttm maintainer Christian is suggesting to map and set ttm->pages as > decrypted > right after ttm->pages are allocated. > > Just checkin