[virtio-dev] Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-11-08 Thread Michael S. Tsirkin
On Fri, Nov 09, 2018 at 10:30:50AM +0800, Jason Wang wrote: > > On 2018/11/8 下午11:56, Michael S. Tsirkin wrote: > > On Thu, Nov 08, 2018 at 07:51:48PM +0800, Tiwei Bie wrote: > > > On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: > > > > On 2018/11/8 上午9:38, Tiwei Bie wrote: > > > > > >

[virtio-dev] Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-11-08 Thread Michael S. Tsirkin
On Fri, Nov 09, 2018 at 10:25:28AM +0800, Jason Wang wrote: > > On 2018/11/8 下午10:14, Michael S. Tsirkin wrote: > > On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: > > > On 2018/11/8 上午9:38, Tiwei Bie wrote: > > > > > > + > > > > > > + if (vq->vq.num_free < descs_used) { > > > > > >

[virtio-dev] Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-11-08 Thread Jason Wang
On 2018/11/8 下午11:56, Michael S. Tsirkin wrote: On Thu, Nov 08, 2018 at 07:51:48PM +0800, Tiwei Bie wrote: On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: On 2018/11/8 上午9:38, Tiwei Bie wrote: + + if (vq->vq.num_free < descs_used) { + pr_debug("Can't add buf l

[virtio-dev] Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-11-08 Thread Jason Wang
On 2018/11/8 下午10:14, Michael S. Tsirkin wrote: On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: On 2018/11/8 上午9:38, Tiwei Bie wrote: + + if (vq->vq.num_free < descs_used) { + pr_debug("Can't add buf len %i - avail = %i\n", +descs_used,

[virtio-dev] Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-11-08 Thread Tiwei Bie
On Thu, Nov 08, 2018 at 10:56:02AM -0500, Michael S. Tsirkin wrote: > On Thu, Nov 08, 2018 at 07:51:48PM +0800, Tiwei Bie wrote: > > On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: > > > > > > On 2018/11/8 上午9:38, Tiwei Bie wrote: > > > > > > + > > > > > > + if (vq->vq.num_free < des

[virtio-dev] Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-11-08 Thread Michael S. Tsirkin
On Thu, Nov 08, 2018 at 07:51:48PM +0800, Tiwei Bie wrote: > On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: > > > > On 2018/11/8 上午9:38, Tiwei Bie wrote: > > > > > + > > > > > + if (vq->vq.num_free < descs_used) { > > > > > + pr_debug("Can't add buf len %i - avail = %i

[virtio-dev] Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-11-08 Thread Michael S. Tsirkin
On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: > > On 2018/11/8 上午9:38, Tiwei Bie wrote: > > > > + > > > > + if (vq->vq.num_free < descs_used) { > > > > + pr_debug("Can't add buf len %i - avail = %i\n", > > > > +descs_used, vq->vq.num_free);

Re: [virtio-dev] Device-to-driver notification management for hardware implementations

2018-11-08 Thread David Riddoch
On 05/11/18 08:53, Stefan Hajnoczi wrote: On Wed, Sep 12, 2018 at 05:41:07PM +0100, David Riddoch wrote: The VIRTIO_F_NOTIFICATION_DATA feature helps hardware implementations by telling them directly how many descriptors are available in the ring, saving speculative reads.  There is a related is

[virtio-dev] Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-11-08 Thread Tiwei Bie
On Thu, Nov 08, 2018 at 04:18:25PM +0800, Jason Wang wrote: > > On 2018/11/8 上午9:38, Tiwei Bie wrote: > > > > + > > > > + if (vq->vq.num_free < descs_used) { > > > > + pr_debug("Can't add buf len %i - avail = %i\n", > > > > +descs_used, vq->vq.num_free);

[virtio-dev] Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-11-08 Thread Jason Wang
On 2018/11/8 上午9:38, Tiwei Bie wrote: + + if (vq->vq.num_free < descs_used) { + pr_debug("Can't add buf len %i - avail = %i\n", +descs_used, vq->vq.num_free); + /* FIXME: for historical reasons, we force a notify here if +