[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-11-27 Thread Michael S. Tsirkin
On Tue, Nov 27, 2018 at 06:10:46PM +, Jean-Philippe Brucker wrote: > On 27/11/2018 18:04, Michael S. Tsirkin wrote: > > On Tue, Nov 27, 2018 at 05:50:50PM +, Jean-Philippe Brucker wrote: > >> On 23/11/2018 22:02, Michael S. Tsirkin wrote: > +/* > + * __viommu_sync_req - Complete

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-11-27 Thread Michael S. Tsirkin
On Tue, Nov 27, 2018 at 05:50:50PM +, Jean-Philippe Brucker wrote: > > I didn't notice this in the past but it seems this will spin > > with interrupts disabled until host handles the request. > > Please do not do this - host execution can be another > > task that needs the same host CPU. This

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-11-27 Thread Michael S. Tsirkin
On Tue, Nov 27, 2018 at 05:58:18PM +, Jean-Philippe Brucker wrote: > On 23/11/2018 21:48, Michael S. Tsirkin wrote: > >> +struct virtio_iommu_config { > >> + /* Supported page sizes */ > >> + __u64 page_size_mask; > >> + /* Supported IOVA range */ > >> +

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-11-27 Thread Jean-Philippe Brucker
On 27/11/2018 18:04, Michael S. Tsirkin wrote: > On Tue, Nov 27, 2018 at 05:50:50PM +, Jean-Philippe Brucker wrote: >> On 23/11/2018 22:02, Michael S. Tsirkin wrote: +/* + * __viommu_sync_req - Complete all in-flight requests + * + * Wait for all added requests to complete.

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-11-27 Thread Michael S. Tsirkin
On Tue, Nov 27, 2018 at 05:55:20PM +, Jean-Philippe Brucker wrote: > On 23/11/2018 21:56, Michael S. Tsirkin wrote: > >> +config VIRTIO_IOMMU > >> + bool "Virtio IOMMU driver" > >> + depends on VIRTIO=y > >> + select IOMMU_API > >> + select INTERVAL_TREE > >> + select ARM_DMA_USE_IOMMU if

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-11-27 Thread Michael S. Tsirkin
On Tue, Nov 27, 2018 at 05:50:50PM +, Jean-Philippe Brucker wrote: > On 23/11/2018 22:02, Michael S. Tsirkin wrote: > >> +/* > >> + * __viommu_sync_req - Complete all in-flight requests > >> + * > >> + * Wait for all added requests to complete. When this function returns, > >> all > >> + *

[virtio-dev] Re: [PATCH v5 0/7] Add virtio-iommu driver

2018-11-27 Thread Auger Eric
Hi Michael, On 11/27/18 6:16 PM, Michael S. Tsirkin wrote: > On Tue, Nov 27, 2018 at 06:09:25PM +0100, Auger Eric wrote: >> Hi Michael, >> >> On 11/27/18 5:53 PM, Michael S. Tsirkin wrote: >>> On Thu, Nov 22, 2018 at 07:37:54PM +, Jean-Philippe Brucker wrote: Implement the virtio-iommu

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-11-27 Thread Jean-Philippe Brucker
On 23/11/2018 21:48, Michael S. Tsirkin wrote: >> +struct virtio_iommu_config { >> +/* Supported page sizes */ >> +__u64 page_size_mask; >> +/* Supported IOVA range */ >> +struct virtio_iommu_range input_range; >> +/* Max domain

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-11-27 Thread Jean-Philippe Brucker
On 23/11/2018 21:56, Michael S. Tsirkin wrote: >> +config VIRTIO_IOMMU >> +bool "Virtio IOMMU driver" >> +depends on VIRTIO=y >> +select IOMMU_API >> +select INTERVAL_TREE >> +select ARM_DMA_USE_IOMMU if ARM >> +help >> + Para-virtualised IOMMU driver with virtio. >> +

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-11-27 Thread Jean-Philippe Brucker
On 23/11/2018 22:02, Michael S. Tsirkin wrote: >> +/* >> + * __viommu_sync_req - Complete all in-flight requests >> + * >> + * Wait for all added requests to complete. When this function returns, all >> + * requests that were in-flight at the time of the call have completed. >> + */ >> +static int

[virtio-dev] Re: [PATCH v5 0/7] Add virtio-iommu driver

2018-11-27 Thread Michael S. Tsirkin
On Tue, Nov 27, 2018 at 06:09:25PM +0100, Auger Eric wrote: > Hi Michael, > > On 11/27/18 5:53 PM, Michael S. Tsirkin wrote: > > On Thu, Nov 22, 2018 at 07:37:54PM +, Jean-Philippe Brucker wrote: > >> Implement the virtio-iommu driver, following specification v0.9 [1]. > >> > >> Since v4 [2]

[virtio-dev] Re: [PATCH v5 0/7] Add virtio-iommu driver

2018-11-27 Thread Auger Eric
Hi Michael, On 11/27/18 5:53 PM, Michael S. Tsirkin wrote: > On Thu, Nov 22, 2018 at 07:37:54PM +, Jean-Philippe Brucker wrote: >> Implement the virtio-iommu driver, following specification v0.9 [1]. >> >> Since v4 [2] I fixed the issues reported by Eric, and added Reviewed-by >> from Eric

[virtio-dev] Re: [PATCH v5 0/7] Add virtio-iommu driver

2018-11-27 Thread Michael S. Tsirkin
On Thu, Nov 22, 2018 at 07:37:54PM +, Jean-Philippe Brucker wrote: > Implement the virtio-iommu driver, following specification v0.9 [1]. > > Since v4 [2] I fixed the issues reported by Eric, and added Reviewed-by > from Eric and Rob. Thanks! > > I changed the specification to fix one

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-27 Thread Sameeh Jubran
On Mon, Nov 26, 2018 at 10:22 PM Samudrala, Sridhar wrote: > > On 11/26/2018 7:43 AM, Sameeh Jubran wrote: > > On Mon, Nov 26, 2018 at 5:13 PM Sameeh Jubran wrote: > >> On Thu, Nov 22, 2018 at 8:27 PM Michael S. Tsirkin wrote: > >>> On Wed, Nov 21, 2018 at 10:04:53PM +0200, Sameeh Jubran wrote:

[virtio-dev] Re: [PATCH v9 5/8] migration/ram.c: add a notifier chain for precopy

2018-11-27 Thread Wei Wang
On 11/27/2018 03:38 PM, Peter Xu wrote: On Thu, Nov 15, 2018 at 06:08:01PM +0800, Wei Wang wrote: +typedef enum PrecopyNotifyReason { +PRECOPY_NOTIFY_ERR = 0, +PRECOPY_NOTIFY_START_ITERATION = 1, +PRECOPY_NOTIFY_BEFORE_SYNC_BITMAP = 2, +PRECOPY_NOTIFY_AFTER_SYNC_BITMAP = 3, +

[virtio-dev] [PATCH v9] vsock: add vsock device

2018-11-27 Thread Stefan Hajnoczi
The virtio vsock device is a zero-configuration socket communications device. It is designed as a guest<->host management channel suitable for communicating with guest agents. vsock is designed with the sockets API in mind and the driver is typically implemented as an address family (at the same

Re: [virtio-dev] Re: [PATCH v9 3/8] migration: use bitmap_mutex in migration_bitmap_clear_dirty

2018-11-27 Thread Wei Wang
On 11/27/2018 03:41 PM, Peter Xu wrote: Ok then I'm fine with it. Though you could update the comments too if you like: /* protects modification of the bitmap and migration_dirty_pages */ QemuMutex bitmap_mutex; And it's tricky that sometimes we don't take the lock when reading

[virtio-dev] Re: [PATCH v2] ACCESS_PLATFORM/ACCESS_ORDER

2018-11-27 Thread Cornelia Huck
On Mon, 26 Nov 2018 19:50:33 -0500 "Michael S. Tsirkin" wrote: > On Mon, Nov 26, 2018 at 11:56:56AM +0100, Cornelia Huck wrote: > > > +It is RECOMMENDED that an add-in card based PCI device > > > > Do we have any special meaning for capitalized RECOMMENDED? > > It's in the RFC we link to: