[virtio-dev] Re: [PATCH v9 5/8] migration/ram.c: add a notifier chain for precopy

2018-11-29 Thread Wei Wang
On 11/30/2018 01:57 PM, Peter Xu wrote: Or you can introduce migration_bitmap_sync_precopy() and let precopy code call that one instead. Agree, thanks. PS. I'm a bit unsure on why we need to sync bitmap in ram_init_bitmaps. I feel like it can be removed... Seems it was added in early days

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-29 Thread Michael S. Tsirkin
On Thu, Nov 29, 2018 at 02:53:08PM -0800, si-wei liu wrote: > > > On 11/29/2018 1:17 PM, Michael S. Tsirkin wrote: > > On Thu, Nov 29, 2018 at 12:14:46PM -0800, si-wei liu wrote: > > > > > > On 11/28/2018 5:15 PM, Michael S. Tsirkin wrote: > > > > On Wed, Nov 28, 2018 at 12:28:42PM -0800, si-wei

[virtio-dev] Re: [PATCH v9 5/8] migration/ram.c: add a notifier chain for precopy

2018-11-29 Thread Wei Wang
On 11/29/2018 01:10 PM, Peter Xu wrote: On Thu, Nov 29, 2018 at 11:40:57AM +0800, Wei Wang wrote: I think this precopy notifier callchain is expected to be used only for the precopy mode. Postcopy has its dedicated notifier callchain that users could use. How about changing the migrate_postcopy(

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-29 Thread si-wei liu
On 11/29/2018 07:08 PM, Samudrala, Sridhar wrote: On 11/29/2018 4:24 PM, si-wei liu wrote: On 11/29/2018 3:53 PM, Samudrala, Sridhar wrote: On 11/29/2018 2:53 PM, si-wei liu wrote: On 11/29/2018 1:17 PM, Michael S. Tsirkin wrote: On Thu, Nov 29, 2018 at 12:14:46PM -0800, si-wei liu wro

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-29 Thread Samudrala, Sridhar
On 11/29/2018 4:24 PM, si-wei liu wrote: On 11/29/2018 3:53 PM, Samudrala, Sridhar wrote: On 11/29/2018 2:53 PM, si-wei liu wrote: On 11/29/2018 1:17 PM, Michael S. Tsirkin wrote: On Thu, Nov 29, 2018 at 12:14:46PM -0800, si-wei liu wrote: On 11/28/2018 5:15 PM, Michael S. Tsirkin wrote:

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-29 Thread si-wei liu
On 11/29/2018 3:53 PM, Samudrala, Sridhar wrote: On 11/29/2018 2:53 PM, si-wei liu wrote: On 11/29/2018 1:17 PM, Michael S. Tsirkin wrote: On Thu, Nov 29, 2018 at 12:14:46PM -0800, si-wei liu wrote: On 11/28/2018 5:15 PM, Michael S. Tsirkin wrote: On Wed, Nov 28, 2018 at 12:28:42PM -080

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-29 Thread Samudrala, Sridhar
On 11/29/2018 2:53 PM, si-wei liu wrote: On 11/29/2018 1:17 PM, Michael S. Tsirkin wrote: On Thu, Nov 29, 2018 at 12:14:46PM -0800, si-wei liu wrote: On 11/28/2018 5:15 PM, Michael S. Tsirkin wrote: On Wed, Nov 28, 2018 at 12:28:42PM -0800, si-wei liu wrote: On 11/28/2018 12:06 PM, Michael

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-29 Thread si-wei liu
On 11/29/2018 1:17 PM, Michael S. Tsirkin wrote: On Thu, Nov 29, 2018 at 12:14:46PM -0800, si-wei liu wrote: On 11/28/2018 5:15 PM, Michael S. Tsirkin wrote: On Wed, Nov 28, 2018 at 12:28:42PM -0800, si-wei liu wrote: On 11/28/2018 12:06 PM, Michael S. Tsirkin wrote: On Wed, Nov 28, 2018

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-29 Thread Michael S. Tsirkin
On Thu, Nov 29, 2018 at 12:14:46PM -0800, si-wei liu wrote: > > > On 11/28/2018 5:15 PM, Michael S. Tsirkin wrote: > > On Wed, Nov 28, 2018 at 12:28:42PM -0800, si-wei liu wrote: > > > > > > On 11/28/2018 12:06 PM, Michael S. Tsirkin wrote: > > > > On Wed, Nov 28, 2018 at 10:39:55AM -0800, Samud

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-29 Thread si-wei liu
On 11/28/2018 5:15 PM, Michael S. Tsirkin wrote: On Wed, Nov 28, 2018 at 12:28:42PM -0800, si-wei liu wrote: On 11/28/2018 12:06 PM, Michael S. Tsirkin wrote: On Wed, Nov 28, 2018 at 10:39:55AM -0800, Samudrala, Sridhar wrote: On 11/28/2018 9:35 AM, Michael S. Tsirkin wrote: On Wed, Nov 2

[virtio-dev] [PATCH] packed-ring: fix queue size for pci

2018-11-29 Thread Michael S. Tsirkin
PCI is the only transport that has text enforcing a power of two size for VQs. There's no real reason for it to do it, so document that it does not apply with the packed rings. Accordingly, drop the text "unless enforced by a transport" from packed ring description. Fixes: https://github.com/oasi

[virtio-dev] [PATCH v10] vsock: add vsock device

2018-11-29 Thread Stefan Hajnoczi
The virtio vsock device is a zero-configuration socket communications device. It is designed as a guest<->host management channel suitable for communicating with guest agents. vsock is designed with the sockets API in mind and the driver is typically implemented as an address family (at the same