Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-12-07 Thread si-wei liu
On 12/05/2018 08:18 AM, Sameeh Jubran wrote: Hi all, This is a followup on the discussion in the DPDK and Virtio monthly meeting. Michael suggested that layer 2 tests should be created in order to test the PF/VF behavior in different scenarios without using VMs at all which should speed up t

Re: [virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-12-07 Thread Jean-Philippe Brucker
Sorry for the delay, I wanted to do a little more performance analysis before continuing. On 27/11/2018 18:10, Michael S. Tsirkin wrote: > On Tue, Nov 27, 2018 at 05:55:20PM +, Jean-Philippe Brucker wrote: + if (!virtio_has_feature(vdev, VIRTIO_F_VERSION_1) || + !virtio_has_fea

[virtio-dev] Re: [RFC 0/3] virtio_ring: define flags as shifts consistently

2018-12-07 Thread Michael S. Tsirkin
On Fri, Dec 07, 2018 at 04:48:39PM +0800, Tiwei Bie wrote: > This is a follow up of the discussion in this thread: > https://patchwork.ozlabs.org/patch/1001015/#2042353 How was this tested? I'd suggest building virtio before and after the changes, stripped binary should be exactly the same. > Ti

[virtio-dev] Re: [RFC 3/3] virtio_ring: use new vring flags

2018-12-07 Thread Michael S. Tsirkin
On Fri, Dec 07, 2018 at 04:48:42PM +0800, Tiwei Bie wrote: > Switch to using the _SPLIT_ and _PACKED_ variants of vring flags > in split ring and packed ring respectively. > > Signed-off-by: Tiwei Bie > --- > @@ -502,7 +505,8 @@ static inline int virtqueue_add_split(struct virtqueue > *_vq, >

[virtio-dev] [RFC 2/3] virtio_ring: add VIRTIO_RING_NO_LEGACY

2018-12-07 Thread Tiwei Bie
Introduce VIRTIO_RING_NO_LEGACY to support disabling legacy macros and layout definitions. Suggested-by: Michael S. Tsirkin Signed-off-by: Tiwei Bie --- VRING_AVAIL_ALIGN_SIZE, VRING_USED_ALIGN_SIZE and VRING_DESC_ALIGN_SIZE are not pre-virtio 1.0, but can also be disabled by VIRTIO_RING_NO_LEGA

[virtio-dev] [RFC 1/3] virtio_ring: define flags as shifts consistently

2018-12-07 Thread Tiwei Bie
Introduce _SPLIT_ and/or _PACKED_ variants for VRING_DESC_F_*, VRING_AVAIL_F_NO_INTERRUPT and VRING_USED_F_NO_NOTIFY. These variants are defined as shifts instead of shifted values for consistency with other _F_ flags. Suggested-by: Michael S. Tsirkin Signed-off-by: Tiwei Bie --- include/uapi/l

[virtio-dev] [RFC 0/3] virtio_ring: define flags as shifts consistently

2018-12-07 Thread Tiwei Bie
This is a follow up of the discussion in this thread: https://patchwork.ozlabs.org/patch/1001015/#2042353 Tiwei Bie (3): virtio_ring: define flags as shifts consistently virtio_ring: add VIRTIO_RING_NO_LEGACY virtio_ring: use new vring flags drivers/virtio/virtio_ring.c | 100 +

[virtio-dev] [RFC 3/3] virtio_ring: use new vring flags

2018-12-07 Thread Tiwei Bie
Switch to using the _SPLIT_ and _PACKED_ variants of vring flags in split ring and packed ring respectively. Signed-off-by: Tiwei Bie --- drivers/virtio/virtio_ring.c | 100 +-- 1 file changed, 59 insertions(+), 41 deletions(-) diff --git a/drivers/virtio/virtio_

[virtio-dev] Re: [RFC 2/3] virtio_ring: add VIRTIO_RING_NO_LEGACY

2018-12-07 Thread Michael S. Tsirkin
On Fri, Dec 07, 2018 at 04:48:41PM +0800, Tiwei Bie wrote: > Introduce VIRTIO_RING_NO_LEGACY to support disabling legacy > macros and layout definitions. > > Suggested-by: Michael S. Tsirkin > Signed-off-by: Tiwei Bie > --- > VRING_AVAIL_ALIGN_SIZE, VRING_USED_ALIGN_SIZE and VRING_DESC_ALIGN_SIZ