Re: [virtio-dev] RFC: Doorbell suppression, packed-ring mode and hardware offload

2019-02-13 Thread Michael S. Tsirkin
On Thu, Feb 14, 2019 at 11:34:22AM +0800, Jason Wang wrote: > > On 2019/2/14 上午1:30, Michael S. Tsirkin wrote: > > On Wed, Feb 13, 2019 at 06:33:50PM +0800, Jason Wang wrote: > > > On 2019/2/13 上午1:35, Michael S. Tsirkin wrote: > > > > On Tue, Feb 12, 2019 at 04:47:08PM +, David Riddoch wrote:

Re: [virtio-dev] RFC: Doorbell suppression, packed-ring mode and hardware offload

2019-02-13 Thread Michael S. Tsirkin
On Thu, Feb 14, 2019 at 11:21:54AM +0800, Jason Wang wrote: > > On 2019/2/13 下午11:20, Michael S. Tsirkin wrote: > > On Wed, Feb 13, 2019 at 06:00:41PM +0800, Jason Wang wrote: > > > On 2019/2/12 下午9:44, Michael S. Tsirkin wrote: > > > > On Tue, Feb 12, 2019 at 03:28:26PM +0800, Jason Wang wrote: >

Re: [virtio-dev] RFC: Doorbell suppression, packed-ring mode and hardware offload

2019-02-13 Thread Jason Wang
On 2019/2/14 上午1:30, Michael S. Tsirkin wrote: On Wed, Feb 13, 2019 at 06:33:50PM +0800, Jason Wang wrote: On 2019/2/13 上午1:35, Michael S. Tsirkin wrote: On Tue, Feb 12, 2019 at 04:47:08PM +, David Riddoch wrote: I would prefer to have the write barrier before writing the idx. Well that

Re: [virtio-dev] [PATCH v2 1/2] content: add virtio file system device

2019-02-13 Thread Stefan Hajnoczi
On Wed, Feb 13, 2019 at 05:47:19PM +0100, Paolo Bonzini wrote: > On 13/02/19 07:33, Stefan Hajnoczi wrote: > > +Notifications are different from normal requests because they only contain > > +device writable fields. The driver sends notification replies on one of > > the > > +request queues. The

Re: [virtio-dev] RFC: Doorbell suppression, packed-ring mode and hardware offload

2019-02-13 Thread Jason Wang
On 2019/2/13 下午11:20, Michael S. Tsirkin wrote: On Wed, Feb 13, 2019 at 06:00:41PM +0800, Jason Wang wrote: On 2019/2/12 下午9:44, Michael S. Tsirkin wrote: On Tue, Feb 12, 2019 at 03:28:26PM +0800, Jason Wang wrote: On 2019/2/12 下午1:08, Michael S. Tsirkin wrote: On Mon, Feb 11, 2019 at 02:58

Re: [virtio-dev] RFC: Doorbell suppression, packed-ring mode and hardware offload

2019-02-13 Thread Michael S. Tsirkin
On Tue, Feb 12, 2019 at 03:03:06PM -0500, Rob Miller wrote: > > > On Tue, Feb 12, 2019 at 1:55 PM Michael S. Tsirkin wrote: > > On Fri, Feb 01, 2019 at 09:43:02AM -0800, Rob Miller wrote: > > Agreed that this is needed. > > > > I would also like to suggest splitting the F_IN_ORD

Re: [virtio-dev] RFC: Doorbell suppression, packed-ring mode and hardware offload

2019-02-13 Thread Michael S. Tsirkin
On Wed, Feb 13, 2019 at 06:33:50PM +0800, Jason Wang wrote: > > On 2019/2/13 上午1:35, Michael S. Tsirkin wrote: > > On Tue, Feb 12, 2019 at 04:47:08PM +, David Riddoch wrote: > > > > > > > I would prefer to have the write barrier before writing the idx. > > > > > > Well that's driver overhead f

Re: [virtio-dev] [PATCH v2 2/2] virtio-fs: add DAX window

2019-02-13 Thread Paolo Bonzini
On 13/02/19 07:33, Stefan Hajnoczi wrote: > Describe how shared memory region ID 0 is the DAX window and how > FUSE_SETUPMAPPING maps file ranges into the window. > > Signed-off-by: Stefan Hajnoczi > --- > virtio-fs.tex | 25 + > 1 file changed, 25 insertions(+) > > diff

Re: [virtio-dev] [PATCH v2 1/2] content: add virtio file system device

2019-02-13 Thread Paolo Bonzini
On 13/02/19 07:33, Stefan Hajnoczi wrote: > +Notifications are different from normal requests because they only contain > +device writable fields. The driver sends notification replies on one of the > +request queues. The format of notification requests is as follows: > + > +\begin{lstlisting} >

Re: [virtio-dev] RFC: Doorbell suppression, packed-ring mode and hardware offload

2019-02-13 Thread Michael S. Tsirkin
On Wed, Feb 13, 2019 at 06:00:41PM +0800, Jason Wang wrote: > > On 2019/2/12 下午9:44, Michael S. Tsirkin wrote: > > On Tue, Feb 12, 2019 at 03:28:26PM +0800, Jason Wang wrote: > > > On 2019/2/12 下午1:08, Michael S. Tsirkin wrote: > > > > On Mon, Feb 11, 2019 at 02:58:30PM +, David Riddoch wrote:

Re: [virtio-dev] RFC: Doorbell suppression, packed-ring mode and hardware offload

2019-02-13 Thread Jason Wang
On 2019/2/13 上午1:35, Michael S. Tsirkin wrote: On Tue, Feb 12, 2019 at 04:47:08PM +, David Riddoch wrote: I would prefer to have the write barrier before writing the idx. Well that's driver overhead for something device might never utilise in a given workload. If we are optimizing let's o

Re: [virtio-dev] RFC: Doorbell suppression, packed-ring mode and hardware offload

2019-02-13 Thread Jason Wang
On 2019/2/12 下午9:44, Michael S. Tsirkin wrote: On Tue, Feb 12, 2019 at 03:28:26PM +0800, Jason Wang wrote: On 2019/2/12 下午1:08, Michael S. Tsirkin wrote: On Mon, Feb 11, 2019 at 02:58:30PM +, David Riddoch wrote: This can result in a very high rate of doorbells with some drivers, which c

Re: [virtio-dev] RFC: Doorbell suppression, packed-ring mode and hardware offload

2019-02-13 Thread David Riddoch
Maybe we should use a flag in event suppression structure. This way device can switch between being notification driven and being driven by index reads. On first thought it seems hard to avoid races: On receiving a doorbell the device wishes to transition from doorbells to polling, so driver->

[virtio-dev] Re: Requesting ballots for #31 and #32

2019-02-13 Thread Stefan Hajnoczi
On Tue, Feb 12, 2019 at 09:04:35PM -0500, Michael S. Tsirkin wrote: > On Wed, Feb 13, 2019 at 09:38:13AM +0800, Stefan Hajnoczi wrote: > > Hi, > > I'd like to request ballots for the following issues: > > > > "content: reserve virtio device ID for file system devices" > > https://github.com/oasis-