Re: [virtio-dev] [PATCH] content: add vendor specific cfg type

2019-11-24 Thread Jan Kiszka
On 28.10.19 11:55, Michael S. Tsirkin wrote: Vendors might want to add their own capability in the PCI capability list. However, Virtio already uses the vendor specific capability ID (0x09) for its own purposes. Did some vendor express that need, or do we only assume it so far? IOW: Do we know

Re: [virtio-dev] [PATCH] virtio-rng: fix device/driver confusion

2019-11-24 Thread Pankaj Gupta
> > The point of rng is to give data to driver so of course > all buffers are driver readable. What shouldn't be there > is device readable buffers - this matches our terminology > elsewhere too (read/write-ability is from POV of device). > > Fixes: https://github.com/oasis-tcs/virtio-spec/issu

Re: [virtio-dev] [PATCH RESEND v4 1/1] Add virtio-iommu device specification

2019-11-24 Thread Jan Kiszka
On 20.11.19 16:19, Jean-Philippe Brucker wrote: The IOMMU device allows a guest to manage DMA mappings for physical, emulated and paravirtualized endpoints. Add device description for the virtio-iommu device and driver. Introduce PROBE, ATTACH, DETACH, MAP and UNMAP requests, as well as translati

[virtio-dev] Re: [virtio] [PATCH] pci: strengthen requirement of the correct subsystem id

2019-11-24 Thread Jan Kiszka
On 28.10.19 17:12, Michael S. Tsirkin wrote: If a hardware implementation of virtio does not have the correct subsystem id, then drivers can't report ir properly, or detect and work around bugs. s/ir/it. Jan Change the requirement from MAY to SHOULD. We can't make it a MUST since we did not

[virtio-dev] [PATCH] virtio-rng: fix device/driver confusion

2019-11-24 Thread Michael S. Tsirkin
The point of rng is to give data to driver so of course all buffers are driver readable. What shouldn't be there is device readable buffers - this matches our terminology elsewhere too (read/write-ability is from POV of device). Fixes: https://github.com/oasis-tcs/virtio-spec/issues/55 Signed-off-

[virtio-dev] Re: [PATCH] content: add vendor specific cfg type

2019-11-24 Thread Michael S. Tsirkin
On Mon, Oct 28, 2019 at 06:55:42AM -0400, Michael S. Tsirkin wrote: > Vendors might want to add their own capability > in the PCI capability list. However, Virtio already > uses the vendor specific capability ID (0x09) > for its own purposes. > > Provide a structure for vendor specific extensions.

[virtio-dev] Re: [virtio] [PATCH] pci: strengthen requirement of the correct subsystem id

2019-11-24 Thread Michael S. Tsirkin
On Mon, Oct 28, 2019 at 12:12:49PM -0400, Michael S. Tsirkin wrote: > If a hardware implementation of virtio does not have > the correct subsystem id, then drivers can't report > ir properly, or detect and work around bugs. > Change the requirement from MAY to SHOULD. > > We can't make it a MUST s

[virtio-dev] [PATCH v3] content: document speed, duplex

2019-11-24 Thread Michael S. Tsirkin
Document as used by Linux. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/59 Signed-off-by: Michael S. Tsirkin --- changes from v2 - address comments by Cornelia - fix more typos - consistent upper/lower case for hex values - explicitly ask that devices use 0x for unknown speed