[virtio-dev] Re: [PATCH v4 1/3] virtio: add dma-buf support for exported objects

2020-06-18 Thread David Stevens
On Thu, Jun 18, 2020 at 9:29 PM Guennadi Liakhovetski wrote: > > Hi Michael, > > On Thu, Jun 04, 2020 at 03:05:23PM -0400, Michael S. Tsirkin wrote: > > On Tue, May 26, 2020 at 07:58:09PM +0900, David Stevens wrote: > > > This change adds a new flavor of dma-bufs that can be used by virtio > > >

[virtio-dev] Re: [PATCH v25 QEMU 3/3] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-06-18 Thread David Hildenbrand
> >> 2. Unclear semantics. Alex tried to document what the actual semantics >> of hinted pages are. Assume the following in the guest to a previously >> hinted page >> >> /* page was hinted and is reused now */ >> if (page[x] != Y) >>page[x] == Y; >> /* migration ends, we now run on the

[virtio-dev] Re: [PATCH v25 QEMU 3/3] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-06-18 Thread Alexander Duyck
On Thu, Jun 18, 2020 at 10:10 AM David Hildenbrand wrote: > > >> > >> Ugh, ... > >> > >> @MST, you might have missed that in another discussion, what's your > >> general opinion about removing free page hinting in QEMU (and Linux)? We > >> keep finding issues in the QEMU implementation, including

Re: [virtio-dev] Re: [PATCH v25 QEMU 3/3] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-06-18 Thread Dr. David Alan Gilbert
* Alexander Duyck (alexander.du...@gmail.com) wrote: > On Tue, May 26, 2020 at 9:14 PM Alexander Duyck > wrote: > > > > From: Alexander Duyck > > > > In an upcoming patch a feature named Free Page Reporting is about to be > > added. In order to avoid any confusion we should drop the use of the

[virtio-dev] Re: [PATCH v25 QEMU 3/3] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-06-18 Thread David Hildenbrand
> There are other concerns I had regarding the iothread (e.g., while > reporting is active, virtio_ballloon_get_free_page_hints() is > essentially a busy loop, in contrast to documented - > continue_to_get_hints will always be true). FWIW, I just double checked this and my memory was bad. - --

[virtio-dev] Re: [PATCH v25 QEMU 3/3] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-06-18 Thread David Hildenbrand
>> >> Ugh, ... >> >> @MST, you might have missed that in another discussion, what's your >> general opinion about removing free page hinting in QEMU (and Linux)? We >> keep finding issues in the QEMU implementation, including non-trivial >> ones, and have to speculate about the actual semantics. I

[virtio-dev] Re: [PATCH v25 QEMU 3/3] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-06-18 Thread Michael S. Tsirkin
On Thu, Jun 18, 2020 at 05:58:28PM +0200, David Hildenbrand wrote: > On 18.06.20 17:14, Alexander Duyck wrote: > > On Thu, Jun 18, 2020 at 5:54 AM David Hildenbrand wrote: > >> > >> On 13.06.20 22:07, Alexander Duyck wrote: > >>> On Tue, May 26, 2020 at 9:14 PM Alexander Duyck > >>> wrote: >

[virtio-dev] Re: [PATCH v25 QEMU 3/3] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-06-18 Thread David Hildenbrand
On 18.06.20 17:14, Alexander Duyck wrote: > On Thu, Jun 18, 2020 at 5:54 AM David Hildenbrand wrote: >> >> On 13.06.20 22:07, Alexander Duyck wrote: >>> On Tue, May 26, 2020 at 9:14 PM Alexander Duyck >>> wrote: From: Alexander Duyck In an upcoming patch a feature named Free

Re: [virtio-dev] Re: Constraining where a guest may allocate virtio accessible resources

2020-06-18 Thread Michael S. Tsirkin
On Thu, Jun 18, 2020 at 05:22:40PM +0200, Jan Kiszka wrote: > On 18.06.20 17:05, Michael S. Tsirkin wrote: > > On Thu, Jun 18, 2020 at 04:58:40PM +0200, Jan Kiszka wrote: > >>> Option 5 - Additional Device > >>> > >>> > >>> The final approach would be

Re: [virtio-dev] Re: Constraining where a guest may allocate virtio accessible resources

2020-06-18 Thread Jan Kiszka
On 18.06.20 17:05, Michael S. Tsirkin wrote: > On Thu, Jun 18, 2020 at 04:58:40PM +0200, Jan Kiszka wrote: >>> Option 5 - Additional Device >>> >>> >>> The final approach would be to tie the allocation of virtqueues to >>> memory regions as defined

[virtio-dev] Re: [PATCH v25 QEMU 3/3] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-06-18 Thread Alexander Duyck
On Thu, Jun 18, 2020 at 5:54 AM David Hildenbrand wrote: > > On 13.06.20 22:07, Alexander Duyck wrote: > > On Tue, May 26, 2020 at 9:14 PM Alexander Duyck > > wrote: > >> > >> From: Alexander Duyck > >> > >> In an upcoming patch a feature named Free Page Reporting is about to be > >> added. In

Re: [virtio-dev] Re: Constraining where a guest may allocate virtio accessible resources

2020-06-18 Thread Michael S. Tsirkin
On Thu, Jun 18, 2020 at 04:58:40PM +0200, Jan Kiszka wrote: > > Option 5 - Additional Device > > > > > > The final approach would be to tie the allocation of virtqueues to > > memory regions as defined by additional devices. For example the > >

Re: [virtio-dev] Re: Constraining where a guest may allocate virtio accessible resources

2020-06-18 Thread Jan Kiszka
On 18.06.20 16:52, Michael S. Tsirkin wrote: > On Thu, Jun 18, 2020 at 03:59:54PM +0200, Jan Kiszka wrote: >> On 18.06.20 15:29, Stefan Hajnoczi wrote: >>> On Wed, Jun 17, 2020 at 08:01:14PM +0200, Jan Kiszka wrote: On 17.06.20 19:31, Alex Bennée wrote: > > Hi, > > This

Re: [virtio-dev] Re: Constraining where a guest may allocate virtio accessible resources

2020-06-18 Thread Michael S. Tsirkin
On Thu, Jun 18, 2020 at 03:59:54PM +0200, Jan Kiszka wrote: > On 18.06.20 15:29, Stefan Hajnoczi wrote: > > On Wed, Jun 17, 2020 at 08:01:14PM +0200, Jan Kiszka wrote: > >> On 17.06.20 19:31, Alex Bennée wrote: > >>> > >>> Hi, > >>> > >>> This follows on from the discussion in the last thread I

Re: [virtio-dev] Re: Constraining where a guest may allocate virtio accessible resources

2020-06-18 Thread Jan Kiszka
On 18.06.20 15:29, Stefan Hajnoczi wrote: > On Wed, Jun 17, 2020 at 08:01:14PM +0200, Jan Kiszka wrote: >> On 17.06.20 19:31, Alex Bennée wrote: >>> >>> Hi, >>> >>> This follows on from the discussion in the last thread I raised: >>> >>> Subject: Backend libraries for VirtIO device emulation >>>

Re: [virtio-dev] Re: Constraining where a guest may allocate virtio accessible resources

2020-06-18 Thread Laszlo Ersek
On 06/17/20 20:01, Jan Kiszka wrote: > On 17.06.20 19:31, Alex Bennée wrote: >> >> Hi, >> >> This follows on from the discussion in the last thread I raised: >> >> Subject: Backend libraries for VirtIO device emulation >> Date: Fri, 06 Mar 2020 18:33:57 + >> Message-ID:

Re: [virtio-dev] Re: Constraining where a guest may allocate virtio accessible resources

2020-06-18 Thread Stefan Hajnoczi
On Wed, Jun 17, 2020 at 08:01:14PM +0200, Jan Kiszka wrote: > On 17.06.20 19:31, Alex Bennée wrote: > > > > Hi, > > > > This follows on from the discussion in the last thread I raised: > > > > Subject: Backend libraries for VirtIO device emulation > > Date: Fri, 06 Mar 2020 18:33:57 + >

[virtio-dev] Re: Constraining where a guest may allocate virtio accessible resources

2020-06-18 Thread Stefan Hajnoczi
On Wed, Jun 17, 2020 at 06:31:15PM +0100, Alex Bennée wrote: > This follows on from the discussion in the last thread I raised: > > Subject: Backend libraries for VirtIO device emulation > Date: Fri, 06 Mar 2020 18:33:57 + > Message-ID: <874kv15o4q@linaro.org> > > To support the

[virtio-dev] Re: [PATCH v25 QEMU 3/3] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-06-18 Thread David Hildenbrand
On 13.06.20 22:07, Alexander Duyck wrote: > On Tue, May 26, 2020 at 9:14 PM Alexander Duyck > wrote: >> >> From: Alexander Duyck >> >> In an upcoming patch a feature named Free Page Reporting is about to be >> added. In order to avoid any confusion we should drop the use of the word >> 'report'

[virtio-dev] Re: [PATCH v4 1/3] virtio: add dma-buf support for exported objects

2020-06-18 Thread Guennadi Liakhovetski
Hi Michael, On Thu, Jun 04, 2020 at 03:05:23PM -0400, Michael S. Tsirkin wrote: > On Tue, May 26, 2020 at 07:58:09PM +0900, David Stevens wrote: > > This change adds a new flavor of dma-bufs that can be used by virtio > > drivers to share exported objects. A virtio dma-buf can be queried by > >

[virtio-dev] Re: Constraining where a guest may allocate virtio accessible resources

2020-06-18 Thread Michael S. Tsirkin
On Wed, Jun 17, 2020 at 06:31:15PM +0100, Alex Bennée wrote: > > Hi, > > This follows on from the discussion in the last thread I raised: > > Subject: Backend libraries for VirtIO device emulation > Date: Fri, 06 Mar 2020 18:33:57 + > Message-ID: <874kv15o4q@linaro.org> > > To