Re: [virtio-dev] Re: [PATCH v2] virtio-pmem: PMEM device spec

2021-08-18 Thread Pankaj Gupta
> > Posting virtio specification for virtio pmem device. Virtio pmem is a > > paravirtualized device which allows the guest to bypass page cache. > > Virtio pmem kernel driver is merged in Upstream Kernel 5.3. Also, Qemu > > device is merged in Qemu 4.1. > > > > Signed-off-by: Pankaj Gupta > > ---

[virtio-dev] Re: [PATCH v2] virtio-pmem: PMEM device spec

2021-08-18 Thread Pankaj Gupta
> >> > +\drivernormative{\subsubsection}{Driver Initialization: Virtio > >> > flush}{Device Types / PMEM Driver / Driver Initialization / Virtio flush} > >> > + > >> > +The driver MUST implement a virtio based flushing interface. > >> > >> I think this can be dropped. The only way to make writes p

[virtio-dev] Re: [PATCH] virtio-net: support device stats

2021-08-18 Thread Xuan Zhuo
On Wed, 18 Aug 2021 12:41:38 +0800, Jason Wang wrote: > On Tue, Aug 17, 2021 at 11:37 AM Xuan Zhuo wrote: > > > > This patch allows the driver to obtain some statistics from the device, > > such as: > > > > 1. queue_N_rx_drops: Rx packets not passed to the driver. > > 2. queue_N_tx_drops: The tx

[virtio-dev] [PATCH V2] virtio-gpio: Specify character encoding for gpio names

2021-08-18 Thread Viresh Kumar
Specify 7-bit ASCII character encoding for GPIO names strings. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/115 Suggested-by: Stefan Hajnoczi Signed-off-by: Viresh Kumar --- V2: - Use ASCII instead of UTF-8. virtio-gpio.tex | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) dif

Re: [virtio-dev] Re: [PATCH] virtio-gpio: Specify character encoding for gpio names

2021-08-18 Thread Stefan Hajnoczi
On Wed, Aug 18, 2021 at 02:02:19PM +0200, Arnd Bergmann wrote: > On Wed, Aug 18, 2021 at 1:31 PM Viresh Kumar wrote: > > diff --git a/virtio-gpio.tex b/virtio-gpio.tex > > index 5da16d920aa3..0b0689cceb08 100644 > > --- a/virtio-gpio.tex > > +++ b/virtio-gpio.tex > > @@ -119,7 +119,8 @@ \subsubsec

[virtio-dev] Re: [PATCH] virtio-gpio: Specify character encoding for gpio names

2021-08-18 Thread Arnd Bergmann
On Wed, Aug 18, 2021 at 1:31 PM Viresh Kumar wrote: > diff --git a/virtio-gpio.tex b/virtio-gpio.tex > index 5da16d920aa3..0b0689cceb08 100644 > --- a/virtio-gpio.tex > +++ b/virtio-gpio.tex > @@ -119,7 +119,8 @@ \subsubsection{requestq Operation: Get Line > Names}\label{sec:Device Types / GPIO >

[virtio-dev] [PATCH] virtio-gpio: Specify character encoding for gpio names

2021-08-18 Thread Viresh Kumar
Specify UTF-8 character encoding for GPIO names strings. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/115 Suggested-by: Stefan Hajnoczi Signed-off-by: Viresh Kumar --- virtio-gpio.tex | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/virtio-gpio.tex b/virtio-gpio.t

[virtio-dev] Re: [PATCH V9] virtio-gpio: Add the device specification

2021-08-18 Thread Cornelia Huck
On Wed, Aug 18 2021, Viresh Kumar wrote: > On 18-08-21, 13:05, Cornelia Huck wrote: >> Pushed out the voted-upon change; please follow up on the raised >> comments separately. > > Thanks. > > Do I need to create a new issue for the UTF-8 thing ? Or just a simple > patch without a Fixes tag is fin

[virtio-dev] Re: [PATCH V9] virtio-gpio: Add the device specification

2021-08-18 Thread Viresh Kumar
On 18-08-21, 13:05, Cornelia Huck wrote: > Pushed out the voted-upon change; please follow up on the raised > comments separately. Thanks. Do I need to create a new issue for the UTF-8 thing ? Or just a simple patch without a Fixes tag is fine ? -- viresh --

[virtio-dev] Re: [PATCH V9] virtio-gpio: Add the device specification

2021-08-18 Thread Cornelia Huck
On Mon, Aug 09 2021, Viresh Kumar wrote: > virtio-gpio is a virtual GPIO controller. It provides a way to flexibly > communicate with the host GPIO controllers from the guest. > > Note that the current implementation doesn't provide atomic APIs for > GPIO configurations. i.e. the driver (guest) w

[virtio-dev] Re: [PATCH v2] virtio-pmem: PMEM device spec

2021-08-18 Thread Cornelia Huck
On Fri, Aug 13 2021, Pankaj Gupta wrote: > Posting virtio specification for virtio pmem device. Virtio pmem is a > paravirtualized device which allows the guest to bypass page cache. > Virtio pmem kernel driver is merged in Upstream Kernel 5.3. Also, Qemu > device is merged in Qemu 4.1. > > Signe

[virtio-dev] Re: [PATCH v2] virtio-pmem: PMEM device spec

2021-08-18 Thread Cornelia Huck
On Tue, Aug 17 2021, Pankaj Gupta wrote: >> > +\drivernormative{\subsubsection}{Driver Initialization: Virtio >> > flush}{Device Types / PMEM Driver / Driver Initialization / Virtio flush} >> > + >> > +The driver MUST implement a virtio based flushing interface. >> >> I think this can be dropped

Re: [virtio-dev] Re: [PATCH V2] virtio: i2c: Allow zero-length transactions

2021-08-18 Thread Viresh Kumar
On 18-08-21, 10:03, Arnd Bergmann wrote: > I'd prefer your earlier approach. > > My feeling is that changing the virtqueue code to allow zero-length > buffers is more fragile than having something in the virtio-i2c code > that has a special case for leaving out both read_buf and write_buf. Exactl

Re: [virtio-dev] Re: [PATCH V2] virtio: i2c: Allow zero-length transactions

2021-08-18 Thread Arnd Bergmann
On Wed, Aug 18, 2021 at 5:26 AM Viresh Kumar wrote: > On 18-08-21, 10:38, Jie Deng wrote: > > > > From the perspective of specification,I think we can allow zero-length > > buffers in virtio. > > > > we can use the len of descriptor to see if it is a zero-length buffer. > > > > But for a specific